Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v54]

2023-04-04 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Recommended changes - Changes: - all: https://g

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Jim Laskey
On Tue, 4 Apr 2023 15:31:12 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RuntimeException is the only exception type that can is deduced from a >> lambda. > &

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Jim Laskey
On Tue, 4 Apr 2023 15:18:43 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RuntimeException is the only exception type that can is deduced from a >> lambda. > &

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: RuntimeException is the only exception type that can is ded

Integrated: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-04-03 Thread Jim Laskey
On Thu, 23 Feb 2023 13:13:43 GMT, Jim Laskey wrote: > Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. This pull request has now been integrated. Changeset: 9b9b5a7a Author: Jim Laskey URL: https://git.openjdk.org/jdk/

Re: Small survey about JDK-8280101: in String.split grouped regex should keep the delimiter

2023-03-31 Thread Jim Laskey
gt; > The proposed overload in String would be >String[] split(String regex, int limit, boolean withDelimiters) > with the existing split(regex, limit) simply invoking split(regex, limit, > false) > > > > On 2023-03-31 14:47, Jim Laskey wrote: >> [IMHO] I thin

Re: Small survey about JDK-8280101: in String.split grouped regex should keep the delimiter

2023-03-31 Thread Jim Laskey
[IMHO] I think you’ll find that split isn’t everyone’s favourite method for lots of reasons. For example, more often than not I would like to have split guarantee N + 1 elements in the result, where N is the number delimiters found. Case 1: text blocks split on newlines. Case 2: string

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v52]

2023-03-29 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Update combine example - Changes: - all: https://g

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v51]

2023-03-29 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 69 commits: - Merge branch 'master' into

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v50]

2023-03-28 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Update StringTemplate.combine javadoc - Chang

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v10]

2023-03-27 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Use Arrays.fill - Changes: - all: https://git.openjdk.org/jd

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v8]

2023-03-27 Thread Jim Laskey
On Tue, 14 Mar 2023 10:14:44 GMT, Claes Redestad wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Expand test for StringBuffer and illegal code points > > src/jav

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v9]

2023-03-27 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull r

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v49]

2023-03-27 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Requested review changes. - Changes: - all: https

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-24 Thread Jim Laskey
On Thu, 23 Mar 2023 01:12:20 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-24 Thread Jim Laskey
On Wed, 22 Mar 2023 23:56:48 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/jav

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v3]

2023-03-24 Thread Jim Laskey
On Wed, 22 Mar 2023 23:26:13 GMT, Chen Liang wrote: >> As i said above, i consider this thread as resolved > > Suggestion: > > * to {@value #MAX_INDY_CONCAT_ARG_SLOTS}. Changing - PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1147748029

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-24 Thread Jim Laskey
On Wed, 22 Mar 2023 23:27:20 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 16:21:56 GMT, Rémi Forax wrote: >> It's coming back to me why we didn't do this in the first place (these >> projects tend to go on for months and years). `SimpleProcessor` exists >> because of that ugly second parameter, `E`, in `Processor`, when a >> majority of the time

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v48]

2023-03-23 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Clean up list construction - Changes: - all: https

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 16:25:22 GMT, Rémi Forax wrote: >> The values list can't be null-hostile for the same reason that string >> concatenation can't be null-hostile. Please point to examples of >> null-hostile lists (other that fragments) being used in the template code. >> Apologies if I

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 16:30:42 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 15:01:27 GMT, Jim Laskey wrote: >> You can, of course, reduce this to; >> >> >> interface Processor { >> >> ... >> >> static StringTemplate.Processor >> of(

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 14:39:39 GMT, Jim Laskey wrote: >> Worth considering. Thank you. > > You can, of course, reduce this to; > > > interface Processor { > > ... > > static StringTemplate.Processor > of(Function function

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 12:12:36 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/StringTemplate.java line 679: >> >>> 677: @PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES) >>> 678: @FunctionalInterface >>> 679: p

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v47]

2023-03-23 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Review recommended changes - Changes: - all: https

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 01:31:13 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 01:36:14 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/jav

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 01:45:54 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/ja

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Thu, 23 Mar 2023 01:33:59 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/ja

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Wed, 22 Mar 2023 23:23:38 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/ja

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Wed, 22 Mar 2023 23:16:11 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/ja

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-23 Thread Jim Laskey
On Wed, 22 Mar 2023 23:12:02 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/classes/ja

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-22 Thread Jim Laskey
On Tue, 21 Mar 2023 13:37:02 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/StringTemplate.java line 69: >> >>> 67: * List values = st.values(); >>> 68: * } >>> 69: * The value of {@code fragments} will be equivalent to {@code >>> List.of("", " + ", " = ", "")},

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-22 Thread Jim Laskey
On Tue, 21 Mar 2023 13:25:58 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tidy javadoc >> - Rename StringTemplate classes > > src/java.base/share/c

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

2023-03-20 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with two additional commits since the last revision: - Tidy javadoc - Rename StringTemplate classes -

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v45]

2023-03-16 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 62 commits: - Merge branch 'master' into 828

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v3]

2023-03-12 Thread Jim Laskey
On Sat, 11 Mar 2023 11:11:05 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v44]

2023-03-10 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 61 commits: - Correction - Merge branch 'ma

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v43]

2023-03-06 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 59 commits: - Merge branch 'master' into

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-06 Thread Jim Laskey
On Sat, 4 Mar 2023 19:34:36 GMT, Marius Volkhart wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tighten up reporting of string template errors (fewer messages) > > src/java.base/sh

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-06 Thread Jim Laskey
: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tighten up reporting of string template errors (fewer messages) > > src/java.base/share/classes/java/lang/template/ProcessorLinkage.java line 3

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-06 Thread Jim Laskey
On Fri, 3 Mar 2023 19:42:53 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tighten up reporting of string template errors (fewer messages) > > src/jav

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v8]

2023-03-03 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Expand test for StringBuffer and illegal code points - Changes:

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-03 Thread Jim Laskey
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-03 Thread Jim Laskey
On Thu, 2 Mar 2023 20:19:01 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > &g

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v7]

2023-03-02 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Add snippet - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v5]

2023-03-02 Thread Jim Laskey
On Thu, 2 Mar 2023 18:39:36 GMT, Andrey Turbanov wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Move @since in subclasses >> - Move @since > > src/java.base/share/classes/

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v6]

2023-03-02 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Support code points - Changes: - all: https://git.openjdk.org/jd

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-02 Thread Jim Laskey
Correct and thank you.  > On Mar 2, 2023, at 1:04 PM, Alex Buckley wrote: > > On 3/2/2023 3:14 AM, Jim Laskey wrote: >> Can I get some signing reviewers of the CSR >> https://bugs.openjdk.org/browse/JDK-8286021 ? > > I added remarks to the CSR

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-02 Thread Jim Laskey
On Mon, 27 Feb 2023 12:47:03 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression w

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v5]

2023-03-01 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with two additional commits since the last revision: - Move @since in subclasses - Move @since - Changes: - all:

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v4]

2023-03-01 Thread Jim Laskey
On Tue, 28 Feb 2023 22:08:34 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove @throws IndexOutOfBoundsException >> - Change error report to use "is negati

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Jim Laskey
On Tue, 28 Feb 2023 10:54:14 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize for empty CharSequence > > src/java.base/share/classes/java/lang/Abstra

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v4]

2023-02-28 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with two additional commits since the last revision: - Remove @throws IndexOutOfBoundsException - Change error report to use "

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Jim Laskey
On Tue, 28 Feb 2023 07:50:18 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize for empty CharSequence > > src/java.base/share/classes/java/lang/Abstra

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-02-27 Thread Jim Laskey
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote: > `LinkedList` is used as a field > `jdk.tools.jimage.JImageTask.OptionsValues#jimages` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred as more

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-27 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Optimize for empty CharSequence - Changes: - all:

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-27 Thread Jim Laskey
On Sun, 26 Feb 2023 17:28:08 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PR Cleanup > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-27 Thread Jim Laskey
On Sun, 26 Feb 2023 17:29:09 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PR Cleanup > > src/java.base/share/classes/java/lang/AbstractStringBuil

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-02-27 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Tighten up reporting of string template erro

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v41]

2023-02-23 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 56 commits: - Merge branch 'master' into 82859

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-23 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: PR Cleanup - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-02-23 Thread Jim Laskey
On Thu, 23 Feb 2023 16:54:10 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1918: >> >>> 1916: } >>> 1917: int valueLength = length << UTF16; >>> 1918: if ((Integer.MAX_VALUE -

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-02-23 Thread Jim Laskey
On Thu, 23 Feb 2023 16:40:32 GMT, Roger Riggs wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1918: > >> 1916: } >> 1917: int valueLength =

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-02-23 Thread Jim Laskey
On Thu, 23 Feb 2023 15:56:37 GMT, Roger Riggs wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1876: > >> 1874: int length = this.count - offset; >>

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-02-23 Thread Jim Laskey
On Thu, 23 Feb 2023 15:52:15 GMT, Roger Riggs wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1839: > >> 1837: * @throws StringIndexOutOfBoundsException

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-02-23 Thread Jim Laskey
On Thu, 23 Feb 2023 15:17:26 GMT, Raffaello Giulietti wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1851: > >> 1849: while (count-- != 0) { >>

RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer

2023-02-23 Thread Jim Laskey
Add the ability to repeatedly append char and CharSequence data to StringBuilder/StringBuffer. - Commit messages: - Clean up fro CSR - Add synchronized to StringBuffer repeats - AbstractStringBuilder repeat Changes: https://git.openjdk.org/jdk/pull/12728/files Webrev:

Re: RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v3]

2023-02-14 Thread Jim Laskey
On Tue, 14 Feb 2023 19:30:19 GMT, Severin Gehwolf wrote: >> Could I please get a review of this trivial comment-only change? >> `imageFile.hpp` >> describes some properties of the jimage file `lib/modules`. However, I don't >> think >> the comment example matches current code in the JDK. >>

Re: RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v2]

2023-02-14 Thread Jim Laskey
On Tue, 14 Feb 2023 18:01:44 GMT, Severin Gehwolf wrote: >> I meant that an attribute can have zeros in the non-header portion of the >> attribute data. > > Got it. How about we change this comment from: > > // - Even though ATTRIBUTE_END is used to mark the end of the attribute > stream, >

Re: RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v2]

2023-02-14 Thread Jim Laskey
On Tue, 14 Feb 2023 17:10:32 GMT, Severin Gehwolf wrote: >> @JimLaskey OK. Perhaps we can be clearer what is meant here exactly. I was >> having a hard time deciphering this. It does say `stream will contain zero >> byte values to represent lesser significant bits`. **What** are "byte values

Re: RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v2]

2023-02-14 Thread Jim Laskey
On Tue, 14 Feb 2023 14:46:58 GMT, Severin Gehwolf wrote: >> Could I please get a review of this trivial comment-only change? >> `imageFile.hpp` >> describes some properties of the jimage file `lib/modules`. However, I don't >> think >> the comment example matches current code in the JDK. >>

Re: RFR: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp [v2]

2023-02-14 Thread Jim Laskey
On Tue, 14 Feb 2023 14:46:58 GMT, Severin Gehwolf wrote: >> Could I please get a review of this trivial comment-only change? >> `imageFile.hpp` >> describes some properties of the jimage file `lib/modules`. However, I don't >> think >> the comment example matches current code in the JDK. >>

Re: RFR: 8302337: JDK crashes if lib/modules contains non-zero byte containing ATTRIBUTE_END

2023-02-13 Thread Jim Laskey
On Mon, 13 Feb 2023 16:57:17 GMT, Severin Gehwolf wrote: > The `jimage` location attributes are terminated with `ATTRIBUTE_END`-kinds. > However, > the byte containing `ATTRIBUTE_END` (most significant 5 bits, represent > `kind`), might > be non-zero in the lower 3 bits (values up to `0x07`

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v39]

2023-02-10 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Minor correction to javadoc - Chang

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v38]

2023-02-10 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 53 commits: - Merge branch 'master' into 828

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v37]

2023-02-10 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: CSR review - Changes: - all: https://git.openjdk.

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v36]

2023-02-10 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Bring up to date - Changes: - all: https://git.op

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v35]

2023-02-10 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 50 commits: - Merge branch 'master' into 8285932

Re: Math.clamp method?

2023-01-25 Thread Jim Laskey
+1 > On Jan 25, 2023, at 9:41 AM, Tagir Valeev wrote: > > Hello! > > Quite often it's necessary to clamp a numerical value to a given > range, using the algorithm like this: > int clampedValue = value > max ? max : value < min ? min : value; > or probably > int clampedValue = Math.max(min,

Re: RFR: 8300487: Store cardinality as a field in BitSet [v5]

2023-01-19 Thread Jim Laskey
On Wed, 18 Jan 2023 12:43:31 GMT, fabioromano1 wrote: >> The enanchment is useful for applications that make heavy use of BitSet >> objects as sets of integers, and therefore they need to make a lot of calls >> to cardinality() method, which actually require linear time in the number of >>

Re: RFR: 8300487: Store cardinality as a field in BitSet [v5]

2023-01-18 Thread Jim Laskey
On Wed, 18 Jan 2023 12:43:31 GMT, fabioromano1 wrote: >> The enanchment is useful for applications that make heavy use of BitSet >> objects as sets of integers, and therefore they need to make a lot of calls >> to cardinality() method, which actually require linear time in the number of >>

Re: RFR: 8300487: Store cardinality as a field in BitSet

2023-01-18 Thread Jim Laskey
On Tue, 3 Jan 2023 23:25:39 GMT, fabioromano1 wrote: > The enanchment is useful for applications that make heavy use of BitSet > objects as sets of integers, and therefore they need to make a lot of calls > to cardinality() method, which actually require linear time in the number of > words

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v34]

2023-01-17 Thread Jim Laskey
On Wed, 11 Jan 2023 14:07:53 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression w

Re: RFR: 8206890: jlink --endian XXX generates unusable image if endian-ness does not match architecture

2023-01-17 Thread Jim Laskey
On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image.

Re: RFR: 8206890: jlink --endian XXX generates unusable image if endian-ness does not match architecture

2023-01-17 Thread Jim Laskey
On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image.

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v34]

2023-01-11 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Update to JDK 21 - Changes: - all: https://git.op

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v33]

2023-01-11 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 48 commits: - Merge branch 'master' into 82859

Re: RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point

2023-01-11 Thread Jim Laskey
On Wed, 11 Jan 2023 10:47:03 GMT, Raffaello Giulietti wrote: > This change transforms a O(n^2) path to O(n) when prepending zero padding to > decimal outputs, where n is the length of the padding. Just as a note, I've been thinking about adding a `repeat(String src, int count)` method to

Re: [jdk20] RFR: 8297288: Example code in Scanner class

2022-12-09 Thread Jim Laskey
On Fri, 9 Dec 2022 18:32:37 GMT, Naoto Sato wrote: > The example in `Scanner` directly uses `System.in` which may cause unwanted > behavior when the default charset and the console charset differ. Using > `Console.reader()` is more appropriate. Also changed examples into snippets. You're

Re: [jdk20] RFR: 8297288: Example code in Scanner class

2022-12-09 Thread Jim Laskey
On Fri, 9 Dec 2022 18:32:37 GMT, Naoto Sato wrote: > The example in `Scanner` directly uses `System.in` which may cause unwanted > behavior when the default charset and the console charset differ. Using > `Console.reader()` is more appropriate. Also changed examples into snippets. CSR?

Re: RFR: 8295803: Console should be usable in jshell and other environments [v7]

2022-12-05 Thread Jim Laskey
On Mon, 5 Dec 2022 19:52:59 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments [v6]

2022-12-05 Thread Jim Laskey
On Mon, 5 Dec 2022 18:33:10 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v32]

2022-12-02 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 47 commits: - Merge branch 'master' into 8285932

Re: RFR: 8295803: Console should be usable in jshell and other environments [v2]

2022-12-01 Thread Jim Laskey
On Wed, 30 Nov 2022 20:44:30 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached to the >> platform provided terminal, such as the case when the standard input is >> redirected. `System.console()` now returns a Console implementation based on >>

Re: RFR: 8295803: Console should be usable in jshell and other environments

2022-11-30 Thread Jim Laskey
On Tue, 29 Nov 2022 19:38:02 GMT, Naoto Sato wrote: > This is to allow Console to be used even when it is not attached to the > platform provided terminal, such as the case when the standard input is > redirected. `System.console()` now returns a Console implementation based on >

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v31]

2022-11-24 Thread Jim Laskey
r validation and > transformation. This is a [preview language feature and > API](http://openjdk.java.net/jeps/12). Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: FormatProcessor changes - Changes: - all: https

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v30]

2022-11-23 Thread Jim Laskey
On Wed, 23 Nov 2022 17:26:58 GMT, Roger Riggs wrote: >> Will clean up javadoc for FormatProcessor::process. >> >> It is unfortunate. If you have any ideas will gladly take them on. On the >> other hand, not sure if the exception is any worse that a static initializer >> exception visually. >

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v30]

2022-11-23 Thread Jim Laskey
On Wed, 23 Nov 2022 16:08:33 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update @since > > src/java.base/share/classes/java/util/FormatProcessor.java line 85: &

<    1   2   3   4   5   6   >