On Thu, 19 Sep 2024 07:40:43 GMT, Matthias Baesken wrote:
> Windows Server 2025 will be releases in a few months.
> The OS detection code of the JVM/JDK should recognize the new Windows server
> 2025 version.
> (currently Windows server 2022 is printed , that is wrong)
>
> The build numbers of
On Mon, 9 Sep 2024 15:30:47 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop spurious change
>
> src/java.base/share/classes/java/nio/MappedMemoryUtils.java line 128:
>
>> 126:
On Mon, 9 Sep 2024 12:57:17 GMT, Maurizio Cimadamore
wrote:
> The new test added by https://github.com/openjdk/jdk/pull/20854 fails
> spuriously.
> While JNI lookup is now moved into the static initializer of the
> `MappedMemoryUtils` class, this class might only get initialized while in the
On Fri, 6 Sep 2024 17:51:15 GMT, Jorn Vernee wrote:
>> As discussed in the JBS issue:
>>
>> FFM upcall stubs embed a `Method*` of the target method in the stub. This
>> `Method*` is read from the `LambdaForm::vmentry` field associated with the
>> target method handle at the time when the upcal
On Wed, 4 Sep 2024 16:45:38 GMT, Amit Kumar wrote:
>> I looked into it, but couldn't find out. But I remove the `save_return_pc` &
>> `restore_return_pc` and everything seems fine. So maybe we can remove it.
>
> Tier1 test are fine with/without "saving & restoring" return_pc;
I found it:
https
On Wed, 4 Sep 2024 13:14:55 GMT, Jorn Vernee wrote:
>> As discussed in the JBS issue:
>>
>> FFM upcall stubs embed a `Method*` of the target method in the stub. This
>> `Method*` is read from the `LambdaForm::vmentry` field associated with the
>> target method handle at the time when the upcal
On Tue, 6 Aug 2024 17:26:55 GMT, Jorn Vernee wrote:
> As discussed in the JBS issue:
>
> FFM upcall stubs embed a `Method*` of the target method in the stub. This
> `Method*` is read from the `LambdaForm::vmentry` field associated with the
> target method handle at the time when the upcall stu
On Tue, 6 Aug 2024 17:26:55 GMT, Jorn Vernee wrote:
> As discussed in the JBS issue:
>
> FFM upcall stubs embed a `Method*` of the target method in the stub. This
> `Method*` is read from the `LambdaForm::vmentry` field associated with the
> target method handle at the time when the upcall stu
On Fri, 9 Aug 2024 12:44:45 GMT, Jorn Vernee wrote:
> I think that's a good compromise. (Although I wish the C++ code was just as
> fast, as it's much nicer)
Agreed.
> I'm not sure what other decorator would apply.
I think `ON_STRONG_OOP_REF` and `IS_NOT_NULL` could also be used. But, I guess
On Tue, 6 Aug 2024 17:26:55 GMT, Jorn Vernee wrote:
> As discussed in the JBS issue:
>
> FFM upcall stubs embed a `Method*` of the target method in the stub. This
> `Method*` is read from the `LambdaForm::vmentry` field associated with the
> target method handle at the time when the upcall stu
On Tue, 3 Sep 2024 07:26:53 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or
>> functions , for example :
>> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
On Thu, 29 Aug 2024 13:55:25 GMT, Matthias Baesken wrote:
> We see HiddenClassUnloading.java failing on the ppc64 based platforms. On AIX
> it seems to fail always; Linux ppc64le sometimes.
> Failure output :
> java.lang.RuntimeException: unloadedClassCount is zero
> at HiddenClassUnloading.main
On Tue, 25 Jun 2024 13:47:39 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
On Tue, 25 Jun 2024 13:47:39 GMT, Adam Sotona wrote:
>> After JDK-8294960 is java.lang.invoke.ClassSpecializer using lamdas for code
>> generation and unfortunately it causes StackOverflow on BigEndian platforms.
>>
>> This patch converts all lambdas in ClassSpecializer into anonymous inner
>>
On Mon, 24 Jun 2024 09:40:14 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8222884](https://bugs.openjdk.org/browse/JDK-8222884), commit
> [bd046d9b](https://github.com/openjdk/jdk/commit/bd046d9b9e79e4eea89c72af358961ef6e98e660)
> from the [openjd
On Tue, 28 May 2024 14:01:44 GMT, Martin Doerr wrote:
> Fix obvious typo in micro benchmark.
This pull request has now been integrated.
Changeset: 9ac8d05a
Author: Martin Doerr
URL:
https://git.openjdk.org/jdk/commit/9ac8d05a2567fbf65b944660739e5f8ad1fc2020
Stats: 8 lines i
On Tue, 28 May 2024 14:01:44 GMT, Martin Doerr wrote:
> Fix obvious typo in micro benchmark.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/19427#issuecomment-2136008570
On Tue, 28 May 2024 14:01:44 GMT, Martin Doerr wrote:
> Fix obvious typo in micro benchmark.
Thanks for the review!
-
PR Comment: https://git.openjdk.org/jdk/pull/19427#issuecomment-2135446758
Fix obvious typo in micro benchmark.
-
Commit messages:
- 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'
Changes: https://git.openjdk.org/jdk/pull/19427/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19427&range=00
Issue: https://bugs.openjd
On Fri, 24 May 2024 07:24:13 GMT, Matthias Baesken wrote:
>> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
>> jtreg tests afterwards I run into this error :
>>
>> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime
>> error: null pointer passed a
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 7 May 2024 08:08:05 GMT, Joachim Kern wrote:
>> Since ~ end of March, after
>> [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131),
>> tools/launcher/JliLaunchTest.java fails on AIX. Failure is :
>>
>> stdout: [];
>> stderr: [Error: could not find libjava.so
>> Error: Could no
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those ove
On Wed, 17 Apr 2024 11:20:24 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Wed, 17 Apr 2024 11:20:24 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 15 Apr 2024 16:10:38 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 15 Apr 2024 16:10:38 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 15 Apr 2024 16:07:14 GMT, Suchismith Roy wrote:
>> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
>> line 71:
>>
>>> 69: }
>>> 70: }
>>> 71: }
>>
>> I think files typically have a newline at the end.
>
> In ClassLoader i didnt see it. P
On Mon, 8 Apr 2024 10:27:40 GMT, Martin Doerr wrote:
>> Suchismith Roy has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - update tests
>> - update tests
>> - update tests
>
> src
On Mon, 15 Apr 2024 13:23:22 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Wed, 10 Apr 2024 16:46:30 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Wed, 10 Apr 2024 18:07:33 GMT, Suchismith Roy wrote:
> > BUILD_JDK_JTREG_OUTPUT_DIR
>
> I agree. How can i fetch this path ? I tried
> System.getEnv("BUILD_JDK_JTREG_OUTPUT_DIR") But it doesn't seem to work.
Hmm. Good question. Maybe it can get extracted from the library path. I noticed
th
On Wed, 10 Apr 2024 16:33:53 GMT, Suchismith Roy wrote:
> I have referred to the lib directory under jdk and not jtreg anymore.
> Wouldn't that be fine ?
I don't think writing to the jdk is a good design. People may even want to
write protect it.
-
PR Comment: https://git.openjdk
On Wed, 10 Apr 2024 11:06:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Tue, 9 Apr 2024 10:01:59 GMT, Suchismith Roy wrote:
>> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
>> line 37:
>>
>>> 35: File awtSharedObjectPath = new File("/test/lib/libawt.so");
>>> 36: File awtArchivePath = new File("/test/lib/lib
On Mon, 8 Apr 2024 18:44:51 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 18:14:36 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Fri, 5 Apr 2024 18:14:36 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Wed, 3 Apr 2024 12:32:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Wed, 3 Apr 2024 12:32:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Mon, 1 Apr 2024 17:07:47 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Mon, 1 Apr 2024 17:07:47 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Mon, 1 Apr 2024 18:31:52 GMT, Mandy Chung wrote:
> > Now, I'm getting "java.lang.UnsatisfiedLinkError: no libname.a in
> > java.library.path" when trying `System.loadLibrary("libname.a")` even
> > though the file exists in the library path. Is this intended?
>
> To load a library file, you
On Mon, 1 Apr 2024 17:07:47 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request increment
On Wed, 27 Mar 2024 17:23:50 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request with a n
On Wed, 27 Mar 2024 17:01:30 GMT, Suchismith Roy wrote:
>>> So we should keep the mapAlternativeName for atleast .so to .a
>>> mapping(without any members mentioned).
>>
>> "libname.so(member_name)" is not a valid library name. No reason why
>> `System.load` has to support it.
>
>> > So we s
On Wed, 27 Mar 2024 08:23:53 GMT, Suchismith Roy wrote:
>> I think `mapAlternativeName` isn't needed at all. If
>> `loadLibraryOnlyIfPresent` returns false, `System.load("libname.a(member)")`
>> should be passed to dlopen directly. @suchismith1993 can verify it.
>
> @mlchung The first name
On Mon, 25 Mar 2024 09:46:50 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 18 Mar 2024 17:43:45 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Thu, 21 Mar 2024 15:22:22 GMT, Jaikiran Pai wrote:
>> Hello @suchismith1993, I haven't fully caught up on the necessity of this
>> change. The current proposed change, renames files in the underlying
>> filesystem in the code flow of `System.loadLibrary()` and I don't think is
>> the right
On Tue, 19 Mar 2024 10:01:31 GMT, Suchismith Roy wrote:
>>> > In AIX, we have an usecase where shared libraries have certain member
>>> > objects to be referred to. E.g libclang.a(shr_64.o) .
>>>
>>> Would you happen to know any official documentation which explains that AIX
>>> syntax?
>>>
>
On Tue, 19 Mar 2024 14:59:19 GMT, Goetz Lindenmaier wrote:
> …rve enough space for 2097152KB object heap
>
> I would like to fix this as the two related issues mentioned in the JBS bug.
> We see it currently in most GHA runs.
LGTM.
-
Marked as reviewed by mdoerr (Reviewer).
PR Re
On Tue, 30 Jan 2024 14:02:41 GMT, Matthias Baesken wrote:
>>> Yes there is a nice define in the AIX header
>>
>> *sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE
>> mechanism. Oh well.
>>
>> Anyway, I think this particular can be resolved by not including the
>> sta
On Thu, 25 Jan 2024 09:15:38 GMT, Matthias Baesken wrote:
>> According to the sysinfo manpage (
>> https://man7.org/linux/man-pages/man2/sysinfo.2.html ) the memory and swap
>> related entries in the struct sysinfo are given as multiples of mem_unit
>> bytes.
>> "In the above structure, sizes
On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote:
> In the review of the PR for JDK-8322417 it was noted that a fully qualified
> class name "java.util.Arrays" is unnecessary but it was forgotten to clean it
> up prior to integration.
LGTM.
-
Marked as reviewed by mdoerr
On Mon, 4 Dec 2023 21:25:41 GMT, Martin Doerr wrote:
> I'd like to clean this up: Use the canonical layouts which are available in
> JDK22. Use try-with-resources for `Arena.ofConfined()`.
This pull request has now been integrated.
Changeset: a1fe16b5
Author:Martin
On Mon, 4 Dec 2023 21:25:41 GMT, Martin Doerr wrote:
> I'd like to clean this up: Use the canonical layouts which are available in
> JDK22. Use try-with-resources for `Arena.ofConfined()`.
Thanks for the reviews! The Pre-submit test errors are unrelated.
-
PR Com
I'd like to clean this up: Use the canonical layouts which are available in
JDK22. Use try-with-resources for `Arena.ofConfined()`.
-
Commit messages:
- 8321300: Cleanup TestHFA
Changes: https://git.openjdk.org/jdk/pull/16959/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=
On Tue, 21 Nov 2023 14:24:47 GMT, Martin Doerr wrote:
>> Following test fails due to missing pthread attributes on AIX :
>> java/foreign/TestUpcallAsync.java
>> java/foreign/stackwalk/TestAsyncStackWalk.java
>> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>> j
On Tue, 21 Nov 2023 10:09:04 GMT, Varada M wrote:
> Following test fails due to missing pthread attributes on AIX :
> java/foreign/TestUpcallAsync.java
> java/foreign/stackwalk/TestAsyncStackWalk.java
> java/foreign/loaderLookup/TestLoaderLookupJNI.java
> java/foreign/enablenativeaccess/TestEnabl
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Tue, 21 Nov 2023 17:54:08 GMT, suchismith1993 wrote:
>> src/java.base/aix/native/libsyslookup/syslookup.c line 30:
>>
>>> 28: #include
>>> 29: #include
>>> 30: #include
>>
>> Are string.h and stdlib.h needed? I can't see them in the comments below.
>
> string.h is needed for strlen. Let m
On Tue, 21 Nov 2023 17:49:43 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Tue, 21 Nov 2023 11:52:23 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Tue, 21 Nov 2023 11:21:40 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up wi
On Fri, 17 Nov 2023 12:45:32 GMT, suchismith1993 wrote:
> And I still don't understand if this is the list of symbols that are required
> by our tests, or the complete list of symbols that FFI `defaultLookup`
> returns to user applications. If it is the latter, then this is sort-of okay
> as a
On Mon, 13 Nov 2023 11:47:52 GMT, suchismith1993 wrote:
>>> There is not generic way of generating this. It needs a manual intervention
>>> and symbols are to be added on a need basis in future. Looks like a list to
>>> be maintained. I had tried adding comments to explain the list, but that
>
On Wed, 15 Nov 2023 08:18:31 GMT, Per Minborg wrote:
> This PR proposes to fix a failing test on big endian architectures like AIX.
Thanks for fixing it so quickly! Looks correct and makes the test happy on AIX.
-
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.ope
On Thu, 9 Nov 2023 09:22:45 GMT, suchismith1993 wrote:
> 1. use pragma directive to handle alignment.
>
> JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175)
Looks good. I had proposed this solution here:
https://github.com/openjdk/jdk/pull/16179#discussion_r1360709308
-
On Mon, 13 Nov 2023 12:51:36 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
On Mon, 13 Nov 2023 20:42:00 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that migh
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
Changes requested by mdoerr (Reviewer).
LGTM. You may want to replace the Copyright header of th
On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has
On Fri, 13 Oct 2023 10:12:24 GMT, Martin Doerr wrote:
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
This pull request has now been i
On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has
On Fri, 27 Oct 2023 10:23:43 GMT, Quan Anh Mai wrote:
>> Question: `r12` does not need to remember?
>>
>> According to [CallingSequences in OpenJDK
>> Wiki](https://wiki.openjdk.org/display/HotSpot/CallingSequences), `r12` may
>> be reserved for HeapBase if COOP is enabled.
>> (`r12` is also
On Fri, 20 Oct 2023 07:59:25 GMT, Jorn Vernee wrote:
> > Why is 84 the maximum? That would result in 170 Java parameters at most,
> > which is well within the 255 limit imposed by the VM spec.
>
> Ah, right, longs take up 2 slots. So, we get 84*3 = 252 + 4 (target address &
> return buffer) +
On Thu, 19 Oct 2023 15:28:54 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
On Thu, 19 Oct 2023 12:58:39 GMT, Martin Doerr wrote:
>>> I wonder if the native_invoker_size_per_arg thing still works good enough.
>>> We may exceed the computed size, now, right?
>>
>> Good point. I'll have a look at enhancing the test we have for this.
On Wed, 18 Oct 2023 14:47:58 GMT, Jorn Vernee wrote:
> > I wonder if the native_invoker_size_per_arg thing still works good enough.
> > We may exceed the computed size, now, right?
>
> Good point. I'll have a look at enhancing the test we have for this.
>
> Intuitively, I think it will be okay
On Thu, 19 Oct 2023 06:18:18 GMT, Per Minborg wrote:
> This PR suggests a fix for a failing test on platforms with big endian.
>
> The PR also contains a drive-by removal of an unused import.
Test has passed. Thanks for fixing this so quickly!
-
Marked as reviewed by mdoerr (Revie
On Wed, 18 Oct 2023 13:49:40 GMT, Jorn Vernee wrote:
> > Note: This error is not related to this PR. It was broken by
> > https://github.com/openjdk/jdk/commit/b12c471a990eb8f789410a20084918368c655659
> > which is incorrect for Big Endian. Should I file a new issue or is that
> > already known
On Wed, 18 Oct 2023 13:13:07 GMT, Martin Doerr wrote:
>> Jorn Vernee has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Add xor benchmark
>> - add readOnly heap segment test
>> - shorten linker doc
On Wed, 18 Oct 2023 12:45:05 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
Martin Doerr has updated the pull request incrementally with two additional
commits since
On Mon, 16 Oct 2023 22:56:42 GMT, Jorn Vernee wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to PlatformLayouts.java
>
> src/java.base/share/classes/jdk/
On Mon, 16 Oct 2023 19:24:51 GMT, Jorn Vernee wrote:
> Ok. I'm assuming there are currently some failing tests due to the mismatch
> in ABI? (assuming the test libraries are compiled for the packed ABI)
We should be careful with the names:
- "#pragma align (power)" is the default which is curr
On Mon, 16 Oct 2023 14:41:40 GMT, Maurizio Cimadamore
wrote:
>> Please take a look at commit number 4. I think we need to support both,
>> 4-byte and 8-byte aligned doubles in structures. IBM recommends to use
>> "#pragma align (natural)": "The power suboption is the default to ensure
>> comp
On Mon, 16 Oct 2023 14:06:09 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
Martin Doerr has updated the pull request incrementally with one additional
commit since
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment within structures. This PR is based
> on JDK22 version of the FFI.
Martin Doerr has updated the pull request incrementally with one additional
commit since
On Sat, 14 Oct 2023 18:01:00 GMT, Jorn Vernee wrote:
>> I was thinking something like this:
>>
>>
>> diff --git
>> a/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
>> b/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java
>> index dbd9a3f67a4..10b
On Fri, 13 Oct 2023 14:48:51 GMT, Martin Doerr wrote:
>> Discussed this a bit with Maurizio. There are a few things to consider:
>>
>> - `cannonicalLayouts` allows for just a single mapping from type name to
>> layout. I think `double` should map to the 8-byte a
1 - 100 of 285 matches
Mail list logo
