On Thu, 11 Aug 2022 07:23:28 GMT, David Holmes wrote:
>> What you have is okay although I would have preferred if the sentence on the
>> join method was in the previous paragraph rather as it fits with termination.
>
> Plus one on the join() bit. You could also argue for mentioning isAlive()
>
On Tue, 9 Aug 2022 13:56:44 GMT, Alan Bateman wrote:
>> Thread.State was added (in Java 5) for monitoring and management purposes,
>> it's not an API that most libraries or programs would use. It could be
>> introduced in the class description and referenced from other APIs that
>>
On Mon, 8 Aug 2022 02:27:15 GMT, David Holmes wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Runtime.java line 99:
>
>> 97: * >
On Tue, 9 Aug 2022 05:51:17 GMT, Alan Bateman wrote:
>> The whole paragraph is about thread termination, so I don't think we need to
>> say "terminate" again in the last sentence. We could mention isAlive or the
>> TERMINATED state, but that brings in Thread.State which which require a
>>
On Mon, 8 Aug 2022 22:34:00 GMT, Stuart Marks wrote:
>> I would also suggest that the join() sentence simply be the last sentence of
>> the above paragraph:
>>
>>> The join method can be be used to wait for a thread to terminate.
>
> The whole paragraph is about thread termination, so I don't
On Mon, 8 Aug 2022 02:06:18 GMT, David Holmes wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Runtime.java line 55:
>
>> 53: * to one
On Mon, 8 Aug 2022 01:55:08 GMT, David Holmes wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Runtime.java line 66:
>
>> 64: *
On Mon, 8 Aug 2022 02:33:13 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 73:
>>
>>> 71: * or if its {@code run} method completes abruptly and the appropriate
>>> 72: * {@linkplain Thread.UncaughtExceptionHandler uncaught exception
>>> handler} completes
On Mon, 8 Aug 2022 02:36:45 GMT, David Holmes wrote:
>> "initiated" is also used.
>
> I would suggest saying as little as possible here and simply deferring to the
> Runtime text ie.:
>
>> The shutdown sequence begins when all
>> started
> non-daemon threads have terminated.
>
> No need to
On Sat, 6 Aug 2022 07:47:04 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/System.java line 1888:
>
>> 1886: *
On Sat, 6 Aug 2022 00:42:23 GMT, Stuart Marks wrote:
>> Initial edits to addShutdownHook from Alex.
>>
>> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 Aug 2022 02:34:08 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 104:
>>
>>> 102: * The shutdown sequence begins
>>> when all started
>>> 103: * non-daemon threads have terminated. Unstarted non-daemon threads do
>>> not prevent
>>> 104: * the
On Sat, 6 Aug 2022 08:11:53 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Thread.java line 73:
>
>> 71: * or if
On Sat, 6 Aug 2022 00:42:23 GMT, Stuart Marks wrote:
>> Initial edits to addShutdownHook from Alex.
>>
>> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> Initial edits to addShutdownHook from Alex.
>
> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
More edits from Alex's suggestions.
-
Changes:
- all:
15 matches
Mail list logo
