On Mon, 10 Apr 2023 10:09:04 GMT, Lance Andersen wrote:
> I think we are good to go.
Thanks, the PR is now ready to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1501666039
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Fri, 7 Apr 2023 16:29:31 GMT, Alan Bateman wrote:
> I've updated the CSR to align it with the proposed solution. Please review
> again and if you happy, press "Finalize".
Thanks, Alan, this looks good to me. I have pressed "Finalize".
The CSR makes promises about the Release Note. Do you th
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Thu, 6 Apr 2023 07:32:12 GMT, Alan Bateman wrote:
> One additional thing we could do is update the usage output for
> -i/--generate-index to say that the option is deprecated. Looking at `jdeps
> -help` output to see this for the deprecated -P/--profile option.
Implemented as suggested. The
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Wed, 5 Apr 2023 10:25:01 GMT, Lance Andersen wrote:
> I am not convinced we need a test but to your point Jai, Eirik, lets handle
> this as a separate PR/Issue and work through what we are hoping to
> achieve/validate
Good. Let's agree to handle testing of dusty 'index jars' separately from
On Wed, 5 Apr 2023 07:05:11 GMT, Eirik Bjorsnos wrote:
> > The new test that was planned for testing `JarFile` and `JarInputStream`
> > when dealing with a jar containing a `META-INF/INDEX.LIST`, is that
> > something that you want to be done as a separate PR/task? It's fine with me
> > if you
On Wed, 5 Apr 2023 05:53:38 GMT, Jaikiran Pai wrote:
> The new test that was planned for testing `JarFile` and `JarInputStream` when
> dealing with a jar containing a `META-INF/INDEX.LIST`, is that something that
> you want to be done as a separate PR/task? It's fine with me if you want that
>
On Wed, 5 Apr 2023 06:12:24 GMT, Alan Bateman wrote:
> I used the inline code formatting (3 backquotes) to make the output clear,
> but maybe it looks differently for you or maybe your comment was while I was
> editing?
It looks good now, so my comment was probably made during your edits.
>
On Tue, 4 Apr 2023 18:41:31 GMT, Eirik Bjorsnos wrote:
> Thanks a lot Alan, as this CSR has deeper waters than what I've experienced
> before. Did you intend to remove the line break in the example warning
> output, collapsing it into one line?
I used the inline code formatting (3 backquotes)
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Tue, 4 Apr 2023 18:39:54 GMT, Lance Andersen wrote:
> I've edited it to add a Specification section with a summary of the changes
> to the JAR file spec. I also update the Solution section so that it provides
> a clearer summary of the changes.
Thanks a lot Alan, as this CSR has deeper wate
On Tue, 4 Apr 2023 18:37:34 GMT, Alan Bateman wrote:
> > I have drafted CSR https://bugs.openjdk.org/browse/JDK-8305597, but I'm not
> > sure what to put in the _Specification_ section.
> > What is the specification change in this PR? The removal of the system
> > property? The adding of the wa
On Tue, 4 Apr 2023 18:23:23 GMT, Eirik Bjorsnos wrote:
> I have drafted CSR https://bugs.openjdk.org/browse/JDK-8305597, but I'm not
> sure what to put in the _Specification_ section.
>
> What is the specification change in this PR? The removal of the system
> property? The adding of the warni
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Thu, 30 Mar 2023 17:10:20 GMT, Mandy Chung wrote:
> yes, that's not used. It was a leftover from JDK-8204981 & JDK-8234596.
Thanks a lot for this clarificaton, Mandy.
https://bugs.openjdk.org/browse/JDK-8204981
https://bugs.openjdk.org/browse/JDK-8234596
-
PR Comment: https://g
On Thu, 30 Mar 2023 14:19:55 GMT, Eirik Bjorsnos wrote:
> Is this repurposing of warn.flag.is.deprecated considered ok?
yes, that's not used. It was a leftover from JDK-8204981 & JDK-8234596.
-
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1490647633
On Thu, 30 Mar 2023 13:40:09 GMT, Alan Bateman wrote:
> I think the warning should also communicate that the JAR index is also
> ignored, maybe something like this:
I added the following property to `jar.properties`:
warn.index.is.ignored=\
The JAR index (META-INF/INDEX.LIST) is ignor
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Thu, 30 Mar 2023 11:16:14 GMT, Eirik Bjorsnos wrote:
> We seem to have wiggled a bit on this issue, but I'm ok with including it.
I think we've converged on `jar -i` work as before but print a warning. For the
purposes of the CSR and the release note then I think it would be better to
have
On Thu, 30 Mar 2023 07:05:37 GMT, Alan Bateman wrote:
> For CSR and release note purposes it would be a bit easier if it was this PR,
> would that be okay?
We seem to have wiggled a bit on this issue, but I'm ok with including it.
I have implemented the -i warning using the existing warnings s
On Thu, 30 Mar 2023 07:00:47 GMT, Alan Bateman wrote:
>> Eirik Bjorsnos has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Wed, 29 Mar 2023 19:55:37 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Tue, 28 Mar 2023 20:06:03 GMT, Mandy Chung wrote:
>> Eirik Bjorsnos has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation class is moved into `jdk.jartool` module.
> - The `Invalid
On Thu, 23 Mar 2023 12:05:50 GMT, Eirik Bjorsnos wrote:
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation
On Tue, 28 Mar 2023 18:31:28 GMT, Lance Andersen wrote:
> If we are thinking of emitting a warning, we probably should do that in = JDK
> 22 as that could break tests with golden files so we might want to give a
> heads up in JDK 21 before doing this
The best option might be to just have `jar
On Sat, 25 Mar 2023 09:35:56 GMT, Alan Bateman wrote:
> > I see that Alan suggested that we take up the `jar -i` deprecation in a
> > separate PR. I think that simplifies the work in this PR.
>
> Yes, there are options for `jar -i` that include "leave it as is", have the
> option create the in
On Thu, 23 Mar 2023 15:31:31 GMT, Eirik Bjorsnos wrote:
> Do you know if the `jar` tool allows running with a `SecurityManager`? If
> not, we could perhaps simply use `System.getProperty`?
I ended up feeling opimistic and replaced the current code with just
`System.getProperty`. If that is any
On Thu, 23 Mar 2023 15:10:39 GMT, Jaikiran Pai wrote:
> I don't think we should be exporting that package. Instead, the `JarIndex`
> class can be updated to do `AccessController.doPrivileged(...)`.
Nice, I'll try that!
Do you know if the `jar` tool allows running with a `SecurityManager`? If
On Tue, 28 Mar 2023 13:42:21 GMT, Alan Bateman wrote:
>Adding a test would be good. In the mean-time, I think it would be good to get
>the review started to flush out any concerns about removing this index.
Good! I will mark this ready for review.
(I did not find time to write a test today)
On Thu, 23 Mar 2023 14:09:32 GMT, Jaikiran Pai wrote:
> Perhaps now is the time to add a deprecation/warning message when `jar -i`
> option is used?
I'm not entirely sure I know what you mean or suggest here, so I'll try to be
explicit with what I do (think I) understand and what my reasoning
On Thu, 23 Mar 2023 15:31:31 GMT, Eirik Bjorsnos wrote:
> > I don't think we should be exporting that package. Instead, the `JarIndex`
> > class can be updated to do `AccessController.doPrivileged(...)`.
>
> Nice, I'll try that!
>
> Do you know if the `jar` tool allows running with a `Security
On Mon, 27 Mar 2023 17:12:25 GMT, Eirik Bjorsnos wrote:
> > Adding these tests I think will help us verify that these APIs and also
> > exercise the code in these classes where we have checks for
> > `META-INF/INDEX.LIST` entry. Is that something you could consider adding as
> > part of this P
On Thu, 23 Mar 2023 12:05:50 GMT, Eirik Bjorsnos wrote:
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation
On Fri, 24 Mar 2023 16:22:33 GMT, Jaikiran Pai wrote:
> I see that Alan suggested that we take up the `jar -i` deprecation in a
> separate PR. I think that simplifies the work in this PR.
Yes, there are options for `jar -i` that include "leave it as is", have the
option create the index and em
On Thu, 23 Mar 2023 14:33:19 GMT, Jaikiran Pai wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementati
On Fri, 24 Mar 2023 05:20:34 GMT, Jaikiran Pai wrote:
>>> I don't think we should be exporting that package. Instead, the `JarIndex`
>>> class can be updated to do `AccessController.doPrivileged(...)`.
>>
>> Nice, I'll try that!
>>
>> Do you know if the `jar` tool allows running with a `Secur
This PR removes the JAR index feature from the runtime:
- `URLClassPath` is updated to remove the `enableJarIndex` system property and
any code which would be called when this property was `true`
- The `JarIndex` implementation class is moved into `jdk.jartool` module.
- The `InvalidJarIndexErro
On Thu, 23 Mar 2023 12:05:50 GMT, Eirik Bjorsnos wrote:
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation
50 matches
Mail list logo
