On Mon, 2 Oct 2023 14:51:47 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> test/langtools/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java
>
On Mon, 2 Oct 2023 14:03:48 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package-info.java line 389:
>
>> 387: *
On Mon, 2 Oct 2023 13:54:22 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package-info.java line 259:
>
>> 257: *
On Mon, 2 Oct 2023 13:57:58 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package-info.java line 273:
>
>> 271: *
On Mon, 2 Oct 2023 13:50:56 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java
>> line 67:
>>
>>> 65:
>>> 66: /**
>>> 67: * {@return for an {@code invokeinterface}, the {@code count}
>>> value, as defined in {@jvms 6
On Mon, 2 Oct 2023 13:46:53 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/instruction/CharacterRange.java
> line 77
On Mon, 2 Oct 2023 13:38:18 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/attribute/package-info.java
> line 27:
>
On Mon, 2 Oct 2023 14:45:52 GMT, Maurizio Cimadamore
wrote:
>> test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line
>> 107:
>>
>>> 105: }
>>> 106:
>>> 107: // this version of the code can be used when ClassFile API in not in a
>>> preview
>>
>> Do you want to kee
On Mon, 2 Oct 2023 14:56:11 GMT, Maurizio Cimadamore
wrote:
>> test/langtools/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase_legacy.java
>> line 45:
>>
>>> 43: * @see #compileAndTest
>>> 44: */
>>> 45: public class SourceFileTestBase_legacy extends TestBase {
>>
>> Why is t
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 14:52:58 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> test/langtools/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase_legacy.java
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 14:40:49 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line
> 107:
>
>>
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 13:40:40 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/components/CodeRelabeler.java
> line 71:
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 13:26:38 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/CodeTransform.java line 101:
>
>> 99:
>>
On Mon, 2 Oct 2023 13:29:59 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/classfile/FieldTransform.java line 116:
>>
>>> 114:
>>> 115: /**
>>> 116: * @implSpec The default implementation returns a resolved
>>> transform with all
>>
>> Perhaps lose the `all
On Mon, 2 Oct 2023 13:23:00 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164:
>>
>>> 162:
>>> 163: /**
>>> 164: * @implSpec
>>
>> Should these overridden method have `@inheritDoc` ? If not, their javadoc
>> won't show mu
On Mon, 2 Oct 2023 13:50:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java
> line
On Mon, 2 Oct 2023 13:24:49 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 596:
>
>> 594:
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 13:19:48 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164:
>
>> 162:
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
27 matches
Mail list logo
