Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v35]

2024-10-09 Thread Luca Kellermann
On Fri, 31 May 2024 18:33:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v35]

2024-05-31 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-31 Thread Viktor Klang
On Wed, 22 May 2024 07:56:26 GMT, Alan Bateman wrote: >>> @bchristi-git Just checking in—we're waiting for CSR-approval here before >>> integrating? 🤔 >> >> Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer >> ✔️s. 😉 > >> Indeed - can't move forward without a CSR. Als

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v34]

2024-05-30 Thread Joe Darcy
On Fri, 31 May 2024 01:34:45 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v34]

2024-05-30 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v32]

2024-05-30 Thread Brent Christian
On Thu, 30 May 2024 05:14:30 GMT, Joe Darcy wrote: >> Brent Christian has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 69 commits: >> >> - Merge branch 'master' into refDocs2 >> - add link to Thread.isAlive() >> - small review t

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v33]

2024-05-30 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v32]

2024-05-29 Thread Joe Darcy
On Fri, 24 May 2024 21:39:33 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v32]

2024-05-29 Thread Joe Darcy
On Fri, 24 May 2024 21:39:33 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v32]

2024-05-24 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-22 Thread Alan Bateman
On Tue, 21 May 2024 16:59:38 GMT, Brent Christian wrote: > Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer > ✔️s. 😉 I can do that. One other thing to do is to rebase the changes, it looks like this branch is 6 months behind main line. - PR Comment: ht

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-21 Thread Brent Christian
On Wed, 17 Apr 2024 17:12:28 GMT, Brent Christian wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another update to reachabilityFence() @apiNote > > AFAICT, all review feedback on this change has been addressed.

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-21 Thread Viktor Klang
On Wed, 17 Apr 2024 17:12:28 GMT, Brent Christian wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another update to reachabilityFence() @apiNote > > AFAICT, all review feedback on this change has been addressed.

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v31]

2024-05-13 Thread Hans Boehm
On Mon, May 13, 2024 at 12:16 PM Brent Christian wrote: > On 5/10/24 10:54 AM, Hans Boehm wrote: > > I'm not convinced this helps. > > > > The isAlive() spec says: > > > > "A thread is alive if it has been started and has not yet terminated." > > > > Clearly an object is reachable if it can be ac

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v31]

2024-05-13 Thread Brent Christian
On 5/10/24 10:54 AM, Hans Boehm wrote: I'm not convinced this helps. The isAlive() spec says: "A thread is alive if it has been started and has not yet terminated." Clearly an object is reachable if it can be accessed by a thread that will be started in the future. Is that part of a "potentia

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v31]

2024-05-13 Thread Alan Bateman
On Thu, 9 May 2024 18:44:10 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v31]

2024-05-10 Thread Hans Boehm
I'm not convinced this helps. The isAlive() spec says: "A thread is alive if it has been started and has not yet terminated." Clearly an object is reachable if it can be accessed by a thread that will be started in the future. Is that part of a "potential continuing computation from any live thr

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v31]

2024-05-09 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v30]

2024-05-08 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v29]

2024-05-08 Thread Brent Christian
On Wed, 8 May 2024 08:33:31 GMT, Alan Bateman wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> small grammar fixes > > src/java.base/share/classes/java/lang/ref/Cleaner.java line 224: > >> 222: * Actions in

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v10]

2024-05-08 Thread Brent Christian
On Fri, 23 Feb 2024 14:37:20 GMT, Alan Bateman wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> VM -> virtual machine; also fix misspelling > > src/java.base/share/classes/java/lang/ref/Cleaner.java line 218: >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v29]

2024-05-08 Thread Alan Bateman
On Mon, 29 Apr 2024 21:17:24 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v29]

2024-05-08 Thread Alan Bateman
On Mon, 29 Apr 2024 21:17:24 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-05-08 Thread Alan Bateman
On Tue, 19 Mar 2024 00:40:02 GMT, Y. Srinivas Ramakrishna wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> further tweaks to reachability > > src/java.base/share/classes/java/lang/ref/package-info.java line 137:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v29]

2024-05-08 Thread Alan Bateman
On Mon, 29 Apr 2024 21:17:24 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v10]

2024-05-08 Thread Alan Bateman
On Fri, 23 Feb 2024 06:06:21 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v28]

2024-04-29 Thread Brent Christian
On Sat, 27 Apr 2024 11:58:52 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> new section for finalizer memviz > > src/java.base/share/classes/java/lang/ref/package-info.java line 157: > >> 155

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v29]

2024-04-29 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v28]

2024-04-29 Thread Brent Christian
On Sat, 27 Apr 2024 11:57:23 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> new section for finalizer memviz > > src/java.base/share/classes/java/lang/ref/package-info.java line 137: > >> 135

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v28]

2024-04-27 Thread Viktor Klang
On Fri, 26 Apr 2024 17:59:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v28]

2024-04-26 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v27]

2024-04-25 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v26]

2024-04-25 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v25]

2024-04-25 Thread Brent Christian
On Thu, 25 Apr 2024 08:25:39 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> package spec updates, mostly about reference queues and dequeueing > > src/java.base/share/classes/java/lang/ref/pac

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v25]

2024-04-25 Thread Viktor Klang
On Wed, 24 Apr 2024 23:15:45 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v25]

2024-04-24 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v24]

2024-04-23 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v23]

2024-04-22 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-04-20 Thread Viktor Klang
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-04-17 Thread Brent Christian
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-04-05 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v21]

2024-04-04 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v20]

2024-04-02 Thread Viktor Klang
On Fri, 29 Mar 2024 20:48:09 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v20]

2024-03-29 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v19]

2024-03-29 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v18]

2024-03-28 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v17]

2024-03-26 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v16]

2024-03-25 Thread Brent Christian
On Mon, 25 Mar 2024 19:26:41 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v15]

2024-03-25 Thread Brent Christian
On Fri, 22 Mar 2024 09:28:02 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Elaborate on 'surprising and undesirable effects' in reachabilityFence() > > src/java.base/share/classes/java/lang/r

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v16]

2024-03-25 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v15]

2024-03-22 Thread Viktor Klang
On Thu, 21 Mar 2024 23:38:30 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v15]

2024-03-21 Thread Hans Boehm
Is it worth keeping the discussion starting with "It is sometimes possible to better encapsulate ..." and the associated example code? I find this example extremely unconvincing. It's very hard to construct a case in which you can safely use the result of getExternalResource(). And I don't want to

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v15]

2024-03-21 Thread David Holmes
On Thu, 21 Mar 2024 23:38:30 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v15]

2024-03-21 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-19 Thread Y . Srinivas Ramakrishna
On Tue, 19 Mar 2024 22:26:22 GMT, Stuart Marks wrote: >> I think you are overthinking this somewhat Ramki. I don't see a practical >> (non discrete-math) distinction between "some" and "any", so would not >> object to that single word change if it helps. But "potential" should remain >> as it

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-19 Thread Stuart Marks
On Tue, 19 Mar 2024 22:19:50 GMT, David Holmes wrote: >> In fact, it appears as if the problem is with the use of "any", which is >> universal in strength, whereas the intention here is existential in strength >> (as suggested by. my wording). Indeed, you might achieve the same effect by >> re

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-19 Thread David Holmes
On Tue, 19 Mar 2024 16:38:49 GMT, Y. Srinivas Ramakrishna wrote: >> Sorry, my use of words was sloppy here. I think I did mean loose or somewhat >> informal and therefore slippery. >> >> What I was saying is that using terms such as "any continuing computation" >> doesn't make sense because t

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-19 Thread Y . Srinivas Ramakrishna
On Tue, 19 Mar 2024 16:20:55 GMT, Y. Srinivas Ramakrishna wrote: >> https://docs.oracle.com/javase/specs/jls/se21/html/jls-12.html#jls-12.6.1 >> >>> A reachable object is any object that can be accessed in any potential >>> continuing computation from any live thread. >> >> It may be "loose"

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-19 Thread Y . Srinivas Ramakrishna
On Tue, 19 Mar 2024 02:53:37 GMT, David Holmes wrote: >> src/java.base/share/classes/java/lang/ref/package-info.java line 137: >> >>> 135: * >>> 136: * A reachable object is any object that can be accessed in >>> any potential >>> 137: * continuing computation from any live thread (as stated

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-18 Thread David Holmes
On Tue, 19 Mar 2024 00:40:02 GMT, Y. Srinivas Ramakrishna wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> further tweaks to reachability > > src/java.base/share/classes/java/lang/ref/package-info.java line 137:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-18 Thread Y . Srinivas Ramakrishna
On Thu, 14 Mar 2024 23:23:07 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-18 Thread Brent Christian
On Sat, 16 Mar 2024 04:20:44 GMT, Stuart Marks wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> further tweaks to reachability > > src/java.base/share/classes/java/lang/ref/Reference.java line 402: > >> 400:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-18 Thread Brent Christian
On Sat, 16 Mar 2024 04:21:55 GMT, Stuart Marks wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> further tweaks to reachability > > src/java.base/share/classes/java/lang/ref/package-info.java line 127: > >> 125:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v14]

2024-03-18 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-16 Thread Stuart Marks
On Wed, 31 Jan 2024 01:13:18 GMT, Brent Christian wrote: >> src/java.base/share/classes/java/lang/ref/package-info.java line 109: >> >>> 107: * >>> 108: * The clearing of a reference by the garbage collector >>> happens-before >>> 109: * the garbage collector enqueues the reference. >> >> I

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-16 Thread Stuart Marks
On Thu, 14 Mar 2024 23:23:07 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-14 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v12]

2024-03-12 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v11]

2024-03-01 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-23 Thread Y . Srinivas Ramakrishna
On Thu, 22 Feb 2024 23:43:41 GMT, Brent Christian wrote: >> Thanks for finding my misspelling, djelinski. 👍 > > The use of "(un)successful(ly)" in relation to `Reference.enqueue()` is quite > deliberate (and builds on the previous wording, "successful"). > > The intention was to use it consiste

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v10]

2024-02-22 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Brent Christian
On Thu, 22 Feb 2024 23:14:37 GMT, Brent Christian wrote: >> I note that the adjective(s) (un)successful and the adverb(s) >> (un)successfully are used at several places in these comments, it might >> makes sense to use those terms here as well such that the documentation in >> internally consi

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Brent Christian
On Thu, 22 Feb 2024 18:24:39 GMT, Y. Srinivas Ramakrishna wrote: >> or, better yet, `fails` > > I note that the adjective(s) (un)successful and the adverb(s) > (un)successfully are used at several places in these comments, it might makes > sense to use those terms here as well such that the do

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Y . Srinivas Ramakrishna
On Mon, 27 Nov 2023 22:41:25 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Cleaner thread dequeue happens-before running cleaning action > > src/java.base/share/classes/java/lang/ref/Reference.

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Y . Srinivas Ramakrishna
On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Y . Srinivas Ramakrishna
On Thu, 22 Feb 2024 12:05:31 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/java/lang/ref/Reference.java line 491: >> >>> 489: * If this reference is not registered with a queue, or was >>> already enqueued >>> 490: * (by the garbage collector, or a previous call to {@code

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Daniel Jeliński
On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Daniel Jeliński
On Thu, 22 Feb 2024 12:04:05 GMT, Daniel Jeliński wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Cleaner thread dequeue happens-before running cleaning action > > src/java.base/share/classes/java/lang/ref/Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Viktor Klang
On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-22 Thread Viktor Klang
On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-21 Thread David Holmes
On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v9]

2024-02-21 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v8]

2024-02-21 Thread Brent Christian
On Wed, 21 Feb 2024 01:52:57 GMT, David Holmes wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to reachabilityFence() > > src/java.base/share/classes/java/lang/ref/package-info.java line 118: > >> 116:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v8]

2024-02-20 Thread David Holmes
On Wed, 21 Feb 2024 01:20:24 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v8]

2024-02-20 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Mon, 27 Nov 2023 22:52:10 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/package-info.java line 109: > >> 107:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Mon, 27 Nov 2023 21:51:01 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/package-info.java line 104: > >> 102:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Thu, 30 Nov 2023 22:39:26 GMT, Brent Christian wrote: >> IMO, the core of the semantics here are that the reachabilityFence() call >> happens before clearing or enqueueing of any References to the argument. I >> think it's the call itself, not the end of the argument.s scope (which may >> n

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Mon, 27 Nov 2023 22:33:16 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/Reference.java line 546: > >> 544:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Hans Boehm
On Thu, 25 Jan 2024 23:09:51 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-25 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v6]

2024-01-25 Thread Brent Christian
On Tue, 23 Jan 2024 11:40:00 GMT, Kim Barrett wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Tweak Reference.enqueue memory consistency effects wording > > src/java.base/share/classes/java/lang/ref/Reference.ja

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v6]

2024-01-23 Thread Kim Barrett
On Wed, 10 Jan 2024 22:12:40 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v6]

2024-01-10 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v4]

2024-01-10 Thread Brent Christian
On Wed, 10 Jan 2024 16:09:14 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add links to new Memory Consistency section in package doc > > src/java.base/share/classes/java/lang/ref/Reference.j

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v5]

2024-01-10 Thread Brent Christian
On Sat, 18 Nov 2023 01:56:11 GMT, Mandy Chung wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove hyphen in 'strongly reachable' in Cleaner > > src/java.base/share/classes/java/lang/ref/Reference.java line 39

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v5]

2024-01-10 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v4]

2024-01-10 Thread Viktor Klang
On Tue, 12 Dec 2023 23:36:30 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v4]

2023-12-12 Thread Brent Christian
On Wed, 6 Dec 2023 01:24:51 GMT, Brent Christian wrote: >> Perhaps in each of these places add a link to #Memory Consistency Properties > > I can flesh out the new Memory Consistency Properties section in the package > info to cover the whole chain. Adding links to it sounds like a good idea. I

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v4]

2023-12-12 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

  1   2   >