On Windows, do not return `true` from the `java.io.File` methods
`setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
file does not exist.
-
Commit messages:
- 8316000: File.setExecutable silently fails if file does not exist
Changes: https://git.openjdk.or
On Mon, 11 Sep 2023 22:22:47 GMT, Brian Burkhalter wrote:
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Unfortunately, reformatting caused there to appear to be a lot of c
On Mon, 11 Sep 2023 22:22:47 GMT, Brian Burkhalter wrote:
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
src/java.base/windows/native/libjava/WinNTFileSystem_md.c line 479:
On Tue, 12 Sep 2023 01:36:34 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> src/java.base/windows/native/libjava/WinNTFileSystem_md.c lin
On Tue, 12 Sep 2023 06:27:42 GMT, Alan Bateman wrote:
>> src/java.base/windows/native/libjava/WinNTFileSystem_md.c line 479:
>>
>>> 477: if (access == java_io_FileSystem_ACCESS_READ ||
>>> 478: access == java_io_FileSystem_ACCESS_EXECUTE) {
>>> 479: return _waccess(pathbuf, 0
On Thu, 14 Sep 2023 18:03:48 GMT, Brian Burkhalter wrote:
> If this code does not interact with ACL-based security, then it's not clear
> to me that there's anything to be done here.
Right, these methods were created with POSIX file permissions in mind. On the
surface, the only result it can r
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Re
On Fri, 15 Sep 2023 14:35:43 GMT, Alan Bateman wrote:
>> If this code does not interact with ACL-based security, then it's not clear
>> to me that there's anything to be done here.
>
>> If this code does not interact with ACL-based security, then it's not clear
>> to me that there's anything to
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Ad
On Tue, 19 Sep 2023 22:48:20 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Mo
On Wed, 20 Sep 2023 23:11:27 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Al
On Thu, 21 Sep 2023 08:32:21 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316000: Move apiNotes to normative text; update @return descriptions
>
> src/java.base/share/classes/java/io/File.
On Fri, 22 Sep 2023 22:46:43 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Re
On Mon, 25 Sep 2023 20:25:41 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Mo
On Tue, 26 Sep 2023 18:03:54 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
On Wed, 27 Sep 2023 08:03:38 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316000: Modify spec and return verbiage
>
> src/java.base/share/classes/java/io/File.java line 1630:
>
>> 1628:
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Ad
On Wed, 27 Sep 2023 16:19:04 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
On Wed, 27 Sep 2023 16:57:08 GMT, Alan Bateman wrote:
> I'll add myself as Reviewer to the CSR when you create it.
CSR created. Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/15673#issuecomment-1737786818
23 matches
Mail list logo
