On Wed, 22 Nov 2023 17:57:22 GMT, Gaurav Chaudhari wrote:
>> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a
>> typo. When running without security manager, the test references
>> 'badfactoty.jar' instead of 'badfactory.jar'. This change addresses this by
>> correcting
On Mon, 27 Nov 2023 16:45:12 GMT, Gaurav Chaudhari wrote:
> You can go ahead and contribute the PR in that case.
Thanks! You'll need a sponsor to integrate this PR, then I'll go ahead and
follow up with #16830
-
PR Comment:
On Sat, 25 Nov 2023 16:45:07 GMT, Eirik Bjorsnos wrote:
>>> Reviewer time is a scarce resource. It would be wasteful to spend review
>>> cycles on getting a fix of this `.sh` test integrated now and then
>>> immediately follow up with a delete in the rewrite PR.
>>>
>>> I think we should
On Fri, 24 Nov 2023 16:46:05 GMT, Alan Bateman wrote:
> The change here is trivial, it's okay to integrate and use a separate
> issue/PR to replace the shell test.
Fair point, I filed https://bugs.openjdk.org/browse/JDK-8320712 to track the
rewrite.
@Deigue, would you like to contribute a PR
On Wed, 22 Nov 2023 18:28:30 GMT, Eirik Bjorsnos wrote:
> Reviewer time is a scarce resource. It would be wasteful to spend review
> cycles on getting a fix of this `.sh` test integrated now and then
> immediately follow up with a delete in the rewrite PR.
>
> I think we should handle this
On Wed, 22 Nov 2023 18:01:21 GMT, Eirik Bjorsnos wrote:
>> @eirbjo Yes, as you noticed, the jar file does matter. And the reason I
>> suspected it wasn't noticed was because it was in the scenario of running
>> without security manager, So may that part of the code wasn't being actively
>>
On Wed, 22 Nov 2023 18:01:21 GMT, Eirik Bjorsnos wrote:
>> @eirbjo Yes, as you noticed, the jar file does matter. And the reason I
>> suspected it wasn't noticed was because it was in the scenario of running
>> without security manager, So may that part of the code wasn't being actively
>>
On Wed, 22 Nov 2023 17:53:33 GMT, Gaurav Chaudhari wrote:
> As for the rewrite, it does look good. But would it make more sense to bring
> this change as a separate PR having a own openjdk bug issue # designated to
> reworking of BadFactoryTest.sh for tracking purposes?
We have two options:
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change addresses this by correcting the jar
> name.
Gaurav Chaudhari has refreshed the contents of
On Wed, 22 Nov 2023 11:32:13 GMT, Eirik Bjorsnos wrote:
>>> Looks okay. This test is begging to be re-written in Java, maybe some day.
>>>
>>> I assume the copyright header will be updated before this change is
>>> integrated.
>>
>> Hi @AlanBateman, do I have to update the copyright year to
On Tue, 21 Nov 2023 19:59:16 GMT, Gaurav Chaudhari wrote:
>> Looks okay. This test is begging to be re-written in Java, maybe some day.
>>
>> I assume the copyright header will be updated before this change is
>> integrated.
>
>> Looks okay. This test is begging to be re-written in Java, maybe
On Tue, 21 Nov 2023 21:16:41 GMT, Eirik Bjorsnos wrote:
> So it's not clear to me why this test uses a jar file at all, it does not
> seem necessary.
On a closer look, `${TESTCLASSES}` contains the compiled java classes, but not
the service definition file
On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari wrote:
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change addresses this by correcting the jar
On Tue, 21 Nov 2023 16:36:26 GMT, Alan Bateman wrote:
>> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a
>> typo. When running without security manager, the test references
>> 'badfactoty.jar' instead of 'badfactory.jar'. This change addresses this by
>> correcting the
On Tue, 21 Nov 2023 16:36:26 GMT, Alan Bateman wrote:
> Looks okay. This test is begging to be re-written in Java, maybe some day.
>
> I assume the copyright header will be updated before this change is
> integrated.
Hi @AlanBateman, do I have to update the copyright year to 2023 manually and
On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari wrote:
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change addresses this by correcting the jar
The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
When running without security manager, the test references 'badfactoty.jar'
instead of 'badfactory.jar'. This change addresses this by correcting the jar
name.
-
Commit messages:
- 8319668: Fixup of jar
17 matches
Mail list logo
