Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-22 Thread Hur, Joone
Hi Peter, I’ve updated the file-picker patches as follows: https://github.com/crosswalk-project/crosswalk/pull/2707 https://github.com/crosswalk-project/chromium-crosswalk/pull/241 They should land together. Thanks, Joone _ From: Wang, Peter H Sent: M

Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-18 Thread Hur, Joone
Hi Yongkang, Yes, I’m applying the patches to Crosswalk on Ubuntu so it should work on Linux. I will try to land them this week. Thanks, Joone _ From: You, Yongkang Sent: Tuesday, March 17, 2015 11:38 PM To: Hur, Joone; Wang, Peter H; crosswalk-dev@list

Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-17 Thread You, Yongkang
Hi Joone, What’s the schedule to land the patch? Will it work for general Linux? Thanks, Yongkang _ From: Hur, Joone Sent: Tuesday, March 17, 2015 1:18 AM To: Wang, Peter H; crosswalk-dev@lists.crosswalk-project.org Cc: You, Yongkang; Christiansen, Ke

Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-16 Thread Wang, Peter H
Hi Joone, Thank you for helping. Once it’s landed, I can help to verify on the target platform ASAP, since we really need it before the end of March. Any problem or block please let me know also. Thank you very much for your time. Regards, Peter Wang

Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-16 Thread Hur, Joone
Hi Peter, I have worked on the file-picker support. https://github.com/crosswalk-project/chromium-crosswalk/pull/218 https://github.com/crosswalk-project/crosswalk/pull/2707 It worked on ozone-wayland, but the patches for Crosswalk doesn’t land because there was a crash problem with the shared-p

Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-16 Thread Wang, Peter H
t not reuse the code of 'File Picker' too? At least, we can have 'File Picker' on Linux and not bad than Chrome. Regards, Peter Wang -- Message: 4 Date: Mon, 16 Mar 2015 10:55:06 +0200 From: Raphael Kubo da Costa To: crosswalk-dev@lists.crosswalk-pro

Re: [Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-16 Thread Raphael Kubo da Costa
"Wang, Peter H" writes: > Implementation details: > 1.Inherit ‘ui::LinuxShellDialog’ to implement the factory class of ‘File > Picker’ dialog. >Only ‘ui::LinuxShellDialog::CreateSelectFileDialog’ needs to be overridden. > 2. In ‘XWalkBrowserMainParts::PreEarlyInitialization’, feed the instan

[Crosswalk-dev] Intent to Implement: 'File Picker' of Crosswalk for Linux

2015-03-15 Thread Wang, Peter H
Description: Crosswalk for Linux still doesn’t support ‘File Picker’ now. Since it’s a widely supported feature - especially for desktop - we’re planning to implement it. Affected component: Crosswalk on Linux Related feature: XWALK-950 Targe