[PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> * RECTPP.h: New file. -- Gary R. Van Sickle Brewer. Patriot. 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> * RECTPP.h: New file. RECTPP.h Description: Binary data

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote: > 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> > > * RECTPP.h: New file. Much better. A few remaining nits. a) The class name, as discussed before. b) RECTCC_H__F4098557_9A48_446d_AF28_2BE45D29F68D__INCLUDED_ Uhm, thats plain

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote: >> 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> >> >> * RECTPP.h: New file. > > Much better. A few remaining nits. > > a) The class name, as discussed before. > b) RECTCC_H__F4098557_9A48_446d_AF28_2BE45D29F68D

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Gary R. Van Sickle wrote: >> Robert Collins wrote: >>> On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote: 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> * RECTPP.h: New file. >>> >>> Much better. A few remaining nits. >>> >>> a) The class name, as discussed before. >>> b) RE

RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

> Robert Collins wrote: > > On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote: > >> 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> > >> > >> * RECTPP.h: New file. > > > > Much better. A few remaining nits. > > > > a) The class name, as discussed before. > > b) RECTCC_H__F4098557_9A48_446d_

RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

> On Sun, 2003-04-06 at 10:02, Max Bowsher wrote: > > > > But RECTFOO is a completely different sort of thing to > > SIDWrapper/HANDLEWrapper. Surely we shouldn't call it something that > > suggests resemblance? > > Your point is reasonable. However, the goal of both things is to ease > the use of

RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 13:01, Gary R. Van Sickle wrote: > And that adaptation is not in a manner analagous to that happening in e.g. > HANDLEWrapper*. xxWrapper are full-blown, honest-to-God classes, with > destructors and everything, and are not inherited from structs. Virtual > functions could

RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 13:40, Robert Collins wrote: > On Sun, 2003-04-06 at 13:01, Gary R. Van Sickle wrote: > > > And that adaptation is not in a manner analagous to that happening in e.g. > > HANDLEWrapper*. xxWrapper are full-blown, honest-to-God classes, with > > destructors and everything, an

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 01:01, Max Bowsher wrote: > Robert Collins wrote: > > On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote: > >> 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> > >> > >> * RECTPP.h: New file. > > > > Much better. A few remaining nits. > > > > a) The class name, as dis

RE: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 01:46, Gary R. Van Sickle wrote: > It's a GUID, it's supposed to by ugly. Guaranteed to be unique, not going to > collide with anything ever. That's how MS's "AppWizard" does it, and it seems > like a good idea to me. Please Rob, if you're going to pick nits, pick on > som

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sun, 2003-04-06 at 01:01, Max Bowsher wrote: >> Robert Collins wrote: >>> On Sat, 2003-04-05 at 19:23, Gary R. Van Sickle wrote: 2003-04-05 Gary R. Van Sickle <[EMAIL PROTECTED]> * RECTPP.h: New file. >>> >>> Much better. A few remaining nits. >>> >>> a)

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 04:13, Max Bowsher wrote: > Also, the file has DOS line endings. If convenient, please d2u it. > Otherwise, mention that the committer must d2u it when you resend. Good catch, and a very important point. Rob -- GPG key available at:

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sun, 2003-04-06 at 01:46, Gary R. Van Sickle wrote: > >> It's a GUID, it's supposed to by ugly. Guaranteed to be unique, not >> going to collide with anything ever. That's how MS's "AppWizard" does >> it, and it seems like a good idea to me. Please Rob, if you're goin

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 09:22, Max Bowsher wrote: > > PP doesn't evoke 'Memory compatible wrapper'. It doesn't even evoke > > Wrapper. Or Adapter. > > RECTPP - a C++ version of RECT. If it was that, then we could change field, give it child classes (which implies virtual destructors ...) We can't.

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 09:24, Max Bowsher wrote: > > (We're not a library, so the namespace is ours). > > Rather sparsely used at the moment. Want me to do a global rename? Sure, if you have the time. Probably obvious, but this doesn't apply to libgetopt++/zlib/bz2lib/librsync. If you have the

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sun, 2003-04-06 at 09:22, Max Bowsher wrote: > >>> PP doesn't evoke 'Memory compatible wrapper'. It doesn't even evoke >>> Wrapper. Or Adapter. >> >> RECTPP - a C++ version of RECT. > > If it was that, then we could change field, give it child classes (which > implies vir

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 09:51, Max Bowsher wrote: > >> Maybe RECTWrapper > > > > Exactly. > > Reviewing my suggestion, I don't like it any more. After all, is doesn't > wrap - it inherits. The Adapter pattern (Design Patterns, pg 139) a.k.a. Wrapper uses inheritance. Rob -- GPG key available at:

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sun, 2003-04-06 at 09:51, Max Bowsher wrote: > Maybe RECTWrapper >>> >>> Exactly. >> >> Reviewing my suggestion, I don't like it any more. After all, is doesn't >> wrap - it inherits. > > The Adapter pattern (Design Patterns, pg 139) a.k.a. Wrapper uses > inheritance

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 10:02, Max Bowsher wrote: > But RECTFOO is a completely different sort of thing to > SIDWrapper/HANDLEWrapper. Surely we shouldn't call it something that > suggests resemblance? Your point is reasonable. However, the goal of both things is to ease the use of a MS struct, an

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sun, 2003-04-06 at 19:40, Gary R. Van Sickle wrote: > > >> The question is not what I'd like, but what you won't. If RECTWrapper >> is still acceptable, that's what it'll be. > > RECTWrapper is still acceptable. Can we go with RECTAdapter? It doesn't wrap, and since Rob

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

On Sun, 2003-04-06 at 20:15, Max Bowsher wrote: > Robert Collins wrote: > > On Sun, 2003-04-06 at 19:40, Gary R. Van Sickle wrote: > > > > > >> The question is not what I'd like, but what you won't. If RECTWrapper > >> is still acceptable, that's what it'll be. > > > > RECTWrapper is still accepta

Re: [PATCH] Bigger Chooser Part 3 In Super 3-D: RECTPP

Robert Collins wrote: > On Sun, 2003-04-06 at 20:15, Max Bowsher wrote: >> Robert Collins wrote: >>> On Sun, 2003-04-06 at 19:40, Gary R. Van Sickle wrote: >>> >>> The question is not what I'd like, but what you won't. If RECTWrapper is still acceptable, that's what it'll be. >>> >>> REC