Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip

2023-04-02 Thread Achim Gratz via Cygwin-apps
Jon Turney via Cygwin-apps writes: >> Exchange the while loop using an iffy read construct to a for loop using a >> temporary file. > > I think this change from zero-delimited to whitespace means this will > now fail to handle any filenames containing whitespace correctly? Yes, sorry. I thought

Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip

2023-04-02 Thread Jon Turney via Cygwin-apps
On 30/03/2023 21:34, Jon Turney via Cygwin-apps wrote: On 30/03/2023 20:49, Achim Gratz via Cygwin-apps wrote: Jon Turney via Cygwin-apps writes: On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote: Exchange the while loop using an iffy read construct to a for loop using a temporary

Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip

2023-03-30 Thread Jon Turney via Cygwin-apps
On 30/03/2023 20:49, Achim Gratz via Cygwin-apps wrote: Jon Turney via Cygwin-apps writes: On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote: -    usr/lib/gcc/*/lib*|usr/lib/gcc/*/*.o) +    usr/lib/gcc/*/*.o) Why this change? It looks like a mistake that I didn't catch. +   

Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip

2023-03-30 Thread Achim Gratz via Cygwin-apps
Jon Turney via Cygwin-apps writes: > On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote: >>> -    usr/lib/gcc/*/lib*|usr/lib/gcc/*/*.o) >>> +    usr/lib/gcc/*/*.o) >> Why this change? It looks like a mistake that I didn't catch. >> >>> +    local nproc=$(nproc) >> This limit should

Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip

2023-03-27 Thread Jon Turney via Cygwin-apps
On 26/03/2023 19:12, Jon Turney via Cygwin-apps wrote: -    usr/lib/gcc/*/lib*|usr/lib/gcc/*/*.o) +    usr/lib/gcc/*/*.o) Why this change? +    local nproc=$(nproc) This limit should probably be taken from the --jobs command line parameter, if specified Looking at this a bit

Re: [PATCH cygport] lib/src_postinst.cygpart: parallelize __prepstrip

2023-03-26 Thread Jon Turney via Cygwin-apps
- usr/lib/gcc/*/lib*|usr/lib/gcc/*/*.o) + usr/lib/gcc/*/*.o) Why this change? + local nproc=$(nproc) This limit should probably be taken from the --jobs command line parameter, if specified