Re: [darktable-dev] Deconvolution and Python framework

2017-10-16 Thread Aurélien PIERRE
I understand your point and all I can offer for now are intuitions to be confirmed by experiments. But… : 1. the lens distorsion profiles provided by lensfun are user-produced and my bet is they are not 100 % accurate, which could do more harm than good, 2. to some extend, the

Re: [darktable-dev] Deconvolution and Python framework

2017-10-16 Thread johannes hanika
On Mon, Oct 16, 2017 at 11:21 PM, Tobias Ellinghaus wrote: > Am Sonntag, 15. Oktober 2017, 14:51:47 CEST schrieb Aurélien PIERRE: >> Hi, >> >> this technic aims at solving all kinds of blurs (static and motion >> blurs). The most challenging configuration is when the blur is not >>

Re: [darktable-dev] Deconvolution and Python framework

2017-10-16 Thread Tobias Ellinghaus
Am Sonntag, 15. Oktober 2017, 14:51:47 CEST schrieb Aurélien PIERRE: > Hi, > > this technic aims at solving all kinds of blurs (static and motion > blurs). The most challenging configuration is when the blur is not > uniform along the image. I fear that applying geometric corrections > before

Re: [darktable-dev] Deconvolution and Python framework

2017-10-15 Thread Aurélien PIERRE
Hi ! The algorithm I have implemented so far is http://www.cvg.unibe.ch/dperrone/tvdb/index.html which cites the article you mention in its references. However, I don't like the way your article plays because the algorithm adds a bilateral filter to avoid ringing at the last step which is kind

Re: [darktable-dev] Deconvolution and Python framework

2017-10-15 Thread Aurélien PIERRE
Hi, this technic aims at solving all kinds of blurs (static and motion blurs). The most challenging configuration is when the blur is not uniform along the image. I fear that applying geometric corrections before deblurring could modify the spatial distribution of the blur in the corners and lead

Re: [darktable-dev] Deconvolution and Python framework

2017-10-14 Thread Tim Rolph
Hi All, have any of you guys seen this work? Sounds promising. http://appsrv.cse.cuhk.edu.hk/~leojia/projects/motion_deblurring/index.html Tim. On Wednesday, 11 October 2017 20:59:59 BST Heiko Bauke wrote: > Hi, > > Am 11.10.2017 um 19:11 schrieb Martin Marmsoler: > > Gimp use python as

Re: [darktable-dev] Deconvolution and Python framework

2017-10-14 Thread Tobias Ellinghaus
Am Donnerstag, 12. Oktober 2017, 22:30:51 CEST schrieb Aurélien PIERRE: [...] > I believe that it should be applied right after denoising since this is > low-level signal processing. Also a Total Variation and a Wiener filter > denoising methods should be added to the modules for better results

Re: [darktable-dev] Deconvolution and Python framework

2017-10-13 Thread François Tissandier
Hi Probably a silly idea, but in case this deconvolution is really really long, wouldn't it be possible to run it separately, and save the result as a DNG file ? This way it would be done just once, and no need to recalculate everything each time you want to edit the photo. But maybe it's

Re: [darktable-dev] Deconvolution and Python framework

2017-10-12 Thread Aurélien PIERRE
Hi Tobias and Johannes ! @ Tobias : The standard deconvolution has to be computed on the whole picture since the iterations stack represents the approximated numeric solution of the equation we try to solve with an implicit method, so there is no way to just store a bunch of parameters for a

Re: [darktable-dev] Deconvolution and Python framework

2017-10-12 Thread Tobias Ellinghaus
Am Donnerstag, 12. Oktober 2017, 00:23:42 CEST schrieb Aurélien PIERRE: > Hi ! > > I understand the performance concerns and I'm working on some trade off. > But… [...] > 3 - The most computation-demanding operation is convolution product (2 > FFT-convolve by non blind iteration, 4 by blind

Re: [darktable-dev] Deconvolution and Python framework

2017-10-12 Thread johannes hanika
hi, 1) 16s in single-thread python sounds like it would be possible to do < 100ms in a programming language. 4) that depends on the order of modules. if you want to do it in the current sharpen module as an option, it'll come pretty much last. if you do it early, dt will transparently cache the

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Aurélien PIERRE
Hi ! I understand the performance concerns and I'm working on some trade off. But… 1 - Non-blind Richardson-Lucy deconvolution by gradient descent with Total Variation regularization (probably not the algorithm used in Gimp since it's relatively recent) gives very good results in 25 iterations,

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Heiko Bauke
Hi, Am 11.10.2017 um 19:11 schrieb Martin Marmsoler: Gimp use python as scripting language. It might be easier to port for Gimp? by the way: there is a Richardson Lucy sharpening filter in G'MIC. (As far as I understand this is a non-blind deconvolution algorithm.) Heiko -- --

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Martin Marmsoler
Gimp use python as scripting language. It might be easier to port for Gimp? Am 11.10.2017 17:55 schrieb "Jean-Luc Coulon (f5ibh)" < jean.luc.cou...@gmail.com>: > > but those "challenges" would only affect a small sub-set of dt users > *every* "challenge affect only a small subset of dt users… >

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Jean-Luc Coulon (f5ibh)
> but those "challenges" would only affect a small sub-set of dt users *every* "challenge affect only a small subset of dt users… Only base curve, demosaicing, light-contrast-saturation affect everybody ;) 2017-10-11 17:34 GMT+02:00 Patrick Shanahan : > * Jørn Villesen

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Patrick Shanahan
* Jørn Villesen Christensen [10-11-17 11:25]: > On 2017-10-11 15:35, Pete Hall wrote: > >Just an opinion from a devoted user... It might be a very useful tool for > >me. I shoot a lot of sporting events. It's common for me to find a great > >shot ruined because at the

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Jørn Villesen Christensen
On 2017-10-11 15:35, Pete Hall wrote: Just an opinion from a devoted user... It might be a very useful tool for me. I shoot a lot of sporting events. It's common for me to find a great shot ruined because at the critical moment, the camera focused on the wrong player, or on the goal keeper's

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Patrick Shanahan
* Pete Hall [10-11-17 09:37]: > Just an opinion from a devoted user... It might be a very useful tool > for me. I shoot a lot of sporting events. It's common for me to find a > great shot ruined because at the critical moment, the camera focused on > the wrong player, or on

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Pete Hall
Just an opinion from a devoted user... It might be a very useful tool for me. I shoot a lot of sporting events. It's common for me to find a great shot ruined because at the critical moment, the camera focused on the wrong player, or on the goal keeper's net. Even if it can't be made efficient

Re: [darktable-dev] Deconvolution and Python framework

2017-10-11 Thread Heiko Bauke
Dear Aurélien, Am 10.10.2017 um 10:25 schrieb Aurélien PIERRE: Following my work from this Summer, I'm glad to propose my first blind deconvolution algorithm, written in Python, based on papers from 2011-2014  : https://github.com/aurelienpierre/Image-Cases-Studies TL;DR : Blind

Re: [darktable-dev] Deconvolution and Python framework

2017-10-10 Thread Maurizio Paglia
Aurélien, this is really interesting. I saw some output of Piccure+ and (if REAL and not otherwise handled) they are really interesting! I hope someone can help you with the porting. Maurizio 2017-10-10 10:25 GMT+02:00 Aurélien PIERRE : > Hi ! > > Following my work

Re: [darktable-dev] Deconvolution and Python framework

2017-10-10 Thread Aurélien PIERRE
Hi ! Following my work from this Summer, I'm glad to propose my first blind deconvolution algorithm, written in Python, based on papers from 2011-2014  : https://github.com/aurelienpierre/Image-Cases-Studies TL;DR : Blind deconvolution is a technique used in astronomy and microscopy to deblur

Re: [darktable-dev] Deconvolution and Python framework

2017-05-04 Thread Coding Dave
I can only speak for myself but I find it very interesting. Am 04.05.2017 03:32 schrieb "Aurélien PIERRE" : > Hi, > > I got critics so I made it better ;-) My Richardson-Lucy implementation > now allows to set a mask. This mask is intended to specify the zone where >

Re: [darktable-dev] Deconvolution and Python framework

2017-05-03 Thread Aurélien PIERRE
Hi, I got critics so I made it better ;-) My Richardson-Lucy implementation now allows to set a mask. This mask is intended to specify the zone where the focus is supposed to be, and thus compute the deconvolution matrix estimation only there. This matrix is then used to deconvolute the whole

[darktable-dev] Deconvolution and Python framework

2017-05-03 Thread Aurélien PIERRE
Hi, being a Darktable user since 2010 (0.9 if I recall), a photographer for many years and an almost engineer, I have looked for a long time to get involved into DT development. I know 10 programming languages but I'm still a newbie in C… Following my last email on adaptative deconvolution, I