Re: Request to review and upload unhide 20210124-2

2022-08-02 Thread Samuel Henrique
Hello Daichi, > Thanks for working on this unhide draft package though you were busy in > Debconf. You're welcome, I actually wanted to review during DebConf, but it turns there were already lots of things to do there so I ended up doing it soon after. > I had a look at Debian Policy, Developer

Re: Request to review and upload unhide 20210124-2

2022-08-02 Thread Daichi Fukui
Hello Samuel, Thanks for working on this unhide draft package though you were busy in Debconf. I had a look at Debian Policy, Developers Reference and Lintian Reports to understand the issues you pointed out. Here is an updated draft of the unhide source package: https://salsa.debian.org/dfukui/

Re: Request to review and upload unhide 20210124-2

2022-07-31 Thread Samuel Henrique
Hello Daichi, There are a few lintian findings I'd like you to resolve before we can perform the upload, especially since this will go through the NEW queue due to the inclusion of a new binary package: 1) no-nmu-in-changelog and source-nmu-has-incorrect-version-number: This is happening because

Re: Request to review and upload unhide 20210124-2

2022-07-27 Thread Samuel Henrique
Hello Daichi, > I have drafted an updated source package of unhide and uploaded it to my > private repository in salsa: > > https://salsa.debian.org/dfukui/unhide/-/tree/debian/20210124-3 > > With this version, we will get two separated binary packages, one of which is > a package for unhide GUI

Re: Request to review and upload unhide 20210124-2

2022-07-27 Thread Daichi Fukui
Hello Samuel, I have drafted an updated source package of unhide and uploaded it to my private repository in salsa: https://salsa.debian.org/dfukui/unhide/-/tree/debian/20210124-3 With this version, we will get two separated binary packages, one of which is a package for unhide GUI. When you hav

Re: Request to review and upload unhide 20210124-2

2022-07-14 Thread Samuel Henrique
Hello Daichi, > > You don't need to work on that, but let us know if you're going to (so > > we avoid having two people working on the same thing). > If there is no one working on this issue, I'll do this. > Shout out if you are already doing something for this issue, then we can make > collabora

Re: Request to review and upload unhide 20210124-2

2022-07-13 Thread Daichi Fukui
Hello Samuel. Thanks for sharing this. Plus, I'm sorry for a very late reply. > You don't need to work on that, but let us know if you're going to (so > we avoid having two people working on the same thing). If there is no one working on this issue, I'll do this. Shout out if you are already doin

Re: Request to review and upload unhide 20210124-2

2022-06-18 Thread Samuel Henrique
Hello Daichi, We've got a bugreport requesting the GUI to be put into a different package, so that users can avoid installing it with all its dependencies: #1013127 - unhide: split gui application into separate package https://bugs.debian.org/1013127 I think we should push the requested change. Y

Re: Request to review and upload unhide 20210124-2

2022-06-14 Thread Samuel Henrique
Hello Daichi, > Now I put the latest upload here: > https://salsa.debian.org/dfukui/unhide/-/tree/debian/master-rebase-v2 Great, > In addition, the tag was updated accordingly. > https://salsa.debian.org/dfukui/unhide/-/tags/debian%2F20210124-2 Just for the record, the debian/* tag should only

Re: Request to review and upload unhide 20210124-2

2022-06-10 Thread Daichi Fukui
Hello Samuel. Thanks a lot for the feedback! Now I put the latest upload here: https://salsa.debian.org/dfukui/unhide/-/tree/debian/master-rebase-v2 In addition, the tag was updated accordingly. https://salsa.debian.org/dfukui/unhide/-/tags/debian%2F20210124-2 Take a look at them for details of

Re: Request to review and upload unhide 20210124-2

2022-06-06 Thread Samuel Henrique
Hello Daichi, > I'd appreciate it if you take a look at my revised changes: > https://salsa.debian.org/dfukui/unhide/-/commits/debian/master-rebase > > To help us understand how things have changed since the last draft, > I'd like to show how each of the issues you mentioned was addressed as > fo

Re: Request to review and upload unhide 20210124-2

2022-06-01 Thread Daichi Fukui
Hello Samuel, Thanks for your advice on the translation support in the previous email. With that help, I managed to polish the draft source package posted a few weeks ago. I'd appreciate it if you take a look at my revised changes: https://salsa.debian.org/dfukui/unhide/-/commits/debian/master-reb

Re: Request to review and upload unhide 20210124-2

2022-05-27 Thread Samuel Henrique
Hello Daichi, > Now I'm wondering how to add translation support to the python script > unhideGui.py. > It's not difficult to just translate the French texts into English thanks to > Google Translate ;) > However, it would be a nice idea to use 'gettext' to add translation support > to the pyth

Re: Request to review and upload unhide 20210124-2

2022-05-25 Thread Daichi Fukui
Hello Samuel Thanks for your feedback. I'm sending this email so that I can share with you what's going on. There is one thing to discuss regarding the language issue of unhideGui.py. Now I'm wondering how to add translation support to the python script unhideGui.py. It's not difficult to just tr

Re: Request to review and upload unhide 20210124-2

2022-05-17 Thread Samuel Henrique
Hello all, > With regard to the French text issue, I came up with the following ideas. > If you don't mind, I'd like to discuss with you how we can resolve this issue. > > 1. Make changes to upstream > I don't know why some parts of the GUI program are written in French, but I > wonder if it is p

Re: Request to review and upload unhide 20210124-2

2022-05-16 Thread Daichi Fukui
Hello Samuel, (CC: Iwamatsu-san) Many thanks for your dedicated and helpful feedback. With regard to the French text issue, I came up with the following ideas. If you don't mind, I'd like to discuss with you how we can resolve this issue. 1. Make changes to upstream I don't know why some parts o

Re: Request to review and upload unhide 20210124-2

2022-05-15 Thread Samuel Henrique
Hello Daichi, To make the review easier and avoiding possible conflicts, I suggest that you rebase your changes on the main repo, I have done this on my side for now but it's a good practice that will save you from a headache: git checkout debian/master git remote add team g...@salsa.debian.org:pk

Re: Request to review and upload unhide 20210124-2

2022-05-10 Thread Samuel Henrique
Hello Daichi, I'll review your changes in the next few days, Thanks -- Samuel Henrique

Request to review and upload unhide 20210124-2

2022-05-06 Thread Daichi Fukui
Hello security tools team, Following a suggestion by Samuel [0], I've prepared a new version of the unhide Debian package, which is release 20210124-2 [1]. This new version introduces the following changes: * Add unhideGui.py * Remove weird spaces of d/copyright * Fix path for python3 inter