Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40550 --- Ship it! Ship It! - Josh Elser On April 15, 2014, 8:51 p.m., Sea

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40463 --- Ship it! Ship It! - kturner On April 15, 2014, 8:51 p.m., Sean B

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:51 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 84 > > > > > > If this file exist but it not referenced in the metadata table, then > > this test will not properly v

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/ --- (Updated April 15, 2014, 8:51 p.m.) Review request for accumulo and Josh Elser.

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:51 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 84 > > > > > > If this file exist but it not referenced in the metadata table, then > > this test will not properly v

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:47 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 86 > > > > > > will this cuase the test to fail if the file does not exist? > > Sean Busbey wrote: > yes, I presu

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:51 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 84 > > > > > > If this file exist but it not referenced in the metadata table, then > > this test will not properly v

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40455 --- test/system/auto/simple/recoverWithEmpty.py

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:51 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 84 > > > > > > If this file exist but it not referenced in the metadata table, then > > this test will not properly v

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:47 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 86 > > > > > > will this cuase the test to fail if the file does not exist? > > Sean Busbey wrote: > yes, I presu

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:51 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 84 > > > > > > If this file exist but it not referenced in the metadata table, then > > this test will not properly v

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 15, 2014, 7:47 p.m., kturner wrote: > > test/system/auto/simple/recoverWithEmpty.py, line 86 > > > > > > will this cuase the test to fail if the file does not exist? yes, I presumed that was desirable? - S

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40448 --- test/system/auto/simple/recoverWithEmpty.py

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40447 --- test/system/auto/simple/recoverWithEmpty.py

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/ --- (Updated April 15, 2014, 7:38 p.m.) Review request for accumulo and Josh Elser.

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/ --- (Updated April 15, 2014, 7:21 p.m.) Review request for accumulo and Josh Elser.

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 10, 2014, 2 a.m., Josh Elser wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > line 43 > > > > > > This will create a file in HDFS because CachedConfiguration will

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review40021 --- src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEm

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 10, 2014, 2 a.m., Josh Elser wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > line 43 > > > > > > This will create a file in HDFS because CachedConfiguration will

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 10, 2014, 2 a.m., Josh Elser wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > line 43 > > > > > > This will create a file in HDFS because CachedConfiguration will

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 10, 2014, 2 a.m., Josh Elser wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > line 43 > > > > > > This will create a file in HDFS because CachedConfiguration will

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 9, 2014, 9:42 p.m., Mike Drob wrote: > > Worth noting that in later version we switched away from commons-cli in > > favor of jcommander. > > > > Also, can you add a unit test? > > kturner wrote: > Since Accumulo does not normally create empty RFiles, its not a well > tested th

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review39975 --- src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEm

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 9, 2014, 9:37 p.m., Vikram Srivastava wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > lines 59-66 > > > > > > We can first validate all args, and then create them

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 9, 2014, 9:37 p.m., Vikram Srivastava wrote: > > src/core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java, > > lines 59-66 > > > > > > We can first validate all args, and then create them

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 9, 2014, 9:42 p.m., Mike Drob wrote: > > Worth noting that in later version we switched away from commons-cli in > > favor of jcommander. > > > > Also, can you add a unit test? > > kturner wrote: > Since Accumulo does not normally create empty RFiles, its not a well > tested th

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 9, 2014, 9:42 p.m., Mike Drob wrote: > > Worth noting that in later version we switched away from commons-cli in > > favor of jcommander. > > > > Also, can you add a unit test? > > kturner wrote: > Since Accumulo does not normally create empty RFiles, its not a well > tested th

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

> On April 9, 2014, 9:42 p.m., Mike Drob wrote: > > Worth noting that in later version we switched away from commons-cli in > > favor of jcommander. > > > > Also, can you add a unit test? Since Accumulo does not normally create empty RFiles, its not a well tested thing. The RFile unit test ex

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review39938 --- Worth noting that in later version we switched away from commons-cli

Re: Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/#review39937 --- Ship it! LGTM. One minor comment regarding usability. src/core/sr

Review Request 20180: ACCUMULO-2654 Adds utility for creating empty rfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20180/ --- Review request for accumulo and Josh Elser. Bugs: ACCUMULO-2654 https://iss