Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> Looking at the CPU graph instead I can see many odd things ie Compaction
is stealing lot of cpu and I/O:
Nice find.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@franz1981 nice graphs, looks like essentially isPaging in QueueImpl unless
everything is dirtyRead then we simply move the problem somewhere else, i think
we probably need to m
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> > > CursorIterator:hasNext
> >
> >
> > Im bit concerned with this doing a dirty read, as this isnt something
that is trigger an ascyn action, in actual fact the h
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
So out the two, the checkDepage is the safer one to use a dirty read, so id
expect to see that changed first before anything else.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
Yes you could add this to set in the section within the constructor where
message != null, seems sensible.
---
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
> Im very cautious of optimising for one case
> Its very unusual for consumers to go away as it is good design in most
mom a consumer is long lived. Like wise upgrade is a non normal e
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245224854
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boole
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce
> @qihongxu you're using JMS api not core api then?
Yes (sometimes for for compatibility concern)
> @qihongxu i dont see checkDepage using the dir
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
Im very cautious of optimising for one case
Its very unusual for consumers to go away as it is good design in most mom
a consumer is long lived.
So without it remov
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
during initial development years ago I needed to be careful when to leave
paging. this needed some sync points to make sure depage would set it
synchronously.
I'm not sayin
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
@michaelandrepearce
There are some cases will perform lots of rollbacks in a short period of
time. For example if we would like to upgrade our server while thousands of
consumers are
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r245195927
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -120,6 +128,8 @@ public PagedR
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> > CursorIterator:hasNext
>
> Im bit concerned with this doing a dirty read, as this isnt something
that is trigger an ascyn action, in actual fact the hasNext is purposefully
sync
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245183888
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boolean i
Github user wy96f commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
> interim
Yes. The problem did't occur these days. We'll give more investigation.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
Looking at the CPU graph instead I can see many odd things:
- Page writing is double copying the heap ByteBuffer into a native
ByteBuffer to write on the page file:
![image]
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
I have taken a look on the version used for this PR + the change suggested
by @michaelandrepearce
on checkDepage and I have found that:
LivePageCacheImpl (in violet) is now a ma
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@michaelandrepearce @qihongxu Just a lil OT but I'm getting these warns on
master:
```
2019-01-03 17:36:44,408 WARN [org.apache.activemq.artemis.journal]
AMQ142007: Can not find
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2480
@michaelandrepearce Not yet, need to chenge it and we just need the opinion
from @clebertsuconic here, given that we I'm concerned about the max size that
the array q can get and that wi
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@qihongxu i dont see checkDepage using the dirtyRead in current commit
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> The version I have shown is just master ie any read lock is there!
I get that, im more relfecting on this change in PR.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245095523
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1350,7 +1
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245094809
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ pub
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
The version I have shown is just master ie any read lock is there!
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2479
@franz1981 this is out my league on this, im not so familiar with journal
bits/logic, you ok with me leaving this for @clebertsuconic ?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2480
@franz1981, did you make the change to syncronized methods? As this PR is
about performance im for getting the most we can in one ;)
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2481
Can we close this for the interim?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2483
Im less familar with the journal stuff in general from what i can tell
though it looks good, so will let @franz1981 give a thumbs up on the logic
change, but from better use of
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r245090041
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -30
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2482
@qihongxu nudge
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> CursorIterator:hasNext
Im bit concerned with this doing a dirty read, as this isnt something that
is trigger an ascyn action, in actual fact the hasNext is purposefull
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> > Instead of transaction consumer you could use client acknowledge or
even individual acknowledge.
>
> It seems that both client-acknowledge and individual-acknowledge
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245048241
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boole
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
Cool so will leave as is then. thanks for the review!
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
@qihongxu Just as a confirmation, I have used
https://github.com/jvm-profiling-tools/async-profiler on lock events ie time
while waiting to enter into a lock and I have found the same ex
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
Yep, it is a common scenario to use a security manager so I prefer to not
force adding any exception on the security manger to allow just this calls to
work
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245030347
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029912
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.jav
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029854
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
+/
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029745
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2494,36 @@ private
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029528
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
@franz1981 can you check your private email, a few queries on MethodHandle
;)
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
@michaelandrepearce It has been introduced into Java 8 to support the
lambda as they are now, Java 9 has introduced VarHandle, that has a similar
name and overlapping functionalities :P
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
@franz1981 is that java 8? I thought it was Java 9+
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
@michaelandrepearce Consider that a static final MethodHandle::invokeExact
has performance similar to a direct call, not a reflective call
http://mail.openjdk.java.net/pipermail/jigsaw-d
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
Reflection would not be good here, getArray is HOT path, its reason why i
need it.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
@michaelandrepearce Yep, I have written it everytime while reading the code
mate, sorry :)
Yes I do understand the bits related to byte vs int (and I agree) and
related to `Iterator:
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245014300
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245013090
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245011975
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
+/
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245012214
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
@franz1981 alot of comments where why integer vs byte, whilst legacy
ActiveMQ only supported 0-127 in open wire, many other brokers support integer
for this feature, e.g. QPID f
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245010184
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
+
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009418
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.jav
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009864
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245008661
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -3080,45 +3053,20 @@ private
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009338
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.jav
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245008000
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2494,36 @@ private
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245007330
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245007052
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006670
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006519
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java
---
@@ -0,0 +1,34 @@
+/*
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006326
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java
---
@@ -21,7 +21,7 @@
import org.apa
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> Instead of transaction consumer you could use client acknowledge or even
individual acknowledge.
It seems that both client-acknowledge and individual-acknowledge mode will
fina
Hello, activemq folks.
As stated earlier in 2018, all git repositories must be migrated from
the git-wip-us.apache.org URL to gitbox.apache.org, as the old service
is being decommissioned. Your project is receiving this email because
you still have repositories on git-wip-us that needs to be migrat
Github user qihongxu commented on the issue:
https://github.com/apache/activemq-artemis/pull/2484
> @qihongxu,
>
> re:
> "
> According to this we have an internal branch that removes isPaging()
methodâs readlock in PagingStoreImpl, along with adding pageSyncTimerâs
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
I have taken a fast look and already written down some comment: it looks ok
to me, but I need to look further in the `QueueConsumersImpl` details.
I'm happy about the nice abstraction
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244987340
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
---
@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986539
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986350
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244985399
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244984864
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -3080,45 +3053,20 @@ private boolean
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244984274
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2494,36 @@ private void del
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244982460
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244980096
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244979227
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244979032
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244978399
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java
---
@@ -0,0 +1,34 @@
+/*
+ * Li
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244977454
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -727,7 +725,
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244976790
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java
---
@@ -21,7 +21,7 @@
import org.apache.activ
Github user CNNJYB commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244976446
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -309,16 +309,17
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2488
Ready for review.
Ill look to merge within the week.
As noted by the Jira ticket, this is to add feature that is in ActiveMQ5
(http://activemq.apache.org/consu
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2488
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in QueueImpl to its own logical
class, to be able to implement
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2487
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2487
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in queueimpl to its own logical
class, to be able to implement
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2486
---
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2486
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2486
Ready for review, will look to merge in a week if no comments.
---
GitHub user michaelandrepearce reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2486
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in queueimpl to its own logical
class, to be able to impleme
89 matches
Mail list logo
