ix it (keep fingers crossed).
> > https://github.com/apache/airflow/pull/6054. If I correctly diagnosed
> it,
> > tt was my mistake of course :(.
> >
> > Seems it was an accidental transitive dependency (coverage) removal when
> I
> > moved codecov integration to
Seems it was an accidental transitive dependency (coverage) removal when I
> moved codecov integration to use the latest recommended integration method
> - I removed codecov from dependencies as it is not needed, but it removed
> coverage as well.
> And it was working when I was testing it, bec
I think the latest PR should fix it (keep fingers crossed).
https://github.com/apache/airflow/pull/6054. If I correctly diagnosed it,
tt was my mistake of course :(.
Seems it was an accidental transitive dependency (coverage) removal when I
moved codecov integration to use the latest recommended
Not yet. Will do soon :).
J.
On Wed, Sep 4, 2019 at 3:51 PM Driesprong, Fokko
wrote:
> Did you find any time to fix this Jarek? Would be great to get this up and
> running again.
>
> Cheers, Fokko
>
> Op wo 28 aug. 2019 om 14:28 schreef Jarek Potiuk >:
>
> > Apologies - I broke it at some poi
Did you find any time to fix this Jarek? Would be great to get this up and
running again.
Cheers, Fokko
Op wo 28 aug. 2019 om 14:28 schreef Jarek Potiuk :
> Apologies - I broke it at some point of time when introducing new CI
> approach. This one commit that Kaxil mentions was supposed to fix it
Apologies - I broke it at some point of time when introducing new CI
approach. This one commit that Kaxil mentions was supposed to fix it :). I
think it was broken afterwards or during rebase.
The problem with codecov is that until you merge it to master you never
know if it finally works or not (i
It seems to be not doing much as it is unable to find a dependency.
_ _
10217 / || |
10218| | ___ __| | ___ ___ _ __
10219| |/ _ \ / _` |/ _ \/ __/ _ \ \ / /
10220| |___| (_) | (_| | __/ (_| (_) \ V /
10221 \_\___/ \__,_|\___|\___\___/ \_/
10222
The change seems to be that the CodeCov is now embedded inside tests and is
run at last.
Check this: https://travis-ci.org/apache/airflow/jobs/577789685#L10216
On Wed, Aug 28, 2019 at 12:49 PM Kaxil Naik wrote:
> Looks like this commit:
> https://github.com/apache/airflow/commit/8b41c3f12944c
Looks like this commit:
https://github.com/apache/airflow/commit/8b41c3f12944c9b87fd04bd7137ba03d7e5a502f#diff-2eeaed663bd0d25b7e608891384b7298
changed
it.
On Wed, Aug 28, 2019 at 12:39 PM Driesprong, Fokko
wrote:
> I've noticed that the latest reports are at 2019-08-08:
> https://codecov.io
I've noticed that the latest reports are at 2019-08-08:
https://codecov.io/github/apache/airflow?branch=master
But I don't see any commits that day that changed any significantly on that
area:
https://github.com/apache/airflow/commits/master?after=f40b3b5dd766f271447fef282bb6681bff575814+139
Op w
Hi Kaxil,
I did notice that the coveralls library is gone, we had this before to push
it to codecov. I know that the names are different, and it is confusing, I
tried to remove it before: https://github.com/apache/airflow/pull/3295
Let us see if it works again when reenabling this library:
https:
Did we remove codecov.io integration from Airflow?
Previously on each PR we used to get info if the Code Coverage would
increase/decrease by what % if it is merged.
Regards,
Kaxil
12 matches
Mail list logo
