Re: [VOTE] LDAP in APR 2.x?

2009-03-24 Thread Ruediger Pluem
On 24.03.2009 12:33, Graham Leggett wrote: Jeff Trawick wrote: any counter-knowledge/opinions on the following? assert(only httpd uses apr LDAP) Can you cite references to show this is so? I would be very hard pressed to assert that functionality that has been available in APR for many

Re: Modular APR

2009-03-24 Thread Ruediger Pluem
On 24.03.2009 17:41, Mladen Turk wrote: Joe Orton wrote: On the topic of how to split up APR into multiple libraries, I had a look through the current directories, and a first cut at how I'd propose to split the code up would be: (directory - library-name [dependencies]) buckets -

Re: svn commit: r748902 - in /apr/apr/trunk: build/buildcheck.sh buildconf configure.in

2009-03-06 Thread Ruediger Pluem
On 02/28/2009 07:32 PM, jerenkra...@apache.org wrote: Author: jerenkrantz Date: Sat Feb 28 18:32:55 2009 New Revision: 748902 URL: http://svn.apache.org/viewvc?rev=748902view=rev Log: Go back around and clean up GNU libtool 2.x detection and usage. (Tested with GNU libtool 2.2.6,

Re: svn commit: r747990 - in /apr/apr/trunk: ./ file_io/netware/ file_io/unix/ include/arch/unix/ network_io/unix/ poll/unix/

2009-02-26 Thread Ruediger Pluem
On 02/26/2009 03:41 AM, bo...@apache.org wrote: Author: bojan Date: Thu Feb 26 02:41:21 2009 New Revision: 747990 URL: http://svn.apache.org/viewvc?rev=747990view=rev Log: Set CLOEXEC flags where appropriate. Either use new O_CLOEXEC flag and associated functions, such as dup3(),

Re: svn commit: r745763 - in /apr/apr/trunk: ./ build/ include/ include/arch/unix/ network_io/unix/ test/

2009-02-19 Thread Ruediger Pluem
On 02/19/2009 08:15 AM, mt...@apache.org wrote: Author: mturk Date: Thu Feb 19 07:15:23 2009 New Revision: 745763 URL: http://svn.apache.org/viewvc?rev=745763view=rev Log: Enable unix domain (AF_UNIX) sockets if supported by the OS Modified: apr/apr/trunk/CHANGES

Re: svn commit: r744095 [1/2] - in /apr/apr/trunk: ./ include/ include/arch/unix/ poll/os2/ poll/unix/

2009-02-14 Thread Ruediger Pluem
On 02/13/2009 01:24 PM, mt...@apache.org wrote: Author: mturk Date: Fri Feb 13 12:24:00 2009 New Revision: 744095 URL: http://svn.apache.org/viewvc?rev=744095view=rev Log: Implement providers for apr_pollset and apr_pollcb Modified: apr/apr/trunk/CHANGES

Re: svn commit: r744096 - in /apr/apr/trunk/poll/unix: pollcb.c pollset.c

2009-02-14 Thread Ruediger Pluem
On 02/13/2009 01:25 PM, mt...@apache.org wrote: Author: mturk Date: Fri Feb 13 12:25:00 2009 New Revision: 744096 URL: http://svn.apache.org/viewvc?rev=744096view=rev Log: Implement providers for apr_pollset and apr_pollcb. Add common files Added:

Re: svn commit: r741862 - in /apr/apr/trunk: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/ shmem/beos/ shmem/os2/ shmem/unix/ shmem/win32/ threadproc/be

2009-02-07 Thread Ruediger Pluem
On 02/07/2009 10:05 AM, mt...@apache.org wrote: Author: mturk Date: Sat Feb 7 09:05:54 2009 New Revision: 741862 URL: http://svn.apache.org/viewvc?rev=741862view=rev Log: Add object perms set macros and implement them for shm and mutex Added:

Re: svn commit: r741862 - in /apr/apr/trunk: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/ shmem/beos/ shmem/os2/ shmem/unix/ shmem/win32/ threadproc/be

2009-02-07 Thread Ruediger Pluem
On 02/07/2009 10:05 AM, mt...@apache.org wrote: Author: mturk Date: Sat Feb 7 09:05:54 2009 New Revision: 741862 URL: http://svn.apache.org/viewvc?rev=741862view=rev Log: Add object perms set macros and implement them for shm and mutex Added:

Re: svn commit: r731291 - in /apr/apr-util/trunk: CHANGES build/crypto.m4 crypto/apr_crypto_nss.c

2009-01-04 Thread Ruediger Pluem
On 01/04/2009 05:28 PM, minf...@apache.org wrote: Author: minfrin Date: Sun Jan 4 08:28:51 2009 New Revision: 731291 URL: http://svn.apache.org/viewvc?rev=731291view=rev Log: apr_crypto_nss: Oh that it was this easy. Use pgk-config to find NSS where possible. Modified:

Re: [Fwd: Re: proxy_ajp connect timeout fix.]

2008-12-18 Thread Ruediger Pluem
On 12/18/2008 02:38 PM, Jess Holle wrote: P.S. Matt Stevenson's fix/workaround seems to have done the trick quite nicely. I tend to agree with the comments on the httpd group, however -- one shouldn't have to do such things in code calling apr_socket_connect(). Rather apr_socket_connect()

Re: APR_BRIGADE_SENTINEL macro causes compile error

2008-12-06 Thread Ruediger Pluem
On 12/06/2008 08:40 PM, Craig Holmquist wrote: Use of the APR_BRIGADE_SENTINEL macro now causes compile errors with the current APR headers. This was observed trying to compile mod_python with the httpd 2.2.10 headers, on MS Windows with Visual Studio 2008, but I suspect it affects all

Re: apr_memcache 1.3.X sending unnecessary QUIT to memcached server

2008-10-03 Thread Ruediger Pluem
On 10/03/2008 06:08 AM, peter baer wrote: Also, if you look at the apr_reslist_create() documentation, it states that the ttl if non-zero, sets the maximum amount of time a resource may be available while exceeding the soft limit. . Why then is the destructor being called for all resources

Re: apr_file_* weirdness on Mac OS X

2008-10-03 Thread Ruediger Pluem
On 10/03/2008 05:50 PM, Tim Bray wrote: Um, I know that. But apr_file_mktemp doesn't let you control where the temp file goes, right? And now that I think of it, the file can be No, of course you can control where the file goes. Just fill the templ parameter appropriately:

Re: Corrected: global_mutex on Solaris 10, does it actually work?

2008-10-03 Thread Ruediger Pluem
On 10/03/2008 09:39 PM, Tim Bray wrote: Correcting two errors in my original post, why don't I just copy paste? So, there's this file I want to update, suppose its name is in the variable filename, so I go status = apr_global_mutex_create(mutex, filename, APR_LOCK_DEFAULT,

Re: svn commit: r692949 [2/2] - in /apr/apr-util/trunk: ./ build/ crypto/ test/ test/data/

2008-09-09 Thread Ruediger Pluem
On 09/07/2008 10:42 PM, [EMAIL PROTECTED] wrote: +static unsigned char *encrypt_block(abts_case *tc, apr_pool_t *pool, +const apr_crypto_driver_t *driver, const apr_crypto_t *f, +const apr_crypto_key_t *key, const unsigned char *in, +const apr_size_t inlen, unsigned

Re: apu_dso_load and errors

2008-09-06 Thread Ruediger Pluem
On 09/06/2008 04:05 PM, Graham Leggett wrote: Hi all, The current dso helper code in apr-util masks the apr_dso_handle_t structure from the caller, and in the process makes it impossible to call apr_dso_error to find the human readable error message for why the module failed to load. The

Re: 1.3.4 apr-util tarball for review

2008-08-15 Thread Ruediger Pluem
For the record my +1 on apr-util 1.3.4. Tested on Solaris 8, 9, 10 (SPARC, 32 Bit compile) and various RedHat and SuSE Linux versions 32 and 64 Bit. Regards Rüdiger On 08/15/2008 11:41 PM, William A. Rowe, Jr. wrote: William A. Rowe, Jr. wrote: Available in the usual;

Re: 1.3.3 tarballs for review

2008-08-12 Thread Ruediger Pluem
On 08/12/2008 05:11 PM, Jeff Trawick wrote: apr-util: testxlate : |Line 63: expected 0, but saw 22 (perhaps the lack of expected charset aliases in Solaris iconv()?) I guess these last two messages are not errors:: Failed to load driver file apr_dbd_sqlite2.so Failed to load

Re: 1.3.3 tarballs for review

2008-08-10 Thread Ruediger Pluem
On 08/09/2008 04:37 PM, William A. Rowe, Jr. wrote: Available in the usual; http://apr.apache.org/dev/dist/, win32 with exported .mak files to follow as soon as I have a bit of free time, busy weekend here so likely on Sunday eve (when I'll look also at committing Carlo's efforts on MinGW).

Time for 1.3.3

2008-08-07 Thread Ruediger Pluem
What obstacles are left between us and an 1.3.3 release of APR / APR-UTIL? Regards Rüdiger

Re: Time for 1.3.3

2008-08-07 Thread Ruediger Pluem
On 08/07/2008 10:08 PM, William A. Rowe, Jr. wrote: Ruediger Pluem wrote: What obstacles are left between us and an 1.3.3 release of APR / APR-UTIL? Here's an offer, I'll tag and roll 24 hours from now unless someone tells me that the API remains broken w.r.t. reslist etc. Unless we hear

Re: svn commit: r683191 - /apr/apr-util/trunk/misc/apr_reslist.c

2008-08-06 Thread Ruediger Pluem
On 08/06/2008 11:25 AM, [EMAIL PROTECTED] wrote: Author: mturk Date: Wed Aug 6 02:25:52 2008 New Revision: 683191 URL: http://svn.apache.org/viewvc?rev=683191view=rev Log: Do not serialize destructor calls. Modified: apr/apr-util/trunk/misc/apr_reslist.c Modified:

Re: svn commit: r683191 - /apr/apr-util/trunk/misc/apr_reslist.c

2008-08-06 Thread Ruediger Pluem
On 08/06/2008 12:27 PM, Mladen Turk wrote: Ruediger Pluem wrote: This looks dangerous to me. The destructor gets the reslist pool handed over and pools are not thread save. See also: Hmm, might be. Although the pool create/destroy is thread safe. I am worried about the case

Re: Resource list limits

2008-07-28 Thread Ruediger Pluem
On 07/28/2008 01:52 AM, Bojan Smojver wrote: I think we should be a little bit more strict when it comes to resource limits in reslist code. As per attached, it should not be possible to set min to less than zero and hmax to zero, as both don't make sense. Comments? Looks good. +1.

Re: Reslist v. no threads

2008-07-28 Thread Ruediger Pluem
On 07/28/2008 02:03 AM, Bojan Smojver wrote: On Sun, 2008-07-27 at 13:50 +0100, Nick Kew wrote: +1. Here is a rough sketch, so please review. Please note the enforcement of min, smax and hmax to 1. Hm, of course still a lot of overhead to manage a single resource. But I am not really

Re: Changing the order of cleanup for some core objects

2008-07-23 Thread Ruediger Pluem
On 07/23/2008 08:21 AM, Bojan Smojver wrote: On Wed, 2008-07-23 at 16:12 +1000, Bojan Smojver wrote: Here is a rough sketch. Just one quick thought from the peanut gallery: Wouldn't it be better to keep the resource specific pools and just do an apr_pool_clear instead of the

Re: svn commit: r676807 - in /apr/apr/trunk: CHANGES include/apr_hash.h tables/apr_hash.c

2008-07-15 Thread Ruediger Pluem
On 07/15/2008 08:29 AM, [EMAIL PROTECTED] wrote: Author: mturk Date: Mon Jul 14 23:29:29 2008 New Revision: 676807 URL: http://svn.apache.org/viewvc?rev=676807view=rev Log: Intruduce apr_hash_do function Modified: apr/apr/trunk/CHANGES apr/apr/trunk/include/apr_hash.h

Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken

2008-07-08 Thread Ruediger Pluem
On 07/08/2008 07:55 PM, Philip M. Gollucci wrote: Resending from an address that will make it through to lists. Philip M. Gollucci wrote: Hi All, as you can see the recent update of devel/apr from 1.2.12 to 1.3.2 breaks apr-util when building with LDAP on FreeBSD. The log is from a

Re: ports/125400: devel/apr APR_UTIL_WITH_LDAP=yes building is broken

2008-07-08 Thread Ruediger Pluem
On 07/08/2008 09:23 PM, Philip M. Gollucci wrote: Ruediger Pluem wrote: if test $apu_has_ldap_openldap = 1; then +CPPFLAGS=$save_cppflags +LDFLAGS=$save_ldflags +LIBS=$save_libs Shouldn't this be the other way round such that you *safe* the old values of CPPFLAGS, LDFLAGS

Re: [Fwd: connobject.c broke with apr 1.3.2]

2008-06-30 Thread Ruediger Pluem
On 06/30/2008 08:28 PM, Tom Donovan wrote: William A. Rowe, Jr. wrote: Guys, please take a look, looks like one of the 1.3.x generation patches has broken our API compatibility rules. It looks like this has always been wrong in mod_python. APR_BRIGADE_SENTINEL takes a brigade argument, not

Re: Strange continous SEVERE error after upgrading to APR 1.3, Critical poller failure, Timer expired

2008-06-26 Thread Ruediger Pluem
On 06/26/2008 01:15 PM, Nick Kew wrote: Works for me in terms of fixing this bug. But looking at the history of this bug (we had a much smaller bug, had a fix, then introduced this bug by switching to apr_get_netos_error because it felt better), I'd be wary of repeating the same thought

Re: Strange continous SEVERE error after upgrading to APR 1.3, Critical poller failure, Timer expired

2008-06-25 Thread Ruediger Pluem
On 06/25/2008 02:55 PM, Nick Kew wrote: On Wed, 2008-06-25 at 12:43, Nick Kew wrote: On Wed, 25 Jun 2008 10:32:58 +0200 Jimi Hullegård [EMAIL PROTECTED] wrote: Hi, After we upgraded APR from 1.2.8 to 1.3.0 we get a strange error in tomcat's catalina.out that we have never seen before: Jun

Re: [vote] Release apr[-util] 1.3.2

2008-06-18 Thread Ruediger Pluem
On 06/17/2008 03:40 PM, William A. Rowe, Jr. wrote: Candidates will be up at http://apr.apache.org/dev/dist/ once the sync happens within the hour... vote away; +/-1 [ +1 ] Release apr 1.3.2 as GA [ +1 ] Release apr-util 1.3.2 as GA Passes all tests on the following platforms: RHEL

Re: svn commit: r668354 - /apr/apr-util/trunk/CHANGES

2008-06-17 Thread Ruediger Pluem
@@ *) Add ODBC DBD driver [Tom Donovan] + *) Older OpenLDAP implementations may have ldap_set_rebind_proc() with two + args. Provide detection code and alternative implementation. + [Ruediger Pluem] + Thanks, but actually you did most of the work by writing the initial patch. I only

Re: [vote] Release apr[-util] 1.3.2

2008-06-17 Thread Ruediger Pluem
On 06/17/2008 06:25 PM, Lucian Adrian Grijincu wrote: On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Candidates will be up at http://apr.apache.org/dev/dist/ once the sync happens within the hour... vote away; A Cell Blade system: Linux 2.6.22-5.20070920bsc #1

Re: [vote] Release apr[-util] 1.3.2

2008-06-17 Thread Ruediger Pluem
On 06/17/2008 08:55 PM, Lucian Adrian Grijincu wrote: On Tue, Jun 17, 2008 at 19:25, Lucian Adrian Grijincu [EMAIL PROTECTED] wrote: On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Candidates will be up at http://apr.apache.org/dev/dist/ once the sync happens

Re: [vote] Release apr[-util] 1.3.2

2008-06-17 Thread Ruediger Pluem
On 06/17/2008 10:37 PM, Lucian Adrian Grijincu wrote: On Tue, Jun 17, 2008 at 22:24, Ruediger Pluem [EMAIL PROTECTED] wrote: Thanks for investigating, but keep two things in mind: 1. If errno is really 0 it would be a bug in your glibc / Linux kernel as the man page is very clear about

Re: [vote] Release apr[-util] 1.3.2

2008-06-17 Thread Ruediger Pluem
On 06/17/2008 11:57 PM, Lucian Adrian Grijincu wrote: On Wed, Jun 18, 2008 at 00:53, Ruediger Pluem [EMAIL PROTECTED] wrote: Please execute the following command on your box and supply the output: Never knew time could list so many things :) /usr/bin/time --verbose sleep 0 Command

Re: [vote] Release apr[-util] 1.3.1

2008-06-16 Thread Ruediger Pluem
On 06/16/2008 02:17 AM, Bojan Smojver wrote: On Mon, 2008-06-16 at 10:07 +1000, Bojan Smojver wrote: Nah, forget it - wrong and incomplete. Let me do a better one... OK, for real this time :-) PS. I don't have RHEL3 platform handy, so please compile and let me know. I checked it on Red

Re: [vote] Release apr[-util] 1.3.1

2008-06-16 Thread Ruediger Pluem
On 06/16/2008 12:46 AM, Bojan Smojver wrote: On Mon, 2008-06-16 at 08:02 +1000, Bojan Smojver wrote: The AC_CACHE_VAL should be changed to AC_CACHE_CHECK, which then provides pretty printing of messages for non-nested version of checks. Could you check if this works on Solaris? I tested

Re: [vote] Release apr[-util] 1.3.1

2008-06-16 Thread Ruediger Pluem
On 06/16/2008 11:08 PM, Bojan Smojver wrote: On Mon, 2008-06-16 at 22:09 +0200, Ruediger Pluem wrote: I checked it on Red Hat AS 3 and it basicly works, but the 'two argument' function prototype is wrong. I adjusted your patch accordingly and now it compiles fine without any warning

Re: [vote] Release apr[-util] 1.3.1

2008-06-15 Thread Ruediger Pluem
On 06/15/2008 06:23 AM, William A. Rowe, Jr. wrote: Subject asks it all, candidates are up at http://apr.apache.org/dev/dist/ for your reviewing pleasure... vote away; +/-1 [ -1 ] Release apr 1.3.1 as GA [ -0 ] Release apr-util 1.3.1 as GA Windows .zip's will follow when my head is

Re: [vote] Release apr[-util] 1.3.1

2008-06-15 Thread Ruediger Pluem
On 06/15/2008 01:08 PM, Ruediger Pluem wrote: On 06/15/2008 06:23 AM, William A. Rowe, Jr. wrote: Subject asks it all, candidates are up at http://apr.apache.org/dev/dist/ for your reviewing pleasure... vote away; +/-1 [ -1 ] Release apr 1.3.1 as GA [ -0 ] Release apr-util 1.3.1

Re: [vote] Release apr[-util] 1.3.1

2008-06-15 Thread Ruediger Pluem
On 06/15/2008 07:39 PM, William A. Rowe, Jr. wrote: Ruediger Pluem wrote: The attached patch fixes this for me, but as I am no autoconf specialist some remote eyes seem to be a good idea before committing. Do you know offhand that multiple AC_CACHE_VAL( ac_cv_val, ...) entries are legit

Re: Attn New Committers

2008-06-14 Thread Ruediger Pluem
On 06/14/2008 10:20 PM, William A. Rowe, Jr. wrote: Please don't do this; --- Revision 663845 - Directory Listing Modified Fri Jun 6 07:39:52 2008 UTC (8 days, 12 hours ago) by henryjen backport r663342 from trunk --- Such commit messages aren't legible when comparing a

Re: showstopper to 1.3.1?

2008-06-14 Thread Ruediger Pluem
On 06/14/2008 10:42 PM, William A. Rowe, Jr. wrote: Guys, if anyone is looking at this, I'll hold off from tagging a bit longer, as I'd rather have apr-1.3.1 address all the platform quirks we identified in preparing 2.2.9 for release. But if I hear nothing, I'll have to just move ahead :)

Re: tabs

2008-06-13 Thread Ruediger Pluem
On 06/13/2008 09:27 PM, William A. Rowe, Jr. wrote: Jim Jagielski wrote: Topic for a fun conversation: Should we detab the various APR source? We've never really instituted a specific coding style, ala httpd, but 1.3.x might not be a bad place to start. I'm proposing this for post-1.3.1

Re: ODBC driver (Re: Summary of win32 build issues)

2008-06-11 Thread Ruediger Pluem
On 06/11/2008 03:27 AM, Nick Kew wrote: On Tue, 10 Jun 2008, Tom Donovan wrote: If there's interest, I have an ODBC DBD driver I would be glad to contribute. +1 Regards Rüdiger

Re: [VOTE] Release apr-1.3.0, apr-util-1.3.0

2008-06-04 Thread Ruediger Pluem
On 06/03/2008 03:34 PM, Ruediger Pluem wrote: Any comments on belows patches? If not I will commit, but don't cry then if it breaks some platform on trunk. You have been asked before :-). Some test results from SPARC Solaris (8, 9, 10) with Solaris LDAP SDK. All test pass except

Re: [VOTE] Release apr-1.3.0, apr-util-1.3.0

2008-06-03 Thread Ruediger Pluem
On 05/31/2008 12:26 AM, William A. Rowe, Jr. wrote: Unix tarballs are up, win32 .zip's with .mak files will follow. Your votes please; +/-1 [ ] Release apr-1.3.0 as GA [ ] Release apr-util-1.3.0 as GA Some test results from SPARC Solaris (8, 9, 10) with Solaris LDAP SDK.

Re: DO NOT REPLY [Bug 45086] New: (reslist_cleanup.c) A potential bug discovered by a static program analysis approach

2008-05-28 Thread Ruediger Pluem
On 05/28/2008 08:10 AM, Nick Kew wrote: On Tue, 27 May 2008, [EMAIL PROTECTED] wrote: File Name: /srclib/apr-util/misc/apr_reslist.c Function Name: reslist_cleanup() Buggy Code: 144: apr_thread_mutex_lock(rl-listlock); 145: 146: while (rl-nidle 0) { 147: res =

Re: svn commit: r659802 - in /apr/apr-util/trunk: CHANGES misc/apr_reslist.c

2008-05-25 Thread Ruediger Pluem
On 05/24/2008 10:11 PM, Ruediger Pluem wrote: On 05/24/2008 07:38 PM, Tom Donovan wrote: Nick Kew wrote: On Sat, 24 May 2008 15:04:01 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: I don't think just calling apr_reslist_invalidate will work. apr_reslist_invalidate assumes

Re: svn commit: r659802 - in /apr/apr-util/trunk: CHANGES misc/apr_reslist.c

2008-05-24 Thread Ruediger Pluem
On 05/24/2008 02:26 PM, [EMAIL PROTECTED] wrote: Author: niq Date: Sat May 24 05:26:43 2008 New Revision: 659802 URL: http://svn.apache.org/viewvc?rev=659802view=rev Log: Enforce ttl (where used) on individual resources in an apr_reslist PR 42841 Modified: apr/apr-util/trunk/CHANGES

Re: svn commit: r659802 - in /apr/apr-util/trunk: CHANGES misc/apr_reslist.c

2008-05-24 Thread Ruediger Pluem
On 05/24/2008 07:38 PM, Tom Donovan wrote: Nick Kew wrote: On Sat, 24 May 2008 15:04:01 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: Sorry for pointing out this that late. I just thought about it again and I guess we have a leak here. I think the following two lines are missing here

Failure with testshm

2008-05-23 Thread Ruediger Pluem
After running make check on APR trunk after quite a while I detected that testshm fails on Linux with one failure: testshm : -Line 254: Error destroying shared memory block (2): No such file or directory FAILED 1 of 6 Failed TestsTotal FailFailed %

Re: apr_reslist semantics

2008-05-23 Thread Ruediger Pluem
On 05/23/2008 09:28 PM, Nick Kew wrote: On Mon, 12 May 2008 20:22:09 +0100 Nick Kew [EMAIL PROTECTED] wrote: In https://issues.apache.org/bugzilla/show_bug.cgi?id=42841 , Tom points out an issue that gives problems with MySQL (and possibly other DBD drivers) and suggests that a change to

Re: Disconnecting -lldap from utilizing apr-util

2008-05-23 Thread Ruediger Pluem
On 05/23/2008 10:05 PM, William A. Rowe, Jr. wrote: Joe Orton wrote: More review: 1) the DSO-loading stuff is not thread-safe (dsos global not mutex-protected) yet apr_ldap_init would/could/should be; it's not documented to explicitly *not* be thread-safe, anyway. The caller must

Re: svn commit: r657516 - in /apr/apr-util/trunk/dbd: apr_dbd_mysql.c apr_dbd_pgsql.c

2008-05-18 Thread Ruediger Pluem
On 05/18/2008 10:54 AM, [EMAIL PROTECTED] wrote: Author: bojan Date: Sun May 18 01:54:09 2008 New Revision: 657516 URL: http://svn.apache.org/viewvc?rev=657516view=rev Log: Make sure PGSQL and MySQL drivers count rows from 1, not 0 Modified: apr/apr-util/trunk/dbd/apr_dbd_mysql.c

Re: svn commit: r657516 - in /apr/apr-util/trunk/dbd: apr_dbd_mysql.c apr_dbd_pgsql.c

2008-05-18 Thread Ruediger Pluem
On 05/18/2008 11:39 AM, Bojan Smojver wrote: On Sun, 2008-05-18 at 11:24 +0200, Ruediger Pluem wrote: I guess this should now be 0? Depends, really. If we want things to break when users pass in 0, then it should be the way it is, provided MySQL returns an error when row it is given is -1

Re: apr_reslist semantics

2008-05-12 Thread Ruediger Pluem
On 05/12/2008 09:22 PM, Nick Kew wrote: In https://issues.apache.org/bugzilla/show_bug.cgi?id=42841 , Tom points out an issue that gives problems with MySQL (and possibly other DBD drivers) and suggests that a change to apr_reslist semantics would fix it. Tom also attaches a patch

Re: DBD driver license issues (must default to --without-driver)

2008-05-11 Thread Ruediger Pluem
On 05/11/2008 08:39 PM, Roy T. Fielding wrote: Actually, I don't understand how this is supposed to work at all. Having these interfaces in a library means that anything we pick as a DBD interface must be redistributed with the binaries. An operating system distro may be able to pick and

Re: svn commit: r654247 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c

2008-05-07 Thread Ruediger Pluem
On 05/07/2008 10:07 PM, [EMAIL PROTECTED] wrote: Author: jim Date: Wed May 7 13:07:52 2008 New Revision: 654247 URL: http://svn.apache.org/viewvc?rev=654247view=rev Log: Oops... forgot to combine the CHANGES :) Modified: apr/apr/trunk/CHANGES apr/apr/trunk/network_io/unix/sendrecv.c

Re: svn commit: r653805 - /apr/apr/trunk/file_io/win32/open.c

2008-05-06 Thread Ruediger Pluem
On 05/06/2008 05:16 PM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Tue May 6 08:16:58 2008 New Revision: 653805 URL: http://svn.apache.org/viewvc?rev=653805view=rev Log: Reduce the point at which we use long filename manipulation to 248 characters, as path names are further constrained to

Re: svn commit: r651395 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c

2008-04-24 Thread Ruediger Pluem
On 04/24/2008 10:26 PM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Thu Apr 24 13:25:55 2008 New Revision: 651395 URL: http://svn.apache.org/viewvc?rev=651395view=rev Log: Support OS/X sendfile by using writev rather than the miscounted sendfile's hdtr iovecs. Submitted by: Geoff Greer

Re: svn commit: r651395 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c

2008-04-24 Thread Ruediger Pluem
On 04/24/2008 11:09 PM, William A. Rowe, Jr. wrote: Ruediger Pluem wrote: Maybe stupid question, but shouldn't this be 1.4.0 instead of 1.3.0 in the meantime? Already backported in the meantime, yes I could have applied three commits but that seemed *really* pedantic. Ups. My bad. I did

Re: svn commit: r649830 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c

2008-04-19 Thread Ruediger Pluem
On 04/19/2008 06:26 PM, [EMAIL PROTECTED] wrote: Author: mturk Date: Sat Apr 19 09:26:39 2008 New Revision: 649830 URL: http://svn.apache.org/viewvc?rev=649830view=rev Log: Introduce (again) apr_pollset_wakeup API Modified: apr/apr/trunk/CHANGES apr/apr/trunk/include/apr_poll.h

Re: svn commit: r647394 - in /apr/apr/trunk: CHANGES include/apr_pools.h memory/unix/apr_pools.c

2008-04-14 Thread Ruediger Pluem
On 04/14/2008 10:05 PM, Sander Striker wrote: On Mon, Apr 14, 2008 at 9:43 PM, Joe Orton [EMAIL PROTECTED] wrote: On Sat, Apr 12, 2008 at 08:42:59AM -, Mladen Turk wrote: Author: mturk Date: Sat Apr 12 01:42:51 2008 New Revision: 647394 URL:

Re: svn commit: r647394 - in /apr/apr/trunk: CHANGES include/apr_pools.h memory/unix/apr_pools.c

2008-04-14 Thread Ruediger Pluem
On 04/14/2008 10:52 PM, Joe Orton wrote: On Mon, Apr 14, 2008 at 10:44:09PM +0200, Ruediger Pluem wrote: But now that we have branched 1.3.0 we have to live with it until 2.0, right? Maybe branching just 48 hours after these commits wasn't such a good idea especially with these 48 hours being

Re: veto on addition of ssl, evp code

2008-04-14 Thread Ruediger Pluem
On 04/14/2008 10:42 PM, Joe Orton wrote: I am also happy to do the grunt work of reversion if the authors are still unwilling to resolve these issues and don't want to (or don't have time to) do that themselves. Does this mean you revert it on trunk or only on 1.3.x branch? If you revert

Re: svn commit: r647540 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c poll/unix/poll.c poll/unix/port.c poll/unix/select.c test/testpoll.c

2008-04-13 Thread Ruediger Pluem
On 04/13/2008 10:31 AM, [EMAIL PROTECTED] wrote: Author: mturk Date: Sun Apr 13 01:31:03 2008 New Revision: 647540 URL: http://svn.apache.org/viewvc?rev=647540view=rev Log: Introduce apr_pollset_wakeup() Modified: apr/apr/trunk/CHANGES apr/apr/trunk/include/apr_poll.h

Re: svn commit: r647390 - in /apr/apr/trunk: CHANGES include/apr_pools.h memory/unix/apr_pools.c

2008-04-12 Thread Ruediger Pluem
On 04/12/2008 09:22 AM, [EMAIL PROTECTED] wrote: Author: mturk Date: Sat Apr 12 00:22:14 2008 New Revision: 647390 URL: http://svn.apache.org/viewvc?rev=647390view=rev Log: Introduce apr_pool_pre_cleanup_register Modified: apr/apr/trunk/CHANGES apr/apr/trunk/include/apr_pools.h

Re: Compilation of trunk broken

2008-04-12 Thread Ruediger Pluem
On 04/12/2008 03:52 PM, Mladen Turk wrote: Rüdiger Plüm wrote: Its seems that the recent commits from Graham (r647263) and Mladen (r647384) (APR) broke httpd trunk: server/.libs/libmain.a(exports.o):(.data+0x9cc): undefined reference to `apr_pool_create_ex_core_debug'

Re: httpd 2.2.8 segfaults

2008-02-24 Thread Ruediger Pluem
On 02/24/2008 03:16 PM, Niklas Edmundsson wrote: On Sat, 23 Feb 2008, Ruediger Pluem wrote: I'm still not liking the casts and the mixed -1's, APR_SIZE_MAX and MAX_APR_SIZE_T... In any case, I'll be busy for most of this weekend so I probably won't have time to try patches until monday

Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c

2008-02-24 Thread Ruediger Pluem
On 02/24/2008 06:13 PM, William A. Rowe, Jr. wrote: [EMAIL PROTECTED] wrote: -apr_size_t written; +int written; FYI - int is apr_ssize_t, please flip that to a signed representation that corresponds to sizeof(void*) Sorry that I don't get it but - apr_vformatter returns an 'int'

Re: httpd 2.2.8 segfaults

2008-02-22 Thread Ruediger Pluem
On 02/22/2008 07:40 PM, William A. Rowe, Jr. wrote: Joe Orton wrote: CC'ing [EMAIL PROTECTED] since the code in question is in APR. On Fri, Feb 22, 2008 at 05:45:53PM +0100, Plüm, Rüdiger, VF-Group wrote: On Feb 22, 2008, at 9:27 AM, Plüm, Rüdiger, VF-Group wrote: +/* + * Try to

Re: apr_pollset_poll return value (APR_EINTR) on solaris

2008-02-12 Thread Ruediger Pluem
On 02/12/2008 08:32 PM, Basant Kukreja wrote: Hi, I am Basant Kukreja. I was working on apache httpd bug 42580. http://issues.apache.org/bugzilla/show_bug.cgi?id=42580 I figured out that the cause of the problem might be in APR. apr_pollset_poll function returns APR_TIMEUP even when

Lastest apr-util fails to build with httpd

2007-11-27 Thread Ruediger Pluem
The latest apr-util trunk (r598680) fails to build with httpd if the system uses an older version of ssl that does not support the EVP features used by recent commits to apr-util or if you compile apr-util without --with-openssl: server/.libs/libmain.a(exports.o)(.data.rel+0x160): undefined

Re: Lastest apr-util fails to build with httpd

2007-11-27 Thread Ruediger Pluem
On 11/27/2007 09:21 PM, Graham Leggett wrote: Ruediger Pluem wrote: The reason for this is that libaprutil does not contain the needed symbols in this case. The attached patch should fix this. Comments? Just took a look - the patch added the symbols when openssl was missing, which

Re: [Votes] Apr candidates in /dev/dist/

2007-11-26 Thread Ruediger Pluem
On 11/26/2007 02:12 AM, Jeff Trawick wrote: On Nov 15, 2007 4:26 PM, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Please provide your input to release. [ ] APR-iconv-1.2.1 diffs from prior release look reasonable (punted on reviewing Windows build changes just as I normally punt on

Re: [Vote] apr-util-1.2.12 candidate in /dev/dist/

2007-11-21 Thread Ruediger Pluem
On 11/21/2007 01:45 AM, William A. Rowe, Jr. wrote: Please provide your input to release the tarball candidate [+1] APR-util 1.2.12 voting closes Friday afternoon/evening. Windows .zip's with all those pesky .mak files on their way by morning. Bill Signatures: OK md5sums :

Re: [Votes] Apr candidates in /dev/dist/

2007-11-21 Thread Ruediger Pluem
On 11/20/2007 11:30 PM, William A. Rowe, Jr. wrote: William A. Rowe, Jr. wrote: Please provide your input to release. [+1] APR-0.9.17 [+1] APR-1.2.12 [XX] APR-util-1.2.11 [+1] APR-iconv-1.2.1 Please note I've withdrawn apr-util-1.2.11 from consideration, and a 1.2.12 package

Re: svn commit: r597218 - in /apr/apr/trunk: CHANGES build/rpm/apr.spec.in

2007-11-21 Thread Ruediger Pluem
On 11/21/2007 10:47 PM, [EMAIL PROTECTED] wrote: Author: minfrin Date: Wed Nov 21 13:47:07 2007 New Revision: 597218 URL: http://svn.apache.org/viewvc?rev=597218view=rev Log: Fix the make test target in the spec file. Modified: apr/apr/trunk/CHANGES

Re: [Votes] Apr candidates in /dev/dist/

2007-11-19 Thread Ruediger Pluem
On 11/19/2007 12:38 AM, Bojan Smojver wrote: On Thu, 2007-11-15 at 16:26 -0500, William A. Rowe, Jr. wrote: Please provide your input to release. [+1] APR-0.9.17 [+1] APR-1.2.12 [-1] APR-util-1.2.11 [ ] APR-iconv-1.2.1 Fedora 8, i686 and x86_64. Both apr-0.9.17 and

Re: [Votes] Apr candidates in /dev/dist/

2007-11-19 Thread Ruediger Pluem
On 11/19/2007 10:04 PM, Jeff Trawick wrote: Did you have a look at diffs between 1.2.x and trunk for apr_date.c? The 1.2.x branch is missing http://svn.apache.org/viewvc?view=revrevision=233425 (combo of bug fixes and support for a new date format and new testcases)

Re: [Votes] Apr candidates in /dev/dist/

2007-11-17 Thread Ruediger Pluem
On 11/16/2007 10:44 PM, Ruediger Pluem wrote: On 11/15/2007 10:26 PM, William A. Rowe, Jr. wrote: Please provide your input to release. [+1] APR-0.9.17 [+1] APR-1.2.12 [-1] APR-util-1.2.11 [ ] APR-iconv-1.2.1 I've already noticed I should have scuttled testreslist current

Re: [Votes] Apr candidates in /dev/dist/

2007-11-16 Thread Ruediger Pluem
On 11/15/2007 10:26 PM, William A. Rowe, Jr. wrote: Please provide your input to release. [+1] APR-0.9.17 [ ] APR-1.2.12 [-1] APR-util-1.2.11 [ ] APR-iconv-1.2.1 I've already noticed I should have scuttled testreslist current implementation, but that's 20/20 hindsight

Re: [Votes] Apr candidates in /dev/dist/

2007-11-16 Thread Ruediger Pluem
On 11/16/2007 10:44 PM, Ruediger Pluem wrote: Solaris 10: All OK except: testpoll: /Line 314: expected 5, but saw 4 FAILED 1 of 13 testshm : -Line 254: Error destroying shared memory block (22): Invalid argument FAILED 1 of 6 Failed TestsTotal

Re: apr_thread_create on all platforms does unnecessary attributions

2007-10-14 Thread Ruediger Pluem
On 10/13/2007 02:59 PM, Lucian Adrian Grijincu wrote: against trunk head. make check (on Ubuntu 7.10) All tests passed. Commited as r584411. Thanks. Regards Rüdiger

Re: compile emits on linux for our new atomics (trunk)

2007-10-14 Thread Ruediger Pluem
On 10/14/2007 09:19 AM, William A. Rowe, Jr. wrote: /bin/sh /local0/asf/build/apr-1.x/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I./include -I/local0/asf/build/apr-1.x/include/arch/unix

Re: svn commit: r584487 - in /apr/apr/trunk: file_io/netware/pipe.c file_io/os2/pipe.c file_io/unix/pipe.c file_io/win32/pipe.c include/apr_file_io.h include/apr_thread_proc.h include/arch/win32/apr_a

2007-10-14 Thread Ruediger Pluem
On 10/14/2007 08:00 AM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Sat Oct 13 23:00:00 2007 New Revision: 584487 URL: http://svn.apache.org/viewvc?rev=584487view=rev Log: Enhance our file_io in APR 1.3 with apr_file_pipe_create_ex(), which should replace apr_file_pipe_create() in apr

Re: svn commit: r584487 - in /apr/apr/trunk: file_io/netware/pipe.c file_io/os2/pipe.c file_io/unix/pipe.c file_io/win32/pipe.c include/apr_file_io.h include/apr_thread_proc.h include/arch/win32/apr_a

2007-10-14 Thread Ruediger Pluem
On 10/14/2007 12:03 PM, Ruediger Pluem wrote: On 10/14/2007 08:00 AM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Sat Oct 13 23:00:00 2007 New Revision: 584487 URL: http://svn.apache.org/viewvc?rev=584487view=rev Log: Enhance our file_io in APR 1.3 with apr_file_pipe_create_ex

Re: Time for new apr-* releases soon? Corrections inc for .vcproj conversion

2007-10-05 Thread Ruediger Pluem
On 10/05/2007 02:19 PM, Jim Jagielski wrote: Once APR is out, I'll plan on a httpd release too. There are several backport proposals in the STATUS file missing only one vote. So I guess it is voting time :-). Regards Rüdiger

Re: svn commit: r580486 - in /apr/apr/trunk: include/apr_thread_proc.h threadproc/unix/proc.c

2007-10-01 Thread Ruediger Pluem
On 09/29/2007 12:53 AM, Ruediger Pluem wrote: On 09/28/2007 11:04 PM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Fri Sep 28 14:04:47 2007 New Revision: 580486 URL: http://svn.apache.org/viewvc?rev=580486view=rev Log: Introduce APR_NO_FILE as an option for any of the three stdio

Re: svn commit: r580486 - in /apr/apr/trunk: include/apr_thread_proc.h threadproc/unix/proc.c

2007-09-28 Thread Ruediger Pluem
On 09/28/2007 11:04 PM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Fri Sep 28 14:04:47 2007 New Revision: 580486 URL: http://svn.apache.org/viewvc?rev=580486view=rev Log: Introduce APR_NO_FILE as an option for any of the three stdio streams to cause the specified streams to be closed

Re: compiling with --disable-ipv6

2007-09-22 Thread Ruediger Pluem
On 09/22/2007 08:11 PM, Agri wrote: Hello Compiling apr-1.2.11 with --disable-ipv6 resuts in unknown symbol find_if_index in the libapr-1.so.0.2.11. Agri I guess the patch below should fix this, but I am not sure if this is the correct thing to do in the case that IPV6 is

Versions 0.9.15 / 1.2.10 missing for apr-util in bugzilla

2007-09-11 Thread Ruediger Pluem
I noticed that the versions 0.9.15 / 1.2.10 are missing in bugzilla in order to open reports for the latest apr-util release. Can someone please add them? Regards Rüdiger

Re: [VOTE] Release apr 0.9.16 / 1.2.11 --- apr-util 0.9.15 / 1.2.10

2007-09-04 Thread Ruediger Pluem
On 09/04/2007 03:38 PM, jean-frederic clere wrote: William A. Rowe, Jr. wrote: Please review and vote on those you have time to - reply once or four times, just review those you can as you can; http://apr.apache.org/dev/dist/ [If you want to speed up the effort by comparing the packages,

Re: [VOTE] Release apr 0.9.15 / 1.2.10 --- apr-util 0.9.14 / 1.2.9

2007-08-31 Thread Ruediger Pluem
On 08/31/2007 07:05 AM, josh rotenberg wrote: On 8/30/07, Bojan Smojver [EMAIL PROTECTED] wrote: PPS. Tests on apr-util-0.9.14 require a key press mid way through, after this: Yes 186124938900 Sun, 24 Dec 2028 05:43:09 GMT Yes 5648237200 Sat, 16 Oct 1971 17:32:52 GMT Yes

Re: [VOTE] Release apr 0.9.15 / 1.2.10 --- apr-util 0.9.14 / 1.2.9

2007-08-30 Thread Ruediger Pluem
On 08/30/2007 01:40 PM, Lucian Adrian Grijincu wrote: On 8/29/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Please review and vote on those you have time to - reply once or four times, just review those you can as you can; http://apr.apache.org/dev/dist/ +1/-1 Release [ ]

<    1   2   3   4   >