Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/#review220753 --- Ship it! Ship It! - Madhan Neethiraj On May 13, 2020, 10:51

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski
> On May 7, 2020, 12:21 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > > Lines 995 (patched) > > > > > > entityType could be null when called from

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/ --- (Updated May 13, 2020, 10:51 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski
> On May 6, 2020, 6:57 a.m., Bolke de Bruin wrote: > > Can you please update the tests? > > Sarath Subramanian wrote: > +1 introduced unit tests for FreetextSearchProcessor - Damian --- This is an automatically generated e-mail.

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-06 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/#review220666 ---

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-06 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/#review220648 --- Can you please update the tests? - Bolke de Bruin On April 29,

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-04-29 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/ --- (Updated April 29, 2020, 10:26 a.m.) Review request for atlas, Ashutosh

Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-04-28 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72440/ --- (Updated April 28, 2020, 8:59 p.m.) Review request for atlas, Ashutosh Mestry,