[GitHub] jiazhai commented on issue #205: Issue 208: Improve ledger fence logic

2017-06-28 Thread git
jiazhai commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-311847825 Seems there are conflict files. This is an automated message from the Apache

[GitHub] jiazhai commented on issue #205: Issue 208: Improve ledger fence logic

2017-06-28 Thread git
jiazhai commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-311847825 Seems there is conflict files. This is an automated message from the Apache Git

[GitHub] bookkeeper issue #205: Issue 208: Improve ledger fence logic

2017-06-28 Thread jiazhai
Github user jiazhai commented on the issue: https://github.com/apache/bookkeeper/pull/205 Seems there is conflict files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Jia Zhai
Hi Sijie, opened a ticket https://issues.apache.org/jira/browse/INFRA-14470 to only "squash merge" Thanks On Thu, Jun 29, 2017 at 5:17 AM, Sijie Guo wrote: > Hi Enrico, > > The gitbox is the readonly mirror of the github repo. The github repo is > the source of truth. So we

[GitHub] sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#discussion_r124678337 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067419#comment-16067419 ] ASF GitHub Bot commented on BOOKKEEPER-1028: Github user reddycharan commented on the

[GitHub] bookkeeper issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

2017-06-28 Thread reddycharan
Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/127 @sijie my bad, missed checking findbugs error after previous push. Fixed them now and it passed. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/issues/198 marked this as a blocker for 4.5.0, since it seems to indicate some kind of reference leaking in current code base. --- If your project is set up for it, you can reply to this email and have

[GitHub] sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

2017-06-28 Thread git
sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/issues/198#issuecomment-311804836 marked this as a blocker for 4.5.0, since it seems to indicate some kind of reference

[jira] [Commented] (BOOKKEEPER-588) SSL support

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067297#comment-16067297 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user sijie commented on the issue:

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread git
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-311802299 fyi, I added @merlimat and me to the reviewers list, making sure we have other eyes on reviewing this change.

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/183 fyi, I added @merlimat and me to the reviewers list, making sure we have other eyes on reviewing this change. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] sijie commented on a change in pull request #213: Issue 212: change github PR template to adjust both issue# and jira#

2017-06-28 Thread git
sijie commented on a change in pull request #213: Issue 212: change github PR template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/pull/213#discussion_r124664720 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,15 +1,16 @@

[jira] [Commented] (BOOKKEEPER-974) make pushing a docker image as part of the release procedure

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067288#comment-16067288 ] ASF GitHub Bot commented on BOOKKEEPER-974: --- Github user sijie commented on the issue:

[GitHub] bookkeeper issue #197: BOOKKEEPER-974: Add an official bookkeeper docker ima...

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/197 @caiok any updates on this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] sijie commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-06-28 Thread git
sijie commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-311800374 @caiok any updates on this pull request? This is an automated

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

2017-06-28 Thread git
sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r124664167 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM

[jira] [Commented] (BOOKKEEPER-588) SSL support

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067282#comment-16067282 ] ASF GitHub Bot commented on BOOKKEEPER-588: --- Github user sijie commented on the issue:

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/183 @eolivelli I will try to go through this again. /cc @merlimat for reviewing as well --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread git
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-311799940 @eolivelli I will try to go through this again. /cc @merlimat for reviewing as well

[jira] [Commented] (BOOKKEEPER-1028) inc/excl opts listunderreplicate

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067280#comment-16067280 ] ASF GitHub Bot commented on BOOKKEEPER-1028: Github user sijie commented on the issue:

[GitHub] sijie commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

2017-06-28 Thread git
sijie commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029 URL: https://github.com/apache/bookkeeper/pull/127#issuecomment-311799683 @reddycharan there is a findbugs error introduced in this pull request. Can you fix that?

[GitHub] bookkeeper issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/127 @reddycharan there is a findbugs error introduced in this pull request. Can you fix that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (BOOKKEEPER-1098) ZkUnderreplicationManager can build up an unbounded number of watchers

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067278#comment-16067278 ] ASF GitHub Bot commented on BOOKKEEPER-1098: Github user sijie commented on the issue:

[GitHub] sijie commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
sijie commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193#issuecomment-311799215 @athanatos yeah, I just changed the title for the correct jira number.

[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/193 @athanatos yeah, I just changed the title for the correct jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] athanatos commented on a change in pull request #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
athanatos commented on a change in pull request #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193#discussion_r124662485 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/util/SubTreeCacheTest.java

[jira] [Commented] (BOOKKEEPER-1098) ZkUnderreplicationManager can build up an unbounded number of watchers

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067267#comment-16067267 ] ASF GitHub Bot commented on BOOKKEEPER-1098: Github user athanatos commented on the

[GitHub] athanatos commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
athanatos commented on issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193#issuecomment-311798072 @sijie Oops, I just noticed the comments. I guess you just changed the title?

[GitHub] bookkeeper issue #195: Update JMX documentation

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/issues/195 @eolivelli I assume this should be go into 4.5.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Resolved] (BOOKKEEPER-1098) ZkUnderreplicationManager can build up an unbounded number of watchers

2017-06-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-1098. --- Resolution: Fixed Assignee: Samuel Just Fix Version/s: 4.5.0 >

[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...

2017-06-28 Thread athanatos
Github user athanatos commented on the issue: https://github.com/apache/bookkeeper/pull/193 @sijie Oops, I just noticed the comments. I guess you just changed the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] sijie commented on issue #195: Update JMX documentation

2017-06-28 Thread git
sijie commented on issue #195: Update JMX documentation URL: https://github.com/apache/bookkeeper/issues/195#issuecomment-311797998 @eolivelli I assume this should be go into 4.5.0 release? This is an automated message from

[GitHub] bookkeeper pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cac...

2017-06-28 Thread sijie
Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] sijie closed pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher

2017-06-28 Thread git
sijie closed pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher URL: https://github.com/apache/bookkeeper/pull/193 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (BOOKKEEPER-753) Bookie should run garbage collection before startup when all directories became full

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067258#comment-16067258 ] ASF GitHub Bot commented on BOOKKEEPER-753: --- Github user sijie commented on the issue:

[GitHub] bookkeeper issue #81: BOOKKEEPER-753: Bookie should run garbage collection b...

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/81 @jvrao @reddycharan #190 is merged. let me know what is your thought of this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

2017-06-28 Thread git
sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-311796693 @jvrao @reddycharan #190 is merged. let me know what is your thought of this pull

[jira] [Resolved] (BOOKKEEPER-1034) When all disks are full, start Bookie in RO mode if RO mode is enabled

2017-06-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-1034. --- Resolution: Fixed Fix Version/s: 4.5.0 Issue resolved by merging pull request 190

[jira] [Commented] (BOOKKEEPER-1034) When all disks are full, start Bookie in RO mode if RO mode is enabled

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067253#comment-16067253 ] ASF GitHub Bot commented on BOOKKEEPER-1034: Github user sijie closed the pull request

[GitHub] sijie closed pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull

2017-06-28 Thread git
sijie closed pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull URL: https://github.com/apache/bookkeeper/pull/190 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] bookkeeper pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskf...

2017-06-28 Thread sijie
Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Sijie Guo
Hi Enrico, The gitbox is the readonly mirror of the github repo. The github repo is the source of truth. So we should use the github repo for jenkins build and also for patch submissions. The merge script uses 'apache' remote as the destination for pushing the squashed changes and uses

[GitHub] bookkeeper pull request #215: Issue 216: Remove useless and misleading '&= t...

2017-06-28 Thread sijie
Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] bookkeeper issue #216: Remove useless and misleading '&= true'

2017-06-28 Thread sijie
Github user sijie closed the issue at: https://github.com/apache/bookkeeper/issues/216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] sijie closed pull request #215: Issue 216: Remove useless and misleading '&= true'

2017-06-28 Thread git
sijie closed pull request #215: Issue 216: Remove useless and misleading '&= true' URL: https://github.com/apache/bookkeeper/pull/215 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie closed issue #216: Remove useless and misleading '&= true'

2017-06-28 Thread git
sijie closed issue #216: Remove useless and misleading '&= true' URL: https://github.com/apache/bookkeeper/issues/216 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Sijie Guo
Enrico, Jia, I have confirmed that I have the permission on creating label/milestones and also I see the 'merge button' in the pull requests as well. Following the BP-9, I have created corresponding labels and milestones for 4.5.0 and 4.6.0. Let me know if they look good to you. For the 'merge

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067060#comment-16067060 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented on the issue:

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311757496 @jvrao I am fine with having a configuration setting as what I said before. The comments are mostly for people knowing different

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao I am fine with having a configuration setting as what I said before. The comments are mostly for people knowing different aspects on the solutions. --- If your project is set up

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066823#comment-16066823 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user jvrao commented on the issue:

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311716056 Multiple entrylog change is coming in and Charan is using this for that. So you can think of this as setting stage for that. If you

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 Multiple entrylog change is coming in and Charan is using this for that. So you can think of this as setting stage for that. If you don't want to have the flag/configuration parameter we can

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311713578 >> re 1. I am not aware if they are users configuring in this way. but I am not sure if this is the case for flagging as error.

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066813#comment-16066813 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented on the issue:

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 >> re 1. I am not aware if they are users configuring in this way. but I am not sure if this is the case for flagging as error. because in current implementation, such configuration

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/210 @jvrao do you mind sending out your proposal. we might need to merge the efforts here, and also @eolivelli has some ideas on how to implement this with standard servlets. --- If your project is

[GitHub] sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread git
sijie commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/210#issuecomment-311709678 @jvrao do you mind sending out your proposal. we might need to merge the efforts here, and also @eolivelli has some ideas on how to

[GitHub] sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#issuecomment-311708998 - in the upcoming changes of long poll requests, we need same speculative policy for long poll requests. abstract the logic as a

[GitHub] sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
sijie commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#issuecomment-311708998 - in the upcoming changes of long poll requests, we need same speculative policy for long poll requests. abstract the logic as a

[GitHub] bookkeeper issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/200 - in the upcoming changes of long poll requests, we need same speculative policy for long poll requests. abstract the logic as a policy will make things easier and we don't have to duplicate the

[GitHub] sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
sijie commented on a change in pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#discussion_r124584618 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Sijie Guo
I think the GitBox change is related to BP-9: Using Github Issues. Gitbox is the solution provided by ASF to managing Github repos, linking the Github accounts with Apache counts. Before this, the bookkeeper repo was setup with dural-sync, when the source-of-truth is the

[GitHub] bookkeeper issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/200 @sijie what is the major drive of this change? Current method of trying speculative reads has any major flaw? I understand this is better organized as speculative reads has its own policy, but

[GitHub] jvrao commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy

2017-06-28 Thread git
jvrao commented on issue #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200#issuecomment-311673084 @sijie what is the major drive of this change? Current method of trying speculative reads has any major flaw? I understand this is

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread git
jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-311665630 @sijie @reddycharan Let me step back and discuss this. 1. Are there any legitimate use cases of specifying multiple ledger dirs on

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 @sijie @reddycharan Let me step back and discuss this. 1. Are there any legitimate use cases of specifying multiple ledger dirs on the same disk partition? if not, in production I would

[jira] [Commented] (BOOKKEEPER-1100) Add Http Endpoint for Bookkeeper

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066479#comment-16066479 ] ASF GitHub Bot commented on BOOKKEEPER-1100: Github user jvrao commented on the issue:

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread jvrao
Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/210 We are adding REST endpoint to BookKeeper. I need to check if they overlap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] jvrao commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread git
jvrao commented on issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/210#issuecomment-311660233 We are adding REST endpoint to BookKeeper. I need to check if they overlap.

Build failed in Jenkins: bookkeeper-master #1799

2017-06-28 Thread Apache Jenkins Server
See -- [...truncated 1.03 MB...] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.433 sec - in

Re: Write retry issues with ZooKeeperClient

2017-06-28 Thread Venkateswara Rao Jujjuri
Current retry logic is transparent to the type of the operation and is down the stack which has no understanding of the operation type. If we want to differentiate between idempotent and non-idempotent, we may need to insert that logic into the retry logic. Other option is to handle retry at

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Venkateswara Rao Jujjuri
What is this change about? Can we still access and use https://github.com/apache/bookkeeper.git ? On Wed, Jun 28, 2017 at 5:53 AM, Enrico Olivelli wrote: > Jia, > I already did it. > I'm not aware of other places to change the link to the repo. > Do you have other ideas for

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Enrico Olivelli
Jia, I already did it. I'm not aware of other places to change the link to the repo. Do you have other ideas for the switch ? Cheers -- Enrico 2017-06-28 14:51 GMT+02:00 Jia Zhai : > Thanks Enrico for the confirm. Yes, we may need some changes, especially > the repo address.

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Jia Zhai
Thanks Enrico for the confirm. Yes, we may need some changes, especially the repo address. On Wed, Jun 28, 2017 at 8:07 PM, Enrico Olivelli wrote: > I am going on with trials in order to discover our new space before > hitting bad problems. > > If you try to access the old

Build failed in Jenkins: bookkeeper-master #1798

2017-06-28 Thread Apache Jenkins Server
See -- [...truncated 1.02 MB...] Running org.apache.bookkeeper.test.LedgerCreateDeleteTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.559 sec - in

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Enrico Olivelli
I am going on with trials in order to discover our new space before hitting bad problems. If you try to access the old git repo you will get [enrico.olivelli@localhost bookkeeper]$ git pull apache master fatal: repository 'https://git-wip-us.apache.org/repos/asf/bookkeeper.git/' not found As

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Enrico Olivelli
This is great it seems that we have also a GitHub team for bookkeeper committers https://github.com/orgs/apache/teams/bookkeeper-committers/members -- Enrico 2017-06-28 12:29 GMT+02:00 Enrico Olivelli : > Hi Jia, > this is a very important change !! > > Do you now what will

Re: BookKeeper repo has been moved into gitbox

2017-06-28 Thread Enrico Olivelli
Hi Jia, this is a very important change !! Do you now what will happen if any committers uses git-ws-us.apache.org as usual ? is there any chance to break things ? we should immediately update the wiki page https://cwiki.apache.org/confluence/display/BOOKKEEPER/Patch+Sumission let's wait for

BookKeeper repo has been moved into gitbox

2017-06-28 Thread Jia Zhai
Hi All, Thanks to the help from INFRA team, now bookkeeper repo has been moved into gitbox. The new URL (on our side) is https://gitbox.apache.org/repos/asf/bookkeeper.git For committers, please go through the setup at https://gitbox.apache.org/setup/ Thanks.

[jira] [Commented] (BOOKKEEPER-1100) Add Http Endpoint for Bookkeeper

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066090#comment-16066090 ] ASF GitHub Bot commented on BOOKKEEPER-1100: Github user sijie commented on the issue:

[GitHub] bookkeeper issue #210: BOOKKEEPER-1100: Add Http Server for Bookkeeper

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/210 regarding the servlet, I agree with @eolivelli , we probably should define a standard API and allow it running with different web container. @yzang : do finagle and vertx support servlet? --- If

Re: Write retry issues with ZooKeeperClient

2017-06-28 Thread Sijie Guo
On Tue, Jun 27, 2017 at 4:27 PM, Sam Just wrote: > Should EXPIRED be considered a recoverable error for retry purposes? > Retrying in that case would mean that operations which might have been > submitted under the assumption that ephemeral nodes were still present > would

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066056#comment-16066056 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented on the issue:

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao @reddycharan one more question, most of the comments are around the performance on journal directories. but it turns out this change has nothing to do with the journal

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

2017-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066032#comment-16066032 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented on the issue:

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao yes, that's the idea. I am +0 on this. It is fine for me to adding an option, although I still don't think it is the right approach to do this. --- If your project is set up for