Re: [DISCUSS] BP-64: Improve the description of 47 commands for bin/bookkeeper

Thanks ,this BP has been fixed in PR https://github.com/apache/bookkeeper/pull/4102 Andrey Yegorov 于2023年10月13日周五 01:05写道： > +1, I think it is a good idea. > Would be nice to make sure these improvements propagate into the docs on > the website. > > On Sun, Oct 8, 2023 at 5:

Re: [DISCUSS] BP-64: Improve the description of 47 commands for bin/bookkeeper

t; > In my opinion you can check here if nobody objects, then you can start > sending out PRs > > Thank you very much > > Enrico > > > > On Sun, Oct 8, 2023, 09:58 steven lu wrote: > > > we will improve the description of 47 commands for bin/bookkeeper with

[DISCUSS] BP-64: Improve the description of 47 commands for bin/bookkeeper

we will improve the description of 47 commands for bin/bookkeeper with BP-64 https://github.com/apache/bookkeeper/issues/4101 # Motivation When executing the command `./bin/bookkeeper shell`, the usage description of each command is not precise enough, - some commands have no description; - if

Re: [DISCUSS] BP-62: Make all PacketProcessorBaseV3 recyclable

+1 (non-binding) Good idea houxiaoyu 于2023年5月5日周五 12:54写道： > Hi Bookkeeper Community > > I opened a BP to discuss "Make all PacketProcessorBaseV3 recyclable" > > I copy the content here for convenience, any suggestions are welcome and > appreciated. > > In V2 Protocol, All the processors are

Re: [DISCUSS] BookKeeper 4.14.8 release

+1 (non-binding) Hang Chen 于2023年5月30日周二 17:09写道： > Hi everyone, > > BookKeeper 4.14.7 was released more than 3 months, and I would like to > discuss the starting 4.14.8 release to include some critical bug fixes > and improvements, such as [1] and [2] > > Here are the PRs for 4.14.8: > >

Re: integrationTests do not run on CI (and locally)

+1 (non-binding) but workflow run failed, this pr cannot be merged, please see below for details https://github.com/apache/bookkeeper/pull/3981#issuecomment-1617613606 Andrey Yegorov 于2023年6月7日周三 06:38写道： > Hi, > > We have a few problems related to integration tests: > > 1. backwards compat

Re: [DISCUSS] Upgrade RocksDB version to 6.29.4.1 for branch-4.14

+1 (non-binding) I feel that there is no need to upgrade RocksDB, and I will not be able to enjoy the Manulife of the new feature, and it will also bring about compatibility issues Hang Chen 于2023年6月25日周日 15:47写道： > Hi guys, > > More than one year ago, we had a discussion[1] about reverting the

Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

+1 (non-binding) sorry,I seem to have misunderstood, I thought you reverted first, and then proposed a replacement, these PRs( #3796 <https://github.com/apache/bookkeeper/pull/3796> #3398 <https://github.com/apache/bookkeeper/pull/3398> ) is for different branches. steven lu 于2023年

Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

-1 (non-binding) for new BP-61 : 1) I think no need to revert 12 PRs to refactor the ByteBuf release method 2) Directly replace ReferenceCountUtil.safeRelease() with ReferenceCountUtil.release() Hang Chen 于2023年2月21日周二 12:38写道： > Hi, All > > After a fascinating discussion, I would start the

Re: [DISCUSS] BookKeeper 4.14.7 release

+1 Hang Chen 于2023年2月8日周三 15:16写道： > Hi everyone, > > One core dump issue[1] related to RocksDB was introduced by [2] and > released in BookKeeper 4.14.6. To fix the RocksDB core dump issue, I > pushed one PR [3] to revert the [2] to make branch-4.14 stable. > > Due to BookKeeper 4.14.6 having

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

There are three ways to write release in current pulsar and bookkeeper projects: 1.ByteBuf.release: Call release directly without handling any exceptions; 2.ReferenceCountUtil.release: return processing status; 3. ReferenceCountUtil.safeRelease: without return value, print exception information I

Re: BP-60:Change PCBC limitStatsLogging default value to true

+1 Thanks for your great work! Wenbing Shen 于2022年12月26日周一 17:29写道： > Hi BookKeepers, I've changed the limitStatsLogging default value to true > from false: > BP-60 > > Motivation > > We have an efficient online bookie cluster with hundreds of

Re: [VOTE] Release 4.14.6, release candidate #1

+1 non binding Hang Chen 于2022年12月19日周一 13:15写道： > Hi everyone, > Please review and vote on the release candidate #1 for version 4.14.6, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available

Re: [VOTE] Release 4.15.2, release candidate #0

+1 - non binding - deployed and verified in our own test environment, no problems were found Enrico Olivelli 于2022年10月6日周四 18:03写道： > Il Mer 5 Ott 2022, 03:25 steven lu ha scritto: > > > +1 (binding) > > > > Sorry, but binding votes are only from PMC members

Re: [VOTE] Release 4.15.2, release candidate #0

+1 (binding) deployed and verified in our own test environment, no problems were found Yong Zhang 于2022年9月23日周五 15:32写道： > Hi everyone, > Please review and vote on the release candidate #0 for the version 4.15.2, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release

Re: [VOTE] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

k we need this VOTE as the patch has already been merged > > Steven, it's up to you > > Enrico > > Il giorno mar 27 set 2022 alle ore 09:10 steven lu > ha scritto: > > > > Hi Bookkeeper Community, > > I would like to start a VOTE on " Change the AP

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

t; > Thanks. > > > > Wenbing Shen > > > > > > > > ZhangJian He 于2022年9月26日周一 11:15写道： > > > > > > > > > +1 （non-binding） > > > > > > > > > > Thanks > > > > > ZhangJian He > > > >

Re: [DISCUSS] End-Of-Life for some release lines

+1 I agree. Nicolò Boschi 于2022年9月27日周二 16:00写道： > I agree. And it actually reflects what we're doing in the community (only > cherry-pick to branches 4.14 and 4.15). > > In my opinion we should formalize this process in order to have a clear > vision when 4.16.0 will be out. > This will also

[VOTE] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

update its implementation in other projects Here is the design detail: https://github.com/apache/bookkeeper/issues/3502 Steven Lu

[DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

Hi BookKeepers, I've changed the API for org.apache.bookkeeper.stats.Counter: BP-58 "Motivation" The latency of the OpStatsLogger.registerSuccessfulEvent calculation is to convert the time to milliseconds but Counter.add nothing to do so when

Re: [VOTE] BP-57 Add a public API for creating embeddable servers

+1 (non binding) Great work Diego Salvi 于2022年9月24日周六 00:00写道： > Hi Bookkeeper Community, > I would like to start a VOTE on " Add a public API for creating embeddable > servers."(BP-57) > > It is a new public API to create bookie from configuration and/or custom > implementations without having

Re: [DISCUSS] BP-57 Add a public API for creating embeddable servers

+1 this idea seems really useful Diego Salvi 于2022年9月18日周日 21:02写道： > Hi BookKeepers, > I've added a new BP to add a public API for creating embeddable servers: > BP-57 > > *Motivation* > BK is used and run in many OS project as an embedded

Re: [VOTE] BP-56: Support data migration

+1 (non-binding) lordcheng10 <1572139...@qq.com.invalid> 于2022年9月15日周四 12:47写道： > Hi Bookkeeper Community, I would like to start a VOTE on "Support data > migration."(BP-56) > > Here is the design detail: > https://github.com/apache/bookkeeper/issues/3456 > and the discussion thread: >

Re: [DISCUSS] BookKeeper 4.15.2 release

Good idea +1 Yong Zhang 于2022年9月19日周一 13:36写道： > Hi everyone, > > I want to discuss starting 4.15.2 release to resolve the regression > mentioned here: > https://lists.apache.org/thread/d9gm50kysgjcpbq448s2sy822kho6z6k > > Although it is an unexpected setting caused, we never know how the

Re: Modify the structure of LedgerDirsManager

7月13日周三 18:15写道： > Il giorno mer 13 lug 2022 alle ore 12:12 steven lu > ha scritto: > > > > only about refactoring BK code  > > Great. > I think we can do the improvements you propose > > Enrico > > > > > Enrico Olivelli 于2022年7月13日周三 17:25写道： &g

Re: [VOTE] Release 4.15.1, release candidate #3

+1 (binding) deployed and verified in our own test environment, no problems were found thank you ! Yong Zhang 于2022年8月24日周三 10:41写道： > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.15.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve

Re: [VOTE] Release 4.15.1, release candidate #3

hello,Yang Yong Why are there no such fixes for cherry pick indexDirs, so there will be problems when indexDirs are specified independently. For the function fixes of indexDirs, please refer to https://github.com/apache/bookkeeper/issues/3419 Yong Zhang 于2022年8月24日周三 10:41写道： > Hi everyone, >

Re: [VOTE] Release 4.15.1, release candidate #3

Great work! I’m verifying this Yong Zhang 于2022年8月24日周三 10:41写道： > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.15.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete

Re: [Discuss] BP-56: Support non-stop bookie data migration and bookie offline

I think this feature is somewhat custom and not very generic; and there are risks: 1. If you want to go offline on node A (which has already been extracted), but wrong write B, this function will directly go offline on node B, which is likely to cause online failures 2. If the node to be offline

Re: [VOTE] Release 4.15.1, release candidate #2

Bookkeeper 4.15 has performance issue. There are too many journal sync. please have a look this new pr: https://github.com/apache/bookkeeper/pull/3454 Yong Zhang 于2022年8月22日周一 19:36写道： > Since there has a new commit when I release rc1, I skip the rc1 and > start releasing rc2 to include that

Re: .asf.yaml details are determined

ends a patch it is required only one more approval and not > two > > > > Enrico > > Il Lun 22 Ago 2022, 17:26 steven lu ha scritto: > > > I completely agree with your description, but you only answered the first > > question, > > the secon

Re: .asf.yaml details are determined

uldn't be blocking for a PR. > > Yong > > On Sat, 20 Aug 2022 at 22:05, steven lu wrote: > > > For details, see https://github.com/apache/bookkeeper/pull/3453 > > > > Now Bookkeeper is using .asf.yaml ( > > > > > https://cwiki.apache.org/confluence/d

.asf.yaml details are determined

For details, see https://github.com/apache/bookkeeper/pull/3453 Now Bookkeeper is using .asf.yaml ( https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection ) to configure the project, .asf.yaml details are determined 1. Whether

Re: [VOTE] Release 4.15.1, release candidate #0

t; org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:431) > at > org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1813) > at > org.apache.bookkeeper.client.LedgerHandle$5.safeRun(LedgerHandle.java:575) > > Il giorno ven 5 ago 2022 alle ore 03:31 steven lu > ha

Re: [VOTE] Release 4.15.1, release candidate #0

t; org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:431) > at > org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1813) > at > org.apache.bookkeeper.client.LedgerHandle$5.safeRun(LedgerHandle.java:575) > > Il giorno ven 5 a

Re: [VOTE] Release 4.15.1, release candidate #0

ient.AsyncCallback$AddCallback.addCompleteWithLatency(AsyncCallback.java:92) > at > org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:431) > at > org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1813) > at > org.apache.bookkeeper.client.Ledger

Re: [DISCUSS] Expose Rocks DB (Cache) Metrics

it's look good but it maybe similar to another existed metric "read-locations-index-time" Michael Marshall 于2022年8月10日周三 14:10写道： > Hi Bookkeeper Community, > > I created an issue [0] yesterday to discuss exposing Rocks DB metrics > via the bookie's /metrics endpoint. My primary focus is

Re: [VOTE] Release 4.15.1, release candidate #0

+1, Approve the release look good to me Yong Zhang 于2022年8月4日周四 20:39写道： > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.15.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

I re-read the code again, look good to me At the same time, please Enrico review the code, thank you Yan Zhao 于2022年8月2日周二 13:30写道： > Could you describe detail. > > On 2022/08/01 17:00:47 steven lu wrote: > > I feel that the code is not the same as the discussion: > > http

Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.

I feel that the code is not the same as the discussion: https://github.com/apache/bookkeeper/pull/3359 Enrico Olivelli 于2022年7月31日周日 01:55写道： > Il Ven 29 Lug 2022, 19:24 Yan Zhao ha scritto: > > > You means we define api in EnsemblePlacementPolicy, and use SPI to load > > special

Re: [DISCUSS] Bookkeeper 4.16.0 release

ok, I see , thanks Hang Chen 于2022年7月28日周四 10:29写道： > Hi Steven, > Those Prs are in the 4.16.0 milestone, and they are already > merged. They will be included in the 4.16.0 release. Thanks for your > great work! > > Thanks, > Hang > > steven lu 于2022年7月28日

Re: [DISCUSS] Bookkeeper 4.16.0 release

I think this index's optimization can release for 4.16.0 for details, have a look https://github.com/apache/bookkeeper/issues/3419 Hang Chen 于2022年7月20日周三 10:24写道： > Andrey, thanks for your noticing. > > I'm happy to be a volunteer for the version 4.16.0 release. > I have created an issue to

Re: [DISCUSS] BookKeeper 4.15.1 release

I think this index's optimization can release for 4.15.1 for details, please see https://github.com/apache/bookkeeper/issues/3419 Yong Zhang 于2022年7月22日周五 10:34写道： > Hi, > > There are some fixes in the 4.15, and 4.15.0 has been > released 2 month, I'd propose to do a minor release for > the

Re: directories to store index files

the function(set dir name to store index files) optimization is finished, thanks Enrico, for progress details, please see https://github.com/apache/bookkeeper/issues/3419 Enrico Olivelli 于2022年6月28日周二 19:33写道： > Steven, > > Il giorno lun 27 giu 2022 alle ore 11:22 steven lu >

Re: Modify the structure of LedgerDirsManager

only about refactoring BK code  Enrico Olivelli 于2022年7月13日周三 17:25写道： > Steven, > > Il giorno mer 13 lug 2022 alle ore 09:25 steven lu > ha scritto: > > > > old structure of LedgerDirsManager brings a lot of usage problem: > > 1. LedgerDirsManager is

Modify the structure of LedgerDirsManager

old structure of LedgerDirsManager brings a lot of usage problem: 1. LedgerDirsManager is not equal to other structures (for example: DefaultEntryLogger ) and cannot be 1-to-1 2. so we need to split into multiple LedgerDirsManager with only one dir this bring tedious conversion, and it is easy

Re: directories to store index files

thanks, coding the other stages Enrico Olivelli 于2022年6月28日周二 19:33写道： > Steven, > > Il giorno lun 27 giu 2022 alle ore 11:22 steven lu > ha scritto: > > > > There is a problem with the function of bookie's directories to store > index > > files, I plan to fi

bookkeeper testcase planning

this is junit 5, import by org.junit.jupiter.api: old junit 4,import by org.junit how to plan the follow-up testcase of bookkeeper 1. the new testcase is implemented with junit5 2. the old testcase remains the status quo, if necessary, upgrade to junit5

directories to store index files

There is a problem with the function of bookie's directories to store index files, I plan to fix this problem in 4 stages: 1) Iterate on a basic function first, pr: https://github.com/apache/bookkeeper/pull/3352 2) Add metadata and consistency check 3) Increase disk monitoring 4) The readonly