Build failed in Jenkins: brooklyn-master-windows #279

2016-09-09 Thread Apache Jenkins Server
See -- [...truncated 32978 lines...] [INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [01:44 min] [INFO] Brooklyn Server Root ... SUCCESS [ 1.533 s]

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-client/pull/25 interesting discussion on mailing list but seems like consensus is to go with what you've originally done here @andreaturli merge away! --- If your project is set up for it, you c

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Aled Sage
+1 for single brooklyn-client repo with subfolders 'cli' and 'java'. Aled On 09/09/2016 13:41, Geoff Macartney wrote: hi Alex et al. I guess those are fair points - it still makes me a bit queasy but I’ll go with the majority if they are happy to move it there. Don’t think I voted yet so I

[jira] [Commented] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-09-09 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15477634#comment-15477634 ] Aled Sage commented on BROOKLYN-345: The exception in https://issues.apache.org/jira

[jira] [Updated] (BROOKLYN-346) NPE after restart, in AutoScalerPolicy.onMetricChanged (when using yaml DSL for config)

2016-09-09 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage updated BROOKLYN-346: --- Description: After restarting Brooklyn (using 0.10.0-SNAPSHOT), I saw the NPE below in the log: {n

[jira] [Created] (BROOKLYN-346) NPE after restart, in AutoScalerPolicy.onMetricChanged (when using yaml DSL for config)

2016-09-09 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-346: -- Summary: NPE after restart, in AutoScalerPolicy.onMetricChanged (when using yaml DSL for config) Key: BROOKLYN-346 URL: https://issues.apache.org/jira/browse/BROOKLYN-346

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/25 @andreaturli you'll need to update the README.md to reflect the new location of the Go code. --- If your project is set up for it, you can reply to this email and have your reply appear on G

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Geoff Macartney
hi Alex et al. I guess those are fair points - it still makes me a bit queasy but I’ll go with the majority if they are happy to move it there. Don’t think I voted yet so I will say +0. :-) I certainly agree that there’s no point in changing the ‘brooklyn-client’ repo name. In terms of repo

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Alex Heneveld
hi geoff, andrea- brooklyn-library is a place to keep a library of blueprints that are officially part of Apache Brooklyn, not for just any library of code -- see [1]. definitely feels wrong to put it there. even if you have a preference separate projects, the other question to ask is whet

[jira] [Created] (BROOKLYN-345) NPE on rebind of enricher ServiceStateLogic$ComputeServiceState

2016-09-09 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-345: -- Summary: NPE on rebind of enricher ServiceStateLogic$ComputeServiceState Key: BROOKLYN-345 URL: https://issues.apache.org/jira/browse/BROOKLYN-345 Project: Brooklyn

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

2016-09-09 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/279#discussion_r78161634 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -49,6 +50,68 @@ import javax.annota

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Geoff Macartney
oh - adding my comments from the github discussion for completeness: geomacy commented 2 hours ago @andreaturli what's the reason for this? I think it would be better to keep the br CLI as a separate, Go, project, and not add in unrelated code. If there's some reason why the rest client needs to

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Geoff Macartney
Why not move it to brooklyn-library? It is a library, after all - a REST client library. Plus, just moving it to brooklyn-client (or anywhere) isn’t going to do anything to solve the problems Svet mentions in cases where it does need to be loaded. As a Go developer I’d be put off contributing

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Svetoslav Neykov
Adding some details to the discussion. "brooklyn-rest-client" is not bundled with the Brooklyn distribution (neither classic nor Karaf). It only shares a repo with it. resteasy is not causing problems but only because we are not using the client in a normal Brooklyn distribution. There are use c

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Andrea Turli
Robert, thanks for your feedback! Alex, https://github.com/apache/brooklyn-client/pull/25 implements ``` brooklyn-client/ cli/ **/*.go java/ src/main/java/**/*.java ``` Happy to change it to whatever you guys prefer (Alex's option 2 or option 3) Person

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Alex Heneveld
i lean towards this: brooklyn-client/ cli/ **/*.go java/ src/main/java/**/*.java or brooklyn-client/ cli/ **/*.go bindings/ java/ src/main/java/**/*.java but I could live with this: br

[GitHub] brooklyn-docs pull request #106: Advise running ntpd on Brooklyn server

2016-09-09 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/106#discussion_r78152257 --- Diff: guide/ops/troubleshooting/deployment.md --- @@ -40,9 +40,12 @@ means there was some problem obtaining or connecting to the machine. An

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Robert Moss
+1, prefer separate repo, though. Robert On 9 September 2016 at 10:03, Andrea Turli wrote: > Hi, > > I'd like to move `rest/rest-client` out of `brooklyn-server` > > brooklyn-server has a dependency on resteasy which is used only by the > rest/rest-client module. Having resteasy and cxf (two ja

[PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Andrea Turli
Hi, I'd like to move `rest/rest-client` out of `brooklyn-server` brooklyn-server has a dependency on resteasy which is used only by the rest/rest-client module. Having resteasy and cxf (two jax-rs implementations) in the classpath looks redundant to me. Also the extra work needed to support osgi

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/25 yes, definitely worth discussing there, thanks @andreaturli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-client/pull/25 I see your good point, @geomacy Let's discuss it more broadly, then. I'll ask the mailing list, thanks! --- If your project is set up for it, you can reply to this email and have you

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/25 the `resteasy` issue is its own thing, we should fix that in brooklyn-server, or, if moving the code is the right solution, fair enough, but I don't think this is the right place to move it.

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/25 It just feels wrong to me from the "keep things decoupled" / "do one thing" viewpoint.If I am a Go developer I might want to contribute to the brooklyn-client, but if I have no Java backg

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-client/pull/25 As for the reason: `brooklyn-server` has a dependency on `resteasy` which is used only by the `rest/rest-client` module. Having `resteasy` and `cxf` (2 jax-rs implementations) in the clas

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-client/pull/25 @geomacy, I think `brooklyn-client` may be the home for multiple brooklyn clients. I think the `go cli` is just one (the preferred one!), `java` is another one, and ideally we could have

[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client

2016-09-09 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/25 @andreaturli what's the reason for this? I think it would be better to keep the `br` CLI as a separate, Go, project, and not add in unrelated code. If there's some reason why the rest clien

[GitHub] brooklyn-client pull request #25: move rest-client to brooklyn-client

2016-09-09 Thread andreaturli
GitHub user andreaturli opened a pull request: https://github.com/apache/brooklyn-client/pull/25 move rest-client to brooklyn-client See also https://github.com/apache/brooklyn-server/pull/325 , merge them in tandem, if ok. You can merge this pull request into a Git repository by

[GitHub] brooklyn-server pull request #325: move rest/rest-client to brooklyn-client ...

2016-09-09 Thread andreaturli
GitHub user andreaturli opened a pull request: https://github.com/apache/brooklyn-server/pull/325 move rest/rest-client to brooklyn-client submodule You can merge this pull request into a Git repository by running: $ git pull https://github.com/andreaturli/brooklyn-server mov

[GitHub] brooklyn-server issue #279: Allow provisioning.properties to reference resol...

2016-09-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/279 I think this resolves and stores config too early. We need to ensure the raw unresolved values are given to the `JcloudsSshMachineLocation` (and a few other places). See https://github.co

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

2016-09-09 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/279#discussion_r78140278 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -603,21 +607,37 @@ public MachineLocatio

[GitHub] brooklyn-server issue #144: Allows for multiple deserialization class rename...

2016-09-09 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/144 @nakomis ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s