Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Aled Sage
+1 for single brooklyn-client repo with subfolders 'cli' and 'java'. Aled On 09/09/2016 13:41, Geoff Macartney wrote: hi Alex et al. I guess those are fair points - it still makes me a bit queasy but I’ll go with the majority if they are happy to move it there. Don’t think I voted yet so I

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Geoff Macartney
hi Alex et al. I guess those are fair points - it still makes me a bit queasy but I’ll go with the majority if they are happy to move it there. Don’t think I voted yet so I will say +0. :-) I certainly agree that there’s no point in changing the ‘brooklyn-client’ repo name. In terms of repo

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Alex Heneveld
hi geoff, andrea- brooklyn-library is a place to keep a library of blueprints that are officially part of Apache Brooklyn, not for just any library of code -- see [1]. definitely feels wrong to put it there. even if you have a preference separate projects, the other question to ask is whet

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Geoff Macartney
oh - adding my comments from the github discussion for completeness: geomacy commented 2 hours ago @andreaturli what's the reason for this? I think it would be better to keep the br CLI as a separate, Go, project, and not add in unrelated code. If there's some reason why the rest client needs to

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Geoff Macartney
Why not move it to brooklyn-library? It is a library, after all - a REST client library. Plus, just moving it to brooklyn-client (or anywhere) isn’t going to do anything to solve the problems Svet mentions in cases where it does need to be loaded. As a Go developer I’d be put off contributing

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Svetoslav Neykov
Adding some details to the discussion. "brooklyn-rest-client" is not bundled with the Brooklyn distribution (neither classic nor Karaf). It only shares a repo with it. resteasy is not causing problems but only because we are not using the client in a normal Brooklyn distribution. There are use c

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Andrea Turli
Robert, thanks for your feedback! Alex, https://github.com/apache/brooklyn-client/pull/25 implements ``` brooklyn-client/ cli/ **/*.go java/ src/main/java/**/*.java ``` Happy to change it to whatever you guys prefer (Alex's option 2 or option 3) Person

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Alex Heneveld
i lean towards this: brooklyn-client/ cli/ **/*.go java/ src/main/java/**/*.java or brooklyn-client/ cli/ **/*.go bindings/ java/ src/main/java/**/*.java but I could live with this: br

Re: [PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Robert Moss
+1, prefer separate repo, though. Robert On 9 September 2016 at 10:03, Andrea Turli wrote: > Hi, > > I'd like to move `rest/rest-client` out of `brooklyn-server` > > brooklyn-server has a dependency on resteasy which is used only by the > rest/rest-client module. Having resteasy and cxf (two ja

[PROPOSAL] Remove rest/rest-client from brooklyn-server

2016-09-09 Thread Andrea Turli
Hi, I'd like to move `rest/rest-client` out of `brooklyn-server` brooklyn-server has a dependency on resteasy which is used only by the rest/rest-client module. Having resteasy and cxf (two jax-rs implementations) in the classpath looks redundant to me. Also the extra work needed to support osgi