[GitHub] [incubator-brpc] zzjshaok opened a new issue #992: ParallelChannel发送消息偶尔失败

2019-12-11 Thread GitBox
zzjshaok opened a new issue #992: ParallelChannel发送消息偶尔失败 URL: https://github.com/apache/incubator-brpc/issues/992 brpc::ParallelChannel 对象内部只AddChannel了一个sub channel,进行rpc 客户端调用时,有时候会报错,业务代码如下: stub.rnd_next(&(m_readrpcDone->cntl), &request, &(m_readrpcDone->read_response), m_readrpcDo

committer 申请 -- 何磊

2019-12-11 Thread lhestz
Hi all: 大家好,我是何磊, 来自爱奇艺广告销售部,目前主要负责广告引擎基础架构的相关工作,github主页是 https://github.com/TousakaRin 。我们团队在 2017 年引入了 brpc,并对广告引擎大部分后台服务进行了brpc改造。我们在爱奇艺内部维护了自己分支,并且会定期和社区同步代码,同时也会将一些 feature 及 bug fix 推送到社区。期间我们向社区推送了consul名字服务、自动限流、单节点熔断,multi连接方式等 feature 以及一些 bug fix。其中自动限流及单节点熔断功能均主要由我开发并且已经merge到m

Re: committer 申请 -- 何磊

2019-12-11 Thread tan zhongyi
thanks helei, we will discuss it and call for a vote later, according to apache rules. Let me translate your request into English for better understanding as below. "Hello, I'm he Lei from iqiyi advertising department. I'm mainly responsible for the infrastructure of advertising engine. My home

vote to accept helei as committer

2019-12-11 Thread tan zhongyi
Hi, guys, Let us vote to accept Helei as committer. Please reply +1 if you agree, Reply -1 if you disagree, together with your reason. Thanks Below is his application: "Hello, I'm he Lei from iqiyi advertising department. I'm mainly responsible for the infrastructure of advertising engine. My

Re: vote to accept helei as committer

2019-12-11 Thread JiashunZhu
+1. tan zhongyi 于2019年12月11日周三 下午11:26写道: > Hi, guys, > > Let us vote to accept Helei as committer. > Please reply +1 if you agree, > Reply -1 if you disagree, together with your reason. > Thanks > > > Below is his application: > > "Hello, I'm he Lei from iqiyi advertising department. I'm mainly

Re: vote to accept helei as committer

2019-12-11 Thread James Ge
+1 On Thu, Dec 12, 2019 at 11:12 AM JiashunZhu wrote: > +1. > > tan zhongyi 于2019年12月11日周三 下午11:26写道: > > > Hi, guys, > > > > Let us vote to accept Helei as committer. > > Please reply +1 if you agree, > > Reply -1 if you disagree, together with your reason. > > Thanks > > > > > > Below is his

Re: vote to accept helei as committer

2019-12-11 Thread Zhangyi Chen
+1 On Thu, Dec 12, 2019 at 11:17 AM James Ge wrote: > +1 > > On Thu, Dec 12, 2019 at 11:12 AM JiashunZhu > wrote: > > > +1. > > > > tan zhongyi 于2019年12月11日周三 下午11:26写道: > > > > > Hi, guys, > > > > > > Let us vote to accept Helei as committer. > > > Please reply +1 if you agree, > > > Reply -1

[GitHub] [incubator-brpc] lpstudy opened a new issue #993: Does IOPortal consider to support create memory aligned block for direct IO

2019-12-11 Thread GitBox
lpstudy opened a new issue #993: Does IOPortal consider to support create memory aligned block for direct IO URL: https://github.com/apache/incubator-brpc/issues/993 1. IOPortal calls `pappend_from_file_descriptor` to read data from a opened `fd`, where in my condition `fd` is opened with

申请成为brpc committer

2019-12-11 Thread 牟盖东
hi,all 我是牟盖东, 来自爱奇艺广告部门,负责广告在线服务的架构。 2017年,我将brpc引入我们业务线,到2019年我们所有服务已经改造为基于brpc框架。期间,我提交过bug fix,并与2019年参加百度技术沙龙,分享brpc中熔断和限流的实现原理。 后面,希望能进一步参与brpc社区事务,参与代码review和宣传活动等。

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356971336 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952231 ## File path: src/brpc/redis.h ## @@ -209,7 +213,54 @@ class RedisResponse : public ::google::protobuf::Message { std::ost

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355987152 ## File path: example/redis_c++/redis_server.cpp ## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952596 ## File path: src/brpc/policy/redis_protocol.h ## @@ -33,6 +33,13 @@ ParseResult ParseRedisMessage(butil::IOBuf* source, So

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952885 ## File path: src/brpc/redis.h ## @@ -209,7 +213,54 @@ class RedisResponse : public ::google::protobuf::Message { std::ost

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952989 ## File path: src/brpc/redis_command.cpp ## @@ -360,4 +360,86 @@ butil::Status RedisCommandByComponents(butil::IOBuf* outp

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953916 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953233 ## File path: src/brpc/redis_reply.cpp ## @@ -189,7 +245,7 @@ ParseError RedisReply::ConsumePartialIOBuf(butil::IOBuf& buf

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356954111 ## File path: src/brpc/redis_command.h ## @@ -40,6 +40,28 @@ butil::Status RedisCommandByComponents(butil::IOBuf* buf,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953434 ## File path: src/brpc/redis_reply.cpp ## @@ -37,6 +38,61 @@ const char* RedisReplyTypeToString(RedisReplyType type) {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356973158 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356952177 ## File path: src/brpc/redis.h ## @@ -124,7 +128,7 @@ class RedisRequest : public ::google::protobuf::Message { void P

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356954267 ## File path: src/brpc/redis_reply.h ## @@ -128,6 +167,8 @@ class RedisReply { } array; uint64_t padding[

[GitHub] [incubator-brpc] jamesge commented on issue #993: Does IOPortal consider to support to create memory aligned block for direct IO

2019-12-11 Thread GitBox
jamesge commented on issue #993: Does IOPortal consider to support to create memory aligned block for direct IO URL: https://github.com/apache/incubator-brpc/issues/993#issuecomment-564868544 A work-around: allocate and read into the buffer by you own, and manage&share the buffer by IOBuf

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #991: Support protocol parsing order

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #991: Support protocol parsing order URL: https://github.com/apache/incubator-brpc/pull/991#discussion_r356976911 ## File path: src/brpc/global.cpp ## @@ -556,7 +575,7 @@ static void GlobalInitializeOrDieImpl() { NULL,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #991: Support protocol parsing order

2019-12-11 Thread GitBox
jamesge commented on a change in pull request #991: Support protocol parsing order URL: https://github.com/apache/incubator-brpc/pull/991#discussion_r356976719 ## File path: src/brpc/input_messenger.cpp ## @@ -86,7 +86,7 @@ ParseResult InputMessenger::CutInputMessage(

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #972: Redis server protocol

2019-12-11 Thread GitBox
zyearn commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356990098 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +58,206 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] ten2ton opened a new issue #994: Link to contributing page is invalid

2019-12-11 Thread GitBox
ten2ton opened a new issue #994: Link to contributing page is invalid URL: https://github.com/apache/incubator-brpc/issues/994 **Describe the bug (描述bug)** In project home site community page, link to contributing page is invalid. **To Reproduce (复现方法)** **Expected beha