Re: Supporting multiple JDKs

2018-08-22 Thread Dinesh Joshi
> On Aug 22, 2018, at 7:23 PM, Mick Semb Wever wrote: > > There's a cost-optimisation here in reducing what we have to support. I agree and animal sniffer is a great way to ferret out obvious issues. I am not against using animal sniffer. I'm concerned that there are various incompatibilities[

Re: Supporting multiple JDKs

2018-08-22 Thread Mick Semb Wever
What do we mean "support multiple JDKs" ? Are we talking Run-time or Compile-time? > If we support multiple JDKs, at a minimum we should compile code against > those JDKs. Why? I really don't get that logic. There's a cost-optimisation here in reducing what we have to support. If we supp

Re: JIRAs in Review

2018-08-22 Thread Joseph Lynch
Just want to bump this up if any reviewers have time before the 9/1 window. I think these are all patch available and ready for review at this point. Useful improvements for 4.0: > > https://issues.apache.org/jira/browse/CASSANDRA-14303 and > https://issues.apache.org/jira/browse/CASSANDRA-14557 -

Re: Supporting multiple JDKs

2018-08-22 Thread dinesh.jo...@yahoo.com.INVALID
I think we should have the ability to build & run unit tests and dtests against a specified JDK. If we support multiple JDKs, at a minimum we should compile code against those JDKs. It would be ideal if we could run unit tests and dtests but given the availability of CircleCI resources that coul

Supporting multiple JDKs

2018-08-22 Thread Sumanth Pasupuleti
Hi, The goal of this email is to arrive at a solution (probably resulting in a few follow-ups) to ensure support for multiple JDKs for different versions of Cassandra. This comes out of Jason's comment in https://issues.apache.org/jira/browse/CASSANDRA-14563. Below is the proposal. Please provide

Re: JIRAs in Review

2018-08-22 Thread Marcus Olsson
Hi, Hopefully it's not too late to add to this list. https://issues.apache.org/jira/browse/CASSANDRA-14096 could use some reviewing. This issue occurs if you have multiple tables in a keyspace and perform a full repair. Then you could end up storing alot of MerkleTrees in memory until the repair