Hi Mike,
Yes, I won¹t hesitate to ask your help. Thank you as always.
Hi Cam and everyone,
I would like to clarify that the time wasting discussion is not about the
project workflow at all.
I am sorry, but I have been too busy to read any email thread on the
workflow.
The discussion in my ema
Beyond my comments below I'm stepping off this thread. It's become too
toxic for my liking and most of the "discussion" on here is helping nothing.
I think getting feedback on our current workflow would be great. If you
have ideas anyone please do respond (or maybe just make a new thread) so we
ca
Hi Chris,
I'm aware that I'm not responding to your previous reply exactly but my
reaponse is still on this overall thread so that's OK.
This thread seems to have, rather drastically turned into a bit of a
pissibg match on one hand and borderline argument on the other. Which is
uncharacteristic and
Wow! There sure is a lot of passion and fire in this thread, so let me put
on my asbestos small clothes and wade into the pool.
Dear Kyo,
When you say that this discussion is a waste of your time it makes me sad.
Sure sitting here the last 20 minutes reading this thread could be seen as
a waste
Thank you for the great responses Lewis. You put into words what I haven't
seemed to be able to type out today. Few comments below (it's really mostly
just me typing +100 to be honest though)
-- Jimmy
On Tue, May 12, 2015 at 8:29 PM, Lewis John Mcgibbney <
lewis.mcgibb...@gmail.com> wrote:
Lewis,
-Original Message-
From: Lewis John Mcgibbney
Reply-To: "dev@climate.apache.org"
Date: Tuesday, May 12, 2015 at 8:29 PM
To: "dev@climate.apache.org"
Subject: Re: Project Workflow
>Hi Chris,
>Please see replies inline
>
>On Tue, May 12, 2015 at 6:10 PM,
>wrote:
>
>>
>> I’m hone
Hi Chris,
Please see replies inline
On Tue, May 12, 2015 at 6:10 PM, wrote:
>
> I’m honestly not sure what you are talking about,
Not even one wee bit ;) maybe some of my replies will bridge the gap
between you not being sure about what I am talking about Vs disagreeing
with what I am trying t
I'm not sure I want to wade all the way into this, but a few notes from
the climate science side of things :)
First, I agree with Chris's sentiment. There should be as few barriers as
possible towards any development of the code. Everyone working on this is
capable of writing software and if he
Shadowing => Apache != having a healthy dev community.
Cheers,
Chris
++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 1
Lewis,
I’m honestly not sure what you are talking about, and to be honest,
waiting 72 hours before committing everything is not a project I’d
ever want to be on. Like I said - if I care about a review, or
want something to be seen by someone, fine, I can choose to ask for
it. It shouldn’t be *impo
Mike,
A few top level thoughts without replying directly inline below I
get pretty tired of reading in-between threads on that, so thought
I would summarize here:
1. I’ve been on tons of projects that had commit, review later,
commit. In fact, pretty much every project I’m on works that way,
most
Hi Kyo,
On Tue, May 12, 2015 at 3:05 PM, wrote:
>
> This debate just wastes my time.
>
! Why !
> I am not simply talking about the advantages or disadvantages.
Advantages or disadvantages of what? The Workflow?
> The old one
> has serious problems.
The old what? The Workflow? It is if t
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540888#comment-14540888
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540884#comment-14540884
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540883#comment-14540883
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101438266
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101437915
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101437947
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540866#comment-14540866
]
ASF GitHub Bot commented on CLIMATE-634:
Github user huikyole commented on the pu
Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101436518
Now in the latest commit, utils.calc_climatology_year,
utils.calc_climatology_season and utils.calc_climatology_montly can be all
replaced by using dataset_processor.t
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540865#comment-14540865
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101436226
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540863#comment-14540863
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540862#comment-14540862
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101435802
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101435785
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
As far as I'm aware that is the current case Lewis. Also it maps to the
relevant JIRA ticket if people name their PRs properly.
-- Jimmy
On Tue, May 12, 2015 at 1:03 PM, Lewis John Mcgibbney <
lewis.mcgibb...@gmail.com> wrote:
> Hi Folks,
>
> On Tue, May 12, 2015 at 10:39 AM,
> wrote:
>
> >
>
Hi Chris,
Responses inline
On Tue, May 12, 2015 at 10:39 AM,
wrote:
>
> I don’t think we should dictate everything be code reviewed.
72 hours seems pretty permissive to me. I would comment that I see it as a
different case where comments are provided and not addressed. I also don't
think that
Hi Jimmy,
On Tue, May 12, 2015 at 10:39 AM,
wrote:
> Since this has been brought up a few times on various tickets I thought now
> would be a good time to go over our project workflow and make sure it's
> working for us.
>
Excellent idea!
>
> A general overview of the workflow that we use is
Hi Folks,
On Tue, May 12, 2015 at 10:39 AM,
wrote:
>
> I notice that most of the discussions around dev for the project
> are occurring on Github issues. I think if they are architecturally
> relevant and things like that, they should happen here on dev,
> with a noticeable subject line and requ
Yeah Kyo I was trying to remove the need to debate and to move forward with
code where we can.
Sent from my iPhone
> On May 12, 2015, at 12:37 PM, Lee, Kyo (329C-Caltech)
> wrote:
>
> Dear Chris,
>
> This debate just wastes my time.
> I am not simply talking about the advantages or disadvant
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540488#comment-14540488
]
ASF GitHub Bot commented on CLIMATE-634:
Github user MJJoyce commented on the pul
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101388428
The problem with the movement of calc_climatology_season in the format it
was moved in is that it doesn't follow the dataset processor conventions. A
dataset_processor
Pre-email note - 'you' is used here to collectively refer to a nonexistent
person, not a specific person in this chain of emails.
---
I would certainly agree that RTC COULD cause problems if it wasn't applied
fairly. But it's applied generally across all commits from all contributors
here. If no
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540423#comment-14540423
]
ASF GitHub Bot commented on CLIMATE-634:
Github user MJJoyce commented on the pul
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540425#comment-14540425
]
ASF GitHub Bot commented on CLIMATE-634:
Github user kwhitehall commented on the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540422#comment-14540422
]
ASF GitHub Bot commented on CLIMATE-634:
Github user kwhitehall commented on the
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101379241
@huikyole I'm not entirely sure I am following your slide on PR #197
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101378903
Ah I see @kwhitehall. I would say it really doesn't hurt to have more tests
honestly. Worst case we can remove them later if they don't help out, but
that's just my tho
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101378372
@MJJoyce thanks for the advice! I'm not entirely sure it's for the code
base in general, more so for explanation of what's going on here. But if you
want it in the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540391#comment-14540391
]
ASF GitHub Bot commented on CLIMATE-634:
Github user MJJoyce commented on the pul
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101372878
@kwhitehall For the unittest you're going to want to put that with the
other unit tests for the core library (ocw/tests) and name it inline with the
other ones. For thi
Dear Chris,
This debate just wastes my time.
I am not simply talking about the advantages or disadvantages. The old one
has serious problems. If anyones know the problem, that person would never
use the module.
The module of the debate is too simple to spend my time to discuss. Anyone
at JPL can
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540312#comment-14540312
]
ASF GitHub Bot commented on CLIMATE-634:
Github user huikyole commented on the pu
Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101361410
---
If your project is set up for it, you can r
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540249#comment-14540249
]
ASF GitHub Bot commented on CLIMATE-634:
Github user kwhitehall commented on a di
Github user kwhitehall commented on a diff in the pull request:
https://github.com/apache/climate/pull/197#discussion_r30156559
--- Diff: examples/simple_model_to_model_bias_DJF_and_JJA.py ---
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540219#comment-14540219
]
ASF GitHub Bot commented on CLIMATE-634:
Github user kwhitehall commented on the
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101349340
@chrismattmann I've added a unittest as suggested. (I can clean it up
later if we decide to keep it The purpose is to illustrate the shape of the
datasets and which
I believe the current workflow has inhibited progress and caused tension.
Although I've been more of an observer than contributor it seems to me that
when your community is small that the emphasis should be on allowing as Chris
states for people to "scratch their own itch." Additionally, I've se
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101346906
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540204#comment-14540204
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540202#comment-14540202
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540203#comment-14540203
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101346682
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101346694
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
I think another interesting question would be: Are we not having
discussions we need to have or do we just not need to have those
discussions and that's why we haven't had them? I.e., are the changes being
made not sweeping architectural changes vs feature additions/bug fixes??
Coming back from t
I don’t think we should dictate everything be code reviewed. I’ve
seen this directly lead to conversations that are relevant to
development being buried in Github. Take for example your and
Whitehall’s conversation(s) with Kyo that I doubt anyone here has
ever seen since they aren’t even commenting
Hi folks,
Since this has been brought up a few times on various tickets I thought now
would be a good time to go over our project workflow and make sure it's
working for us.
A general overview of the workflow that we use is available at [1]. A brief
overview is that:
- ALL changes are pushed up t
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540085#comment-14540085
]
ASF GitHub Bot commented on CLIMATE-634:
Github user MJJoyce commented on the pul
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/196#issuecomment-101328087
@chrismattmann, the normal workflow on the project is to push changes for
review via PR. I don't think it's a great idea to suggest people to just push
their changes wh
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539506#comment-14539506
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101186299
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
[
https://issues.apache.org/jira/browse/CLIMATE-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539504#comment-14539504
]
ASF GitHub Bot commented on CLIMATE-634:
Github user OCWJenkins commented on the
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101186148
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/197#issuecomment-101186156
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
GitHub user huikyole opened a pull request:
https://github.com/apache/climate/pull/197
Climate 634 please take a look at this request as a reference.
1. Currently, we cannot load ocw.dataset or ocw.datset_processor library in
utils.py. So calc_climatology_season is moved from ocw.ut
67 matches
Mail list logo
