Re: Review Request 12719: CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12719/#review23487 --- Ship it! Ship It! - Jayapal Reddy On July 19, 2013, 6:55 a.m., H

Re: Review Request 12743: removed unused class and related test utils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12743/#review23486 --- Hi, Indeed it looks like it is coming from the vmsync branch, it do

Re: documentation links to epub/pdf broken

Hi, Some links for the 4.0.2 pdf's are also invalid: - api developers guide - installation guide Can someone take a look at this please? Thanks! On Wed, Jul 17, 2013 at 7:01 PM, Jörgen Maas wrote: > No sir, thank you for fixing this! :) > > > On Wed, Jul 17, 2013 at 6:35 PM, Sebastien Goasg

Re: Review Request 12719: CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12719/ --- (Updated July 19, 2013, 6:55 a.m.) Review request for cloudstack, Abhinandan Pr

Re: [jira] [Commented] (CLOUDSTACK-3163) KVM Virtual Router startup time is painfully long

Marcus How far are you from prototype to a usable patch? On somewhat similar topic, this is more on rvm side For vmware, while a single call is made, userdata.sh had to be enhanced due to too many indentical entries in htaccess file (I.e. Each vm creation would add about 10 or more entries into

Re: CallContexts?

"Ipc framework and events framework needs to add this." Alex, what specifically events framework need to handle this? Till 4.2, UserContext was used to keep info like entity type, entity UUID, event description etc in the UserContext. With CallContext, I see storing entity details in CallContext

Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/#review23484 --- Commit 12c711cef7d75f2feaebb8da82e57979869dac49 in branch refs/heads

Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/#review23485 --- Commit 03fac831800a8b7fd34af607a0ca36ced05cb0ea in branch refs/heads

Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

> On July 17, 2013, 5:58 a.m., Harikrishna Patnala wrote: > > api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java, > > line 103 > > > > > > This will be inconsistent at some times when we cr

Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/#review23483 --- Ship it! Ship It! - Nitin Mehta On July 15, 2013, 12:10 p.m., Ha

RE: Query String Request Authentication(QSRA) support by S3 providers

Hi, I have not seen the issue in extract template/iso after the changes. Works fine. Thanks, Sanjeev -Original Message- From: Min Chen [mailto:min.c...@citrix.com] Sent: Friday, July 19, 2013 5:08 AM To: Jessica Wang Cc: dev@cloudstack.apache.org; Edison Su; Thomas O'Dowd Subject: Re: Q

Re: Review Request 12755: Fix ostype CLOUDSTACK-3645

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12755/#review23481 --- Ship it! Ship It! - Prasanna Santhanam On July 19, 2013, 5:25 a.

Re: Review Request 12755: Fix ostype CLOUDSTACK-3645

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12755/#review23480 --- Commit 78ac22e157e1bc0874dff5e6a4422559697d54e8 in branch refs/heads

Re: Review Request 12755: Fix ostype CLOUDSTACK-3645

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12755/#review23479 --- Commit c03296808b81c543f6c5c5c3d1844c68ae9b1370 in branch refs/heads

Re: deleteAffinityGroup API

All of our tests go over 8080, I explained this to Prachi last night over IRC. The logs I picked out oddly had only system-background threads. I'll add more relevant logs. or you can run the test_affinity_groups.py tests against a simulator run from test/integration/component/. That's how I repro-

Re: Review Request 12747: Fix configuration of Jetty-based execution so that CloudStack can execute scripts properly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12747/#review23477 --- Change looks ok. If someone familiar with mvn could also look at it,

Review Request 12755: Fix ostype CLOUDSTACK-3645

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12755/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3645 R

Re: secondary storage questions

When we use the word "template" here, do we mean both templates (like OVAs) and ISOs? Thanks! On Wed, Jun 5, 2013 at 5:07 PM, Marcus Sorensen wrote: > Thanks, I have one follow-up: > > On Tue, Jun 4, 2013 at 12:10 AM, Nitin Mehta > wrote: > > All the public templates will be replicated to all

RE: CallContexts?

I wrote a small wiki page on what we want to do with CallContext. Please have a read and comment. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+CallContext --Alex > -Original Message- > From: Kelven Yang [mailto:kelven.y...@citrix.com] > Sent: Thursday, July 18, 2013 2:

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11479/#review23472 --- Updated diff files related to Review Board comments can be found her

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11479/#review23471 --- Updated diff files related to Review Board comments can be found her

Re: Git Push Summary

Hi Pranav, I'll do more tests before applying the code to master in next few days. Since the UI code has been re-formatted yesterday, I'd like to copy/paste the modified part into master instead of merging the branch. Thanks for all the help and advice :) Regards On Thu, Jul 18, 2013 at

RE: Demo Lab - To rent or To buy

Ian You dont need a server, a nicely loaded desktop or even large laptop would do the job. What is the budget like? I would go with desktop grade motherboard (budget being tight), ssd disk for root, sata for remaining. Setup multiple disks in raid 1 or raid 5. CPU depending on the budget. RA

RE: [rant] stupid test cases

I disagree. Error handling should be part of our testing. We should incorporate the simulator into the BVT and regression tests. On testcases that really is to test the business logic rather than the provisioning code, the test case should perform all of the provisioning on the simulator inst

RE: code formatting for enums

Yes it's brittle. I assume "law of least astonishment" here means reducing learning curve of developers and the changes they made should not surprise user. To achieve this the code must provide very flexibility to developer. However, I am thinking of such kind of flexibility is really needed,

Re: Review Request 12752: Async commands can inject the job id

> On July 18, 2013, 11:34 p.m., Marcus Sorensen wrote: > > server/src/com/cloud/async/AsyncJobVO.java, line 141 > > > > > > I'm not immediately certain why this was pulled out. Nothing is using it. I did a scan to se

Demo Lab - To rent or To buy

Hi, I'm looking for peoples personal opinions. I'm thinking about undertaking a project for a 2 month college assignment sometime in the future to create an API wrapper and web front end with the end goal of producing something like the rackspace or linode web-ui. I do realise 'basic cloud' is a

Re: [jira] [Commented] (CLOUDSTACK-3163) KVM Virtual Router startup time is painfully long

I've prototyped a fix for this, and it took the VmDataCommand from ~7 seconds on restarting one VM down to ~300ms. For rebooting a router, with multiple VMs connected, that should be significant. I'm just dumping the data sent to vmdata into a file as json, copying that up to the router, and proce

RE: code formatting for enums

Agreed it's brittle. On the db side, it's not a big deal though. It just means when you change the enums, make sure the toString() method still retuns what's in the DB. I just wanted to caution that in case we're making changes. On the API side, I generally think we shouldn't expose states

RE: deleteAffinityGroup API

This code is generic to all APIs - not just for deleteAffinity API. Alena do you know why does accountmanager deny access to system user? -Original Message- From: Alex Huang Sent: Thursday, July 18, 2013 4:39 PM To: Prachi Damle; dev@cloudstack.apache.org Subject: RE: deleteAffinityGroup

Re: code formatting for enums

Alex and Frank, In terms of conventions, the APIs exposed Java SDK and many other common APIs following this convention. Hence, the reason for my suggestion. The notion that changing an enum key can break the API and/or database persistence feels a bit brittle. In particular, it doesn't confo

RE: deleteAffinityGroup API

Prachi, Unrelated to the bug, I also want to ask why do we check for system account in this case. In CloudStack System context should have the same privileges as an admin.Why in this specific case we check for system account and deny access? --Alex > -Original Message- > From: Pra

Re: Query String Request Authentication(QSRA) support by S3 providers

Thanks Jessica. Tom, did you still see the issue? -min On 7/8/13 1:20 PM, "Jessica Wang" wrote: >Min, > >> would you please take a look at this to see if UI can disable decoding >>in displaying this download template url >> returned from API? > >I just changed UI to not decode the URL returned

Re: Review Request 12752: Async commands can inject the job id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12752/#review23457 --- api/src/org/apache/cloudstack/api/BaseAsyncCmd.java

Review Request 12752: Async commands can inject the job id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12752/ --- Review request for cloudstack and Marcus Sorensen. Repository: cloudstack-git

Re: Review Request 12611: Patch to fix stale cookie and refresh issue in UCS plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12611/#review23455 --- Ship it! Ship It! - Frank Zhang On July 17, 2013, 12:11 a.m., Am

RE: code formatting for enums

Those enums cannot be simply considered as internal data structures where code convention applies to, they should be considered in API level. Most CloudStack API responses retrieve its fields from xxxVO classes which represent database table. In our example, enum State directly maps to UserVmRes

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

Yes, CPVM has to be destroyed and be re-deployed so that updates can be pushed over to make it work Kelven On 7/18/13 2:54 PM, "Musayev, Ilya" wrote: >When I say upgraded, I mean it needs to be trashed and redeployed. > >> -Original Message- >> From: Musayev, Ilya [mailto:imusa...@webmd

RE: deleteAffinityGroup API

Prasanna does the regression test scripts call using 8096 port? If yes then that's the reason why the API is failing. From: Alena Prokharchyk Sent: Thursday, July 18, 2013 4:13 PM To: dev@cloudstack.apache.org; Prachi Damle; Alex Huang Subject: Re: deleteAffinityGroup API If the API came throug

Re: deleteAffinityGroup API

If the API came through port 8096, then the caller comes as a System context (System default user id=1, account id=1). It was always like this since the time the UserContext was introduced. -Alena. From: Alex Huang mailto:alex.hu...@citrix.com>> Reply-To: "dev@cloudstack.apache.org

RE: deleteAffinityGroup API

This one is a problem. I will look into it. In the bug description, all the logs were background threads. All of CloudStack background threads act with system context. That's correct. That's why I closed it out. Here I think you're actually saying that when called through admin API, it came

RE: code formatting for enums

Actually, that's more of a C/C++ coding convention. (Speaking of which, please don't use "I" to start interfaces.) I prefer to have enums as follows Public class Vm { enum State { IsRunning, Stopped, } } I generally like to write Vm.State.IsRunning in the code. It's readable and clear.

Re: Review Request 12743: removed unused class and related test utils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12743/ --- (Updated July 18, 2013, 10:53 p.m.) Review request for cloudstack and Kelven Ya

Re: Review Request 12744: Removed unused classes

> On July 18, 2013, 10:42 p.m., Sheng Yang wrote: > > Ship It! Pushed to MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/#review23444 ---

Re: Review Request 12744: Removed unused classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/#review23444 --- Ship it! Ship It! - Sheng Yang On July 18, 2013, 8:51 p.m., Lasz

RE: [rant] stupid test cases

+1 VM can be in "Stopped" state Anthony -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Wednesday, July 17, 2013 10:47 PM To: dev@cloudstack.apache.org Subject: Re: [rant] stupid test cases I can understand that we may want to test that everything related

RE: [DISCUSS] Upgrade path to ACS 4.2 from CCP

> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, July 18, 2013 6:49 AM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] Upgrade path to ACS 4.2 from CCP > > On Wed, Jul 17, 2013 at 11:43:49PM +, Animesh Chaturvedi wrote: > > > >

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

When I say upgraded, I mean it needs to be trashed and redeployed. > -Original Message- > From: Musayev, Ilya [mailto:imusa...@webmd.net] > Sent: Thursday, July 18, 2013 5:46 PM > To: Kelven Yang; dev@cloudstack.apache.org > Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

Kelven, Perhaps I missed it, Does CPVM needs to be upgraded from 4.1 to 4.1.1? Thanks ilya > -Original Message- > From: Kelven Yang [mailto:kelven.y...@citrix.com] > Sent: Thursday, July 18, 2013 5:25 PM > To: Musayev, Ilya; dev@cloudstack.apache.org > Subject: Re: [ACS4.1.1][BLOCKER] U

Review Request 12747: Fix configuration of Jetty-based execution so that CloudStack can execute scripts properly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12747/ --- Review request for cloudstack, Chip Childers, Devdeep Singh, and Hugo Trippaers.

Re: Review Request 12716: Fix for NPE

> On July 18, 2013, 3:54 p.m., Sheng Yang wrote: > > Ship It! Pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12716/#review23385

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

I'll take a look at it. It seems that my devCloud environment failed to get CPVM upgraded thus let my testing on this skipped with success Kelven On 7/17/13 8:04 PM, "Musayev, Ilya" wrote: >Kelven > >Please review the commit "73a6aa78854f379e6439bf22457094a5272cbfed", >cloudstack-3433. > >After

Re: CallContexts?

CallContext was renamed from original UserContext. The semantic is pretty much the same as before to API calls Kelven On 7/18/13 1:25 AM, "Prasanna Santhanam" wrote: >On Thu, Jul 18, 2013 at 11:58:30AM +0530, Prasanna Santhanam wrote: >> I see the following repeated lines with API calls on mast

Re: [DISCUSS] coding convention for method - and class length

Like eight or so years ago, I sent a method I had to modify to the printer (so I could study it on regular paper) and it came out on 14 pages. On Thu, Jul 18, 2013 at 3:04 PM, Donal Lafferty wrote: > > -Original Message- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent

Re: [jira] [Commented] (CLOUDSTACK-3163) KVM Virtual Router startup time is painfully long

... and each vmdata.sh calls ssh and/or scp several times. Off the top of my head, it seems like we could serialize that cmd.getVmData() output to maybe JSON or something, get it up on the router in one call, and then process it there in a python script. On Thu, Jul 18, 2013 at 7:08 AM, Wido den H

RE: [DISCUSS] coding convention for method - and class length

> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: 18 July 2013 9:43 PM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] coding convention for method - and class length > > On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: > > I'm no

Review Request 12744: Removed unused classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Review Request 12743: removed unused class and related test utils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12743/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: [DISCUSS] coding convention for method - and class length

On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: > I'm not sure how I feel about an arbitrary number of lines per method > (although 200 is obviously quite high and I would recommend modularizing > such a method), but I'm not in favor of limiting the number of methods per > class (es

RE: Why are these code in utils?

+1 > -Original Message- > From: John Burwell [mailto:jburw...@basho.com] > Sent: Thursday, July 18, 2013 12:25 PM > To: dev@cloudstack.apache.org > Subject: Re: Why are these code in utils? > > Edison, > > I suggest creating a utils model in engine/storage in package > org.apache.cloudst

Re: [DISCUSS] coding convention for method - and class length

I'm not sure how I feel about an arbitrary number of lines per method (although 200 is obviously quite high and I would recommend modularizing such a method), but I'm not in favor of limiting the number of methods per class (especially not to just 10). Some types of objects simply need many discret

Re: code formatting for enums

All, Another thing I have noticed is that enum values are not capitalized. General coding convention is that enum values are declared in all caps using an underscore to separate words. I notice that our coding conventions are silent on enumerations. Any opposition to adding this rule to our

Re: Why are these code in utils?

Edison, I suggest creating a utils model in engine/storage in package org.apache.cloudstack.engine.storage.utils. When I Swift and S3 were originally implemented, we didn't have such a good place to put these types of classes. Now that we have a more robust module structure, it seems appropri

[ACS 4.1.1] Bug fixes applicable to 4.1.1

Dear ACS Dev Community, We need help with identifying which bug fixes in 4.2 or 4.0 need to be back-ported to 4.1 before ACS 4.1.1 release. If you've released a bug fix that is applicable to 4.1, please kindly back-port or let me know and I will do it on your behalf. We need a response by next

RE: deleteAffinityGroup API

Hi Alex, The error thrown while deleting affinitygroup by Id is: " Account and domainId are needed for resource creation " Many of our APIs call AccntManager to figure out owner of the resources the API is working on like this: Account caller = CallContext.current().getCallingAccount(

RE: Why are these code in utils?

For s3/swift, both secondary storage code and storage plugin will access S3/Swift library. What you suggestion to put these library? > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Thursday, July 18, 2013 10:02 AM > To: dev@cloudstack.apache.org > Subject: W

RE: [DISCUSS] Upgrade path to ACS 4.2 from CCP

Citrix QA would test the upgrades on the suggested paths. > The proposed upgrade paths are CCP3.0.4, CCP3.0.5, CCP3.06, CCP3.0.7 to ACS4.2 So far it is always testing from all versions to current release. Hope with the suggestion from Hugo/Chip, this can be reduced to checkpoint releases.

Re: Review Request 12702: Fix CopyCmdAnswer returned by backupSnapshotCommand for VMware

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12702/#review23407 --- Ship it! Ship It! - edison su On July 18, 2013, 4:29 a.m., Satee

Re: Ending IRC Meetings

On Wed, Jul 17, 2013 at 6:04 PM, Donal Lafferty wrote: > >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> Sent: 17 July 2013 6:46 PM >> To: dev@cloudstack.apache.org >> Subject: Re: Ending IRC Meetings >> >> On Wed, Jul 17, 2013 at 1:43 PM, Joe Brockmeier wrote: >> >

Re: Why are these code in utils?

On Thu, Jul 18, 2013 at 05:01:54PM +, Alex Huang wrote: > As part of the work to merge vmsync over to master, I've been combing through > our code. > > I'm surprised to find the following code in the utils package. > > Cisco n1kv.vsm > S3 > Swift > > The intent of the utils package is to pr

Why are these code in utils?

As part of the work to merge vmsync over to master, I've been combing through our code. I'm surprised to find the following code in the utils package. Cisco n1kv.vsm S3 Swift The intent of the utils package is to provide generic java software libraries that all other cloudstack libraries to us

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

We need some mechanism to help on review board. Sometime the people didn't know who to ask for review and sometime committer push the code they didn't familiar with. I decided to spend much more time on reviewing code during 4.2 release period, trying to make sure I would review everything on netw

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On June 28, 2013, 9:42 a.m., John Burwell wrote: > > api/src/com/cloud/offering/DiskOffering.java, line 60 > > > > > > When would it be valid for the value of this property to be null? > > Seems like it should be bo

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On May 31, 2013, 2:32 p.m., Wei Zhou wrote: > > Mike, > > > > I think it is better to create a table for SolidFire instead of changing > > disk_offering table. > > It is not a good idea to change disk_offering for a specific vendor. > > You can have a look at what nicira did in the past, mayb

Regarding the bug Cloudstack-3589 VM created from VPC network is not getting IP

Hi Dann, The bug fix https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b903262df5e2ff5d174859ce28abae75c4689f0c is causing an null value in dnsmasq.config file while creating VPC network (bug-id Cloudstack-3589 ). Can you please take a look at this. Regards, Bharat.

Re: Template Question

It does seem indeterministic. Sometimes there are two; sometimes there is only one. On Thu, Jul 18, 2013 at 4:23 AM, Devdeep Singh wrote: > Changes were made recently to allow some commands to execute in parallel > on a hypervisor resource. Maybe that is causing it. > > Regards, > Devdeep > > >

RE: [rant] stupid test cases

I don't believe this is a bad testcase. It's to force the code path on cleanup procedure before a domain is properly deleted. If this was a unit-test I would say there's no point. For a systems/integration test, the testcase makes sense. --Alex > -Original Message- > From: Prasanna

Re: [ACS42] Release Status Update

Hi John, Oh, not yet...I am still working on one of your VMware issues. It should be done today or tomorrow, I expect. Thanks On Thu, Jul 18, 2013 at 8:47 AM, John Burwell wrote: > Mike, > > Have you posted the diff with the resolved second round issues for the > SolidFire patch to Review Boa

Re: Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/#review23394 --- Ship it! committed to master ad69bc8da3244b783dd003ddf3184fca2762c5

Re: Review Request 12721: Formatting of CSS and JS files

> On July 18, 2013, 4:24 p.m., Pranav Saxena wrote: > > Changes look good. I don't have an access to my machine from where I could > > commit your changes. Hence, request a committer to merge these into all the > > relevant branches. > > Thanks ! Okay will leave it as open until a committer me

Re: Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/#review23391 --- Ship it! Changes look good. I don't have an access to my machine fr

Re: Problem in adding Ceph RBD storage to CloudStack

On Thu, Jul 18, 2013 at 12:09 PM, Takuma Nakajima wrote: > Hi, > > I'm building a CloudStack 4.1 with Ceph RBD storage using RHEL 6.3 recently > but it fails when adding RBD storage to primary storage. > Does anybody know about the problem? Why not 6.4?

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote: > this has been kind of bugging me too. Along with unanswered questions on > teh list by newbees like me. As we all depend on volunteers and > conculeagues I don't really see a solution but reporting on outstanding > reviews and maybe u

Re: Problem in adding Ceph RBD storage to CloudStack

Hi, On 07/18/2013 06:09 PM, Takuma Nakajima wrote: Hi, I'm building a CloudStack 4.1 with Ceph RBD storage using RHEL 6.3 recently but it fails when adding RBD storage to primary storage. Does anybody know about the problem? No, it works for me like a charm :) Could you set the Agent loggin

Re: Review Request 12658: Corrected typos in log messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12658/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12679: CLOUDSTACK-904: Changed multiple vcpus to one vcpu with multiple sockets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12679/ --- (Updated July 18, 2013, 4:06 p.m.) Review request for cloudstack and Wido den H

Problem in adding Ceph RBD storage to CloudStack

Hi, I'm building a CloudStack 4.1 with Ceph RBD storage using RHEL 6.3 recently but it fails when adding RBD storage to primary storage. Does anybody know about the problem? 1. qemu (1.5.50, configured with "--enable-rbd") and libvirt (0.10.2, configured with "--with-storage-rbd") are installed t

Re: Review Request 12659: Removed unused script scripts/storage/qcow2/cleanupmyvms.sh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12659/ --- (Updated July 18, 2013, 4:09 p.m.) Review request for cloudstack and Wido den H

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

this has been kind of bugging me too. Along with unanswered questions on teh list by newbees like me. As we all depend on volunteers and conculeagues I don't really see a solution but reporting on outstanding reviews and maybe unanswered questions. The latter can only be done manually though, as it

Re: Review Request 12646: Truncated trailing/double spaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12646/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12646: Truncated trailing/double spaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12646/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12660/ --- (Updated July 18, 2013, 3:57 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12716: Fix for NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12716/#review23385 --- Ship it! Ship It! - Sheng Yang On July 18, 2013, 2:10 a.m., Venk

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

So personally, I try my best to look at reviews whenever I have a spare moment. That's not all that frequent, but if everyone did that we would be moving new code into the repo much more effectively and efficiently. On Thu, Jul 18, 2013 at 11:42:01AM +0530, Prasanna Santhanam wrote: > Yes and I'

Review Request 12723: test for Script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12723/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/ --- (Updated July 18, 2013, 2:47 p.m.) Review request for cloudstack, Abhinandan Pr

Re: [ACS42] Release Status Update

Mike, Have you posted the diff with the resolved second round issues for the SolidFire patch to Review Board? Thanks, -John On Jun 28, 2013, at 12:49 PM, Mike Tutkowski wrote: > Hi John, > > OK, this sounds good. > > I updated from master yesterday and was resolving some (major) conflicts

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On June 28, 2013, 3:42 p.m., John Burwell wrote: > > api/src/com/cloud/offering/DiskOffering.java, line 60 > > > > > > When would it be valid for the value of this property to be null? > > Seems like it should be bo

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On May 31, 2013, 8:32 p.m., Wei Zhou wrote: > > Mike, > > > > I think it is better to create a table for SolidFire instead of changing > > disk_offering table. > > It is not a good idea to change disk_offering for a specific vendor. > > You can have a look at what nicira did in the past, mayb

Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/ --- Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien

  1   2   >