Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710980
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r3676
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36711314
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP
Congrats Remi and welcome!
On 10-Aug-2015, at 10:38 pm, Daan Hoogland
daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
Hi all,
Starting tomorrow I’ll be working towards the release management of next ACS
4.5 release, ACS 4.5.2 and next CloudMonkey release, CM 5.3.2.
I’ve identified 4 issues (some of them are security related and private, others
have open PRs and are SAML related) targeting 4.5 branch that I’ll
Congrats Remi!
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Monday, 10 August 2015 22:39
To: dev
Subject: Remi Bergsma joins the PMC
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36712694
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ public
Congratulations, dude!
Cheers,
Wilder
Sent from my iPhone
On 10 Aug 2015, at 19:09, Daan Hoogland daan.hoogl...@gmail.com wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Happy Birthday Cloudstack :)
@Daan - IIRC, Manuel moved the source code from sccs to git so all the commits,
since 2008 until this date, reflect his name :)
Regards,
Somesh
-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
Sent: Monday, August 10, 2015 7:48 AM
Congratulations, Remi!
On Mon, Aug 10, 2015 at 11:08 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
--
*Mike Tutkowski*
Congrats Remi! Well deserved.
Ahmad E
On Aug 10, 2015, at 10:08 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
Hi Suresh,
Thanks for picking this up! Some PRs got feedback, it’d be great if that could
be addressed. In a perfect world, changes are submitted with tests. I see many
reviewers ask for them, so adding them definitely helps in getting LGTMs.
Not 100% sure what you mean by “Can we take up the
Congratulations Remi!
Regards,
Somesh
-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com]
Sent: Monday, August 10, 2015 2:13 PM
To: dev
Subject: Re: Remi Bergsma joins the PMC
On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
LS,
Today the
Congrats!!
On Monday, August 10, 2015, Daan Hoogland daan.hoogl...@gmail.com wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
--
Todd Pigram
http://about.me/ToddPigram
Congratulations Remi!
From: Daan Hoogland daan.hoogl...@gmail.com
Sent: Monday, August 10, 2015 12:08 PM
To: dev
Subject: Remi Bergsma joins the PMC
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
Congrats Remi!
On 10/08/2015 18:08, Daan Hoogland wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
I should be able to test it.
Talk to you soon,
Mike
On Sun, Aug 9, 2015 at 10:40 PM, Remi Bergsma rberg...@schubergphilis.com
wrote:
Hi Mike,
Thanks! It seems the testing / verification is still to do and that is the
work. Merging itself can be done with a one-liner.
Are you able to
Github user srikanteswartalluri closed the pull request at:
https://github.com/apache/cloudstack/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129546119
Folks,
i am closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
Congratulations Remi :-)
--
Erik
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/673#issuecomment-129572848
@anshul1886 I want to test this but haven't used the 'details' feature
before. In what format am I supposed to send the key/value pairs? If you have a
I did not see (or understand) a major change proposed or needed in this
thread.
The primary topic of discussion is categorization of a defect as Blocker, that
is, how to qualify a defect as Blocker. The discussion scope widened and
included process to raise an issue as Blocker.
The
Can you make a PR that updates the README with this config option…
Done.
thanks
On Aug 6, 2015, at 3:07 AM, Carlos Reategui create...@gmail.com wrote:
BTW I figured out how to force the cli to send v2. It would still be nice
to update Ec2Stack though:
aws configure set
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/674
getUsedBytes should query the SolidFire cluster to acquire the size oâ¦
â¦f the given volume if there is no volume_details info for that volume
(and then create a volume_details row
Hi,
I just opened the following PR:
https://github.com/apache/cloudstack/pull/674
This only impacts the SolidFire storage plug-in.
Anyone able to spend a few minutes reviewing it for me?
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e:
Fantastic, well deserved Remi!
On Mon, Aug 10, 2015 at 4:10 PM, Boris Schrijver bo...@pcextreme.nl wrote:
Congrats Remi!
Best regards,
Boris Schrijver
TEL: +31633784542
MAIL: bo...@pcextreme.nl
On August 10, 2015 at 8:57 PM Somesh Naidu somesh.na...@citrix.com
wrote:
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/673#issuecomment-129696884
@remibergsma Using cloudmonkey we can pass as shown below
update virtualmachine id=00f19661-da81-40b2-a07c-e46967421195
details[0].keyboard=fr
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710619
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Congratulations Remi!
~Rajani
On Tue, Aug 11, 2015 at 1:49 AM, Ian Rae i...@cloudops.com wrote:
Fantastic, well deserved Remi!
On Mon, Aug 10, 2015 at 4:10 PM, Boris Schrijver bo...@pcextreme.nl
wrote:
Congrats Remi!
Best regards,
Boris Schrijver
TEL: +31633784542
MAIL:
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710924
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710950
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private
Congrats Remi!
Best regards,
Boris Schrijver
TEL: +31633784542
MAIL: bo...@pcextreme.nl
On August 10, 2015 at 8:57 PM Somesh Naidu somesh.na...@citrix.com
wrote:
Congratulations Remi!
Regards,
Somesh
-Original Message-
From: Erik Weber
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705867
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36704745
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705033
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP (code
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705320
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
I went ahead and tested, then checked in PR 547:
https://github.com/apache/cloudstack/pull/547/files
I also resolved and closed the JIRA ticket for it:
https://issues.apache.org/jira/browse/CLOUDSTACK-8601
On Mon, Aug 10, 2015 at 11:43 AM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705202
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private
Hi,
Please find the latest report on new defect(s) introduced to cloudstack found
with Coverity Scan.
17 new defect(s) introduced to cloudstack found with Coverity Scan.
55 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36608900
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609212
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
I’d just be a bit careful here.
There might be some tale branches that still have useful info.
like the ‘docker’ branch. it might just be 100 LOC that are interesting but
yet, that’s where they are.
On Aug 3, 2015, at 6:06 PM, Remi Bergsma rberg...@schubergphilis.com wrote:
+1
On 02 Aug
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611140
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611175
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611512
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611661
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129368171
-1
Without changes it works fine, because if we don't specify the enabled
attribute for the zone in the config file, it will enable the zone by default.
Even
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129368352
@koushik-das Thanks, glad the merge commit is gone now. Do you want to keep
two commits? I'd say squash them together. From the subject line I cannot tell
the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129371706
@remibergsma Yes the commits can be squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612331
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129374324
@koushik-das Check, please squash and then force push again. After that
I'll merge it.
---
If your project is set up for it, you can reply to this email and
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/671
CLOUDSTACK-8720: Handle corner case in remove nic from vm
Please see the bug for more details
You can merge this pull request into a Git repository by running:
$ git pull
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609071
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO
On Aug 6, 2015, at 7:35 AM, Raja Pullela raja.pull...@citrix.com wrote:
Looks like there are few of us who differ with the current
process/restriction.
Just to close this thread - there are already guidelines that exist currently
and we should continue to adopt or follow those.Let
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611014
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611046
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611296
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/668#issuecomment-129368593
@pritisarap12 Please remove the merge commit and force push again. See PR
#656 on how to do this. Thanks!
---
If your project is set up for it, you can reply
I will, Sebastien. I know that some of this is gems. A lot of it has been
merged or really abandoned and superseded by other code. I know you and
Pierre-Luc are working on docker so I would definitely inquire with you
guys about this branch.
On Mon, Aug 10, 2015 at 10:29 AM, Sebastien Goasguen
GitHub user kevindierkx opened a pull request:
https://github.com/apache/cloudstack/pull/670
Made interface changes related to CLOUDSTACK-8580
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevindierkx/cloudstack
Congrats! Great :-)
On 10-08-15 11:17, Daan Hoogland wrote:
Ladies and gentleman,
At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of
On Aug 10, 2015, at 11:17 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
Ladies and gentleman,
At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the
Github user kevindierkx commented on the pull request:
https://github.com/apache/cloudstack/pull/670#issuecomment-129381995
Looks like the changes to listCapabilities aren't merged yet. (@borisroman)
Ignore this pull-request =D
---
If your project is set up for it, you can reply to
Github user kevindierkx closed the pull request at:
https://github.com/apache/cloudstack/pull/670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609019
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609278
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36609308
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private
On Aug 4, 2015, at 6:48 PM, Ramanath Katru ramanath.ka...@citrix.com wrote:
Daan,
I beg to differ. This is very much a product issue. We cannot knowingly
release with an existing/working functionality broken. Especially if it is
one of the features that users expect to be there. Remote
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129365283
Travis failure is due to timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
since we don’t have docs for ec2stack yet.
Can you make a PR that updates the README with this config option…
thanks
On Aug 6, 2015, at 3:07 AM, Carlos Reategui create...@gmail.com wrote:
BTW I figured out how to force the cli to send v2. It would still be nice
to update Ec2Stack though:
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611238
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612463
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612869
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Ladies and gentleman,
At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of our
repository.
:beer::cake::clappinghands:
--
Daan
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r36613344
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description =
Wow! happy birthday cloudstack :)
On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander w...@widodh.nl wrote:
Congrats! Great :-)
On 10-08-15 11:17, Daan Hoogland wrote:
Ladies and gentleman,
At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/672
Allow VM snapshots and volume snapshots to exist together
This branch fixes issues involved in allowing VM snapshots and volume
snapshots to exist together.
You can merge this pull request
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129378007
Test to verify remove nic from vm if the nic ip is same as another vm ip in
another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS
===
Github user pritisarap12 closed the pull request at:
https://github.com/apache/cloudstack/pull/645
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/645#issuecomment-129316634
C
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129334661
@koushik-das Check. If you fix the commits, I'll LGTM and merge. Let me
know if you need help.
---
If your project is set up for it, you can reply to this
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/668
CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath
-Adding cls.hypervisor = cls.testClient.getHypervisorInfo()
-Fixed pep8 issues
You can merge this pull request
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/662#issuecomment-129323691
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129335984
@remibergsma I have fixed the commits, please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-129337423
@mike-tutkowski Thanks! It seems the testing / verification is still to do
and that is the work. Merging itself can be done with a one-liner. Are you able
to
LGTM!!
On Mon, Aug 10, 2015 at 11:34 AM, pritisarap12 g...@git.apache.org wrote:
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/668
CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath
-Adding cls.hypervisor =
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129336998
@manuiiit Thanks! Final request: please squash the 3 commits you have now
into one. After that, force push to this branch. Once done, I'll LGTM and merge.
---
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/669
Made the adding new keyboard language support easier
This branch has implemented following improvements in console proxy
keyboard language support
1) ajaxviewer.js and ajaxkeys.js
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hi devs,
Just wondering if anyone is looking at implementing Cisco ACI support in
CloudStack?
--
Erik
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/673#issuecomment-129407249
cloudstack-pull-requests #945 failure is because of some random error in
git fetching
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129407180
@DaanHoogland You already gave your LGTM? See here:
https://github.com/apache/cloudstack/pull/656#issuecomment-127529005
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-129408998
@devdeep How about testing if the right (number of) threads are being
started? Does my comment make any sense?
---
If your project is set up for it, you can
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r36620562
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description =
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129396359
@koushik-das Thank you!
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
Looks Good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129405117
@remibergsma ahum,... LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
1 - 100 of 113 matches
Mail list logo
