Thanks for the summary Somesh and thanks for Mike for the clarification.
(3) sounds good - it's always good to let everyone know that you've/reporter
created a blocker bug! Hope we will have enough people to chime in to voice
their yea's or nay's?
-Original Message-
From: Mike Tutkow
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129720549
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Congratulations, dude!
Cheers,
Wilder
Sent from my iPhone
> On 10 Aug 2015, at 19:09, Daan Hoogland wrote:
>
> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
> regards,
> --
> Daan
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36712694
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ public St
Congrats Remi!
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Monday, 10 August 2015 22:39
To: dev
Subject: Remi Bergsma joins the PMC
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in cong
Hi all,
Starting tomorrow I’ll be working towards the release management of next ACS
4.5 release, ACS 4.5.2 and next CloudMonkey release, CM 5.3.2.
I’ve identified 4 issues (some of them are security related and private, others
have open PRs and are SAML related) targeting 4.5 branch that I’ll
Congrats Remi and welcome!
On 10-Aug-2015, at 10:38 pm, Daan Hoogland
mailto:daan.hoogl...@gmail.com>> wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
Regards,
Rohit Yadav
Softwa
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36711314
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP && (c
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r3676
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710980
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710950
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710924
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Congratulations Remi!
~Rajani
On Tue, Aug 11, 2015 at 1:49 AM, Ian Rae wrote:
> Fantastic, well deserved Remi!
>
> On Mon, Aug 10, 2015 at 4:10 PM, Boris Schrijver
> wrote:
>
> > Congrats Remi!
> >
> > Best regards,
> >
> > Boris Schrijver
> >
> > TEL: +31633784542
> > MAIL: bo...@pcextreme.nl
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36710619
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/673#issuecomment-129696884
@remibergsma Using cloudmonkey we can pass as shown below
update virtualmachine id=00f19661-da81-40b2-a07c-e46967421195
details[0].keyboard=fr
H
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705867
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705320
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705202
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNicA
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36705033
--- Diff: systemvm/js/ajaxviewer.js ---
@@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
if(eventType == AjaxViewer.KEY_UP && (cod
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36704745
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cmds
I went ahead and tested, then checked in PR 547:
https://github.com/apache/cloudstack/pull/547/files
I also resolved and closed the JIRA ticket for it:
https://issues.apache.org/jira/browse/CLOUDSTACK-8601
On Mon, Aug 10, 2015 at 11:43 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
"3. In case the reporter feels the defect qualifies as a Blocker, they
should raise it as Blocker and create a discussion/voting thread on the ML
for the same."
This is what I always do these days and I think it makes a lot of sense: Go
ahead and mark the bug as a Blocker, but then send out an obv
Hi,
I just opened the following PR:
https://github.com/apache/cloudstack/pull/674
This only impacts the SolidFire storage plug-in.
Anyone able to spend a few minutes reviewing it for me?
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/674
getUsedBytes should query the SolidFire cluster to acquire the size oâ¦
â¦f the given volume if there is no volume_details info for that volume
(and then create a volume_details row for
>
> Can you make a PR that updates the README with this config option…
Done.
>
> thanks
>
>> On Aug 6, 2015, at 3:07 AM, Carlos Reategui wrote:
>>
>> BTW I figured out how to force the cli to send v2. It would still be nice
>> to update Ec2Stack though:
>>
>> aws configure set profile..
Fantastic, well deserved Remi!
On Mon, Aug 10, 2015 at 4:10 PM, Boris Schrijver wrote:
> Congrats Remi!
>
> Best regards,
>
> Boris Schrijver
>
> TEL: +31633784542
> MAIL: bo...@pcextreme.nl
>
> >
> > On August 10, 2015 at 8:57 PM Somesh Naidu
> > wrote:
> >
> >
> > Congratulations Remi
Congrats Remi!
Best regards,
Boris Schrijver
TEL: +31633784542
MAIL: bo...@pcextreme.nl
>
> On August 10, 2015 at 8:57 PM Somesh Naidu
> wrote:
>
>
> Congratulations Remi!
>
> Regards,
> Somesh
>
>
> -Original Message-
> From: Erik Weber [mailto:terbol...@
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/673#issuecomment-129572848
@anshul1886 I want to test this but haven't used the 'details' feature
before. In what format am I supposed to send the key/value pairs? If you have a
CloudMonke
Congratulations Remi!
Regards,
Somesh
-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com]
Sent: Monday, August 10, 2015 2:13 PM
To: dev
Subject: Re: Remi Bergsma joins the PMC
On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland
wrote:
> LS,
>
> Today the PMC has invited Remi
Hi Suresh,
Thanks for picking this up! Some PRs got feedback, it’d be great if that could
be addressed. In a perfect world, changes are submitted with tests. I see many
reviewers ask for them, so adding them definitely helps in getting LGTMs.
Not 100% sure what you mean by “Can we take up the
On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland
wrote:
> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
>
Congratulations Remi :-)
--
Erik
Github user srikanteswartalluri closed the pull request at:
https://github.com/apache/cloudstack/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129546119
Folks,
i am closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
I should be able to test it.
Talk to you soon,
Mike
On Sun, Aug 9, 2015 at 10:40 PM, Remi Bergsma
wrote:
> Hi Mike,
>
> Thanks! It seems the testing / verification is still to do and that is the
> work. Merging itself can be done with a one-liner.
>
> Are you able to verify the fix in your lab?
Congratulations, Remi!
On Mon, Aug 10, 2015 at 11:08 AM, Daan Hoogland
wrote:
> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
> regards,
> --
> Daan
>
--
*Mike Tutkowski*
*Senior CloudStack D
Congrats Remi! Well deserved.
Ahmad E
> On Aug 10, 2015, at 10:08 AM, Daan Hoogland wrote:
>
> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
> regards,
> --
> Daan
Congrats Remi!
On 10/08/2015 18:08, Daan Hoogland wrote:
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
Congratulations Remi!
From: Daan Hoogland
Sent: Monday, August 10, 2015 12:08 PM
To: dev
Subject: Remi Bergsma joins the PMC
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulati
Congrats!!
On Monday, August 10, 2015, Daan Hoogland wrote:
> LS,
>
> Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
> that he accepted. Please join me in congratulating Remi.
>
> regards,
> --
> Daan
>
--
Todd Pigram
http://about.me/ToddPigram
www.linkedin.co
LS,
Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say
that he accepted. Please join me in congratulating Remi.
regards,
--
Daan
> I did not see (or understand) a major change proposed or needed in this
> thread.
The primary topic of discussion is categorization of a defect as Blocker, that
is, how to qualify a defect as Blocker. The discussion scope widened and
included process to raise an issue as "Blocker".
The issue
Happy Birthday Cloudstack :)
@Daan - IIRC, Manuel moved the source code from sccs to git so all the commits,
since 2008 until this date, reflect his name :)
Regards,
Somesh
-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
Sent: Monday, August 10, 2015 7:48 AM
Hi,
Please find the latest report on new defect(s) introduced to cloudstack found
with Coverity Scan.
17 new defect(s) introduced to cloudstack found with Coverity Scan.
55 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defec
Hi, Dave, Somesh,
Thanks for your feedback. Thanks for the help that you promised on this
task.
Hi, Dave,
Thanks for providing the Style Guide for the API Guides and some good
pointers on improving the API content. This is helpful.
Hi, Somesh,
Thanks for your willingness to help with the conte
Norbert, I haven't begun to think about it. including dev@ to gather ideas.
The db structure is based on updates since 4.0. A new install will be a 4.0
DB which will then undergo a series of upgrade steps. A validation of the
db could be divided in a basic part and an incremental part, maybe.
A go
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/646#issuecomment-129424914
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-129423682
WRT master/4.6 4.5.2 was assumed frozen. There are other changes in
452to462 sql as well which may/maynot be bug fixes.
A separate PR needs to be done for 451to
Awesome! Happy birthday :-)
On 10 Aug 2015, at 13:39, Rohit Yadav
mailto:rohit.ya...@shapeblue.com>> wrote:
Fantastic :)
On 10-Aug-2015, at 3:07 pm, Punith S
mailto:punit...@cloudbyte.com>> wrote:
Wow! happy birthday cloudstack :)
On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander
mailto:w
Fantastic :)
On 10-Aug-2015, at 3:07 pm, Punith S
mailto:punit...@cloudbyte.com>> wrote:
Wow! happy birthday cloudstack :)
On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander
mailto:w...@widodh.nl>> wrote:
Congrats! Great :-)
On 10-08-15 11:17, Daan Hoogland wrote:
Ladies and gentleman,
At
Hello,
We have problems with compiling 4.5 branch.
We think that this problem occurs for last week.
Cound someone confirm this ?
Step to reproduce:
1. Download source
https://github.com/apache/cloudstack/archive/4.5.zip
2. mvn install
3. errror
Running rdpclient.MockServerTest
Error in mock s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-129412845
You can mock the call and verify how often it has been called with mockito.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36621580
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ publi
Github user devdeep commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-129411154
@DaanHoogland That is what I am looking into; how to get the number of
threads that have been started by the executor service.
---
If your project is set up for it,
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36621140
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ public St
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/646#discussion_r36621050
--- Diff: test/integration/component/maint/test_escalation_templates.py ---
@@ -0,0 +1,394 @@
+# Licensed to the Apache Software Foundation (ASF) unde
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/646#discussion_r36620849
--- Diff: test/integration/component/maint/test_escalation_templates.py ---
@@ -0,0 +1,394 @@
+# Licensed to the Apache Software Foundation (ASF) unde
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r36620562
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description = "
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-129408998
@devdeep How about testing if the right (number of) threads are being
started? Does my comment make any sense?
---
If your project is set up for it, you can re
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129407180
@DaanHoogland You already gave your LGTM? See here:
https://github.com/apache/cloudstack/pull/656#issuecomment-127529005
---
If your project is set up for it,
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/673#issuecomment-129407249
cloudstack-pull-requests #945 failure is because of some random error in
git fetching
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129405117
@remibergsma ahum,... LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/673
CLOUDSTACK-8721: Fixed Setting details of VM through API results in removal
of all other details except the one passed in API
You can merge this pull request into a Git repository by runnin
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
Looks Good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Hi devs,
Just wondering if anyone is looking at implementing Cisco ACI support in
CloudStack?
--
Erik
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129398162
Looks Good to me.
Probably remove_nic might return an error if the NIC is not removed , but
just wondering if a check is needed in the below step , to val
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129396359
@koushik-das Thank you!
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
> On Aug 10, 2015, at 11:17 AM, Daan Hoogland wrote:
>
> Ladies and gentleman,
>
> At the 11th of August 2010, Manuel Amador made the first commit in our
> repository. I never met the guy but want to take the occasion to
> congratulate him and all other contributors with the 5th aniversary of o
Github user kevindierkx closed the pull request at:
https://github.com/apache/cloudstack/pull/670
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user kevindierkx commented on the pull request:
https://github.com/apache/cloudstack/pull/670#issuecomment-129381995
Looks like the changes to listCapabilities aren't merged yet. (@borisroman)
Ignore this pull-request =D
---
If your project is set up for it, you can reply to t
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129378007
Test to verify remove nic from vm if the nic ip is same as another vm ip in
another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS
===
Wow! happy birthday cloudstack :)
On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander wrote:
> Congrats! Great :-)
>
> On 10-08-15 11:17, Daan Hoogland wrote:
> > Ladies and gentleman,
> >
> > At the 11th of August 2010, Manuel Amador made the first commit in our
> > repository. I never met the
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/672
Allow VM snapshots and volume snapshots to exist together
This branch fixes issues involved in allowing VM snapshots and volume
snapshots to exist together.
You can merge this pull request i
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/671
CLOUDSTACK-8720: Handle corner case in remove nic from vm
Please see the bug for more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.c
Congrats! Great :-)
On 10-08-15 11:17, Daan Hoogland wrote:
> Ladies and gentleman,
>
> At the 11th of August 2010, Manuel Amador made the first commit in our
> repository. I never met the guy but want to take the occasion to
> congratulate him and all other contributors with the 5th aniversary o
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r36613344
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description =
GitHub user kevindierkx opened a pull request:
https://github.com/apache/cloudstack/pull/670
Made interface changes related to CLOUDSTACK-8580
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevindierkx/cloudstack CLOUDSTACK-8580
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129374324
@koushik-das Check, please squash and then force push again. After that
I'll merge it.
---
If your project is set up for it, you can reply to this email and hav
Ladies and gentleman,
At the 11th of August 2010, Manuel Amador made the first commit in our
repository. I never met the guy but want to take the occasion to
congratulate him and all other contributors with the 5th aniversary of our
repository.
:beer::cake::clappinghands:
--
Daan
I will, Sebastien. I know that some of this is gems. A lot of it has been
merged or really abandoned and superseded by other code. I know you and
Pierre-Luc are working on docker so I would definitely inquire with you
guys about this branch.
On Mon, Aug 10, 2015 at 10:29 AM, Sebastien Goasguen
wr
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612869
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612463
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36612331
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129371706
@remibergsma Yes the commits can be squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611905
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cm
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/668#issuecomment-129368593
@pritisarap12 Please remove the merge commit and force push again. See PR
#656 on how to do this. Thanks!
---
If your project is set up for it, you can reply to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129368352
@koushik-das Thanks, glad the merge commit is gone now. Do you want to keep
two commits? I'd say squash them together. From the subject line I cannot tell
the di
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129368171
-1
Without changes it works fine, because if we don't specify the "enabled"
attribute for the zone in the config file, it will enable the zone by default.
Even
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611661
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611512
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNicA
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611296
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
since we don’t have docs for ec2stack yet.
Can you make a PR that updates the README with this config option…
thanks
> On Aug 6, 2015, at 3:07 AM, Carlos Reategui wrote:
>
> BTW I figured out how to force the cli to send v2. It would still be nice
> to update Ec2Stack though:
>
> aws configu
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611238
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cmds
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611175
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands
cmds
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611140
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -595,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611046
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO get
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36611014
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1279,6 +1285,27 @@ private static DiskTO get
> On Aug 4, 2015, at 6:48 PM, Ramanath Katru wrote:
>
> Daan,
>
> I beg to differ. This is very much a product issue. We cannot knowingly
> release with an existing/working functionality broken. Especially if it is
> one of the features that users expect to be there. Remote Access VPN is an
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129365283
Travis failure is due to timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
1 - 100 of 115 matches
Mail list logo
