[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-134504120 result information : @desc:Incorrect guest os mapping in vmware for CentOS 5.9 and above ... === TestName: test2_attach_ISO_in_CentOSVM | Status : SUCCESS =

[GitHub] cloudstack pull request: CLOUDSTACK-8685: Fix for missing defaultr...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/738#issuecomment-134503158 I do not understand most of this stuff. not a good candidate to review :) --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134502839 Result information: test_01_FTPModulesInVR (integration.component.maint.test_escalations_routers.TestVR) ... === TestName: test_01_FTPModulesInVR | Status : SU

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134502526 This is what I have done to test installed a fresh setup with centos63 rpms on MS with 6.3 and KVM host with 6.3. verified that systemvms, VR and user

Re: [ANNOUNCE] Apache CloudStack 4.5.2 release

Hi Wido, On 25-Aug-2015, at 11:42 am, Wido den Hollander mailto:w...@widodh.nl>> wrote: Awesome! The RPM en DEB packages should come online on cloudstack.apt-get.eu automatically since Jenkins now syncs them there. Cool. FYI - I’ve updated the 4.5.2 systemvms he

Build failed in Jenkins: simulator-4.5-singlerun #265

See -- Started by upstream project "build-4.5-simulator" build number 320 originally caused by: Started by upstream project "build-4.5" build number 517 originally caused by: Started by an

Re: [ANNOUNCE] Apache CloudStack 4.5.2 release

Awesome! The RPM en DEB packages should come online on cloudstack.apt-get.eu automatically since Jenkins now syncs them there. Let's see if that really works. Wido On 08/25/2015 07:11 AM, Rohit Yadav wrote: > 25 August 2015 - The Apache CloudStack project is pleased to announce > the 4.5.2 rele

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134491315 @koushik-das thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134491115 @bhaisaab Cherry-picked to 4.5 with commit 3d9cbf0bcb011f4012c94f0df040d9b8ddd325bc --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/740 CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template… … listing Uses listViewDataProvider to implement pagination on listTemplates API requests in the UI, when

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/739 CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template… … listing Uses listViewDataProvider to implement pagination on listTemplates API requests in the UI, when

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/684#issuecomment-134489114 Testcase result: Check if Virtual Router has same IP after network restart or not. ... === TestName: test_10_vr_has_same_ip | Status : SUCCESS === o

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/684#issuecomment-134488914 Merged the testcase in test_routers.py file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134480002 I think we should not be using TransactionLegacy anymore. It was used in first place just to be consistent with UsageServer and due to time constraints. I

[ANNOUNCE] Apache CloudStack 4.5.2 release

25 August 2015 - The Apache CloudStack project is pleased to announce the 4.5.2 release of the CloudStack, the cloud orchestration platform. The 4.5.2 release contains more than 80 bug-fixes and improvements since the last minor CloudStack 4.5.1 release announced on 11 May 2015. # Documentation W

[ANNOUNCE] Apache CloudStack CloudMonkey 5.3.2

25 August 2015 —Apache CloudStack, the mature, turnkey Open Source cloud computing software platform used for creating private, public, and hybrid cloud environments, today announced Apache CloudMonkey v5.3.2, the latest release of its command line interface tool. CloudMonkey is written in Python,

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134472326 @koushik-das yes that will work, you may also send a PR with the cherry-picked commit so we can be sure it does not break smoke tests/travis --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134467595 @bhaisaab Should I simply cherry-pick to 4.5 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

Re: review wanted

Hi Daan, I think that we should do a proper introduction. It might seem kind of odd to some people that a bunch of folks suddenly started working for free. Our first PR was done a while ago: https://github.com/apache/cloudstack/pull/560. Then we did https://github.com/apache/cloudstack/pull/700, a

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/714#issuecomment-134380116 I think that the best way to merge this PR is for us to create it over a head version. We have a script that changes almost everything automatically. There

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134364934 @jburwell can you review this please? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/735#issuecomment-134364893 @jburwell can you review this please? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134364759 @shwetaag Could you change the title to: "CLOUDSTACK-8757: Test to verify if FTP modules are loaded in VR" as right now it looks like there is a defect, which th

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134363088 @bhaisaab No worries, took me some time as well to understand how it is supposed to work and I'm also still learning. In the Jira issue you mention two i

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134350634 Verified that it now works on my weird URL as well. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Fix for missing defaultroute on VPC route...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/738#issuecomment-134343822 LGTM Deployed advanced zone with two VPCs, each with a tier, two VMs. Verified the default routes were there (and that the VMs could reach the internet)

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134331260 @ustcweizhou Thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/735#issuecomment-134329574 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: Fix for missing defaultroute on VPC route...

GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/738 Fix for missing defaultroute on VPC router https://issues.apache.org/jira/browse/CLOUDSTACK-8685 Refactored CsRoute and CsAddress to: - add methods to add and verify the de

[GitHub] cloudstack pull request: Quota master

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134245543 @abhi An connection pool makes acquiring a scarce resource less expensive, but it is not cost-free. By taking a connection when the pool is under load, the followi

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/737 CLOUDSTACK-8758: Handle redirects in communication with NXS controller (a.k.a. Nicira NVP) When an NSX controller node is part of a cluster it will redirect API calls to the master cont

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134219947 @koushik-das Thanks for letting me know, there might be an issue because part of the merge message is missing. Will fix it. --- If your project is set up for it

Re: [cloudstack] Changed variable s_logger to non-static and fixed its name in “com.cloud.utils.component.ComponentLifecycleBase” and its subclasses (#714)

No trouble Rajani ;) We worked just because we already had all of the classes mapped that would need some work. On Mon, Aug 24, 2015 at 1:19 AM, Rajani Karuturi wrote: > Hi Rafael, > I assigned the issue while doing some jira cleanup. I saw some PRs in the > comments. I thought you werent able

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134215959 @terbolous Squashed the latest fix into an earlier commit, as that makes more sense. If you want to see the diff that should fix your issue, look here: https://g

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134211424 Squashed some commits that belong to each other. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134198135 @terbolous Hmm, the default always includes .git in the end (both for https and ssh). Although, as you said, omitting the .git part works (in both cases). Just s

Re: SDN solutions in use today with CloudStack

>The others I have never tried. Really wondering if anyone is using GRE in >CloudStack? Just FYI. There was a post today on the user lists where someone was attempting to setup GRE, so it appears it is probably out there. - Si > On 20 Aug 2015, at 20:41, Simon Weller wrote: > > Hi all, > > W

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134179676 LGTM to me. We should however stay as far away as possible from invoking all kinds of scripts. Implementing this for RBD is also a lot easier since you

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134176791 @koushik-das if this applies for 4.5.x, it would be great to have it in 4.5 branch as well --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134174620 @terbolous Ah, I see your point now ;-) Thanks, I will make it work. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134173550 @bhaisaab I haven't merged it to 4.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8765: fix vm migration failure...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/736 CLOUDSTACK-8765: fix vm migration failure due to different dev name on KVM You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/c

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134169583 just to clarify I've not tested this against a real env, just reviewed the code; there are few cgroup related things I don't completely grok but I'll invest time on

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134168798 @koushik-das this issue seems to affect 4.5.0, have you already or can you port/merge this on 4.5 branch? --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134167474 @remibergsma it does point to the apache repo, but with a somewhat different url I used 'git clone gh:apache/cloudstack' to initialize the repo, and that

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134165993 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134165204 @terbolous You need to point to the Apache mirror on GitHub, not your fork. The PRs are at the mirror repository. Also, the version from this PR gives more descr

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134164828 LGTM on this one, will do the other once the tests are done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134164753 @bhaisaab Thanks, now the tests can run on master as well :-) --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134164677 @remibergsma I used the script to do the merge. This is how I used it tools/git/git-pr 698 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134163621 On the other side, if you just drop the '.git' suffix, you risk matching things like 'cloudstack-docs-rn' while you really mean 'cloudstack' --- If your project i

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134163369 Might not be related as this is the first time I try the script, but I'm getting this: eriweb@eriweb:~/git/cloudstack/tools/git master$ git pr 735 --force W

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134161439 @remibergsma here: https://github.com/apache/cloudstack/pull/735 --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/735 CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input Based on @jburwell's comment on PR #718 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Git PR merge script improvements

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134160535 tested with a cloudstack-docs-admin PR and a cloudstack PR. worked great. Thanks for the update. :+1: --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134160495 @remibergsma sending another PR just for master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134160459 @remibergsma merges cleanly on master, if you LGTM; I can merge this on master and 4.5 --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134158150 @bhaisaab Can you send this PR against master please? For now, I'd rather merge to master, then cherry-pick back to 4.5 as I want to prevent all the cherry-picks

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-134155661 @koushik-das Thanks for merging, sorry I forgot to do it for you ;-) Could you have a look at this script, to help you merge it? https://cwiki.apache.org/conflue

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134154979 @borisroman @bhaisaab Thanks for testing! I'll have another look at the commits and see if it makes sense to quash some of them together (I'll make them

[GitHub] cloudstack pull request: Git PR merge script improvements

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/734 Git PR merge script improvements Processed feedback from @bhaisaab and (a colleague of) @karuturi - make the help message better (I also updated Confluence) - make sure we can u

IPv6 in ACS and Basic Zones

Hi all, The first steps toward IPv6 support [0] had been taken by Sheng Yang in late 2012 / early 2013. [1][2] Since then it has been awfully quite around IPv6. Remi Bergsma from Schuberg Philis created a design document for IPv6 in VPCs but had not implemented it yet. [3] I'm going to give a try

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134107765 @remibergsma looks good, but let me test it and get back to you on this; also for a small patch a single commit is preferred as multiple commits dilute the main mot

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/733 CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input Based on @jburwell's comment on PR #718 You can merge this pull request into a Git repository by running: $ git pull http

[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/722#issuecomment-134107177 @miguelaferreira yeah, I could not make the git-pr script work on my system; so used the old one. have figured the issue, will use the git-pr script next time. --

[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/722#issuecomment-134105943 @bhaisaab You are very welcome. Just one thing, when I look at master I see this PR was not merged. I mean, there is no merge commit, and t

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/732 CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2 Guys, can you review it? things need to be discussed: (1) this supports KVM/QCOW2 only. Anyone want to implement for other Hyperviso

Re: [VOTE] Apache Cloudstack 4.5.2 (Round 2)

Hi all, +1 Env: XenServer 6.2, 6.5, Advanced zone, upgrade 4.2.1 -> 4.5.2 2015-08-20 20:23 GMT+02:00 Remi Bergsma : > Hi all, > > +1 (binding) > > Tested: > > 1. Advanced zone with XenServer > - Deployed VPCs, VMs and VPNs between them > - Crashed a XenServer, watched it recover >

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-134098323 Merged on master through: https://github.com/apache/cloudstack/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

How does the parameter startdate/enddate of api listEvents() use new time format like 'yyyy-MM-dd HH:mm:ss' ?

Hello Every. I know this is a very simple question to most of you. but it is really hard for me to continue my work. So could Anyone spend your three minutes to give me some advice, it will be very usefull to me. my question is: How does the parameter startdate/enddate of api listEvent

[GitHub] cloudstack pull request: Fixing syntax error introduced in PR #717

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/722#issuecomment-134097022 LGTM, merging. Thanks @miguelaferreira for fixing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-8754: VM migration triggered b...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/725#issuecomment-134089286 @kishankavala a trivial test is better then none. for better tests, a jira ticket can be created and comments in the test class can be added. that said

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-134088772 I would like to see two unit tests for checkForKeyByPublicKey. The succes and the failure cases. I am not sure if this check shows a very good pattern but that

CloudStack Docker images on Docker hub.

Hi Everyone, Last week David and I worked on the Docker hub to get automated builds for ec2stack and cloudmonkey. You can now get those on Docker hub: $ docker pull cloudstack/cloudmonkey $ docker pull cloudstack/ec2stack These are automated build of master, I will work to get other tags that

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134071270 LGTM -> Deployed on Centos7 started 2 systemvms, 1 router and 1 guest vm without libvirt errors. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: Replace some profiler.getDuration with pr...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134069656 @karuturi @wilderrodrigues I just created a ticket for it. https://issues.apache.org/jira/browse/CLOUDSTACK-8761 --- If your project is set up for it, you can