Re: [VOTE] Apache CloudStack 4.6.0

Kicked off some Jenkins builds: CentOS 6 packages: http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64/ CentOS 7 packages:

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user mlsorensen commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153863283 John, I probably shouldn't respond in this thread, but from your response I feel like much of my point was missed. In fact I had pointed out the very

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/17#discussion_r43938320 --- Diff: source/users.markdown --- @@ -229,5 +245,4 @@ If you noticed something wrong with your entry here (or if you’d like us to r *

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/17 Update the list of known CloudStack users Based on formwize as of 2015/11/04 You can merge this pull request into a Git repository by running: $ git pull

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

I agree, John, that visual code inspection is not sufficient to "prove" the code behaves as expected (too many variables to take into consideration that just examining the code can easily miss problems). I believe the idea, though, was just to protect the state of the DB since the plug-ins don't

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/32#issuecomment-153963381 @ronatartifact next time, in addition to jira id, please add more information to the subject line. something like "CLOUDSTACK-9034: Fixed bad bullet

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/32#issuecomment-153963135 Thanks for the PR. looks good. verified in github preview. merging now. --- If your project is set up for it, you can reply to this email and have your

Seeking comments about JIRA issues on Admin Guide

I have created issues 9031-9033 that identify some apparent deficiencies in the structure of the documentation files - not the content. I would be grateful if anyone who knows anything about the docs could add some comments that provide some background. Thanks Ron -- Ron Wheeler President

User vm password gets update only the master VR.

Hi, In my local setup i found this issue, The user VM password is not getting saved in the backup router. we send the save password command to both the VRs in a rvr enabled network, But the password gets saved only in the master VR. This happens because the password server is not running in

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

GitHub user ronatartifact opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/32 JIRA CLOUDSTACK-9034 Fixed bad bullet ending You can merge this pull request into a Git repository by running: $ git pull

Re: User vm password gets update only the master VR.

On Thu, Nov 5, 2015 at 7:15 AM, Bharat Kumar wrote: > Hi, > > In my local setup i found this issue, The user VM password is not getting > saved in the backup router. > > we send the save password command to both the VRs in a rvr enabled > network, But the password gets

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43892103 --- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java --- @@ -38,6 +40,7 @@

[VOTE] Apache CloudStack 4.6.0

Hi all, I've created a 4.6.0 release candidate, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522 Commit: b0ebe68e375432b28eef031ab62ccd5831234c77 Source release (checksums and

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153755733 @koushik-das On second thought LogLevel can not be used I think: It is used for json serialization and one might have to serialize a password to be send to an

[GitHub] cloudstack pull request:

Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/commit/59a9db39b1d17056753385c0e091bfe26d2df522#commitcomment-14184110 Issue CLOUDSTACK-9024 refers to this commit. https://issues.apache.org/jira/browse/CLOUDSTACK-9024 --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153749695 ``` 2015-11-04 14:23:51,076 DEBUG [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-34:ctx-0d2ee513 job-104/job-105 ctx-0d5c6252) Done executing VM work

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43891649 --- Diff: api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java --- @@ -40,6 +42,7 @@ @SerializedName("fingerprint")

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Its merged. ~Rajani Sent from my Windows Phone From: Raja Pullela Sent: ‎04-‎11-‎15 15:55 To: dev@cloudstack.apache.org Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config Remi,

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153709054  --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153693746 Ping @remibergsma @karuturi @borisroman @DaanHoogland @miguelaferreira Test is finally done and bug-free! Test Environment: *

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153701619 Jenkins error is not related. It says "no failures" but still shows a red button on Cloud Server. By the way, I pushed a python file.

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153707458 A ticket is out for this at infra: INFRA-10703 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153699912 @wilderrodrigues @remibergsma Still had the tests setup running. Here are the results: ``` === TestName:

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153708419 Just did LGTM (logging in as a sturmbahn) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153708491 @DaanHoogland A picture or it didn't happen! ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1032 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153717404 Ping @borisroman @remibergsma @DaanHoogland @miguelaferreira @karuturi Test results: ``` Test redundant router internals ... ===

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153690595 @DaanHoogland if you look at the changes or the code that takes in Object (Response object) and serializes it; we create the json or xml response string by

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153694220 @wilderrodrigues Running now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Thank you Rajani! -Original Message- From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] Sent: Wednesday, November 4, 2015 5:18 PM To: dev@cloudstack.apache.org Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config Its merged. ~Rajani Sent from my Windows Phone

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153702504 ok, travis green does not mean it actually does anything, does it? In this case I think it did compile but none of the tests were run. Maybe that's enough for

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153708234 Shouldn't we at least try a compile and see if the UI shows up? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153726658 LGTM, the test from this branch now succeed: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153695015 @bhaisaab Agree that the existing JSON and XML serialization can be improved but it is better to do it as a separate PR. For JSON, the standard Gson library is

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/902 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153704575 @koushik-das makes sense so we have a policy that for any sensitive field LogLevel(LogLevel.OFF) be used. We should add that as a comment to the enum to

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153701940 JVM died: https://builds.apache.org/job/cloudstack-pull-analysis/1150/org.apache.cloudstack$cloud-server/console --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153713989 @borisroman , could you please retest? It worked for me and for you, but not for @remibergsma due to a resolving thing on RVR test. I then ran it again and

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/997#issuecomment-153775777 nope, I'd like to figure out why tests are not running. Just have not found the time to do so. --- If your project is set up for it, you can reply to this email and

Re: [VOTE] Apache CloudStack 4.6.0

That's great, thanks a lot! Saves on time and confusion. If we could do this with every (rc) release, that'd be great. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Rajani Karuturi" > To:

Re: [VOTE] Apache CloudStack 4.6.0

Hi, Has jenkins built rpms for this somewhere? -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Remi Bergsma" > To: dev@cloudstack.apache.org > Sent: Wednesday, 4 November, 2015 14:55:11 > Subject: [VOTE]

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153783852 I think we should add isSensitive() to @Parameter and use that. Also we should base this on gson 2+ and not on the version we are presently using.

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43897789 --- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java --- @@ -62,10 +65,12 @@

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43898594 --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java --- @@ -27,30 +29,40 @@ import com.google.gson.GsonBuilder; /** -

Re: [VOTE] Apache CloudStack 4.6.0

I started jenkins builds for cloudstack RPM packages and systemvm templates for this branch here http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/19/console http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/3/console

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43897730 --- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java --- @@ -62,10 +65,12 @@

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43898186 --- Diff: api/src/org/apache/cloudstack/api/response/UserVmResponse.java --- @@ -256,6 +259,7 @@

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1021#discussion_r43899212 --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java --- @@ -71,4 +83,19 @@ public boolean shouldSkipField(FieldAttributes f) {

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

GitHub user Carles-Figuerola opened a pull request: https://github.com/apache/cloudstack/pull/1033 CLOUDSTACK-9029: Proper support to identify CentOS 7 version number https://issues.apache.org/jira/browse/CLOUDSTACK-9029 You can merge this pull request into a Git repository by

Re: [VOTE] Apache CloudStack 4.6.0

The jobs failed due to the git clone failing (time out). I also experience it is quite slow at the moment. It is mirrored here (same commit id): https://github.com/apache/cloudstack/tree/4.6.0-RC20151104T1522 Regards, Remi On 04/11/15 17:17, "Rajani Karuturi"

Re: [VOTE] Apache CloudStack 4.6.0

I have CentOS 7.1 RPMs. In case anyone needs them now, I can make available. Testing the 4.6.0 RC as I type. Cheers, Wilder > On 04 Nov 2015, at 18:12, Remi Bergsma wrote: > > The jobs failed due to the git clone failing (time out). I also experience it > is

[GitHub] cloudstack pull request:

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/34fee547cd10025f91e47e5efa6a97a96dd96313#commitcomment-14176906 German is now fully translated --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1031 CLOUDSTACK-9026: Modifying testpath for adding missing parameter Addning service_offering creation in testpath_storage_migration.py testpath which is missing right now You can merge

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153650536 @wido code are updated. I have a node running with Ubuntu 12.04/qemu 1.2.1/libvirt 0.9.13 (not stock QEMU 1.0 and libvirt 0.9.8). It works fine in the vm

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153643254 @koushik-das You are right, I did not realise the display name was missing from there. Can't we make that table a bit wider so we can add another column or two?

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153656222 Talked with @karuturi and agreed that we make the tests in this PR work, then merge it. The other issue should be tracked and fixed separately as it is not a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153631129 @runseb I am with you but for 4.7 instead of 4.6. The Nuage people have shown great effort of elegantly using our crappy plugin system and are now maintaining

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153629584 @jburwell I hear what you are saying, but I think it would be totally unfair to ask this plugin provider to provide independent testing capability to the community.

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153631839 @DaanHoogland yep, so we can release this right on the heel of 4.6 release, with just one commit to get 4.7. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153634024 @koushik-das Thanks for your comments. I pushed a new commit . --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153822915 I agree with @runseb that we need to move this discussion to dev@, and re-assess accepting the maintenance responsibly for code that cannot be tested and verified

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153830070 This PR will be merged once 4.6.0 is out and together with some other cool features (I counted at least 5 of them that have pull requests that are almost ready

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153665922 +1 LGTM just looking at the translated strings. did not build it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153667126 Consistent Snapshots are not possible without freeze/thaw via the guest-agent. I think most people want good snapshots of their virtual machines. That

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153668149 Also, it is possible to avoid serializing the objects by hand (like adding/appending {, >, <, } etc by hand?). Probably use any available library, and if that's

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153668057 So I wrote #985 which adds a channel by default to all guests. The question is, how do we proceed. Which one goes in? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153669186 @runseb, yes in principle but we have a list of 4.7 candidates allready, so It would cantain a little more. Let's try to contain it though. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153671338 I created https://issues.apache.org/jira/browse/CLOUDSTACK-9027 to track the new issue --- If your project is set up for it, you can reply to this email and have

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Remi, Rajani, can you push this PR in ? Best, Raja -Original Message- From: Raja Pullela [mailto:raja.pull...@citrix.com] Sent: Tuesday, November 3, 2015 7:02 PM To: dev@cloudstack.apache.org Subject: Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config Cool, thanks Remi!

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153674330 @ustcweizhou Ah, I see indeed. So the discussion is: - Do we enable the port by default? I would say yes. (Less code!) - Do we enable the port for

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153677208 @bhaisaab can you explain ? I like your comment about the annotation not being descriptive on the sensitivity of the field. So for the best solution we would

[GitHub] cloudstack pull request: CLOUDSTACK-8902 Restart Network fails in ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153664020 ran the regression set with some f ```nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

cc @remibergsma @DaanHoogland @karuturi You can merge this pull request into a Git repository by running: $ git pull https://github.com/milamberspace/cloudstack L10N-update-updateMaster-20151104 Alternatively you can review and apply these changes as the patch at: https://github.com

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153664686 @koushik-das I understand removal of the column may not be accepted, but then the UI would look misaligned if I add another column due to strict width issues.

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1004 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153664875 @ustcweizhou I don't see the difference personally, as a admin you already have full access to the Instance if you want to. But this PR conflicts with mine,

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1030#issuecomment-153668049 I am not sure why this PR is marked blocker/critical. The implemented code is a nested. It should have been a factored out check-method with unit test, not

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153667726 @koushik-das I think it's inappropriate as we're not marking those fields to note that they have hold sensitive information; but anyway that works --- If your

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153667850 @sspans Indeed. Users can stop/disable the agent or even block specific commands if they wish to. As CloudStack we don't control what's in the Instance, so it's the

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153669733 Seems good! Great to see this :) Some tests are failing though, could you look into that? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153672795 @wido this PR already includes your commits in #985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153673706 LGTM, test runs fine: ``` [root@cs1 MarvinLogs]# less test_vpc_vpn_WK8870/results.txt Test Remote Access VPN in VPC ... === TestName:

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153673995 Thanks, @karuturi ! I already found the error in the test, running it now and will push the code. The problem was: * For RVR networks, an

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153678077 +1 LGTM (ignore jenkins, one of the modules crashed due to jvm issue not code issues) @remibergsma include this? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1032#issuecomment-153680282 @bhaisaab I agree that this run on jenkins can be ignored but let's see a successful compile anyhow. I have it in my queue but I will forgive anybody that

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-153680788 LGTM +1 (just code review, no testing was performed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153681147 Glad you found it @wilderrodrigues and thanks for the fix! Will retest soon! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153681436 @wido @sspans To be honest, this code was written by me about two years ago , which is not used for now. I created the PR because you guys can judge this

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1009#issuecomment-153681458 code LGTM, @rags22489664 can you put the integration test in the simulator on your backlog? would love to see it :) If tests pass merge, @remibergsma .

[GitHub] cloudstack pull request: CID 1338016: multi catch instead of pokem...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1018#issuecomment-153681786 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-153681753 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153681687 @DaanHoogland we can simply use @LogLevel I simply shared that there is a slight chance on confusion in future, and do we then remove the

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9012 :automation of cores feat...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1011#issuecomment-153681911 LGTM (not tested, just reviewed code) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1010#issuecomment-153682260 @pritisarap12 I don't see any changes on the "Files changed" tab is the file plaintext with 0644 file mod, or is it already merged on master? --- If your project

  1   2   >