[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-209224739 So do we have 2 LGTM code reviews for this then? @jburwell do you give this a +1? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

2016-04-12 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-209222090 I am confused as to the issue at this point. Building the PR using ``mvn clean install findbugs:check`` passes. It appears that commit reversions have addressed

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

2016-04-12 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-209210558 @DaanHoogland I don't know how these changes could cause secondary storage controller unit tests to break. Unfortunately, the Jenkins report link returns a 404.

[JIRA] cleanup

2016-04-12 Thread Pierre-Luc Dion
Hi, I've "released" in Jira our version that got released over the last few months, so now the only unreleased versions are: 4.9.0, 4.8.1, 4.7.2. I've archived release that I don't think we will release: 4.4.5, 4.5.3 if someone is planning to be RM on these we can unarchive them. I've close

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r59486755 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long vmId,

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

2016-04-12 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1479#discussion_r59486626 --- Diff: agent/src/com/cloud/agent/Agent.java --- @@ -227,6 +227,7 @@ public void start() { try { _connection.start();

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1487#issuecomment-209099808 just to finalize my report, @swill ; I isolated the failing test: ``` SSH into VM: 192.168.23.7 Trying SSH Connection: Host:192.168.23.7

4.9 Release Schedule

2016-04-12 Thread Will Stevens
Sorry this has taken me so long to publish. I was trying to make sure I had good momentum before I published a timeline so the timeline was realistic given our current pace. I know this release has taken quite a bit longer than usual. Sorry about that, I will be trying to get us back to a

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-209095939 This one looks like it is ready to go now. I will add it to my next 'ready to merge' batch. Thanks again for all the hard work @GabrielBrascher. :+1: --- If

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2016-04-12 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-209084883 I am sorry, but I forgot to update the com.cloud.api.ApiServletTest class, now that those tests are running, all checks have passed. @bhaisaab

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-209077230 I have created a jira ticket for this. https://issues.apache.org/jira/browse/CLOUDSTACK-9345 Maybe we could close this PR, and then next

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209024302 I did nto noticed that @swill LGTM. So, it is OK. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209026461 @swill @bhaisaab I started reviewing but it changed while busy, Is it done now? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1445#discussion_r59422694 --- Diff: utils/src/test/java/com/cloud/utils/TestProfiler.java --- @@ -19,84 +19,79 @@ package com.cloud.utils; -import

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209028959 I appreciate it. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209026193 Some screenshots \* Roles Tab: ![Uploading Screenshot from 2016-04-12 23-11-42.png…]() Add a new role: ![screenshot from 2016-04-12

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209025189 @pdube sorry, my brain is into something else right now and I didn't review the scope of the code. Yes, your tests are valid tests for this change. So yes, I will

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209026629 Just trying to help get things merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209026886 @DaanHoogland I was pushing some changes and adding some info/screenshots above. Since this aims to deprecate use of commands.properties (affecting marvin and

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209028162 @bhaisaab, ok will continue tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209023846 @rafaelweingartner @swill The only thing changed was the unit tests, which I ran. And the only code change he did was to remove useless variables. @swill also gave

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r59419363 --- Diff: tools/marvin/marvin/cloudstackConnection.py --- @@ -143,7 +143,7 @@ def __sign(self, payload): ["=".join(

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209021645 This is a feature that we definitely need. Can I please get some code review on this PR? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209021841 I would say it is missing an LGTM. But, it is very good the code. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209020807 @pdube we need to run CI against it first, but otherwise, yes it is ready... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-209020597 @rafaelweingartner +1 to remove all that stuff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-209018498 ## test_staticroles.py === TestName: test_static_role_account_acls | Status : SUCCESS === ## scripts/util/migrate-dynamicroles.py I'll

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-12 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-209017286 @swill this looks ready, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-12 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1489 CLOUDSTACK-8562: Dynamic Role-Based API Checker for CloudStack You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack

Re: Travis Failing

2016-04-12 Thread Rohit Yadav
I forgot to reply all, I replied following to Will: ## start ## Will, can you share the travis job URL which failed? I suspect it could be environment related, Travis builds run on ubuntu trusty on GCE with 2 cores and 7.5GB RAM. We're running the build process/tests in parallel with -T4 to save

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2016-04-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-209009495 @GabrielBrascher thanks, Travis failed again. I'll test this on my env tomorrow (night for me here). Meanwhile, can you build with -T4 -Dnoredist -Dsimulator

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-208987688 I have tried a few times, but I also was having problems with my CI when trying to test this. I was getting errors, but I was trying to determine if it was my env

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-208986832 @swill, @DaanHoogland Have you already executed test on this one? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2016-04-12 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208969926 @bhaisaab force pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2016-04-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-208956680 @GabrielBrascher can you do a rebase or push -f again so that Travis build can be re-kicked --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1487#issuecomment-208924288 Ok, perfect. I will merge this now. Thx for confirming.. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-208922778 I would like to get the LGTM from @remibergsma and @pdion891 before I merge this. Thanks for all the hard work @jayapalu.. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208921203 @swill sorry it is not the same test that fails in my env: "Ping to outside world from VM should be successful" in

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208919017 @swill that is definitely not the same issue as I'm having. it is in the same test however --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1487#issuecomment-208917458 fine I had a failure but the re-run worked. Not very reassuring but mainly about my test-env not the pr. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208915830 @DaanHoogland for the test that often fails in my environment, check @remibergsma's comments here:

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-208914356 Do we have any assurances that this works and does not break anything? Do we need to run CI or how do we validate this? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-208909441 I am not sure what is going on with Jenkins and Travis now days, but they are being very flaky. Maybe the added load of people being more active is messing with

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1487#issuecomment-208907818 @DaanHoogland I already ran tests against this one as #1449. I am planning to merge this today... --- If your project is set up for it, you can reply to this email

Re: instances in test vpc without router

2016-04-12 Thread Will Stevens
im not sure, i will let remi answer that. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Apr 12, 2016 at 6:10 AM, Daan Hoogland wrote: > @swill and

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208903886 I also thought it was the HyperV agent; but, that agent is built in a different way. I was going over the files, and it seems that is used to build an

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208900500 might be just for the agent, I have never run it. I read about people running it on windows but back in the days when i did it is was on cygwin. --- If your

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208898455 you mean the ACS itself? The whole ACS? For what I have seen of the code base, it does not seem to work in Windows environments. --- If your

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208897161 the windows install of acs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208896922 Is that "wix-acs" maven task executed? What does it build? I noticed it has as an output a file called "acs.msi", what is it? --- If your

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208891268 Isn't there references to these files? Forget the ones in `target`, but the references in `cloudstack/scripts/installer/windows/client.wxs` should probably be

Re: ACS PRs Status - 2016/04/11

2016-04-12 Thread Will Stevens
Yep, I got it. Thanks... :) 1487 (1449) - 4.7 (ready) NOTE: This closes #1449 *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Apr 12, 2016 at 2:14 AM, martin kolly

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-12 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-208847097 @swill what's the status on getting this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

instances in test vpc without router

2016-04-12 Thread Daan Hoogland
@swill and @remibergsma I saw this in the test ``` [dahn@blimbing ~]$ for i in 1 2 ; do ssh kvm$i virsh list; done Warning: Permanently added 'kvm1,192.168.22.21' (ECDSA) to the list of known hosts. IdName State

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-208821534 after a long search, I can find no syntax errors. LGTM based on code and report. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-208819704 @wido Great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1487#issuecomment-208819610 code LGTM running tests as we write --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-208817879 @jayapalu Please talk to @swill before merge. I'll also have another look at it and see if I can get it to work this time. --- If your project is set

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-04-12 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-208814933 @pdion891 I have rebased this branch with the master. Can you please trigger a template job on this branch. I don't have the permissions. I am planning to ask

[GitHub] cloudstack pull request: speedup iptables by prefetching the varia...

2016-04-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1487#issuecomment-208812713 Seems like a sane Python change. Looking at the code it's OK. I can't find an issue. Testing it is a bit harder to do for me now. Based on the code:

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208812036 Yes, seems rather stupid to keep those :) LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

2016-04-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-208811822 At PCextreme we have 'ipv6disabled' set to 'false' on our hypervisors and they are all connected over IPv6. Connections we see open from the Management Server

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

2016-04-12 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1488 agent: Enable IPv6 connectivity for KVM Agent to Management Server IPv4 is still preferred, so if the hostname of the Management Server returns a A and -record the Agent will still connect

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-208803326 LGTM in spite of comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1474#discussion_r59343588 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py --- @@ -274,3 +277,46 @@ def __moveFile(self, origPath, path):

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1474#discussion_r59342176 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -260,6 +261,15 @@ public boolean

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1474#discussion_r59341831 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py --- @@ -274,3 +277,46 @@ def __moveFile(self, origPath, path):

[GitHub] cloudstack pull request: Handle private gateways more reliably

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-208795019 @swill I don't think many people read spurious comments on the github PRs. only fanatics do :p I am for safeguarding as much history as possible and only

[GitHub] cloudstack pull request: Remove unused images

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208794882 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-208795627 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-208794235 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-04-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-208793335 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: speedup iptables setup

2016-04-12 Thread kollyma
Github user kollyma closed the pull request at: https://github.com/apache/cloudstack/pull/1449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: speedup iptables setup

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-208777850 @kollyma can you close this one if #1487 is indeed the same? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

2016-04-12 Thread dsclose
Github user dsclose commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-208755644 @kiwiflyer I'm currently working on CLOUDSTACK-9339 to resolve the issues that I mentioned in #1413 - I don't think this PR breaks anything that currently

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208753341 @remibergsma @swill this one test always failing in our environments doesn't sit good with me. It feels like we are accepting a crippled system to be carried.

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208752537 @ustcweizhou Can you review, the rebasing led to more commits then expected. The result looks fine but I am not sure. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-04-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-208751962 ### CI bubble run **Commit Reference: de53cd1799122f6448faef950cf9afd5caeaf412** initially two test failed. I reran the

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-04-12 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-208727264 @pdion891 I was worked for me when I connect remote access vpn from Macbook Air. Can you please send the vpn config file (l2tp.conf) --- If your

Re: ACS PRs Status - 2016/04/11

2016-04-12 Thread martin kolly
Hi Will Could you please update the second line on your list: - 1449 - 4.7 (pending squash) The number of the PR is now 1487 (commits are squashed). Sorry for changing this. thanks martin On 04/11/2016 04:05 PM, Will Stevens wrote: Here is this Monday's weekly status update. Jenkins and