Re: [GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

2015-07-27 Thread Daan Hoogland
can't find a config that runs. I can do with some help. last state was: \\sbpltc2kag3qr\dhoogland:~/cloudstack/cloudstack/test/integration (CLOUDSTACK-8651)> nosetests --with-marvin --marvin-config=../../tools/devcloud/devcloud.cfg -s -a tags=advanced,required_hardware=false component/test_browse_

Re: [DISCUSS] Automatic usage reporting / call-home for CloudStack

2015-07-27 Thread Daan Hoogland
gogogo On Mon, Jul 27, 2015 at 10:28 AM, Wido den Hollander wrote: > Hi, > > It has been quite some time and this feature hasn't merged yet. > > I created a issue for this: > https://issues.apache.org/jira/browse/CLOUDSTACK-8677 > > The code is ready to merge and is in the "reporter" [0] branch o

Re: Build failed in Jenkins: build-master-slowbuild #1887

2015-07-24 Thread Daan Hoogland
Rajani, applicationCtx is static but being set by the override setApplicationContext(..) which is not static. Does is need to be static? If so an extra wrapper method will kill the warning (not the issue). As the LdapUserManagerFactory is a singleton I don't think the appctx needs to be static. Ag

Re: [Proposal] CoreOS support

2015-07-23 Thread Daan Hoogland
; - I thought this functionality already exists with > APIs like, > addGuestOs > updateGuestOs > removeGuestOs > addGuestOsMapping > updateGuestOsMapping > removeGuestOsMapping > > Regards, > Somesh > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl..

Re: [DISCUSS] Add at least test steps to PR

2015-07-23 Thread Daan Hoogland
+1 for less trivial changes that have no clear instruction on testing I would say you would have to be very interested in the component to not just -1 from the start. We are not writing code for the experts. We are writing code for the whole world to use understand and enhance. point of a review

Re: [Proposal] Continuos Integration Testing on ACS master.

2015-07-23 Thread Daan Hoogland
Good work Bharat, Keep in mind that many people work on this in many ways and many attempts have failed due to nothing but lack of consensus. I have only glanced but will take my time with it soon. On Thu, Jul 23, 2015 at 10:50 AM, Bharat Kumar wrote: > Hi All, > > Currently we do sanity checks o

Re: [Proposal] CoreOS support

2015-07-23 Thread Daan Hoogland
of course +1 for adding CoreOS but can we make supporting os-types more a cloud administrator task then a cloudstack maintainer task? I think some work has gone into that already. Some more work will probably be needed. On Thu, Jul 23, 2015 at 10:43 AM, Kishan Kavala wrote: > Sure Sebastian. I'll

Re: [PROPOSAL] drop old upgrade code

2015-07-23 Thread Daan Hoogland
d with proper documentation >> and an advanced notification in some prior releases. This is similar to the >> way some API is deprecated and then eventually removed. >> >> -Koushik >> >> -Original Message- >> From: Daan Hoogland [

Re: Review Request for PR 609

2015-07-21 Thread Daan Hoogland
Lot of work Rajani, I don't understand the spec files in groovy, yet. How can I verify these are run? On Wed, Jul 22, 2015 at 6:39 AM, Rajani Karuturi wrote: > Can someone please review PR 609? Its an enhancement to LDAP import users > functionality > > https://github.com/apache/cloudstack/pull/6

Re: [DISCUSS][PROPOSAL] CloudStack Upgrade Policy

2015-07-21 Thread Daan Hoogland
John, You wrote this here and on users and I think it is a good proposal. There is one technical catch and I don't think it is worth bothering users@ with: our current db installation scheme starts with a 4.0.0 database and performs all upgrade steps from that point onward. This can be solved in t

Re: [PROPOSAL] drop old upgrade code

2015-07-20 Thread Daan Hoogland
in anticipation of loads of +1's I made a new PR (at [2]) On Mon, Jul 20, 2015 at 2:29 PM, Wido den Hollander wrote: > > > On 20-07-15 13:48, Daan Hoogland wrote: >> LS, >> >> In coverity the only remaining high impact issues are concerned with >> upgrade c

[PROPOSAL] drop old upgrade code

2015-07-20 Thread Daan Hoogland
LS, In coverity the only remaining high impact issues are concerned with upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4 upgrades. I addressed the file Upgrade218to22.java in a PR [1] and I move that we don't pull it but instead drop the file altogether together with all upgrade

Re: [QUESTION] SQL in old upgrade code

2015-07-19 Thread Daan Hoogland
nevermind, I was reading over an extra underscore ('_')...:( On Sun, Jul 19, 2015 at 4:10 PM, Daan Hoogland wrote: > devs, > > in Upgrade218to22 in private void modifyIndexes(Connection conn), an > index is removed twice without any code inbetween. Does anybody know >

[QUESTION] SQL in old upgrade code

2015-07-19 Thread Daan Hoogland
devs, in Upgrade218to22 in private void modifyIndexes(Connection conn), an index is removed twice without any code inbetween. Does anybody know of a (my)sql quirk that makes this necessary? I am trying to remove the last high impact coverity warning so we can use coverity in our review process. A

nice read: squash

2015-07-17 Thread Daan Hoogland
I adviced someone to squash a commit today, so to do penance i did some reading [1]. I can't whole heartedly say I won't sin like this again but I do feel better now;) [1] http://paul.stadig.name/2010/12/thou-shalt-not-lie-git-rebase-ammend.html -- Daan

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-17 Thread Daan Hoogland
Rene, Remi, I read back the thread and have another answer on this for you; The branch contains a point version number instead of a x.y.z-SNAPSHOT, without the branch a revert commit must follow if we vote them out. a branch can be simply neglected. On Thu, Jul 2, 2015 at 4:46 PM, Remi Bergsma wr

Re: [DISCUSS] PR list length

2015-07-17 Thread Daan Hoogland
the rule. > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Friday, 17 July 2015 16:50 > To: dev > Subject: Re: [DISCUSS] PR list length > > I agree as well and since I started this thread a lot of work is being done > to keep the

Re: [DISCUSS] PR list length

2015-07-17 Thread Daan Hoogland
specified time (may be 7 days). For new features the existing process >> should be fine. >> > >> > -Original Message- >> > From: Wido den Hollander [mailto:w...@widodh.nl] >> > Sent: Tuesday, 14 July 2015 17:42 >> > To: dev@cloudstack.apache.org

Re: upgrade cloudstack from 4.2.0 to 4.4.2

2015-07-17 Thread Daan Hoogland
sorry sent to soon On Fri, Jul 17, 2015 at 11:38 AM, Daan Hoogland wrote: > ad 1. The roll back procedure is - restore the old db - reinstall the old version of cloudstack - recover the old etc dir (/etc/cloudstack) that should do it > > ad 2. You only need to edit your cluster sett

Re: upgrade cloudstack from 4.2.0 to 4.4.2

2015-07-17 Thread Daan Hoogland
ad 1. The roll back procedure is ad 2. You only need to edit your cluster setting after the upgrade to set them to 4 ad 3. yes they can remain running On Fri, Jul 17, 2015 at 5:03 AM, wrote: > Hello, > My environment is cloudstack4.2.0+vmware5.0.I'm testing the upgrade process > from cloudstac

Re: [LOGGING] Logging levels in CloudStack code

2015-07-17 Thread Daan Hoogland
retweet ;) For those doing regular reviews of code this is also an item. thanks Wido for a sound cry in the desert. On Fri, Jul 17, 2015 at 10:58 AM, Wido den Hollander wrote: > Hi, > > After debugging multiple issues in CloudStack the past week I got > annoyed again by the fact that almost all l

Re: Git Rebase Question

2015-07-15 Thread Daan Hoogland
A directory rename? If you create a patch file of your branch and apply it on HEAD, does that work? On Wed, Jul 15, 2015 at 3:03 AM, Mike Tutkowski wrote: > Hi everyone, > > I have a Git question that relates to a rebase problem I've been seeing. > > I have a branch I've been working on the past

[DISCUSS] PR list length

2015-07-14 Thread Daan Hoogland
H, It is a concern to me that the list of PRs on our github page is beyond a single page (maybe configurable but now a t a very reasonable 25). I think we should adhere to a discipline of not having any PRs open after the weekend. This is putting a very strong statement outthere, I realize. A PR m

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

2015-07-14 Thread Daan Hoogland
you can add that commit here for my part, please don't squash it;) On Tue, Jul 14, 2015 at 12:30 PM, wido wrote: > Github user wido commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/582#discussion_r34554904 > > --- Diff: > plugins/storage/image/s3/src

Re: Github not syncing?

2015-07-14 Thread Daan Hoogland
this happens once in a while. better send your branch to your fork and create the PR. I merged some and they don't get updated either. If it takes to long I think we need to ask infra. On Tue, Jul 14, 2015 at 9:33 AM, Rohit Yadav wrote: > Hi, > > Since past 2 hours, I’ve been waiting to send a

Re: capitalized method name

2015-07-14 Thread Daan Hoogland
thanks, i made https://github.com/apache/cloudstack/pull/584 On Tue, Jul 14, 2015 at 5:45 AM, Jayapal Reddy Uradi wrote: > Hi Daan, > > Please go ahead and change the name. > Thanks for notifying. > > -Jayapal > > > On 13-Jul-2015, at 8:45 PM, Daan Hoogland wrote: &

Re: [2/3] git commit: updated refs/heads/master to 63688e7

2015-07-13 Thread Daan Hoogland
LGTM but what PR did I miss here, Wido? On Mon, Jul 13, 2015 at 4:59 PM, wrote: > kvm: Write Libvirt instead of LibVirt > > > Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo > Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/24f8e66e > Tree: http://git-wip-us.apac

capitalized method name

2015-07-13 Thread Daan Hoogland
Jayapal, I didn't notice this before but in PR 568, in commit 638885a9de0fd651351f0b16cbdd9fc30c4a187d, you added a method name starting with capital 'A' to citrixrecource base. Is this on purpose and can we change it to adhere to convention? public boolean AttachConfigDriveToMigratedVm(Conne

Re: Can we use components based on MIT License?

2015-07-10 Thread Daan Hoogland
The link in Rafael's answer contains a list of allowed licenses. MIT is in the list. On Fri, Jul 10, 2015 at 9:07 PM, Rohit Yadav wrote: > > On 16-Jun-2015, at 5:23 am, ilya wrote: > > General question, can we add/use components based on MIT License? > > > cc Sebastien/David - just to be sure

Re: 4.5.2 open issues remaining

2015-07-10 Thread Daan Hoogland
t; On 09-Jul-2015, at 3:50 pm, Daan Hoogland wrote: > > H, > > Can everybody look at [1] and look if further tickets can be closed. I > reduced the list by 60 tickets moving inactive tickets to 'Future' and > closing what I knew could be closed. The main objective of c

Re: Jenkin automated job to create release package

2015-07-10 Thread Daan Hoogland
great work Pierre-Luc, no we are working on 4.5.2, nothing yet On Fri, Jul 10, 2015 at 8:17 PM, Pierre-Luc Dion wrote: > Hi, > I've create a collection of jenkins jobs [1] allowing to create packages of > a release and publish them on cloudstack.apt-get.eu so current community > yum and apt repos

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-10 Thread Daan Hoogland
I hate to be as opiniated as I am but here it comes ;) On Fri, Jul 10, 2015 at 7:39 PM, Rohit Yadav wrote: > While I like the ideas generally [1], some concerns and observations > that I wish could be considered; > > - active contributor crunch: > > we don’t have large number of active people

Re: [GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...

2015-07-10 Thread Daan Hoogland
my bad, I would like to see "$LGTM" (as in on the start of a line), though. This looks like a comment at first. On Fri, Jul 10, 2015 at 3:42 PM, sateesh-chodapuneedi wrote: > Github user sateesh-chodapuneedi commented on the pull request: > > https://github.com/apache/cloudstack/pull/568#issu

Re: [GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...

2015-07-10 Thread Daan Hoogland
I don't see two LGTM on this one. What happened? On Fri, Jul 10, 2015 at 6:20 AM, asfgit wrote: > Github user asfgit closed the pull request at: > > https://github.com/apache/cloudstack/pull/568 > > > --- > If your project is set up for it, you can reply to this email and have your > reply ap

Re: [PROPOSAL] Commit to master through PR only

2015-07-09 Thread Daan Hoogland
On Thu, Jul 9, 2015 at 12:04 PM, Rohit Yadav wrote: > > On 09-Jul-2015, at 2:56 pm, Daan Hoogland wrote: > > I like the idea but think that 72 hours is way to short > > > I think 72 hours (note: no counting weekends) should be good enough, > which is the window for our

4.5.2 open issues remaining

2015-07-09 Thread Daan Hoogland
H, Can everybody look at [1] and look if further tickets can be closed. I reduced the list by 60 tickets moving inactive tickets to 'Future' and closing what I knew could be closed. The main objective of course is to get 4.5.2 out and voted in;) [1]https://issues.apache.org/jira/issues/?jql=proje

Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...

2015-07-09 Thread Daan Hoogland
I think I look good to myself as well ;} On Thu, Jul 9, 2015 at 11:44 AM, karuturi wrote: > Github user karuturi commented on the pull request: > > https://github.com/apache/cloudstack/pull/563#issuecomment-119891522 > > +1 changes looks good. but, a jira ticket is required. Also, I dont

Re: [PROPOSAL] Commit to master through PR only

2015-07-09 Thread Daan Hoogland
On Thu, Jul 9, 2015 at 10:51 AM, Rohit Yadav wrote: > > On 09-Jul-2015, at 2:14 pm, Rohit Yadav wrote: > > - This seems to be already failing, under the Apache way IMO there is no > way we can enforce and ensure that at least two people would review any and > every PR. There are already a growin

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...

2015-07-09 Thread Daan Hoogland
On Thu, Jul 9, 2015 at 8:44 AM, pavanb018 wrote: > looks good to me pavanb018 you probably should write LGTM ;) -- Daan

Re: Introducing Boris Schrijver

2015-07-08 Thread Daan Hoogland
good luck Boris, Do not hesitate to make PRs for any strange oddities you see. On Wed, Jul 8, 2015 at 5:24 PM, sebgoa wrote: > > On Jul 8, 2015, at 5:08 PM, Wido den Hollander wrote: > >> Hi all, >> >> As you might know, we at PCextreme are using CloudStack for our public >> cloud offering and h

Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

2015-07-08 Thread Daan Hoogland
: > I thought there is a limitation on LGTMs for integration tests? > > On Wed, Jul 8, 2015 at 5:11 PM, Daan Hoogland > wrote: > >> guys and dolss, >> >> this was closed with only 1 LGTM! we agreed not to submit with less >> then two ok reviews

revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

2015-07-08 Thread Daan Hoogland
guys and dolss, this was closed with only 1 LGTM! we agreed not to submit with less then two ok reviews on master. So next steps? revert? some extra justification or else revert? . On Wed, Jul 8, 2015 at 12:39 PM, asfgit wrote: > Github user asfgit closed the pull request at: > > https:/

resource leaks

2015-07-08 Thread Daan Hoogland
Rohit Yadav > wrote: > >> >> On 07-Jul-2015, at 3:40 pm, Daan Hoogland wrote: >> >> I will not do it in one commit, if we insist on a PR i will do 73 commits >> in one PR. >> >> >> Fine. >> >> Regards, >> Rohit Yadav >> S

Re: [ACS4.5] status

2015-07-08 Thread Daan Hoogland
On Tue, Jul 7, 2015 at 10:55 AM, Rohit Yadav wrote: >> On 07-Jul-2015, at 11:47 am, Daan Hoogland wrote: >> >> I haven't heard of this in a few days. Does anyone keep track of 4.5 >> releasebility at the moment? > > Yes. I’ve shared this earlier that I p

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
On Tue, Jul 7, 2015 at 1:37 PM, Rajani Karuturi wrote: > This not a good candidate for squashing/huge commit. > If a regression is found in any of the fixes, it will be easier to just > revert it than reverting all the 70 commits. > > ~Rajani Thanks Rajani, I allready made a booboo in the first

Re: defects cleanup drive...

2015-07-07 Thread Daan Hoogland
we can decide to close the issues that > were fixed more than an year ago or two years ago - that way we can have > less counts to manage... just a thought... > > Raja > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Tuesday, July

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Daan Hoogland
On Tue, Jul 7, 2015 at 12:16 PM, Rohit Yadav wrote: > Depends - I would want this. One could say it’s a bug that UI plugins are > listed but hidden (see the code, a is added, but if the section is a > plugin it hides it by setting display:none). > ​I can go for that :) ​ > > Quick question -

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
Sorre Sebastien, I will -1 squashing any other then typo or to and fro commits. On Tue, Jul 7, 2015 at 12:15 PM, sebgoa wrote: > > On Jul 7, 2015, at 12:10 PM, Daan Hoogland wrote: > >> I will not do it in one commit, if we insist on a PR i will do 73 commits >> in o

Re: resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
I will not do it in one commit, if we insist on a PR i will do 73 commits in one PR. On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:29 pm, Daan Hoogland wrote: > > I want permission to go ahead and address these issues and not create > one huge

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Daan Hoogland
ok, but we should not wait with a release for this or wait releasing 4.6? On Tue, Jul 7, 2015 at 12:02 PM, Rohit Yadav wrote: > > On 07-Jul-2015, at 3:17 pm, Daan Hoogland wrote: > > Rohit, are you basing this on 4.5? seems like a feature (meaning it > should be based on master

resource leaks exception to the 2LGTM rule

2015-07-07 Thread Daan Hoogland
Guys `n' Dolls, I want an exception to the rule requiring two LGTMs for any commit: coverity reports 73 high impact issues at the moment. All of them are resource leaks that can be solved by the well known pattern of using try-with-resource. We (and I do mean a lot of us) have been fixing this in

Re: defects cleanup drive...

2015-07-07 Thread Daan Hoogland
Raja, thanks for picking this up. I have practiced the principle of awaiting (at least verbal) confirmation from the reporter that an issue could indeed be closed. With the increased activity on integration tests we might base ourselves on that. ideas? On Tue, Jul 7, 2015 at 11:42 AM, Raja Pullel

Re: git commit: updated refs/heads/4.5-ui-plugin-enhancement to f8693d2

2015-07-07 Thread Daan Hoogland
Rohit, are you basing this on 4.5? seems like a feature (meaning it should be based on master). On Tue, Jul 7, 2015 at 11:42 AM, wrote: > Repository: cloudstack > Updated Branches: > refs/heads/4.5-ui-plugin-enhancement [created] f8693d24a > > > ui: Allow UI plugins to be shown on navigation b

pull request builder for rat

2015-07-06 Thread Daan Hoogland
H, for my own and your convenience I made a pull request builder at builds.a.o yesterday. It seems to work and it will report license issues in the PR or give an ok. I haven't seen an error apear yet So no idea how that looks but I imagine it'll give you a link from the PR to the build pointing

[ACS4.5] status

2015-07-06 Thread Daan Hoogland
I haven't heard of this in a few days. Does anyone keep track of 4.5 releasebility at the moment? I would like to move on to 4.6:) So can we make a release candidate for 4.5.2 yet? -- Daan

Re: marvin installation error on cloudstack 4.3; Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'

2015-07-06 Thread Daan Hoogland
Can you try unistalling or using --upgrade in the pip command? If that doesn't work can you try a 4.6/master version of marvin? rgards, On Tue, Jul 7, 2015 at 4:30 AM, Urvi Shah wrote: > Hi, > > I am trying to run marvin tests on cloudstack 4.3. the steps that i > followed are as follows : > > 1

Re: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack

2015-07-03 Thread Daan Hoogland
Ah, someone to keep the cowboys in line. success Karen. On Fri, Jul 3, 2015 at 7:20 AM, Koushik Das wrote: > Congrats Karen! > > -Original Message- > From: John Burwell [mailto:john.burw...@shapeblue.com] > Sent: Thursday, 2 July 2015 23:45 > To: dev@cloudstack.apache.org > Cc: Karen Vuon

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-03 Thread Daan Hoogland
finally someone to do the hard work. Go get'm Wilder! On Thu, Jul 2, 2015 at 5:51 PM, Marco Sinhoreli wrote: > Parabéns Wilder! > > Abs! > > Marco Sinhoreli > > Consultant Manager > > > > > > > > > Phone: +55 21 2586 6390 | Fax: +55 21 2586 6002 | Mobile: +55 21 99159 > 4713 | Mobile: +55 21 9827

Re: [GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-07-03 Thread Daan Hoogland
will be much more helpful > to people trying to comprehend the work at some point in the future. > > Thanks, > -John > > --- > John Burwell (@john_burwell) > VP of Software Engineering, ShapeBlue > (571) 403-2411 | +44 20 3603 0542 > http://www.shapeblue.com > > &

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Daan Hoogland
On Thu, Jul 2, 2015 at 2:29 PM, Remi Bergsma wrote: > Since the goal is a stable master, I’d say the bug fix should go to master > first. Remi, this means that merge back of the branch makes no sense anymore. -- Daan

Re: [DISCUSS] Release principles for Apache CloudStack

2015-07-02 Thread Daan Hoogland
be sure you're backed On Thu, Jul 2, 2015 at 1:46 PM, Remi Bergsma wrote: > Hi all, > > We already agreed contributions should always go via a PR and require two > LGTM’s before we merge. Let me propose the next step on how I think we should > do release management for 4.6 and on. > > I talked

Re: [PROPOSAL] Commit to master through PR only

2015-07-02 Thread Daan Hoogland
Wilder, you are being to friendly IMHO here. I would actually -1 a PR that contains a commit that tries to do more then one thing. It is obfuscating and makes it harder to discuss implementations and fixes. in commit abcdef, in the part that fixes the NPE related to the network implementation of s

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Daan Hoogland
On Wed, Jul 1, 2015 at 8:44 PM, John Burwell wrote: > All, > > I think we should stick to 2 votes per PR. Defining types of PRs becomes > difficult bordering on the arbitrary — adding a process complexity and the > potential to start debating if a particular PR is one type or another. agree >

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Daan Hoogland
I'm afraid I don't agree on some of points here, Rohit. On Wed, Jul 1, 2015 at 7:48 PM, Rohit Yadav wrote: ... > Some suggestions and comments to improve PR reviewing/merging: > > - Let's merge the PR commits in a fast forward way instead of doing a branch > merge that introduces frivolous merg

Re: Build failed in Jenkins: build-master-slowbuild #1689

2015-06-29 Thread Daan Hoogland
Rohit, I guess this was your saml merge, Can you fix (parameterizing getBytes() with either StringUtils.getPreferredEncoding() or Charset.defaultCharset(), depending on what you considder applicable)? About the upgrade; I would wait untill 4.5.2 is out. We don't want stale upgrades in the codebase

Re: [GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-06-29 Thread Daan Hoogland
Do not squash commits and hide history unless it makes reading it much and obviously clearer. It is only good in my not so humble opinion in case of to and fro commits where a thing has been reverted and reapplied and reverted again and so on. Also do not rebase commits but make merge commits, thi

[DISCUSS] remaining findbugs issues

2015-06-28 Thread Daan Hoogland
Ladies and gentlemen, As a result of hard work by a lot of people we 'only' have 143 findbugs warning left in our slowbuild run results for findbugs. I am rather pleased with this and almost satisfied. For total euforia this of course needs to be 0 (zero). Even better news then the drop of over 20

Re: [PROPOSAL] Commit to master through PR only

2015-06-26 Thread Daan Hoogland
date := 2015-09-30 ??? On Fri, Jun 26, 2015 at 9:54 PM, David Nalley wrote: > On Thu, Jun 25, 2015 at 10:38 AM, Sebastien Goasguen wrote: >> Folks, >> >> A few of us are in Amsterdam at DevOps days. We are chatting about release >> management procedure. >> Remi is working on a set of principles

test failure question

2015-06-26 Thread Daan Hoogland
H, In a new environment I cannot get marvin tests to run: 2015-06-26 11:36:54,022 - DEBUG - Parsing Test data successful 2015-06-26 11:36:54,023 - DEBUG - Payload: {'account': 'admin', 'command': 'listUsers', 'response': 'json'} 2015-06-26 11:36:54,023 - DEBUG - Sending GET Cmd : listUser

Re: [PROPOSAL] Commit to master through PR only

2015-06-26 Thread Daan Hoogland
On Fri, Jun 26, 2015 at 3:13 PM, Rafael Fonseca wrote: > Or if we really want the extra overhead: > > ( Green_Travis && 2LGTM) || ( Red_Travis_false_positive && 3LGTM_Extended) or ( Green_Travis && 2LGTM) || ( Red_Travis_false_positive && 2LGTM_Extended && justification in writing) that was th

Re: [PROPOSAL] Commit to master through PR only

2015-06-26 Thread Daan Hoogland
:) >> >> Concerning Travis, I’m with Daan and Remi: in case of a red Travis run, a >> good analysis on the results is needed before saying no. >> >> Let’s make ACS more awesome! ;) >> >> Cheers, >> Wilder >> >> >> > On 25 Jun 2015, a

Re: Disabling the quick search (/ character) in the web console before I go crazy

2015-06-26 Thread Daan Hoogland
:) one for the faq page? On Fri, Jun 26, 2015 at 2:07 PM, Nux! wrote: > OMG, I did not realise this is actually a Firefox issue, thanks! > > -- > Sent from the Delta quadrant using Borg technology! > > Nux! > www.nux.ro > > - Original Message - >> From: "Rajani Karuturi" >> To: dev@cloud

{ANNOUNCE] Apache CloudSack 4.4.4 released

2015-06-26 Thread Daan Hoogland
udStack Days Seattle 2015 , 20th August 2015, http://events.linuxfoundation.org/events/cloudstack-seattle <http://events.linuxfoundation.org/events/cloudstack-seattle> and CloudStack Collaboration Conference 2015 in Dublin, 8th and 9th of October 2015, http://cloudstackcollab.org kind

Re: DR service for CloudStack

2015-06-26 Thread Daan Hoogland
Suneel, Alena had written this for cloudplatform, citrix' product based on cloudstack. I don't think it has been contributed back. On Fri, Jun 26, 2015 at 8:25 AM, mvs babu wrote: > Hello, > > > I would like to use DR service for CloudSrtack. Found below useful video. > > > https://www.youtube.co

Re: [PROPOSAL] Commit to master through PR only

2015-06-25 Thread Daan Hoogland
I still don't think travis is reliable enough to give a definite 'no'. Two LGTMs is fine and a good argument if travis is red on why this is not a problem for this case. On Thu, Jun 25, 2015 at 4:47 PM, Rafael Fonseca wrote: > Couldn't make it either :'( > > I think it's a very sound idea in prin

next release

2015-06-25 Thread Daan Hoogland
We are wrapping up 4.4.4. I am assuming there is a need for a 4.5.2 but want some confirmation in response to this. If we don't have extra blockers we should be able to release it within a week. next up is 4.6.0. :o anybody got some input on the release process we should follow? And voluntering t

Re: [GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-06-25 Thread Daan Hoogland
Wilder, then rebase and amend the comment as well to include the ticket number On Thu, Jun 25, 2015 at 3:12 PM, terbolous wrote: > Github user terbolous commented on the pull request: > > https://github.com/apache/cloudstack/pull/527#issuecomment-115251794 > > Excellent, thanks :-) > > >

old failed travis builds

2015-06-25 Thread Daan Hoogland
Anybody knows if I can restart travis builds that failed in the past but should pass IMNSHO? I want to trigger some to see if I can merge them. I am not the owner of the pull request nor, obviously, of the ACS repo. -- Daan

Re: release notes

2015-06-25 Thread Daan Hoogland
ion/reboots, and duplicate ssh > keys in the ``what's new`` section > > -- > Erik > > On Thu, Jun 25, 2015 at 8:14 AM, Daan Hoogland > wrote: > >> no, though that's debatable: one fix is that adding the same public >> key to a domain under a different na

Re: release notes

2015-06-24 Thread Daan Hoogland
gt; On Thu, Jun 25, 2015 at 8:06 AM, Daan Hoogland > wrote: > >> I'll have a look, For the upgrade instructions 4.4.3 should work best. >> >> The only gotcha for people from 4.4.3 that I know of is a setting >> "router.reboot.when.outofband.migrated".

Re: release notes

2015-06-24 Thread Daan Hoogland
PM, Erik Weber wrote: > >> in the perfect world I guess we would all be laying on a beach somewhere >> sunny >> >> i'll bring these `issues` to another thread for discussion >> >> any upgrade instructions for 4.4.4, or is it ok to stay with the upgrade >

Re: release notes

2015-06-24 Thread Daan Hoogland
perfect world I guess those commits really should have been separate > issues > > -- > Erik > > > > On Wed, Jun 24, 2015 at 10:58 PM, Daan Hoogland > wrote: > >> btw CLOUDSTACK-8545 is marked fixed in 4.4.4 as well >> >> On Wed, Jun 24, 2015 at 10:53 P

Re: release notes

2015-06-24 Thread Daan Hoogland
btw CLOUDSTACK-8545 is marked fixed in 4.4.4 as well On Wed, Jun 24, 2015 at 10:53 PM, Daan Hoogland wrote: > there is the git log > > On Wed, Jun 24, 2015 at 10:51 PM, Erik Weber wrote: >> There's only one issue (CLOUDSTACK-8537) with fix version 4.4.4 marked as >> r

Re: release notes

2015-06-24 Thread Daan Hoogland
there is the git log On Wed, Jun 24, 2015 at 10:51 PM, Erik Weber wrote: > There's only one issue (CLOUDSTACK-8537) with fix version 4.4.4 marked as > resolved in Jira. > > I'm guessing that's wrong, so who know what's been fixed? > > -- > Erik > >

release notes

2015-06-24 Thread Daan Hoogland
Someone feeling the urge to write release notes for 4.4.4? Looking for a volunteer. -- Daan

[RESULT][VOTE] Apache CloudStack release 4.4.4

2015-06-24 Thread Daan Hoogland
Hi all, After 72 hours, the vote for CloudStack 4.4.4 *passes* with 3 PMC + 1 non-PMC votes. +1 (PMC / binding) Bruna, Daan, Rohit +1 (non binding) Wilder 0 none -1 none Thanks to everyone participating. I will now prepare the release announcement to go out after 24 hours to give the mirrors

Re: support for /31 Networks

2015-06-24 Thread Daan Hoogland
great, thanks. your feedback is half the work! On Wed, Jun 24, 2015 at 8:29 PM, Singh, Devender wrote: > Hi Daan , > It"s worked grate, a big thanks for your support > > Devender > > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] >

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-24 Thread Daan Hoogland
service offering ... === TestName: >> test_02_edit_service_offering | Status : SUCCESS === >> ok >> Test to delete service offering ... === TestName: >> test_03_delete_service_offering | Status : SUCCESS === >> ok >> test_privategw_acl (integration.smoke.t

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-23 Thread Daan Hoogland
On Tue, Jun 23, 2015 at 9:12 AM, Remi Bergsma wrote: > I can prepare a PR for the release notes and document the new setting. You > can then merge it when the release passes. Or should we do this in another > way? This is fine but it is in the release even if it doesn't pass so no sense waitin

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-22 Thread Daan Hoogland
ible-cloudstack-ubuntu-aio > > > > On 18/06/2015 09:24, Daan Hoogland wrote: >> >> Hi All, >> >> I've created a 4.4.4 release, with the following artifacts up for a vote: >> >> Git Branch and Commit SH: >>

Re: keep stable, stable

2015-06-21 Thread Daan Hoogland
ry. I realize that everyone has their own motivations, timelines, > commitments, and pressure to get improvements into the code base, but I > just don't think point releases are the place for most of these, and I > don't see anyone else pushing back, so I figure I need to get the

Re: Jenkins build is back to normal : build-master-slowbuild #1616

2015-06-20 Thread Daan Hoogland
victory is imminent, We have 164 to go. most of them are the encoding kind which are mostly boring. The others will require thinking (maybe). Also we have a coverage report again. let's focus on getting coverage up :) On Sat, Jun 20, 2015 at 1:19 PM, wrote: > See

Re: keep stable, stable

2015-06-19 Thread Daan Hoogland
On Fri, Jun 19, 2015 at 8:31 PM, Marcus wrote: > Why are we touching 4.5 branch with anything other than known bugfixes? Please don't say this is not a bug, Marcus. have a good look at what it does! I had complaints on it responding counter intuitively and it is in all versions. -- Daan

Re: Build failed in Jenkins: simulator-singlerun #1271

2015-06-19 Thread Daan Hoogland
issues.jenkins-ci.org/browse/JENKINS-22682 > > > > >> On Fri, Jun 19, 2015 at 2:08 PM, Daan Hoogland >> wrote: >>> >>> just a guess, sorry >>> >>> On Fri, Jun 19, 2015 at 2:02 PM, Rafael Fonseca >>> wrote: >>> > But

Re: Build failed in Jenkins: simulator-singlerun #1271

2015-06-19 Thread Daan Hoogland
Prasanna, If you are still on this list, can you help me getting the jenkins-slave-node 'simulator' back on track? It seems there is an issue with the rights on files in the .git directory of the working dirs of some of the jobs. thanks On Fri, Jun 19, 2015 at 12:50 PM, wrote: > See

[VOTE] release candidate 4.4.4 (4.4-RC20150618T1117)

2015-06-18 Thread Daan Hoogland
Hi All, I've created a 4.4.4 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20150618T1117 Commit: 6f41061e1428527c3f826d268377557ce607196b List of changes: https://git-wip-us.ap

Re: [VOTE] release candidate 4.4.4 (4.4-RC20150601T1542)

2015-06-17 Thread Daan Hoogland
done something to the code that might mean it's fixed. please all have a go. I will make a new RC when in the office and some other work is done. On Tue, Jun 9, 2015 at 2:58 PM, Daan Hoogland wrote: > Sure, but I have no time right now to implement the fix for the latest > issue we

Re: 请教增添模块后访问404错误的解决方法

2015-06-17 Thread Daan Hoogland
devs, I let this message through in spite of the language. I don't fully understand Leon but to me it seems he asks how to add a module to the UI. Http://translate.google.com told me as much. Maybe someone understands better and can help him. regards, Daan 2015-06-18 5:17 GMT+02:00 leon sun : > >

Re: [GitHub] cloudstack pull request: findbugs: deal with all the encoding issu...

2015-06-17 Thread Daan Hoogland
yeah, I hate that naming convention but I'll remove the _ from the name. On Thu, Jun 18, 2015 at 5:50 AM, karuturi wrote: > Github user karuturi commented on the pull request: > > https://github.com/apache/cloudstack/pull/467#issuecomment-113027041 > > @DaanHoogland looks like you split t

devopsdays amsterdam

2015-06-17 Thread Daan Hoogland
H, Who are going, next week? -- Daan

<    6   7   8   9   10   11   12   13   14   15   >