Hi Cao,
Inside "_sort_request" function mentioned at the wiki, change the below
line
self.params.append(key + '=' + urllib.quote_plus(args[key]))
to
self.params.append( key + '=' + str.lower(urllib.quote_plus(args[key])).
*replace(**"+", "%20") *)
The time stamp parameter "2015-08-28 16:20:00
1, If you have run cloudstack build with required profile, post that go to
tools/marvin directory and run "python setup.py install", this
should install marvin on your machine.
2, If we want to create tar.gz file and copy it on to another machine, just
run python setup.py sdist, under tools/marvi
Amy,
The error message denotes that API signature generated by the client seems
to be wrong or not what cloudstack is expecting.
Follow the below link, so, basically check out the latest code from the
branch you are running this with, seems you are using 4.5.2. Once you are
done getting simulato
Hi Urvi,
Just go to ../tools/marvin directory under CS and run *"python setup.py
install".*
Regards,
Santhosh
On Tue, Jul 7, 2015 at 4:10 PM, Daan Hoogland
wrote:
> Can you try unistalling or using --upgrade in the pip command?
> If that doesn't work can you try a 4.6/master version of marvin?
gt; While you guys fix it, can you also post the link to wiki or documentation
> on it ?
>
> > On 08-May-2015, at 1:45 pm, Santhosh Edukulla <
> santhosh.eduku...@gmail.com> wrote:
> >
> > Hi Dakshesh,
> >
> > It seems no change in analysis. Is it like it h
er: @coverityScan
> *Coverity* by Synopsys
>
> From: Santhosh Edukulla
> Date: Sunday, May 3, 2015 at 11:39 PM
> To: "dev@cloudstack.apache.org"
> Cc: scan-admin
> Subject: Coverity Scan : cloudstack project
>
> Team,
>
>
> It seems Coverity Scan se
Team,
It seems Coverity Scan service has stopped analysis, since March 16, 2015.
Please check.
Regards,
Santhosh
Marcus,
If the issue is not yet fixed, let me know i will try fix it.
Regards,
Santhosh
On Wed, Apr 15, 2015 at 4:51 PM, Marcus wrote:
> Is anyone running 4.5 mgmt server in cluster setup? I've run into an
> issue where the channel between the two servers is null, and I think
> I've tracked it
Ramzi,
Use the below link to get the simulator up and running tests thereafter.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes%2C+using+Simulator
Regards,
Santhosh
On Fri, Dec 19, 2014 at 11:00 PM, Ramzi Youssefi wrote:
> Hello everyone,
>
>
pache.org/r/27611/#comment105177>
We dont need this i believe
test/integration/component/test_escalations_vpncustomergateways.py
<https://reviews.apache.org/r/27611/#comment105178>
I believe the message sould be not matching by name
- Santhosh
est/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/28437/#comment105159>
Why two asserts for same element "network_created"
- Santhosh Edukulla
On Nov. 25, 2014, 10:24 a.m., anusha bilgi wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27862/#review60774
---
Ship it!
Ship It!
- Santhosh Edukulla
On Nov. 11, 2014, 11:03
people want they can
add it later down the lane.
> On 04-Nov-2014, at 8:43 pm, Santhosh Edukulla
> wrote:
>
> Rohit,
>
> The recent fix can solve the issue, but instead if we can use apache2.conf
> for these directives and remove them from http2.conf and ssl.conf, it makes
>
...@widodh.nl]
Sent: Monday, November 03, 2014 5:27 AM
To: Santhosh Edukulla; dev@cloudstack.apache.org
Cc: shadow...@gmail.com
Subject: Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]
On 11/03/2014 10:05 AM, Santhosh Edukulla wrote:
> Team,
>
> Either of the paths are
88acc9b)
- user-ML
> On 04-Nov-2014, at 2:52 pm, Santhosh Edukulla
> wrote:
>
> There we mentioned to support only TLS1...etc through + logic
I checked again, where and how is httpd.conf used?
I think this file that is no longer used. I think very old systemvms were build
using a
Rohit,
As well, we may want to just revert the previous changes done to httpd.conf to
keep the configuration of ciphers consistent across files.
There we mentioned to support only TLS1...etc through + logic
Here, we are excluding few protocols from all.
Regards
Santhosh
__
...@shapeblue.com]
Sent: Tuesday, November 04, 2014 2:42 AM
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: Patched 4.3.1 SystemVMs (was Re: git commit: updated
refs/heads/master to 88acc9b)
> On 04-Nov-2014, at 1:02 pm, Santhosh Edukulla
> wrote:
>
> 2. TLSv1.2 is the
)
Hi again,
> On 04-Nov-2014, at 6:01 am, Santhosh Edukulla
> wrote:
>
> Apart from SSLv3, we may want to disable TLS1.0, TLS1.1, as they have similar
> vulnerabilities.
If we don’t support TLS v1.0, it will break console proxy on IE etc. Further,
what vulnerabilities do TLS v1.
Rohit,
Apart from SSLv3, we may want to disable TLS1.0, TLS1.1, as they have similar
vulnerabilities.
TLS1.2 is preferrred.
Regards,
Santhosh
From: bhais...@apache.org [bhais...@apache.org]
Sent: Monday, November 03, 2014 3:18 PM
To: comm...@cloudstack.a
Team,
Either of the paths are doing the same thing for below if else, please check.
This is observed under master.
if (srcPool.getType() != StoragePoolType.RBD) {
newDisk = destPool.createPhysicalDisk(name,
Storage.ProvisioningType.THIN, disk.getVirtualSize());
Team,
Can you please point out the areas where ssl is used in CloudStack?
EX: Agent communications, ssvm, cpvm, template download etc? as well pointers
to corresponding modules for these?
Regards,
Santhosh
We may use the below scanner to identify this vulnerability. One of our
ex-colleague has written it, its a remote, network scanner and available as
free download.
http://blog.crowdstrike.com/crowdstrike-shellshock-scanner/
Seems configurable with custom paths. Please check the note at the en
We use code generator for building all relevant api(request\response)
information under marvin/cloudstackAPI directory.
Regards,
Santhosh
On Fri, Sep 12, 2014 at 9:38 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:
> Hi,
>
> I was wondering, do we leverage a code generator at all for
, 2014, at 10:34 AM, Santhosh Edukulla
wrote:
> One small note regarding return values, if we are running tests using nose,
> then discovery, run and report is all handled by it, so in a way commands
> output depends on the nose handling success, failure and error output from
> te
Two weeks before, it was 3.12 in terms of density, now it is up by 0.0.5 pts,
We started at 3.95+, now density is almost reduced by one unit, so some good
sign i would say.
Santhosh
From: Daan Hoogland [daan.hoogl...@gmail.com]
Sent: Friday, September 05
One small note regarding return values, if we are running tests using nose,
then discovery, run and report is all handled by it, so in a way commands
output depends on the nose handling success, failure and error output from
tests, its nothing to do much with marvin.
Regards,
Santhosh
1. If we want to collect all tests applicable for simulator, use nose test
command below (just add these switches to existing nosecmd --collect-only
--with-xunit --xunit-file=/tmp/x.xml )
It will dump all the tests under directory mentioned with -w switch and
required_hardware=false(signifying s
: [PROPOSAL]: MarvinCli
On 28-Aug-2014, at 11:59 am, Santhosh Edukulla
wrote:
> Hello Team,
>
> Good Day. Iam planning to add the below change, please let me know your
> inputs.
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/MarvinCli
Nice. In case you’re interested y
Hello Team,
Good Day. Iam planning to add the below change, please let me know your inputs.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/MarvinCli
Few members have inquired the usage of marvin from cli. There were few mails on
ml, inquiring for few basic usage of marvin and its help
/santhosh/softwares/cs_master/cloudstack/.git/rebase-apply/patch:99:
trailing whitespace.
port="8080"
protocol="org.apache.coyote.http11.Http11NioProtocol"
warning: 1 line adds whitespace errors.
- Santhosh Edukulla
On Aug. 22, 2014, 11:03 a.m., Damodar R
All,
There were few issues reported under new code addition of globodns,apart from
others. For globodns, daniel, you may want to look in to them. Please check.
** CID 1232329: Explicit null dereferenced (FORWARD_NULL)
/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/Network
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24600/#review51197
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 12, 2014, 11:47
936/#comment89221>
A small typo. Change "_pyhto.." to "_pyth.."
- Santhosh Edukulla
On Aug. 21, 2014, 4:15 p.m., Damodar Reddy Talakanti wrote:
>
> ---
> This is an automatically generat
From: Ian Duffy [i...@ianduffy.ie]
Sent: Thursday, August 21, 2014 8:02 AM
To: CloudStack Dev
Subject: Re: Integration Tests on TravisCI
Santosh,
What command/flags did you use for the above test output?
On 14 August 2014 17:22, Santhosh Edukulla
wrote:
> Ian,
>
>
tps://reviews.apache.org/r/23928/#comment89198>
This check is not required
- Santhosh Edukulla
On July 25, 2014, noon, sanjeev n wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24805/#review50892
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 18, 2014, 4:42
: test_vpc_site2site_vpn | Status : SUCCESS ===
Thanks!
Santhosh
From: Santhosh Edukulla
Sent: Thursday, August 14, 2014 11:23 AM
To: dev@cloudstack.apache.org
Subject: RE: Integration Tests on TravisCI
Few test suites under smoke/misc folder say test_vm_ha
Few test suites under smoke/misc folder say test_vm_ha,test_vm_sync,
test_deploy_vm have a dependency to run only on simulator and sequentially with
no entries available in CS, these are written using simulator mocks, so if you
run along with other test suites they will fail.
with -w switch, no
ance of this logic "if possible to
shrink", start vm can still be possible with out previous if, so what check
additionally we do if or if not for previous if?
- Santhosh Edukulla
On Aug. 14, 2014, 10:42 a.m., John Dilley wrote:
>
> --
org/r/24696/#comment88433>
Test case pass\fail depends upon the previous if, then it will pass even
with out going to the previous if? As well, the test case in itself is not
clear as what we are trying to achieve?
- Santhosh Edukulla
On Aug. 14, 2014, 10:42 a.m., John Dilley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24695/#review50569
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 14, 2014, 10:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24550/#review50443
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 13, 2014, 10:44
tps://reviews.apache.org/r/24550/#comment88215>
This check is not required right? As well, i just pushed a similar change
to master, post the ci failure. Please check.
- Santhosh Edukulla
On Aug. 13, 2014, 10:42 a.m., Alex Brett
/integration/smoke/test_primary_storage.py:146
error: test/integration/smoke/test_primary_storage.py: patch does not apply
- Santhosh Edukulla
On Aug. 11, 2014, 2:28 p.m., Alex Brett wrote:
>
> ---
> This is an automatically generated e
> On Aug. 13, 2014, 8:13 a.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/cloudstackTestClient.py, line 348
> > <https://reviews.apache.org/r/24544/diff/1/?file=657577#file657577line348>
> >
> > Make listall as keyword argument, instead of alw
tps://reviews.apache.org/r/24544/#comment88210>
Make listall as keyword argument, instead of always making it to set to
true.
- Santhosh Edukulla
On Aug. 11, 2014, 10:20 a.m., Gaurav Aradhye wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24547/#review50311
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 11, 2014, 12:14
tps://reviews.apache.org/r/24589/#comment87985>
This is not required, may be going ahead we can remove this.
- Santhosh Edukulla
On Aug. 12, 2014, 5:42 a.m., sanjeev n wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24589/#review50295
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 12, 2014, 5:42
che.org/r/23610/#comment87791>
same here and at other places, it will reduce no of lines
- Santhosh Edukulla
On Aug. 11, 2014, 5:38 a.m., sanjeev n wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24502/#review50029
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 8, 2014, 12:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24378/#review49884
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 7, 2014, 7:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24383/#review49878
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 6, 2014, 2:57 p.m
r both left and right hand vlaue.
- Santhosh Edukulla
On Aug. 6, 2014, 2:58 p.m., John Dilley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24298/#review49871
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 7, 2014, 6:19 a.m
.apache.org/r/24298/
> ---
>
> (Updated Aug. 6, 2014, 12:33 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-
views.apache.org/r/24232/
> ---
>
> (Updated Aug. 5, 2014, 12:58 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Remov
tps://reviews.apache.org/r/24298/#comment87033>
why we need a new tag?
- Santhosh Edukulla
On Aug. 5, 2014, 3:13 p.m., Gaurav Aradhye wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
views.apache.org/r/24302/
> ---
>
> (Updated Aug. 5, 2014, 12:04 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7241
> https://issues.apache.org/jira/browse/CLOUDSTACK-7241
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/#review49589
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 5, 2014, 9:45 a.m
> On Aug. 5, 2014, 12:01 p.m., Santhosh Edukulla wrote:
> > Ship It!
Please change the branch to master, its still open for commits, pushed to
master.
64b9ca0..c76302c master -> master
- Santhosh
---
This is an a
> On Aug. 5, 2014, 10:41 a.m., Santhosh Edukulla wrote:
> > Ship It!
dfa607f..2109418 master -> master
- Santhosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24301/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24301/#review49582
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 5, 2014, 10:02
Post the proposal vote, we should have given some time buffer, or prior
intimation of a day or two before this switch i believe. There were still
people using master till today for their development purpose, holding on it at
sudden may not be appropriate.
Regards,
Santhosh
_
> On Aug. 5, 2014, 9:31 a.m., Santhosh Edukulla wrote:
> > Ship It!
Pushed to master
Updated Branches:
refs/heads/master 1bfb1f650 -> cc725e53e
- Santhosh
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49578
---
Ship it!
Ship It!
- Santhosh Edukulla
On July 31, 2014, 5:57
its in plan. Any upload
of marvin to external package download system will tie this dependency on
pom.xml.
- Santhosh Edukulla
On Aug. 4, 2014, 4:08 p.m., Leo Simons wrote:
>
> ---
> This is an automatically generated e-mail.
> On Aug. 4, 2014, 11:59 a.m., Santhosh Edukulla wrote:
> > Ship It!
acffe5a..b73fe32 master -> master
- Santhosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23924/#review49451
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 4, 2014, 11:56
/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/23924/#comment86527>
Please check if static is required here.
- Santhosh Edukulla
On Aug. 4, 2014, 11:42 a.m., Damodar Reddy Talakanti wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/#review49447
---
Ship it!
Ship It!
- Santhosh Edukulla
On July 31, 2014, 2:58
> On Aug. 4, 2014, 4:35 a.m., Santhosh Edukulla wrote:
> > John,
> >
> > 1. Just mark the open issues as resolved.
> > 2. As well, mention the branch information to which it need to be applied.
> >
> > Santhosh
Hi John,
Sorry, iam getting trailing whi
well, mention the branch information to which it need to be applied.
Santhosh
- Santhosh Edukulla
On Aug. 1, 2014, 7:13 p.m., John Dilley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote:
> > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java,
> > line 547
> > <https://reviews.apache.org/r/24111/diff/2/?file=646948#file646948line547>
> >
> > It see
Build on latest master was found to be failing, related to unused imports logs
below, removed them and pushed the change. It went fine thereafter. Please
check.
==
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
cloud-plugin-storage-volume-default
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24185/#review49353
---
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 1, 2014, 4:23 p.m
ror and do a lower conversion string comparison.
- Santhosh Edukulla
On Aug. 1, 2014, 1:43 p.m., John Dilley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
n Fri, Aug 1, 2014 at 2:17 PM, Daan Hoogland wrote:
> On Fri, Aug 1, 2014 at 2:10 PM, Santhosh Edukulla
> wrote:
>> import requests
>> print requests.__version__
>> print requests.__path__
>
>
> seems fine:
>
> \\ebi\daan:~/cloudstack-4.4/cloudstack (4.4)&
I just built cs master and ran python setup.py install under tools/marvin
folder, i could see that requests version 2.3.0 is properly validated.
=Logs==
Using /usr/local/lib/python2.7/dist-packages/paramiko-1.14.0-py2.7.egg
Searching for requests==2.3.0
Best match: request
/BrocadeVcsApi.java
<https://reviews.apache.org/r/24111/#comment86298>
It seems there is no corresponding catch here, did compilation worked?
- Santhosh Edukulla
On July 31, 2014, 5:57 p.m., Ritu Sabharwal wrote:
>
> ---
1. yes, test cases currently run in parallel in ci environment, using parallel
nose commands.
2. There were few hard codings for sleep, where we removed at some places,
still there could be few\many out there.
3. 1 sec sleep and poll check is too heavy i believe, for async. So, worst a
test c
Another issue is does the test case does not hold for hyperv or test case
code is not applicable? If test case code only, then a different addition for
hyperv is required?
- Santhosh Edukulla
On July 28, 2014, 2:17 p.m., John
All,
Iam not sure if it is already available, so i added a simple wiki with few
notes for new submission and review process at the link below.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Code+Submission+and+Review+Guidelines
In case, if there are any issues with the wiki, please feel
sor plugins. To build simulator code use refer to [1].
>>
>> -Koushik
>>
>> [1]
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ
>> r
>> ation
>>
>> -Original Message-
>> From: Santhosh Edukulla [mailto:santhosh.eduku.
quired.
- Santhosh Edukulla
On July 30, 2014, 7:44 p.m., Ritu Sabharwal wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
AS well, the way we build simulator for deploying its db is different , all
packaging scripts needs to be changed and a potential testing involved .
Santhosh
From: Santhosh Edukulla
Sent: Thursday, July 31, 2014 12:05 AM
To: dev@cloudstack.apache.org
, there is a better way suggested by Daan to
auto close resources using try-with-resource to avoid any of these usages.
- Santhosh Edukulla
On July 30, 2014, 7:44 p.m., Ritu Sabharwal wrote:
>
> ---
> This is an automatically gener
as well along with other hypervisor plugins. To build
simulator code use refer to [1].
-Koushik
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration
-Original Message-
From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com]
Sent: Wednesday, 30 July 2014
I just logged a bug for the same.
https://issues.apache.org/jira/browse/CLOUDSTACK-7204
Santhosh
From: Santhosh Edukulla
Sent: Wednesday, July 30, 2014 5:56 AM
To: dev@cloudstack.apache.org
Cc: Anthony Xu
Subject: Simulator on master is not building
I
I believe for every check-in we decided to run sanity tests on simulator
atleast, currently build for simulator is failing.
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (defa
>>> On 28 jul. 2014, at 14:20, Rohit Yadav
>>>>>>>
>>>>>>wrote:
>>>>>> Hi,
>>>>>>>> I think since the Marvin package tightly depends on CloudStack, it's
>>>>>>>>
I believe no, atleast the latest changes under master or 4.4-forward.
Santhosh
From: Ian Duffy [i...@ianduffy.ie]
Sent: Sunday, July 27, 2014 4:47 PM
To: CloudStack Dev; Santhosh Edukulla; Prasanna Santhanam
Subject: Marvin Package?
Hi,
Do we have a
I just pushed individual commits, so all should be in.
Santhosh
From: Santhosh Edukulla
Sent: Thursday, July 24, 2014 5:05 AM
To: dev@cloudstack.apache.org; Santhosh Edukulla
Subject: RE: Failed add KVM agent to CS with latest master
Agree. I decided to
AM
To: dev; Santhosh Edukulla
Subject: Re: Failed add KVM agent to CS with latest master
On Thu, Jul 24, 2014 at 12:12 AM, Amogh Vasekar
wrote:
> 4523490d44160b054de9e943f72db1d0ce06054a
Another big coverity fix reverted Santhosh. Could you split this one
as well. A shame if all that work
its not the nose version, its the Marvin plugin which has change.
It was changed in 4.4-forward and master
From: Luis Henrique Okama [ok...@corp.globo.com]
Sent: Wednesday, July 23, 2014 1:25 PM
To: dev@cloudstack.apache.org
Cc: Santhosh Edukulla; Daan
> On July 23, 2014, 2:58 p.m., Santhosh Edukulla wrote:
> > Ship It!
Pushed the patch to master: 9f4f921..bb1c70b master -> master
One small note though. Please add branch and bug information to review requests.
- Santhosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23847/#review48509
---
Ship it!
Ship It!
- Santhosh Edukulla
On July 23, 2014, 12:17
> On July 23, 2014, 12:05 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinInit.py, line 114
> > <https://reviews.apache.org/r/23847/diff/1/?file=640532#file640532line114>
> >
> > please use is not None, rather !=
>
> Miguel Ferreira wrote:
g/r/23847/#comment85134>
please use is not None, rather !=
- Santhosh Edukulla
On July 23, 2014, 11:56 a.m., Miguel Ferreira wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinLog.py, line 168
> > <https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168>
> >
> > Make it more abstract and see if is not aware of cfg(log_cfg), i me
1 - 100 of 557 matches
Mail list logo
