GitHub user koushik-das reopened a pull request:
https://github.com/apache/cloudstack/pull/1251
CLOUDSTACK-9180: Optimize concurrent VM deployment operation on same â¦
â¦network
Check if VR needs to be allocated for a given network and only acquire lock
if required
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219945994
@DaanHoogland Not able to see diffs for NetscalerResource.java, are the
changes mostly related to adding 'final' keyword? Provided some comments, re
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63655432
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63655061
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-219696525
@anshul1886 @anshulgangwar Can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219692208
@nvazquez I am not too familiar with the VMware specific code, rest of the
code looks ok.
Also a comment on #1361 when this feature was initially added
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63494164
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219400690
@rhtyd While the change looks simple, what happens in case there are say >
1K hosts, > 10K VMs with this fix?
---
If your project is set up for it, y
I am also seeing the same failure happening randomly. OS X El Capitan 10.11.4.
Results :
Tests in error:
NioTest.testConnection:152 » TestTimedOut test timed out after 6
milliseco...
Tests run: 200, Failures: 0, Errors: 1, Skipped: 13
From: Tutko
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-218129820
Looks like nfs version is only supported for VMware. If XS or KVM clusters
are added to the zone (having nfs version set on image store) will there be any
side
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62652337
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -984,7 +984,8 @@ public
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62651265
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r62649582
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
---
@@ -638,7 +638,9 @@ protected Void
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218051058
LGTM, ran the new tests.
Test listing Volumes using 'ids' parameter ... === TestName:
test_01_list_volumes | Status : SUCCESS ===
o
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218048625
@nvazquez My bad, didn't look at the changes. Thanks for the fixing the
tests.
---
If your project is set up for it, you can reply to this email and have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-218048251
@swill The failures doesn't look related to this PR. This can be merged.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218047244
@swill As I had mentioned in my last comment, newly added tests are not
tagged. The command you used to run these tests has tags, don't pass any tags
in
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-217809810
@swill This has the required LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-217798010
Thanks @rafaelweingartner for the updated PR.
LGTM based on code review and verification of PR on simulator.
---
If your project is set up for it, you can
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r62456186
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -0,0 +1,293 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r62456142
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -0,0 +1,293 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-217789291
@nvazquez The test results show that it took ~20mins to complete. Why list
tests are taking so long?
Some observations:
- Tests are not tagged, please
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-217082822
@serg38 LGTM. Verified on my test env.
@swill This is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-216847988
LGTM. Verified that a configuration entry is added with default 8 as pool
size. Increased the default threadpool size, restarted MS and verified that
when
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r62006414
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216785465
LGTM. Verified before and after fix and things are working as expected. The
integration test works fine and properly cleans up stuff on completion.
---
If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216751340
I am getting this error during deploy DB "Specified key was too long; max
key length is 767 bytes". I have provided another inline comment in the code
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r61992331
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,26 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r61844330
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1522#issuecomment-215407693
LGTM. Verified in api.log that job id is getting appended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215389142
+1 on the feature. Based on testing done on the simulator with root admin
and normal user for a few APIs
+0 on the immediate removal of command.properties
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215372191
LGTM. Had already given one earlier based on simulator testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/927#issuecomment-215366546
@karuturi Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/928#issuecomment-215366187
@karuturi Any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-215365287
@SudharmaJain Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-215364487
Changes LGTM.
@swill This can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1282#issuecomment-215350146
@anshul1886 The fix is only for XS snapshots. What about other HVs?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1270#issuecomment-215348912
Changes LGTM. UI changes so CI results doesn't matter.
@anshul1886 From the fix looks like applicable to all browsers, is that
correct?
---
If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-215327572
@sureshanaparti There are some comments, please address them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1257#issuecomment-215326963
@sureshanaparti There are some open items, please address them
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1244#issuecomment-215325140
@kishankavala The changes needs to be moved to the latest sql upgrade files.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-215070344
LGTM. Verified on a simulator setup. Also the test failures from CI run are
unrelated to this change.
---
If your project is set up for it, you can reply to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1517#issuecomment-215038164
@rhtyd Thats right, setup will anyway do the upgrades.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-215026662
Code changes LGTM, verified changes in HighAvailabilityManagerImpl.java.
Someone else needs to verify KVM related changes.
---
If your project is set up for
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1517#issuecomment-215017916
Code changes LGTM.
@swill The change is in upgrade code and CI won't be able to test it. So I
think this can be merged.
---
If your project is set u
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215008749
>>That is to say that the API permissions on a fresh install before and
after this is merged should behave the same out of the box. If that's the c
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214728007
@rhtyd I think you still didn't get my point. Read the comment again. I
would like to see the option for using command.properties available for both
ne
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214707925
>>Consider this an admin creates a read-only admin role and accounts with
that (such users can only do list* calls), now if they go back to
static-check
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214296336
@rhtyd My comment regarding the test was more in the context of perf. test.
In the DB for regular user I saw ~250 permissions got created. So this means
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214269005
@rhtyd Have you ran the tests using a regular user? As per dynamic checker
code, for root admin all checks are bypassed. I think a good comparison will be
to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-214208033
@priyankparihar Are you saying that you have tested the fix in all
scenarios with different HVs (XS, KVM, Vmware)? Also if HV doesn't allow
certain opera
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-214204041
@nitin-maharana The second dialog is not going away after clicking "yes"
even though the API call is issued with forced=true. I don't think th
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-213693730
I did some basic tests yesterday. Some comments based on that. Will do some
more testing next week.
- I see that commands.properties is removed altogether
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60570949
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed
As per the build logs RAT is failing. Not sure from where this file is getting
picked up.
Unapproved licenses:
utils/testsmallfileinactive
***
From: Will Stevens
Sent: Thursday, April 21, 2016 5:27 PM
To: dev@cloudstack.ap
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212870271
@swill This is ready for merge, has the required LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-212868899
@nitin-maharana I checked the discussions on #823 as well. Looks like it is
best to remove all tag checks for selecting offering. Also there is no usage
impact
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-212853751
@shwetaag @swill As I understand from @sanju1010 comment, the script is
used to automate creation of dc, cluster and hosts in vCenter. The setup
created can
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212842361
@swill This is a test only PR. 2 LGTMs are there and the CI failures are
unrelated to the changes. This can be merged.
---
If your project is set up for it
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212832800
@priyankparihar This version check removal is at a generic place and impact
all HVs. Since you have only verified for XS 6.2 -> 6.5, there are concerns as
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1398#issuecomment-212779591
LGTM - verified on 4.7 that alignment is proper
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1399#issuecomment-212777880
LGTM - Verified on 4.7 that the dropdown shows http option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212776381
@swill This has 2 LGTMs and also CI results. The failures are unrelated as
this PR only adds new test cases and no product code changes. This can be
merged
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-212753295
@pdion891 This wasn't tested with HVM VMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60399552
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60389152
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60384825
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60383218
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60365855
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60358060
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60357104
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60356809
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60355293
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212267285
@dmabry Thanks for the fix. I ran it on simulator and it worked as
expected. So +1 on the changes. Although it existed for XenServer and Vmware, I
am trying to
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60352254
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-212265582
@nvazquez Can you add integration tests for all these APIs? Checkout
test_deploy_vm_multiple test in test/integration/smoke/test_vm_life_cycle.py
---
If your
Another way to look at it would be to make isolated network a special case of
VPC (having a single tier).
-Koushik
From: Nick LIVENS
Sent: Tuesday, April 19, 2016 2:46 PM
To: dev@cloudstack.apache.org
Subject: [DISCUSS] Network offerings for Isolated Net
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-211954088
@swill I wanted to understand if it is ok to do these fwd merges once every
week/fortnight (based on number of commits that went into the release branch)
or do
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-211943539
@swill I didn't fwd merge into 4.8 and master. Are we fwd merging for every
individual commit in order to avoid conflicts?
---
If your project is set u
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-21190
@nitin-maharana Looks like there is some problem. In confirmation dialog
when I click "yes" nothing happens and on clicking "no" the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-211864757
Merging as UI change and 2 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-211860607
@swill Again UI changes related to l10n. I think these can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1375#issuecomment-211860481
@swill Again UI changes related to l10n. I think these can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-211859221
The changes are only limited to UI, so there is no need to run
smoke/integration tests.
Cursory look at the changes looks fine.
@swill I think these
't in the commit yet.
We will put it in.
It would be useful to have a list of all the places that rely on the
internal naming convention. security_groups.py and friends is the only one
i know of off the top of my head.
On Thu, Apr 14, 2016 at 4:01 PM, Koushik Das
wrote:
> Are these the n
Are these the names that are sent to HV? For e.g. VM name in the format
i-xx-yy-VM. Currently there are functionalities that rely on the internal
naming convention. All such functionalities needs to be handled appropriately.
-Koushik
From: Jeff Hair
Sen
Based on the namespace log level can be set. It needs to be configured in the
log4j.
Check client/tomcatconf/log4j-cloud.xml.in in the source code and you will get
an idea.
-Koushik
From: williamstev...@gmail.com on behalf of Will
Stevens
Sent: Thursd
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-209830019
@ProjectMoon On latest master during VM deployment no VOLUME.CREATE is
getting generated for ROOT volume. Also during destroy there is no
VOLUME.DELETE event
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-208475514
@jburwell I am not saying FindBugs issues should be suppressed in general.
As part of fixing FindBugs issues some functionality got regressed (refer PR
heading
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-208431289
+1 based on code review and test results posted by @bvbharatk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1287#discussion_r59233185
--- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ---
@@ -200,52 +167,43 @@ public String getSecIpsString() {
return
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1287#discussion_r59231793
--- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ---
@@ -200,52 +167,43 @@ public String getSecIpsString() {
return
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-208405525
How about suppressing the findbug issue (using something like
@SuppressWarnings) till someone comes up with a proper fix? In that case there
won't be any
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58875609
--- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java
---
@@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58874658
--- Diff:
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
---
@@ -521,6 +522,76
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206461710
@swill As mentioned by @ustcweizhou in the first comment. I am not sure if
the current scale VM tests cover the dynamic offering scenario.
"
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-206250177
+1 for code changes and based on the test report from @bvbharatk.
Since the changes are specific to VMware and the test results are for XS,
not sure how to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1357#issuecomment-206245883
@bvbharatk Looks like test_01_vpc_privategw_acl has been failing for
sometime based on the report. Should this be moved to the list of known test
issues
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58672156
--- Diff:
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
---
@@ -521,6 +522,76
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58671820
--- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java
---
@@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws
201 - 300 of 926 matches
Mail list logo
