o merge 4.9.2.0 into our fork, I'm noticing that
> the Juniper Contrail plugin has an "EventUtils" class which looks for
> methods with @ActionEvent on them and them emits over the event bus. This
> does the same thing as the more-standard ActionEventUtils class. Is there a
> reaso
Hi,
In my continuing quest to merge 4.9.2.0 into our fork, I'm noticing that
the Juniper Contrail plugin has an "EventUtils" class which looks for
methods with @ActionEvent on them and them emits over the event bus. This
does the same thing as the more-standard ActionEventU
mstev...@gmail.com <williamstev...@gmail.com> on behalf of
> Will Stevens <wstev...@cloudops.com>
> *Sent:* 27 October 2016 22:50:19
> *To:* dev@cloudstack.apache.org
> *Cc:* Rohit Yadav; us...@cloudstack.apache.org
> *Subject:* Re: Disable open inactive plugins: Contrail
ctober 2016 11:13:49
To: dev@cloudstack.apache.org
Cc: Rohit Yadav; us...@cloudstack.apache.org
Subject: Re: Disable open inactive plugins: Contrail plugin
I second this. I am aware of the customers who are actively using this. In
fact, I have a PR to be merged in this area. Rather, we need
I second this. I am aware of the customers who are actively using this. In
fact, I have a PR to be merged in this area. Rather, we need to fix the build
failures
https://github.com/apache/cloudstack/pull/1715
Thanks,
Subhash
On Oct 27, 2016, at 10:50 PM, Will Stevens
tev...@gmail.com> on behalf of Will
Stevens <wstev...@cloudops.com>
Sent: 27 October 2016 22:50:19
To: dev@cloudstack.apache.org
Cc: Rohit Yadav; us...@cloudstack.apache.org
Subject: Re: Disable open inactive plugins: Contrail plugin
Just because recent builds are failing does not
Just because recent builds are failing does not really mean that no one is
using it. In my experience working with different companies who have ACS
in production, a lot of them are using much older versions of ACS (4.4 for
example). Only a subset of companies keep their ACS install "close" to
From: Wido den Hollander <w...@widodh.nl>
Sent: Thursday, October 27, 2016 6:12 AM
To: Rohit Yadav; dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: Re: Disable open inactive plugins: Contrail plugin
> Op 27 oktober 2016 om 13:00 schr
> Op 27 oktober 2016 om 13:00 schreef Rohit Yadav <rohit.ya...@shapeblue.com>:
>
>
> All,
>
>
> The Juniper contrail plugin is failing for last few hours, this plugin has
> not been maintained in last few years, except for codebase/architectural
> changes n
All,
The Juniper contrail plugin is failing for last few hours, this plugin has not
been maintained in last few years, except for codebase/architectural changes no
changes were made to the plugin itself in last 2 years.
The Jenkins failure is due to the dependency not available, further
Hi all,
I see juniper contrail plugin publishing events to message bus. It is causing a
deadlock in a specific scenario. May I know the reason for the same. The
following is the code piece I am referring to and the corresponding event is
not subscribed to far.
public void interceptComplete
Description
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation during Mgmt
server reboot
following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation during Mgmt
server reboot.
Diffs
-
api/src/com/cloud/event
Battala.
Changes
---
Fixed licenser header and created new EventTypes for serviceInstance VM create
and delete.
Thanks,
Sachin
Repository: cloudstack-git
Description
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes
/
---
(Updated May 7, 2014, 3:44 p.m.)
Review request for cloudstack and Rajesh Battala.
Repository: cloudstack-git
Description
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes
following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation during Mgmt
server reboot.
Diffs
-
api/src/com/cloud/event
.)
Review request for cloudstack and Rajesh Battala.
Repository: cloudstack-git
Description
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix
.
Repository: cloudstack-git
Description
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation
Battala.
Changes
---
.
Repository: cloudstack-git
Description
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence
Team,
We could see lot of logs generated for contrail plugin as part of build under
4.4, at the below path ( as an example ). I believe we wanted to clean them up
post our tests,running as part of build.
./plugins/network-elements/juniper-contrail/logs/testclient.log
Regards,
Santhosh
---
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation during Mgmt
server reboot.
Diffs
-
client
...@trippaers.nlmailto:h...@trippaers.nl, Animesh Chaturvedi
animesh.chaturv...@citrix.commailto:animesh.chaturv...@citrix.com, Sheng
Yang sh...@yasker.orgmailto:sh...@yasker.org, Sunil Bakhru
sbak...@juniper.netmailto:sbak...@juniper.net
Subject: Re: Event Interceptor fix - contrail plugin : Review Request
@cloudstack.apache.org
dev@cloudstack.apache.org
Subject: Re: Event Interceptor fix - contrail plugin : Review Request
Cc: Sheng Yang sh...@yasker.org,Hugo h...@trippaers.nl,Animesh Chaturvedi
animesh.chaturv...@citrix.com,Sunil Bakhru sbak...@juniper.net
Hi Darren,
Can you please review and ship
...@citrix.commailto:animesh.chaturv...@citrix.com
Subject: Re: Event Interceptor fix - contrail plugin : Review Request
I'm sorry, I thought I did this weeks ago. Do you not see the commit in
master? I'll double check, maybe I forgot to push.
Darren
From: Suresh Balineni sbalin
, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
---
Fixing troubling issues on contrail plugin related to dereference nullpoint;
adding unit tests to cover changes on the compare method on the
VirtualNetworkModel
Diffs
-
plugins/network
.
Repository: cloudstack-git
Description
---
Fixing troubling issues on contrail plugin related to dereference nullpoint;
adding unit tests to cover changes on the compare method on the
VirtualNetworkModel
Diffs
-
plugins/network-elements/juniper-contrail/src/org/apache
Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
---
Fixing troubling issues on contrail plugin related to dereference nullpoint;
adding unit tests to cover changes on the compare method on the
VirtualNetworkModel
Diffs
-
plugins/network-elements
On Feb. 14, 2014, 10:18 a.m., Wilder Rodrigues wrote:
This review will be discarded. The changes for the contrail plugin were
squashed with another commit.
A new patch will be uploaded to the review ID 18072
- Wilder
: cloudstack-git
Description
---
Fixing troubling issues on contrail plugin related to dereference nullpoint;
adding unit tests to cover changes on the compare method on the
VirtualNetworkModel
Diffs
-
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network
Hi guys,
We are working with FindBugs and trying to get Scariest and Scary bugs fixed on
the master branch.
FindBugs has reported a bug on the contrail plugin, in the VirtualMachineModel
class. If you check the Checking the commit id
cc2b1c4961244d9c3d8b452f1dcaa6614e56d11a, you will see
, Animesh Chaturvedi
animesh.chaturv...@citrix.commailto:animesh.chaturv...@citrix.com, Sheng
Yang sh...@yasker.orgmailto:sh...@yasker.org, Sunil Bakhru
sbak...@juniper.netmailto:sbak...@juniper.net
Subject: Re: Event Interceptor fix - contrail plugin : Review Request
Hi Darren,
Can you review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17684/#review33636
---
Ship it!
Applied to MASTER.
Thanks.
- Sheng Yang
On Feb. 4,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17684/
---
Review request for cloudstack.
Repository: cloudstack-git
Description
.
Repository: cloudstack-git
Description
---
VPC Element implementation in contrail plugin
Diffs
-
api/src/com/cloud/network/Network.java 62151a4
plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml
4614af7
---
Hi Sheng,
I have created a new diff with your suggested changes.
Please review the same.
Thanks,
Suresh
Repository: cloudstack-git
Description
---
VPC Element implementation in contrail plugin
Diffs (updated)
-
api/src/com/cloud/network/Network.java 62151a4
plugins
.)
Review request for cloudstack.
Repository: cloudstack-git
Description
---
VPC Element implementation in contrail plugin
Diffs
-
api/src/com/cloud/network/Network.java 62151a4
plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail
: Sachchidanand Vaidya vaidy...@juniper.net
Date: Wed Jan 8 00:26:46 2014 -0800
These are additional fixes to make Juniper Contrail plugin work
- Hugo Trippaers
On Jan. 24, 2014, 8:06 a.m., Sachchidanand Vaidya wrote
---
These are additional fixes to make Juniper Contrail plugin work on ACS master
Diffs
-
plugins/network-elements/juniper-contrail/pom.xml ae6961e
plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties
PRE-CREATION
plugins/network
---
VPC Element implementation in contrail plugin
Diffs
-
api/src/com/cloud/network/Network.java 62151a4
plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml
4614af7
plugins/network-elements/juniper-contrail/src/org/apache
---
These are additional fixes to make Juniper Contrail plugin work in ACS4.3.
These changes were missed during last commit
Diffs
-
plugins/network-elements/juniper-contrail/pom.xml 22167fe
plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties
/
---
(Updated Jan. 16, 2014, 6:53 p.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
---
These are additional fixes to make Juniper Contrail plugin work in ACS4.3.
These changes were missed during last
Agreed - there seems to be a ton being dumped into the contrail
plugin. If it wasn't working by feature freeze then we should wait. If
all of these are bugfixes, I'd expect to see more bugs filed and
referenced in commits, but instead have been seeing commits that seem
to expand the functionality
Hi Hugo,
These fixes are blocker for contrail plugin. We missed this fix while
submitting patches to ACS.
Thanks,
Sachin
From: Hugo Trippaers
htrippa...@schubergphilis.commailto:htrippa...@schubergphilis.com
Reply-To: Hugo Trippaers
htrippa...@schubergphilis.commailto:htrippa
.)
Review request for cloudstack.
Repository: cloudstack-git
Description
---
Contrail plugin fixes
- this patch is already applied to 4.3
- a master branch patch.
Diffs
-
api/src/com/cloud/network/Network.java 2197c2b
plugins/network-elements/juniper
/
---
(Updated Jan. 12, 2014, 12:08 a.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
---
Contrail plugin fixes.
- db updates must be done inside a transaction.
- network policy port end type error.
- default host contrail vnc is set to local host
, 2014, 1:02 a.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
---
Contrail plugin fixes
- this patch is already applied to 4.3
- a master branch patch.
Diffs
-
api/src/com/cloud/network/Network.java 0b76789
plugins/network
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/#review31802
---
Looks good to me, but cannot applied to the latest MASTER branch(I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
---
(Updated Jan. 14, 2014, 9:44 p.m.)
Review request for cloudstack.
Changes
Hi Sheng,
I have updated the review with changes based off latest on ACS master.
Thanks Best Regards,
Sachin
On 1/14/14 1:25 PM, Sheng Yang sh...@yasker.org wrote:
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16841/#review31810
---
Ship it!
Applied to 4.3 branch.
Thanks.
- Sheng Yang
On Jan.
---
Hi Sheng,
I updated the fix without db transaction wrappers.
This is a 4.3 version of patch.
Please review and ship it.
Thanks,
Suresh
Repository: cloudstack-git
Description
---
Contrail plugin fixes.
- db updates must be done inside a transaction.
- network policy port end type
Thanks Sheng.
Best Regards,
Sachin
On 1/14/14 1:56 PM, Sheng Yang sh...@yasker.org wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/#review31812
.
By Suresh Balineni.
Updated Jan. 14, 2014, 10:56 p.m.
Repository: cloudstack-git
Description
Contrail plugin fixes
- this patch is already applied to 4.3
- a master branch patch.
Testing
compiled and verified locally
Diffs
* api/src/com/cloud/network/Network.java (0b76789
, 2014, 10:56 p.m.*
*Repository: *cloudstack-git
Description
Contrail plugin fixes
- this patch is already applied to 4.3
- a master branch patch.
Testing
compiled and verified locally
Diffs
- api/src/com/cloud/network/Network.java (0b76789)
-
plugins/network-elements
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16841/
---
Review request for cloudstack.
Repository: cloudstack-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
---
(Updated Jan. 13, 2014, 5:46 a.m.)
Review request for cloudstack.
Changes
---
Contrail plugin fixes.
- db updates must be done inside a transaction.
- network policy port end type error.
- default host contrail vnc is set to local host. This is considered if config
is not present.
Diffs
-
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16279/#review30981
---
Hi Suresh,
There is no way we can review this since it's not added
-git
Description
---
Contrail Virtual Router Controller is expecting virtual network name should
have a fully qualified name while creating a Network Policy in the
controller.
This fix is only applicable to contrail plugin.
Diffs
-
Diff: https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16279/#review30983
---
And this fix involved VPC, which I don't think would be contained
creating a Network Policy in the
controller.
This fix is only applicable to contrail plugin.
Diffs
-
Diff: https://reviews.apache.org/r/16276/diff/
Testing
---
Network Policy creation on Contrail router is verified.
File Attachments
Contrail
---
Contrail Virtual Router Controller is expecting virtual network name should
have a fully qualified name while creating a Network Policy in the controller.
This fix is only applicable to contrail plugin.
Diffs
-
Diff: https://reviews.apache.org/r/16276/diff/
Testing
---
Network
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16279/
---
Review request for cloudstack.
Repository: cloudstack-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16279/
---
(Updated Dec. 15, 2013, 11:57 p.m.)
Review request for cloudstack.
.
Repository: cloudstack-git
Description
---
Contrail Virtual Router Controller is expecting virtual network name should
have a fully qualified name while creating a Network Policy in the controller.
This fix is only applicable to contrail plugin.
Diffs
-
Diff: https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/
---
Review request for cloudstack.
Repository: cloudstack-git
Description
to accomplish that...
The contrail plugin wants to know about project creation and deletion.
Projects need to be reflected in the contrail-api server; the project
delete notification is necessary to understand that the project is not
longer used.
When it comes to network objects it would also
if the JVM dies,
you won't be called. I know this sounds nit picky, but I hate when
there is a situation that could happen that there is no recovery from.
Is it possible for the contrail plugin to on-demand register the
account/projects? So only when the element/guru/whatever is called,
you try to sync
your code to the
transaction of the API code, there is a small window if the JVM dies,
you won't be called. I know this sounds nit picky, but I hate when
there is a situation that could happen that there is no recovery from.
The contrail plugin can resynchronize itself on failure. It assumes
As stated, I've imported the contrail plugin donation into the contrail
branch.
I've taken the time to add the ASF license header to all of the new files
in that branch. I think we have to complete the following in order to
merge into master.
1) I'd like to see the package structure changed
On Tue, Oct 08, 2013 at 10:23:32AM -0400, Chip Childers wrote:
As stated, I've imported the contrail plugin donation into the contrail
branch.
I've taken the time to add the ASF license header to all of the new files
in that branch. I think we have to complete the following in order
On Tue, Oct 08, 2013 at 07:59:24PM +0530, Prasanna Santhanam wrote:
On Tue, Oct 08, 2013 at 10:23:32AM -0400, Chip Childers wrote:
3) I'd love if we could get some consensus on what additional tests and /
or changes to the test approach are needed. Prasanna - as with Hugo and
Chiradeep,
On Oct 8, 2013, at 7:36 AM, Chip Childers wrote:
On Tue, Oct 08, 2013 at 07:59:24PM +0530, Prasanna Santhanam wrote:
On Tue, Oct 08, 2013 at 10:23:32AM -0400, Chip Childers wrote:
3) I'd love if we could get some consensus on what additional tests and /
or changes to the test approach are
Chip,
On Oct 8, 2013, at 7:23 AM, Chip Childers wrote:
As stated, I've imported the contrail plugin donation into the contrail
branch.
I've taken the time to add the ASF license header to all of the new files in
that branch. I think we have to complete the following in order to merge
On Tue, Oct 08, 2013 at 09:43:39AM -0700, Pedro Roque Marques wrote:
Chip,
On Oct 8, 2013, at 7:23 AM, Chip Childers wrote:
As stated, I've imported the contrail plugin donation into the contrail
branch.
I've taken the time to add the ASF license header to all of the new files
I'll take some time and review this code too. I already know there's
going to be a conflict with the stuff I did in the spring
modularization branch. Moving to full spring we have gotten rid of
the custom ACS AOP for the mgmt server. This code relies on that
framework so it will have to move to
Darren,
Using ActionEvents is not desirable for the plugin either... today CloudStack
lacks the ability for a component/plugin to associate itself to the life-cycle
of an object. It would be ideal if there was a generic way to accomplish that...
The contrail plugin wants to know about project
...@apache.org -
Date: Fri, 4 Oct 2013 13:50:47 -0400
From: Chip Childers chipchild...@apache.org
To: gene...@incubator.apache.org
Subject: [IP CLEARANCE] Contrail Plugin for CloudStack
Message-ID: 20131004175047.gg88...@uslt-205755.sungardas.corp
Juniper Networks, Inc has dontated a plugin
With 13 +1 votes, and no other votes, this passes.
I'll work with Pedro and Juniper to complete the donation.
-chip
On Wed, Sep 25, 2013 at 01:13:07PM -0400, Chip Childers wrote:
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack
+1
On Sep 26, 2013, at 12:17 AM, Francois Gaudreault fgaudrea...@cloudops.com
wrote:
Definitely +1 on this :)
Francois
On 2013-09-25 1:13 PM, Chip Childers wrote:
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack
+1
2013/9/25 Chip Childers chipchild...@apache.org
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack. The code itself has been posted
to reviewboard [1]. The design has been documented by Pedro [2].
[1] https
+1.
- Original Message -
From: Chip Childers chipchild...@apache.org
To: dev@cloudstack.apache.org
Sent: Wednesday, September 25, 2013 12:13:07 PM
Subject: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack
Hi all!
As stated in other threads, Juniper
+1 (binding) on donation
-Original Message-
From: Chip Childers [mailto:chipchild...@apache.org]
Sent: Wednesday, September 25, 2013 10:13 AM
To: dev@cloudstack.apache.org
Subject: [VOTE] Accept the donation of a Contrail plugin into Apache CloudStack
Hi all!
As stated in other threads
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack. The code itself has been posted
to reviewboard [1]. The design has been documented by Pedro [2].
[1] https://reviews.apache.org/r/14325/
[2]
https://cwiki.apache.org/confluence
!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack. The code itself has been posted
to reviewboard [1]. The design has been documented by Pedro [2].
[1] https://reviews.apache.org/r/14325/
[2]
https://cwiki.apache.org/confluence/display
+1 for accepting the donation
-Original Message-
From: Chip Childers [mailto:chipchild...@apache.org]
Sent: Wednesday, September 25, 2013 10:13 AM
To: dev@cloudstack.apache.org
Subject: [VOTE] Accept the donation of a Contrail plugin into Apache
CloudStack
Hi all!
As stated
+1 (binding)
On 9/25/13 10:13 AM, Chip Childers chipchild...@apache.org wrote:
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack. The code itself has been posted
to reviewboard [1]. The design has been documented by Pedro [2].
[1
+1(binding)
-Original Message-
From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
Sent: Wednesday, September 25, 2013 5:23 PM
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Accept the donation of a Contrail plugin into Apache
CloudStack
+1 (binding)
On 9/25/13 10
+1
On Wed, Sep 25, 2013 at 10:13 AM, Chip Childers chipchild...@apache.org wrote:
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack. The code itself has been posted
to reviewboard [1]. The design has been documented by Pedro [2
Definitely +1 on this :)
Francois
On 2013-09-25 1:13 PM, Chip Childers wrote:
Hi all!
As stated in other threads, Juniper is proposing the donation of a
Contrail plugin to Apache CloudStack. The code itself has been posted
to reviewboard [1]. The design has been documented by Pedro [2].
[1
90 matches
Mail list logo
