On Mon, Feb 3, 2014 at 7:55 AM, Rajani Karuturi
rajani.karut...@citrix.com wrote:
you please do it on 4.3-forward and master as well.
I'll do it on 4.3-forward and I'll be on all findbugs issues on master
so it'll pass by automatically
...@citrix.com]
Sent: Tuesday, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+
commits from
Daan show many formatting changes that may not be necessary and
hinder
quick review.
-Original
On Sun, Feb 2, 2014 at 12:48 PM, Rajani Karuturi
rajani.karut...@citrix.com wrote:
what we should use is new String(bytes[])
ok, makes sense. Can you revert my commit and make a new patch?
thanks,
Daan
never mind, I thought you are committer. I'll fix
On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi
rajani.karut...@citrix.com wrote:
Sure Daan. Will submit a review request for master and 4.3-forward tomorrow
morning IST.
Thanks,
~Rajani
On 02-Feb-2014, at 8:17 pm, Daan Hoogland
Daan,
Have this done already, just about to push.
On 2 February 2014 18:47, Daan Hoogland daan.hoogl...@gmail.com wrote:
never mind, I thought you are committer. I'll fix
On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi
rajani.karut...@citrix.com wrote:
Sure Daan. Will submit a review
just pushed :(
On Sun, Feb 2, 2014 at 7:50 PM, Ian Duffy i...@ianduffy.ie wrote:
Daan,
Have this done already, just about to push.
On 2 February 2014 18:47, Daan Hoogland daan.hoogl...@gmail.com wrote:
never mind, I thought you are committer. I'll fix
On Sun, Feb 2, 2014 at 6:52 PM,
Hi Daan/Ian,
looks like the change is only in 4.3. Can you please do it on 4.3-forward and
master as well.
Thanks,
~Rajani
On 03-Feb-2014, at 12:21 am, Daan Hoogland daan.hoogl...@gmail.com wrote:
just pushed :(
On Sun, Feb 2, 2014 at 7:50 PM, Ian Duffy i...@ianduffy.ie wrote:
Daan,
or not ?
The point is there may be unintended risks in allowing late
changes.
-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Tuesday, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+
commits from
Daan show many formatting changes that may not be necessary and
hinder
quick review.
-Original Message-
From: Hugo Trippaers [mailto:trip
or not ?
The point is there may be unintended risks in allowing late changes.
-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Tuesday, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all
, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+ commits from
Daan show many formatting changes that may not be necessary and hinder
quick review.
-Original Message-
From
@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+
commits from
Daan show many formatting changes that may not be necessary and
hinder
quick review.
-Original Message-
From: Hugo Trippaers [mailto:trip
-
From: Ian Duffy [mailto:i...@ianduffy.ie]
Sent: Tuesday, January 28, 2014 6:34 PM
To: CloudStack Dev
Subject: RE: Findbugs report on 4.3-forward
Hi Animesh,
Tested all those changes to detail. Those lines were removed due to
unexpected behavior that I had not spotted until now.
[Animesh
:
-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie]
Sent: Tuesday, January 28, 2014 6:34 PM
To: CloudStack Dev
Subject: RE: Findbugs report on 4.3-forward
Hi Animesh,
Tested all those changes to detail. Those lines were removed due to
unexpected behavior that I had
PM
To: CloudStack Dev
Subject: RE: Findbugs report on 4.3-forward
Hi Animesh,
Tested all those changes to detail. Those lines were removed due to
unexpected behavior that I had not spotted until now.
[Animesh] That's what my worry is there may be unintended changes. I
suspect this one
animesh.chaturv...@citrix.com wrote:
-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie]
Sent: Tuesday, January 28, 2014 6:34 PM
To: CloudStack Dev
Subject: RE: Findbugs report on 4.3-forward
Hi Animesh,
Tested all those changes to detail. Those lines were removed due
On Wed, Jan 29, 2014 at 5:47 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
and
caf17c2f46bf317ec8966b08aaff728a73fda14a
never mind that last one, i was in a hury and screwed up. will revert
please pull d38a50343130f6f147e2c9c7b2e32a43f31c7e6b to 4.3
this one came out of our regression testing, I hope other people are
keeping up the testing as well in spite of all the discussion on the
RC!!!
thanks for your patience Animesh,
Daan
On Wed, Jan 29, 2014 at 5:55 PM, Daan Hoogland
On Tue, Jan 28, 2014 at 11:36:52PM +0100, Hugo Trippaers wrote:
Hey Animesh,
Not in agreement here. These are squashed bugs and we want as less bugs in
the release as possible.
This is why we test any RC before we release it. I say include all the big
fixes we have in the release. If
I agree that quality should be our primary focus. My one point of caution
here would be, How risky are these fixes?
Just because we believe we have fixes for issues does not necessarily mean
they should be put in a release late in the game. We have to weigh the
benefits of having the fixes versus
-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
Sent: Wednesday, January 29, 2014 11:15 AM
To: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
I agree that quality should be our primary focus.
[Animesh] No one would disagree
another RC today.
Animesh
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, January 29, 2014 8:47 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
The first five I allready posted. The ones between brackets seem minor to me.
Then again
good point Mike,
I would like to add that in our case 'quality' means 'usability'. We
are not writing military or madical grade code. However I don't want
to tell a big far eastern telco that their it is out because i left an
== in the code that was meant to be an equals() call, or a leak
because
On Wed, Jan 29, 2014 at 8:48 PM, Animesh Chaturvedi
animesh.chaturv...@citrix.com wrote:
Instant gratification on fixing something is trumping managing risk.
I don't think I like the implication of that remark. I am sure you
mean well and are tired.
The patches are littered with formatting
To: dev
Subject: Re: Findbugs report on 4.3-forward
The first five I allready posted. The ones between brackets seem minor to me.
Then again they also pose the least risk so in my opinion you should pull
them all. The last one is a bug we found during testing (which was already
fixed in master
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, January 29, 2014 12:14 PM
To: dev
Subject: Re: Findbugs report on 4.3-forward
On Wed, Jan 29, 2014 at 8:48 PM, Animesh Chaturvedi
animesh.chaturv...@citrix.com wrote:
Instant gratification
On Wed, Jan 29, 2014 at 9:36 PM, Animesh Chaturvedi
animesh.chaturv...@citrix.com wrote:
[Animesh] I know but at this time we need closer scrutiny and just the
specific change helps in that. There was a similar comment in private when
some of us were reviewing security patches.
point taken
On Wed, Jan 29, 2014 at 9:50 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
and will the push
and will then push
H Animesh,
I am done cherry-picking, compiling and pushing.
I wonder if now is opportune to build a new rc. shouldn't we wait till
more people have tested? I for instance (doing a quarter of the test
plans that we have at Schuberg Philis) ran into some issues and am not
sure yet if they are in
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, January 29, 2014 1:06 PM
To: dev; Animesh Chaturvedi
Subject: Re: Findbugs report on 4.3-forward
H Animesh,
I am done cherry-picking, compiling and pushing.
[Animesh] Cool, I will also need
@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+ commits from
Daan show many formatting changes that may not be necessary and hinder
quick review.
-Original Message-
From: Hugo Trippaers [mailto:trip
: Monday, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions
in the code which we may not know and may get broken if these issues are
fixed late. I will pull
, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions
in the code which we may not know and may get broken if these issues are
fixed late. I will pull in the one Hugo
@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions
in the code which we may not know and may get broken if these issues are
fixed late. I will pull in the one Hugo casted his -1 for the first
...@citrix.com]
Sent: Monday, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions
in the code which we may not know and may get broken if these issues are
fixed late. I
@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions
in the code which we may not know and may get broken if these issues are
fixed late. I will pull in the one Hugo casted his -1 for the first
vote,
any others?
Animesh
Hugo's commit for which he called -1.
Thanks
Animesh
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, January 28, 2014 1:29 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
I agree with Daan here. We focussed
, January 28, 2014 1:29 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
I agree with Daan here. We focussed on the bugs with a findbugs annotation of
scariest. I think that would warrant them to be included in the 4.3 release,
so please cherry-pick them all.
Cheers
.
Thanks
Animesh
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Tuesday, January 28, 2014 1:29 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
I agree with Daan here. We focussed on the bugs with a findbugs
-Original Message-
From: Hugo Trippaers [mailto:trip...@gmail.com]
Sent: Tuesday, January 28, 2014 2:37 PM
To: dev@cloudstack.apache.org
Cc: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
Not in agreement here. These are squashed bugs and we want
Subject: Re: Findbugs report on 4.3-forward
Hey Animesh,
Not in agreement here. These are squashed bugs and we want as less bugs in
the release as possible.
[Animesh] I understand but once we enter RC phase we only limit important
fixes. I have pulled in 2 commits from yours and 1 from Daan
@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
Sent from my iPhone
On 28 jan. 2014, at 23:50, Animesh Chaturvedi animesh.chaturv...@citrix.com
wrote:
-Original Message-
From: Hugo Trippaers [mailto:trip...@gmail.com]
Sent: Tuesday, January 28, 2014 2:37 PM
To: dev
]
Sent: Tuesday, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all of the ones are needed. A quick look at 20+ commits from Daan
show many formatting changes that may not be necessary and hinder quick review.
-Original Message
To: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
Sent from my iPhone
On 28 jan. 2014, at 23:50, Animesh Chaturvedi
animesh.chaturv...@citrix.com wrote:
-Original Message-
From: Hugo Trippaers [mailto:trip...@gmail.com]
Sent: Tuesday, January 28, 2014 2
or not ?
The point is there may be unintended risks in allowing late changes.
-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Tuesday, January 28, 2014 3:35 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Are you sure all
-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie]
Sent: Tuesday, January 28, 2014 6:34 PM
To: CloudStack Dev
Subject: RE: Findbugs report on 4.3-forward
Hi Animesh,
Tested all those changes to detail. Those lines were removed due to unexpected
behavior that I had
branch. Are
their specific commits you want me to pick up out of these?
Animesh
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Sunday, January 26, 2014 2:41 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
I didn't get very far last night
[mailto:daan.hoogl...@gmail.com]
Sent: Sunday, January 26, 2014 2:41 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
I didn't get very far last night and will be looking at the server package
again this afternoon.
bon appétit,
On Sun, Jan 26, 2014 at 1:36 AM, Ian Duffy i...@ianduffy.ie wrote
a number of commits 20+ into 4.3-forward branch. Are
their specific commits you want me to pick up out of these?
Animesh
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Sunday, January 26, 2014 2:41 AM
To: dev
Subject: Re: Findbugs report on 4.3-forward
On Mon, Jan 27, 2014 at 2:58 PM, Hugo Trippaers trip...@gmail.com wrote:
Hey David,
As always you are completely right.
I plan on referring to this message alot in the future. Especially in
discussions with my wife. :)
I feel a bit bad about getting the findbugs report through at the last
[mailto:da...@gnsa.us]
Sent: Monday, January 27, 2014 11:46 AM
To: dev@cloudstack.apache.org
Subject: Re: Findbugs report on 4.3-forward
So just curious if I am the only one concerned about a ton of fixes going in at
the last minute. If the fixes are for serious bugs and we have consensus around
: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Monday, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions in the
code which we may not know and may get
Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Monday, January 27, 2014 1:30 PM
To: dev@cloudstack.apache.org
Subject: RE: Findbugs report on 4.3-forward
Agreed
We need to fix the most important ones for 4.3. There may be assumptions
in the code which we may not know and may get broken
I didn't get very far last night and will be looking at the server
package again this afternoon.
bon appétit,
On Sun, Jan 26, 2014 at 1:36 AM, Ian Duffy i...@ianduffy.ie wrote:
Hi,
Fixed the issues highlighted in the ldap user authentication package.
Have pushed to 4.3-forward.
Thanks,
H Hugo,
I'll spend some time on it tonight. Do you have a work load
distribution scheme or is it random access?
;)
regards
On Sat, Jan 25, 2014 at 12:39 PM, Hugo Trippaers h...@trippaers.nl wrote:
Hey all,
I've made Jenkins run the findbugs analysis on 4.3-forward. Is there somebody
who is
Thanks!
Random access. :-) Either push any fixes to the 4.3-forward branch for Animesh
to look at, or reply to this mail with the filename you are working on. I won’t
working on anything tonight, so feel free to go ahead without the sync.
Cheers,
Hugo
On 25 jan. 2014, at 14:13, Daan
I’ve also added a job to master with the Findbugs report and the cobertura code
coverage report.
Good stuff, we have a 12% coverage of our classes with unit tests. Huge
improvement over the last release where we had 4% iirc. We have 306 reports
from Findbugs, of which the majority are
or reply to this mail with the filename you are working on
I'll be looking at the server package as it seems to contain the most issues.
On Sat, Jan 25, 2014 at 4:00 PM, Hugo Trippaers h...@trippaers.nl wrote:
I’ve also added a job to master with the Findbugs report and the cobertura
code
Hi,
Fixed the issues highlighted in the ldap user authentication package.
Have pushed to 4.3-forward.
Thanks,
Ian
On 25 January 2014 22:26, Daan Hoogland daan.hoogl...@gmail.com wrote:
or reply to this mail with the filename you are working on
I'll be looking at the server package as it
59 matches
Mail list logo
