Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review78993 --- Thank you for submitting your CloudStack contribution through review

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review64046 --- ping, any update on this? - Rohit Yadav On July 3, 2014, 11:58 a.

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

ailto:dev@cloudstack.apache.org><mailto:dev@cloudstack.apache.org> Cc: Damoder Reddy; Koushik Das Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers mailto:chipchild...@apache.

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

ailto:dev@cloudstack.apache.org><mailto:dev@cloudstack.apache.org> Cc: Damoder Reddy; Koushik Das Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers mailto:chipchild...@apache.

RE: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

explicitly? Thanks Damoder/ -Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Thursday, 3 July 2014 9:58 PM To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org><mailto:dev@cloudstack.apache.org> Cc: Damoder Reddy; Koushik Das Subject: Re: Review Request

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

o:da...@gnsa.us] Sent: Thursday, 3 July 2014 9:58 PM To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org><mailto:dev@cloudstack.apache.org> Cc: Damoder Reddy; Koushik Das Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also i

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

Damoder/ > > -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Thursday, 3 July 2014 9:58 PM > To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org> > Cc: Damoder Reddy; Koushik Das > Subject: Re: Review Request 23192: Adding Readme a

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

Adding Readme and run checkbox at the end of the installation. Also installing mysql connector On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers mailto:chipchild...@apache.org>> wrote: On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote: It looks like that maven pom on windows _by def

RE: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

explicitly? Thanks Damoder/ -Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Thursday, 3 July 2014 9:58 PM To: dev@cloudstack.apache.org Cc: Damoder Reddy; Koushik Das Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

> On July 3, 2014, 2:18 p.m., Chip Childers wrote: > > -1 to this commit until legal policy issues are resolved Reverted the commit commit 4607c26949b6b925fdc0eb2a5253d536dd333439 Author: Koushik Das Date: Fri Jul 4 10:04:04 2014 +0530 Revert "CLOUDSTACK-6834 : 3. Some description chang

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers wrote: > On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote: >> It looks like that maven pom on windows _by default_ downloads and >> installs a variety of non-apache-license (and/or non-mit/bsd/variant >> license) software. That shouldnąt rea

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote: > It looks like that maven pom on windows _by default_ downloads and > installs a variety of non-apache-license (and/or non-mit/bsd/variant > license) software. That shouldn¹t really happen. The principle is one of > ³least surprise²: As a

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

Heya, On 7/3/14, 4:11 PM, "Chip Childers" wrote: >On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote: >> >> On to the actual point behind my comment, ASF policy is not very clear >> about when we can or can¹t put anything in our code that points to >> something with a (L)GPL license.

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47301 --- -1 to this commit until legal policy issues are resolved - Chip Chi

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

On Thu, Jul 03, 2014 at 01:37:27PM +, Koushik Das wrote: > I was about to give the "ship it" and then saw your comment. Anyways have > done it now. We are likely to need to revert (or at least change through a new commit) a bunch of things introduced within the pom and msi files. See my last

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote: > > On to the actual point behind my comment, ASF policy is not very clear > about when we can or can’t put anything in our code that points to > something with a (L)GPL license. I would like some feedback from > people with a finer g

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

I was about to give the "ship it" and then saw your comment. Anyways have done it now. On 03-Jul-2014, at 6:03 PM, Hugo Trippaers wrote: > Hey Koushik, > > No problem, will do if required. > > The review doesn’t have a “ship it” state, so thats why i assumed it was not > committed. Also a lo

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47300 --- Ship it! master -> ce5061e107f743e52b23445fd97fcf60d8160ec6 - Kous

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

On to the actual point behind my comment, ASF policy is not very clear about when we can or can’t put anything in our code that points to something with a (L)GPL license. I would like some feedback from people with a finer grasp of the policy to see if we can actually include this dependency on

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

Hey Koushik, No problem, will do if required. The review doesn’t have a “ship it” state, so thats why i assumed it was not committed. Also a lot of folks adopted the common practice to put the commit id in a comment after committing a review. That makes it easier to trace. Cheers, Hugo On 3

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote: > > I'm not sure we can actually have a dependency on the mysql connector like > > this because of it's GPL license. I'll check this and get back on this > > before we can accept this patch. > > Koushik Das wrote: > Hugo, I committed thi

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote: > > I'm not sure we can actually have a dependency on the mysql connector like > > this because of it's GPL license. I'll check this and get back on this > > before we can accept this patch. Hugo, I committed this patch (on master ce5061e10

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47289 --- I'm not sure we can actually have a dependency on the mysql connecto

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 3, 2014, 11:58 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 3, 2014, 10:22 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/#review47280 --- scripts/installer/windows/readme.txt

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23192/ --- (Updated July 2, 2014, 12:29 p.m.) Review request for cloudstack, Abhinandan Pr