I think it'd be fairly painful to make it mandatory - maybe see if we can set
that as a goal for 6 months out?
On Nov 4, 2013, at 6:29 AM, Hugo Trippaers
mailto:h...@trippaers.nl>>
wrote:
Hey,
Just added a very basic checkstyle configuration to maven. The configuration
file is in parents/che
Hey John,
That would be my idea.
Make it mandatory for new (maven) projects coming into the code base and slowly
start working on fixing the existing projects. The current checkstyle setting
is very relaxed, just a few basic checks. Stuff that we could technically fix
with a few well written
On Mon, Nov 04, 2013 at 04:33:07PM +0100, Hugo Trippaers wrote:
> Hey John,
>
> That would be my idea.
>
> Make it mandatory for new (maven) projects coming into the code base and
> slowly start working on fixing the existing projects. The current checkstyle
> setting is very relaxed, just a f
How does it compare to previous versions for CloudStack? E.g.
http://markmail.org/message/yz6qa2v47cdeic4d
> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: 04 November 2013 14:30
> To: dev@cloudstack.apache.org
> Subject: checkstyle
>
On Nov 4, 2013, at 7:54 AM, Chip Childers wrote:
> On Mon, Nov 04, 2013 at 04:33:07PM +0100, Hugo Trippaers wrote:
>> Hey John,
>>
>> That would be my idea.
>>
>> Make it mandatory for new (maven) projects coming into the code base and
>> slowly start working on fixing the existing projects.
The search-fu is weak in this one..
Did you ever get to commit that file Donal? I’d be very much interested :-)
Cheers,
Hugo
On 4 nov. 2013, at 17:48, Donal Lafferty wrote:
> How does it compare to previous versions for CloudStack? E.g.
> http://markmail.org/message/yz6qa2v47cdeic4d
>
>
>
-Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: 04 November 2013 16:54
> To: dev@cloudstack.apache.org
> Subject: Re: checkstyle
>
> The search-fu is weak in this one..
>
> Did you ever get to commit that fi
Hi,
It is great to have a code standard, it is even better when it is
maintained, but when checkstyle reports error after several minutes
building the code, while the code should be ok and it reports an issue as
important as a trailing white space, then I believe anyone would more
likely call it a
stack-java-coding.html)
DL
> -Original Message-
> From: Laszlo Hornyak [mailto:laszlo.horn...@gmail.com]
> Sent: 04 November 2013 17:49
> To: dev@cloudstack.apache.org
> Subject: Re: checkstyle
>
> Hi,
>
> It is great to have a code standard, it is even better
30 540 | M: +44 7788 423 969
alex.hitch...@shapeblue.com
-Original Message-
From: Wido den Hollander [mailto:w...@widodh.nl]
Sent: 25 March 2014 14:25
To: dev@cloudstack.apache.org
Subject: Re: Checkstyle Error
On 03/25/2014 03:19 PM, Alex Hitchins wrote:
> Thanks Wido, checking
h 2014 14:15
To: dev@cloudstack.apache.org
Subject: Re: Checkstyle Error
On 03/25/2014 03:12 PM, Alex Hitchins wrote:
I'm getting a checkstyle error on compilation.
What is the best way to see what I'm doing to cause the issue? I seem to be
just getting the project it's failing on. This is with sup
riginal Message-
From: Wido den Hollander [mailto:w...@widodh.nl]
Sent: 25 March 2014 14:15
To: dev@cloudstack.apache.org
Subject: Re: Checkstyle Error
On 03/25/2014 03:12 PM, Alex Hitchins wrote:
> I'm getting a checkstyle error on compilation.
>
> What is the best way to se
On 03/25/2014 03:12 PM, Alex Hitchins wrote:
I'm getting a checkstyle error on compilation.
What is the best way to see what I'm doing to cause the issue? I seem to be
just getting the project it's failing on. This is with supplying -e to maven to
give a stack trace. Is there anything I can
@cloudstack.apache.org
Subject: Re: Checkstyle Error
On 03/25/2014 03:12 PM, Alex Hitchins wrote:
> I'm getting a checkstyle error on compilation.
>
> What is the best way to see what I'm doing to cause the issue? I seem to be
> just getting the project it's failing on. T
I also think the way I have checkstyle configured in Eclipse causes it to
take a super long time to build. Not sure what setting I turned on to do
that, but even removing the plug-in for the time being is extremely slow
because Eclipse always wants to run checkstyle.
On Tue, Jan 14, 2014 at 12:44
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Tuesday, January 14, 2014 12:01 PM
> To: dev@cloudstack.apache.org
> Cc: Hugo Trippaers (htrippa...@schubergphilis.com)
> Subject: Re: checkstyle problems...
>
> I also think the w
>> To: dev@cloudstack.apache.org
>> Cc: Hugo Trippaers (htrippa...@schubergphilis.com)
>> Subject: Re: checkstyle problems...
>>
>> I also think the way I have checkstyle configured in Eclipse causes it to
>> take a
>> super long time to build. Not sure what setting I turn
ect. I've gotten so frustrated with it, I've
>> reverted the commit locally but I don't know checkstyle very well so I'm
>> hoping Hugo has a better solution.
>>
>> --Alex
>>
>>> -Original Message-
>>> From: Mike Tutkows
over completely. After that, I
started seeing the problems.
--Alex
> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Tuesday, January 14, 2014 11:31 PM
> To: dev
> Subject: Re: checkstyle problems...
>
> Hey guys,
&
oject files and started over completely.
> After that, I started seeing the problems.
>
> --Alex
>
> > -Original Message-
> > From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> > Sent: Tuesday, January 14, 2014 11:31 PM
> >
pse
>> workspace and removed all .project files and started over completely.
>> After that, I started seeing the problems.
>>
>> --Alex
>>
>>> -Original Message-
>>> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
&g
ved my
> eclipse
> >> workspace and removed all .project files and started over completely.
> >> After that, I started seeing the problems.
> >>
> >> --Alex
> >>
> >>> -Original Message-
> >>> From: Trippie [mailto:trip.
figure
>>>> out why Mike was seeing problems, I remembered he said he often deletes
>> the
>>>> whole workspace and started over. So I did the same. I removed my
>> eclipse
>>>> workspace and removed all .project files and started over completely.
>
I am a fan of convention and think everyone should have some. Strict
enforcing of non-functionals, I'm not to big on. I see what you want to
achieve here but am reluctant not to -1 any strictness. If we do it with a
post-commit-hook (or if such a thing exists a post-merge-hook) we will
allow for co
The checkstyle rules can be imported in pretty much any IDE to help during
coding and to display the errors immediately.
To speed up the detection of checkstyle errors, we could edit the post
commit hooks to run a mvn command only for the checkstyle rules, and then
do the usual stuff.
I'm not in f
I am in favor of that. I only have a comment to add. We are already
checking code style when validating PRs. So, it is only a matter of adding
more checks to the check-style plugin that we are already using.
On Fri, Sep 29, 2017 at 5:36 AM, Marc-Aurèle Brothier
wrote:
> The checkstyle rules can
I wonder if it wouldn’t be best to wait on this until master is in code freeze.
At that point, it seems like we could add whatever rules we’d like and have
almost no impact on pending master PRs.
For me personally, although I haven’t opened it yet, I have a large PR I plan
to open in the coming
ohw dear Mike, I am changing the log4j version, brr.
On Fri, Sep 29, 2017 at 3:11 PM, Tutkowski, Mike
wrote:
> I wonder if it wouldn’t be best to wait on this until master is in code
> freeze. At that point, it seems like we could add whatever rules we’d like
> and have almost no impact on p
That sounds like another one to wait for until code freeze. :)
On Sep 29, 2017, at 7:45 AM, Daan Hoogland
mailto:daan.hoogl...@gmail.com>> wrote:
ohw dear Mike, I am changing the log4j version, brr.
On Fri, Sep 29, 2017 at 3:11 PM, Tutkowski, Mike
mailto:mike.tutkow...@netapp.com>>
wrote:
29 matches
Mail list logo
