On Aug. 27, 2013, 2:48 p.m., Sanjay Tripathi wrote:
Looks good to me.
Thanks for the detailed review Sanjay. I've merged this to master/4.2-forward.
Gaurav, there were many formatting errors in the patch. Please verify the merge
and ensure that you've checked for formatting in your future
On Aug. 26, 2013, 10:09 a.m., Sanjay Tripathi wrote:
test/integration/component/cpu_limits/test_project_limits.py, line 275
https://reviews.apache.org/r/13001/diff/3/?file=338935#file338935line275
use listResourceLimits API to get the resource limits of respective
account/domain.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---
(Updated Aug. 27, 2013, noon)
Review request for cloudstack, Girish Shilamkar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review25619
---
Ship it!
Looks good to me.
- Sanjay Tripathi
On Aug. 27, 2013,
On Aug. 19, 2013, 11:49 a.m., Sanjay Tripathi wrote:
test/integration/component/cpu_limits/test_cpu_limits.py, line 526
https://reviews.apache.org/r/13001/diff/3/?file=338932#file338932line526
As the test title says reboot_instance , please use reboot instance
API instead of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review25541
---
test/integration/component/cpu_limits/test_project_limits.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review25292
---
test/integration/component/cpu_limits/test_cpu_limits.py
On Aug. 19, 2013, 11:49 a.m., Sanjay Tripathi wrote:
test/integration/component/cpu_limits/test_domain_limits.py, line 718
https://reviews.apache.org/r/13001/diff/3/?file=338933#file338933line718
if i am not wrong, the api_client should be api_client_cadmin_2
Can you please close
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---
(Updated Aug. 8, 2013, 12:51 p.m.)
Review request for cloudstack, Girish
On July 31, 2013, 6:08 a.m., Sanjay Tripathi wrote:
test/integration/component/cpu_limits/test_cpu_limits.py, line 216
https://reviews.apache.org/r/13001/diff/2/?file=330095#file330095line216
This test should be of assigning VM to other account and not of
Migrating VM, because
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review24321
---
test/integration/component/cpu_limits/test_cpu_limits.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---
(Updated July 30, 2013, 10:27 a.m.)
Review request for cloudstack, Girish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---
(Updated July 29, 2013, 2:54 p.m.)
Review request for cloudstack, Girish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/
---
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13001/#review24039
---
Review 13001 PASSED the build test
The url of build
15 matches
Mail list logo
