Re: [csv] Release planning for commons-csv

2014-05-02 Thread Benedikt Ritter
Hello Gabriel, thanks for you interest in commons-csv. Please see my comments inline. 2014-05-02 8:15 GMT+02:00 Gabriel Reid : > Hi, > > I was wondering if there is currently a specific plan or list of > requirements to be fulfilled before the 1.0 of commons-csv is made. > > For me personally, a

Re: Apache Commons & ApacheCon Europe 2014 ...

2014-05-02 Thread Benedikt Ritter
2014-04-30 21:24 GMT+02:00 Siegfried Goeschl : > Hi folks, > > I collected the responses/feedback so far sorted according to the given > committment > > Commons SCXML - Ate Douma - will present > Commons Email - Siegfried Goeschl - will present > > Commons Math - Thomas Neidhart - likely to prese

Re: [VOTE] Release Math 3.3 based on RC2

2014-05-02 Thread Luc Maisonobe
Le 01/05/2014 18:15, Thomas Neidhart a écrit : > Hi all, > > I would like to call a vote to release Commons Math 3.3 based on RC2. > > Changes since RC1: > > * completed changelog > * fixed MATH-1110 > * added exclusion filter for findbugs false-positive > * disabled 2 tests that failed with

Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/ main/java/org/apache/commons/collections4/

2014-05-02 Thread Benedikt Ritter
-1 I agree with sebb. There is no use case for this. I've elaborated this some more in the jira. 2014-05-01 20:18 GMT+02:00 Dipanjan Laha : > -1 > > Imho this usecase also gives a false impression of over riding, so maybe we > should make the util classes final as Gary suggested. And imo switchi

Re: [jcs] building with JSR-107 TCK

2014-05-02 Thread Jean-Louis MONTEIRO
He he, sure :) Here is the error even in Java 7. ERROR] /Users/jlmonteiro/devs/asf/commons/proper/jcs/trunk/commons-jcs-jcache/src/main/java/org/apache/commons/jcs/jcache/JCSCache.java:[92,129] cannot find symbol symbol: class MyThreadFactory location: class org.apache.commons.jcs.utils.thre

Re: [LANG] Algorithm for fuzzy string matching

2014-05-02 Thread Benedikt Ritter
Since nobody had objections against adding this, I'll apply this patch. Benedikt 2014-04-28 17:47 GMT+02:00 Benedikt Ritter : > Hi all, > > we have a nice PR for StringUtils at github: > https://github.com/apache/commons-lang/pull/20 > > It adds a new string matching algorithm to StringUtils, t

Re: [jcs] building with JSR-107 TCK

2014-05-02 Thread Romain Manni-Bucau
ok right, In my patch I put it public since a daemon thread factory is quite eusable and important for framewokr. It was not the case Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmanni

Re: [ALL] Suppressing Javadoc errors with Java 8 - temporary hack

2014-05-02 Thread Mark Struberg
Hi! It turned out that it is always just a bit more complicated. Romain detected that building OpenWebBeans with Java8 did lead to bytecode which does not work on ANY older JVM. The reason is that methods of ConcurrentHashMap (and possibly other) has been moved to an Interface. See OWB-952 [1]

Re: Apache Commons & ApacheCon Europe 2014 ...

2014-05-02 Thread Siegfried Goeschl
Hi Benedikt, there might be a lot of different kinds there :-) IMHO the problem with "Let people tell us, what they like about lang and what they don't like" is that your presentation depends on the input of the attendees and the presentation setup (good for a small room but bad if you have a

Re: Apache Commons & ApacheCon Europe 2014 ...

2014-05-02 Thread Mark Struberg
what about commons lightning talks? 5 minutes about a certain commons feature. There are plenty to choose from... LieGrue, strub On Friday, 2 May 2014, 10:28, Siegfried Goeschl wrote: Hi Benedikt, > >there might be a lot of different kinds there :-) > >IMHO the problem with "Let people tell u

Re: [Math] Javadoc with Java 8 (Was: svn commit: r1591664 [2/2] - ...)

2014-05-02 Thread Phil Steitz
On 5/1/14, 7:20 PM, Paul Benedict wrote: > Phil, I don't know who was telling people Javadoc is XML. I never heard of > that. Well, could be just be personal ignorance, but the practice of closing tags in commons javadoc goes back to at least 2002. You can see it in the [lang] Developer Guide (c

Re: [csv] Release planning for commons-csv

2014-05-02 Thread Gabriel Reid
Hi Benedikt, Thanks for the feedback. My comments are inlined below. On Fri, May 2, 2014 at 9:41 AM, Benedikt Ritter wrote: > 2014-05-02 8:15 GMT+02:00 Gabriel Reid : >> If there are open issues that are specifically standing in the way of >> a release, I would be happy to assist in attempting

Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/ main/java/org/apache/commons/collections4/

2014-05-02 Thread Thomas Neidhart
Reverted commit in r1591832. On Thu, May 1, 2014 at 3:03 PM, sebb wrote: > On 1 May 2014 12:05, wrote: > > Author: tn > > Date: Thu May 1 11:04:59 2014 > > New Revision: 1591602 > > > > URL: http://svn.apache.org/r1591602 > > Log: > > [COLLECTIONS-519] Constructors of *Utils classes are now

[CANCEL][VOTE] Release Math 3.3 based on RC2

2014-05-02 Thread Thomas Neidhart
The vote is cancelled. The changes to javadoc have been reverted in r1591835. Unfortunately, I will not be able to cut another RC, thus I step down as RM. Best regards, Thomas On Thu, May 1, 2014 at 6:15 PM, Thomas Neidhart wrote: > Hi all, > > I would like to call a vote to release Commons

Re: Apache Commons & ApacheCon Europe 2014 ...

2014-05-02 Thread Emmanuel Bourg
I have another suggestion for a Commons talk. If many Apache committers attend the talk I think it might be interesting to explain/remind how Commons is a central playground to share common code between various Apache projets. I guess many devs at Apache have forgotten or are unaware of this. I'm p

Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/ main/java/org/apache/commons/collections4/

2014-05-02 Thread Emmanuel Bourg
Le 01/05/2014 16:13, Thomas Neidhart a écrit : > If there is too much trouble upgrading to collections 4, they might also > switch to guava, which I have seen a couple of times already. And they'll cry on every Guava update when deprecated methods are aggressively removed ;) Emmanuel Bourg ---

[SANDBOX][BEANUTILS2] Property expressions

2014-05-02 Thread Benedikt Ritter
Hi all, one of the goal of BeanUtils2 is to provide the same functionality as BeanUtils1. In BeanUtils1 you can do something like this: BeanUtils.getProperty(person, "address.city.zipCode"); This would be translated into: person.getAddress().getCity().getZipCode(); The same can be done with ma

[SANDBOX][BEANUTILS2] Changing code style

2014-05-02 Thread Benedikt Ritter
Hi all, BeanUtils2 uses the maven code style rules. Every now and then I have to reject patches because they don't follow these conventions. I'd like to change the formatting rules to a more standard rule set for the following reasons: - maven style is very verbose, since it uses a lot of spaces

RE: [SANDBOX][BEANUTILS2] Property expressions

2014-05-02 Thread Gary Gregory
There is also our own jxpath. Gary Original message From: Benedikt Ritter Date:05/02/2014 06:40 (GMT-05:00) To: Commons Developers List Subject: [SANDBOX][BEANUTILS2] Property expressions Hi all, one of the goal of BeanUtils2 is to provide the same functionality as BeanU

Re: [LANG] Algorithm for fuzzy string matching

2014-05-02 Thread Gary Gregory
Do we really want this in SU or should it live in its own class? Gary Original message From: Benedikt Ritter Date:05/02/2014 04:15 (GMT-05:00) To: Commons Developers List Subject: Re: [LANG] Algorithm for fuzzy string matching Since nobody had objections against adding th

Re: [LANG] Algorithm for fuzzy string matching

2014-05-02 Thread Benedikt Ritter
Hi Gary, we had a discussion about this some time ago, where I proposed to create a new class (let's call it StringMetrics) and move Levenshtein and Jaro Winkler to it. We decided not to do this in 3.x, since SU already has 180+ methods which will have to be split up in the next major release. Be

[VFS] JDK 8 & 2.1-SNAPSHOT

2014-05-02 Thread Schalk Cronjé
Does anyone else have failures building VFS 2.1 with JDK8 (SVN rev 1591869)? I am seeing this test failure building on Mac. --- Test set: org.apache.commons.vfs2.provider.ram.test.CustomRamProviderTest --

Re: JDK8 compatible javadoc

2014-05-02 Thread Mark Struberg
-Xdoclint:all -Xdoclint:-missing -Xdoclint:-html That should fix the issue. ATTN: this must ONLY be done in a java8 profile! If you set those params in older java versions (1.7, 1.6) then the build will blow up... LieGrue, strub On Wednesday, 30 April 2014, 7:47, Paul Benedict wrote: Looks

Re: [Math] Javadoc with Java 8 (Was: svn commit: r1591664 [2/2] - ...)

2014-05-02 Thread Gilles
On Fri, 02 May 2014 01:48:28 -0700, Phil Steitz wrote: On 5/1/14, 7:20 PM, Paul Benedict wrote: Phil, I don't know who was telling people Javadoc is XML. I never heard of that. Well, could be just be personal ignorance, but the practice of closing tags in commons javadoc goes back to at least

Re: JDK8 compatible javadoc

2014-05-02 Thread Gary Gregory
So the plan is to let each [component] pick how they want to deal with Java 8 right? Gary On Fri, May 2, 2014 at 8:13 AM, Mark Struberg wrote: > -Xdoclint:all -Xdoclint:-missing -Xdoclint:-html > > That should fix the issue. > ATTN: this must ONLY be done in a java8 profile! If you set those p

Re: [VFS] release preparation: clirr report

2014-05-02 Thread Gary Gregory
I'm not sure how fine grained control we have or want to get over Clirr. For now, I'd rather know about all the differences. We can document how to interpret the Clirr report on the site and release notes as well. Gary On Thu, May 1, 2014 at 3:23 PM, Bernd Eckenfels wrote: > Hello, > > in prep

Re: JDK8 compatible javadoc

2014-05-02 Thread Emmanuel Bourg
Le 02/05/2014 15:37, Gary Gregory a écrit : > So the plan is to let each [component] pick how they want to deal with Java > 8 right? As a side note, I'd like to emphasize that our source code is being recompiled by downstream packagers, most notably Linux distributions. Fedora 21 will default to J

Re: [VOTE] Release Math 3.3 based on RC2

2014-05-02 Thread Gary Gregory
On Thu, May 1, 2014 at 5:10 PM, Paul Benedict wrote: > Personally, I don't see a reason to revert the javadoc changes. There's no > turning back the clock on the javadoc processing engine -- it's not like 9 > or 10 is going to stop warning about malformed HTML. Although I am not a > Math contribu

Re: [Math] Javadoc with Java 8 (Was: svn commit: r1591664 [2/2] - ...)

2014-05-02 Thread Gary Gregory
This is a paragraph. is useless Gary On Thu, May 1, 2014 at 10:20 PM, Paul Benedict wrote: > Phil, I don't know who was telling people Javadoc is XML. I never heard of > that. AFAIK, it has always been HTML but the Javadoc parser didn't care to > enforce it. Now it's enforcing it so the only

Re: [SANDBOX][BEANUTILS2] Changing code style

2014-05-02 Thread Gary Gregory
+1 Gary On Fri, May 2, 2014 at 6:53 AM, Benedikt Ritter wrote: > Hi all, > > BeanUtils2 uses the maven code style rules. Every now and then I have to > reject patches because they don't follow these conventions. I'd like to > change the formatting rules to a more standard rule set for the foll

Re: [LANG] Algorithm for fuzzy string matching

2014-05-02 Thread Gary Gregory
So, keep SU as a kitchen sink and refactor for 4.0? I'm OK with that. Gary On Fri, May 2, 2014 at 7:03 AM, Benedikt Ritter wrote: > Hi Gary, > > we had a discussion about this some time ago, where I proposed to create a > new class (let's call it StringMetrics) and move Levenshtein and Jaro >

Re: JDK8 compatible javadoc

2014-05-02 Thread Gary Gregory
On Fri, May 2, 2014 at 9:43 AM, Emmanuel Bourg wrote: > Le 02/05/2014 15:37, Gary Gregory a écrit : > > So the plan is to let each [component] pick how they want to deal with > Java > > 8 right? > > As a side note, I'd like to emphasize that our source code is being > recompiled by downstream pac

Re: [csv] Release planning for commons-csv

2014-05-02 Thread Gary Gregory
+1 to keep the discussion going with or without patches. We need to get a 1.0 out the door. Gary On Fri, May 2, 2014 at 4:57 AM, Gabriel Reid wrote: > Hi Benedikt, > > Thanks for the feedback. My comments are inlined below. > > On Fri, May 2, 2014 at 9:41 AM, Benedikt Ritter > wrote: > > 2014

Re: [jcs] building with JSR-107 TCK

2014-05-02 Thread Thomas Vandahl
On 02.05.14 10:13, Jean-Louis MONTEIRO wrote: > He he, sure :) > > Here is the error even in Java 7. > ERROR] > /Users/jlmonteiro/devs/asf/commons/proper/jcs/trunk/commons-jcs-jcache/src/main/java/org/apache/commons/jcs/jcache/JCSCache.java:[92,129] > cannot find symbol > symbol: class MyThrea

[continuum] BUILD FAILURE: Apache Commons JCS - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2014-05-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=30072&projectId=286 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 May 2014 14:20:52 + Finished at: Fri 2 May 2014 14:24:56 + Total time: 4m 4s Build Trigger: Schedul

[continuum] BUILD FAILURE: Apache Commons JCS - Apache Commons ()

2014-05-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=30073&projectId=286 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 May 2014 15:00:04 + Finished at: Fri 2 May 2014 15:04:35 + Total time: 4m 30s Build Trigger: Schedu

[jcs] JCache implementation review

2014-05-02 Thread Thomas Vandahl
Hi folks, I took some time to look over the code of the JCache implementation and I have some suggestions for simplification (under the assumption that I understood the intention correctly). - JCS does not implement the same model of cache element expiry, however a few more existing features coul

Re: [jcs] JCache implementation review

2014-05-02 Thread Romain Manni-Bucau
Hi globally a big +1 some more remarks inline 2014-05-02 17:13 GMT+02:00 Thomas Vandahl : > Hi folks, > > I took some time to look over the code of the JCache implementation and > I have some suggestions for simplification (under the assumption that I > understood the intention correctly). > >

[continuum] BUILD FAILURE: Apache Commons JCS - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2014-05-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=30076&projectId=286 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 May 2014 15:20:34 + Finished at: Fri 2 May 2014 15:24:16 + Total time: 3m 42s Build Trigger: Schedu

[continuum] BUILD FAILURE: Apache Commons JCS - Apache Commons ()

2014-05-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=30077&projectId=286 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 May 2014 16:00:05 + Finished at: Fri 2 May 2014 16:04:12 + Total time: 4m 6s Build Trigger: Schedul

Re: [VFS] JDK 8 & 2.1-SNAPSHOT

2014-05-02 Thread Bernd Eckenfels
Yes, I see the same problem. (And besides that it seems PMD and findbugs make problems for Java8, too.) bernd > Am 02.05.2014 um 13:27 schrieb Schalk Cronjé : > > Does anyone else have failures building VFS 2.1 with JDK8 (SVN rev 1591869)? > > I am seeing this test failure building on Mac. >

Re: [jcs] JCache implementation review

2014-05-02 Thread Romain Manni-Bucau
one more thing we can discuss are the close() methods of JCache impl. Did a first version but sometimes closing a JCache component will remove all items of the cache. Not sure it is intended in distributed mode. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ Link

Re: [LANG] Algorithm for fuzzy string matching

2014-05-02 Thread Benedikt Ritter
Yes, that would be the plan, I guess :-) 2014-05-02 15:58 GMT+02:00 Gary Gregory : > So, keep SU as a kitchen sink and refactor for 4.0? I'm OK with that. > > Gary > > > On Fri, May 2, 2014 at 7:03 AM, Benedikt Ritter > wrote: > > > Hi Gary, > > > > we had a discussion about this some time ago,

Re: [SANDBOX][BEANUTILS2] Property expressions

2014-05-02 Thread Benedikt Ritter
So you're saying we should leave this out of BU2? 2014-05-02 12:55 GMT+02:00 Gary Gregory : > There is also our own jxpath. > > Gary > > Original message From: Benedikt Ritter < > brit...@apache.org> Date:05/02/2014 06:40 (GMT-05:00) > To: Commons Developers List > Subject: [

Re: [csv] Release planning for commons-csv

2014-05-02 Thread Benedikt Ritter
So you're saying we should release 1.0 from the current trunk? I would volunteer to RM. 2014-05-02 16:02 GMT+02:00 Gary Gregory : > +1 to keep the discussion going with or without patches. We need to get a > 1.0 out the door. > > Gary > > > On Fri, May 2, 2014 at 4:57 AM, Gabriel Reid > wrote:

Re: JDK8 compatible javadoc

2014-05-02 Thread Mark Struberg
>so it would be nice if our components do compile and work on Java 8 It does of course. But if you compile with java8 then it _might_ not work with older java versions. So it's fine for packages built by Fedora FOR Fedora. But those jars might not work on any other linux distro. Which is ok from

Re: [SANDBOX][BEANUTILS2] Property expressions

2014-05-02 Thread Gary Gregory
Nah, I'm just talking around the water cooler,  thinking aloud... Gary Original message From: Benedikt Ritter Date:05/02/2014 12:59 (GMT-05:00) To: Commons Developers List Subject: Re: [SANDBOX][BEANUTILS2] Property expressions So you're saying we should leave this out of

Re: [csv] Release planning for commons-csv

2014-05-02 Thread Gary Gregory
The question is would fixing these two issues break compatibility? We have three compatibility levels: binary,  source, and behavior.  I'm guessing we would be ok on source and binary. Would the behavior be different enough to mean the version that fixes these should be 2.0? I'm guessing no. 

Re: JDK8 compatible javadoc

2014-05-02 Thread Gary Gregory
It's a distro's business if they want to restrict usage to a given Java version. It's our job to make sure it is not only possible but easy. Build out of the box and all... Gary Original message From: Mark Struberg Date:05/02/2014 13:18 (GMT-05:00) To: Commons Developers L

Re: [VOTE] Release Math 3.3 based on RC2

2014-05-02 Thread Phil Steitz
-0 for reasons Gilles cites. I would rather that we agree on how exactly to deal with the J8 mess before partially implementing "fixes." I am not -1 because formatting damage is minimal in what has been committed thus far [1]. Phil [1] This may seem like a nit; but there are quite a few places

Re: [csv] Release planning for commons-csv

2014-05-02 Thread Dan Tran
API breakage would be 2.0. Do we know yet that fixing those issue would send use to 2.0? Thanks -D On Fri, May 2, 2014 at 11:02 AM, Gary Gregory wrote: > The question is would fixing these two issues break compatibility? We have > three compatibility levels: binary, source, and behavior. > >

Re: [Math] Javadoc with Java 8 (Was: svn commit: r1591664 [2/2] - ...)

2014-05-02 Thread Phil Steitz
On 5/2/14, 6:13 AM, Gilles wrote: > On Fri, 02 May 2014 01:48:28 -0700, Phil Steitz wrote: >> On 5/1/14, 7:20 PM, Paul Benedict wrote: >>> Phil, I don't know who was telling people Javadoc is XML. I >>> never heard of >>> that. >> >> Well, could be just be personal ignorance, but the practice of >>

[continuum] BUILD FAILURE: Apache Commons JCS - Apache Commons ()

2014-05-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=30089&projectId=286 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 May 2014 21:00:08 + Finished at: Fri 2 May 2014 21:04:17 + Total time: 4m 8s Build Trigger: Schedul

[continuum] BUILD FAILURE: Apache Commons JCS - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2014-05-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=30092&projectId=286 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 May 2014 21:20:33 + Finished at: Fri 2 May 2014 21:24:02 + Total time: 3m 29s Build Trigger: Schedu

Re: [VFS] JDK 8 & 2.1-SNAPSHOT

2014-05-02 Thread Bernd Eckenfels
Hello, I opened VFS-521 for this, and it looks like the problem is in try-with-resource in Java8 FilterOutputStream. The test in question is expected to fail with an IOException. Gruss Bernd Am Fri, 02 May 2014 12:27:01 +0100 schrieb Schalk Cronjé : > Does anyone else have failures building

Re: [SANDBOX][BEANUTILS2] Changing code style

2014-05-02 Thread sebb
+1 I don't like the curly brace on new line rule as it wastes vertical space ! On 2 May 2014 14:57, Gary Gregory wrote: > +1 > > Gary > > > On Fri, May 2, 2014 at 6:53 AM, Benedikt Ritter wrote: > >> Hi all, >> >> BeanUtils2 uses the maven code style rules. Every now and then I have to >> reje

[dbcp] cutting 2.0.1

2014-05-02 Thread Phil Steitz
DBCP-414 is kind of nasty so it would be good to cut a patch release including the fix for it. A couple of other issues have also been resolved since the release of 2.0. I will volunteer to RM. Unless I hear objections, I will start cutting RMs in in the next couple of days based on the code in

Re: [SANDBOX][BEANUTILS2] Changing code style

2014-05-02 Thread Yogesh Rao
Hi, Eclipse style seems to be better :) Regards, -Yogesh On Sat, May 3, 2014 at 7:42 AM, sebb wrote: > +1 > > I don't like the > curly brace > on new line > rule > as it > wastes vertical > space > ! > > > On 2 May 2014 14:57, Gary Gregory wrote: > > +1 > > > > Gary > > > > > > On Fri, May 2