Re: [Math] Utilization of Lombok

Hi Thomas, On 09/25/2015 08:45 AM, Thomas Neidhart wrote: Hi Ole, can you explain why you think that the addition of lombok brings any benefit to our users? Sure - I'm looking at the LevenbergMarquardtOptimizer ATM, and it has the following set of parameters: /* configuration parameters

Re: [Math] Utilitzation of SLF4J?

On 9/25/15 8:45 AM, Ole Ersoy wrote: > Hi Thomas, > > On 09/25/2015 08:54 AM, Thomas Neidhart wrote: >> Hi Ole, >> >> for a start, I think you are asking the wrong question. >> First of all we need to agree that we want to add some kind of >> logging >> facility to CM. > Well it has to be SLF4J

Re: [Math] Utilitzation of SLF4J?

On Fri, Sep 25, 2015 at 8:50 AM, Phil Steitz wrote: > On 9/25/15 8:45 AM, Ole Ersoy wrote: > > Hi Thomas, > > > > On 09/25/2015 08:54 AM, Thomas Neidhart wrote: > >> Hi Ole, > >> > >> for a start, I think you are asking the wrong question. > >> First of all we need to

Re: [Math] Utilitzation of SLF4J?

On Fri, 25 Sep 2015 07:28:48 -0700, Phil Steitz wrote: On 9/25/15 7:03 AM, Gilles wrote: On Fri, 25 Sep 2015 15:54:14 +0200, Thomas Neidhart wrote: Hi Ole, for a start, I think you are asking the wrong question. First of all we need to agree that we want to add some kind of logging facility

Re: [Math] Utilitzation of SLF4J?

Hi Thomas, On 09/25/2015 08:54 AM, Thomas Neidhart wrote: Hi Ole, for a start, I think you are asking the wrong question. First of all we need to agree that we want to add some kind of logging facility to CM. Well it has to be SLF4J because that's the one I'm most familiar with :). We did

Re: [Math] LeastSquaresOptimizer Design

On 09/25/2015 06:55 AM, Gilles wrote: On Thu, 24 Sep 2015 21:41:10 -0500, Ole Ersoy wrote: On 09/24/2015 06:01 PM, Gilles wrote: On Thu, 24 Sep 2015 17:02:15 -0500, Ole Ersoy wrote: On 09/24/2015 03:23 PM, Luc Maisonobe wrote: Le 24/09/2015 21:40, Ole Ersoy a écrit : Hi Luc, I gave this

Re: [Math] Utilitzation of SLF4J?

On Fri, Sep 25, 2015 at 5:09 PM, Gilles wrote: > On Fri, 25 Sep 2015 07:28:48 -0700, Phil Steitz wrote: > >> On 9/25/15 7:03 AM, Gilles wrote: >> >>> On Fri, 25 Sep 2015 15:54:14 +0200, Thomas Neidhart wrote: >>> Hi Ole, for a start, I think you are

Re: [Math] Utilitzation of SLF4J?

On 09/25/2015 03:06 PM, Phil Steitz wrote: On 9/25/15 11:01 AM, Ole Ersoy wrote: On 09/25/2015 11:34 AM, Phil Steitz wrote: I disagree. Good tests, API contracts, exception management and documentation can and should eliminate the need for cluttering low-level library code with debug

[validator] Inconsistent behavior in UrlValidator

I was just looking at the UrlValidator test and I noticed that localhost is allowed in the URL if the ALLOW_LOCAL_URLS flag is set, and it is not allowed if the ALLOW_LOCAL_URLS flag is not set. If the ALLOW_LOCAL_URLS is not set, a loopback IP address (127.0.0.1) URL will validate. It seems

Re: [Math] Utilization of Lombok

On 09/25/2015 12:55 PM, Thomas Neidhart wrote: On 09/25/2015 05:04 PM, Ole Ersoy wrote: Hi Thomas, On 09/25/2015 08:45 AM, Thomas Neidhart wrote: Hi Ole, can you explain why you think that the addition of lombok brings any benefit to our users? Sure - I'm looking at the

Re: [Math] Utilitzation of SLF4J?

On 9/25/15 11:01 AM, Ole Ersoy wrote: > > > On 09/25/2015 11:34 AM, Phil Steitz wrote: >> I disagree. Good tests, API contracts, exception management and >> documentation can and should eliminate the need for cluttering >> low-level library code with debug logging. > > Logging could be viewed as

Re: [Math] Utilitzation of SLF4J?

On 9/25/15 8:09 AM, Gilles wrote: > On Fri, 25 Sep 2015 07:28:48 -0700, Phil Steitz wrote: >> On 9/25/15 7:03 AM, Gilles wrote: >>> On Fri, 25 Sep 2015 15:54:14 +0200, Thomas Neidhart wrote: Hi Ole, for a start, I think you are asking the wrong question. First of all we need to

Re: [Math] Utilization of Lombok

On 09/25/2015 05:04 PM, Ole Ersoy wrote: > Hi Thomas, > > On 09/25/2015 08:45 AM, Thomas Neidhart wrote: >> Hi Ole, >> >> can you explain why you think that the addition of lombok brings any >> benefit to our users? > Sure - I'm looking at the LevenbergMarquardtOptimizer ATM, and it has > the

Re: [Math] Utilitzation of SLF4J?

On 09/25/2015 11:34 AM, Phil Steitz wrote: I disagree. Good tests, API contracts, exception management and documentation can and should eliminate the need for cluttering low-level library code with debug logging. Logging could be viewed as clutter. Constructed the right way, the logging

Re: [Math] Utilitzation of SLF4J?

On Fri, 25 Sep 2015 13:06:43 -0700, Phil Steitz wrote: I say something like: "I had to fork some CM class to insert log statements." You say something like: "No, you don't; write test or inspect the code." You had been more constructive: http://markmail.org/thread/a5jl6fkjjtm5qbsw Even if

Re: [Math] Utilitzation of SLF4J?

On Fri, 25 Sep 2015 17:30:33 +0200, Thomas Neidhart wrote: On Fri, Sep 25, 2015 at 5:09 PM, Gilles wrote: On Fri, 25 Sep 2015 07:28:48 -0700, Phil Steitz wrote: On 9/25/15 7:03 AM, Gilles wrote: On Fri, 25 Sep 2015 15:54:14 +0200, Thomas Neidhart wrote: Hi

Re: [Math] Utilitzation of SLF4J?

For such a simple case like logging in a (math) library you can also use the JDK jul logging. However I really do not see a need for it (and I think it can negatively impact the user experience of a lib if it does logging even when it has no environmental interactions) Am Sat, 26 Sep 2015

Re: [Math] Utilitzation of SLF4J?

Oughtn't there be an option to have logging for developers? If you'd like to use it, feel free; if not, don't. Including log4j (or slf or commons-logging, so on) doesn't add too much weight to the jar -- one file, a small properties file, and 4-lines in the pom file. If there is interest, I can

Re: [Math] Utilitzation of SLF4J?

On Sat, 26 Sep 2015 02:00:13 +0200, Bernd Eckenfels wrote: For such a simple case like logging in a (math) library you can also use the JDK jul logging. This may make you change your mind: http://stackoverflow.com/questions/11359187/why-not-use-java-util-logging However I really do not

Re: [Math] Utilitzation of SLF4J?

On Fri, 25 Sep 2015 16:52:26 -0700, Hasan Diwan wrote: On 25 September 2015 at 16:47, Gilles wrote: On Fri, 25 Sep 2015 17:30:33 +0200, Thomas Neidhart wrote: On Fri, Sep 25, 2015 at 5:09 PM, Gilles wrote: On Fri, 25 Sep 2015

Re: [Math] LeastSquaresOptimizer Design

On Thu, 24 Sep 2015 21:41:10 -0500, Ole Ersoy wrote: On 09/24/2015 06:01 PM, Gilles wrote: On Thu, 24 Sep 2015 17:02:15 -0500, Ole Ersoy wrote: On 09/24/2015 03:23 PM, Luc Maisonobe wrote: Le 24/09/2015 21:40, Ole Ersoy a écrit : Hi Luc, I gave this some more thought, and I think I may have

Re: [Math] Utilization of Lombok

Hi Ole, can you explain why you think that the addition of lombok brings any benefit to our users? >From my point of view, lombok can help developers by taking over some tedious tasks, but this is quite irrelevant in the case of CM as the majority of work goes into algorithm design and

[Math] Utilitzation of SLF4J?

Hello, We have been discussing various ways to view what's happening internally with algorithms, and the topic of including SLF4J has come up. I know that this was discussed earlier and it was decided that CM is a low level dependency, therefore it should minimize the transitive dependencies

Re: [Math] LeastSquaresOptimizer Design

On Thu, 24 Sep 2015 22:07:58 -0500, Ole Ersoy wrote: Why should the instance throwing the exception hold a field with the information? Separation of concerns: optimizer does the computation, then the exception holds what's needed for a full report of the failure. I would see what makes sense

[Math] Utilization of Lombok

Hello, I'm going to utilize Lombok in a CM design experiment. Once the experiment is done CM can decide if it likes Lombok. I know that CM tries to stay dependency free, so I just want to make clear that Lombok is compile time only:

Re: [Math] Utilitzation of SLF4J?

Hi Ole, for a start, I think you are asking the wrong question. First of all we need to agree that we want to add some kind of logging facility to CM. If the outcome is positive, there are a handful of alternatives, some of them more viable than slf4j in the context of CM (e.g. JUL or

Re: [Math] Utilitzation of SLF4J?

On Fri, 25 Sep 2015 15:54:14 +0200, Thomas Neidhart wrote: Hi Ole, for a start, I think you are asking the wrong question. First of all we need to agree that we want to add some kind of logging facility to CM. If the outcome is positive, there are a handful of alternatives, some of them

Re: [Math] Utilitzation of SLF4J?

On 9/25/15 7:03 AM, Gilles wrote: > On Fri, 25 Sep 2015 15:54:14 +0200, Thomas Neidhart wrote: >> Hi Ole, >> >> for a start, I think you are asking the wrong question. >> First of all we need to agree that we want to add some kind of >> logging >> facility to CM. >> If the outcome is positive,