+1
Built with JDK 17.0.9 and passed BCEL tests.
Then integrated with Daikon and ran all our acceptance tests without error.
Mark
-Original Message-
From: Gary Gregory
Sent: Sunday, January 7, 2024 12:20 PM
To: Commons Developers List
Subject: [VOTE] Release Apache Commons BCEL 6.8.1 base
Issues I opened marked resolved fixed: 287, 294, 295, 296, 297, 329, 330,
333, 334, 335, 340
Issue I opened that has fix available: 361
On Sun, Dec 3, 2023 at 9:10 AM Elliotte Rusty Harold
wrote:
> https://issues.apache.org/jira/projects/BCEL/issues/BCEL-337 looks
> like it's fixed and should b
What is the difference/preferred usage between
github.com/apache/commons-bcel and
gitbox.apache.org/repos/asf/commons-bcel.git?
Thanks,
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-
#68 = Methodref #901.#902//
> "[B".clone:()Ljava/lang/Object;
>
> Thoughts?
>
> Gary
>
> On 2022/11/17 13:04:32 "Gary D. Gregory" wrote:
> > Actually: VerifyJavaMathTestCase and VerifyJavaUtilTestCase
> >
> > Gary
> >
&
In the constructor of
/src/main/java/org/apache/bcel/verifier/structurals/ExceptionHandlers.java -
the 'computeIfAbsent' line is duplicated. Is this correct?
Mark
-Original Message-
From: Gary D. Gregory [mailto:ggreg...@apache.org]
Sent: Tuesday, November 1, 2022 10:17 AM
To: dev@common
I think a camelCase edit was missed in classfile/FieldOrMethod.java. The
method 'copy_' has constantPool in the arg list and constant_pool in the
body. constant_pool is class field and I don’t think the intention of copy_
is to reuse the existing ConstantPool.
Mark
-Original Message-
Fr
+1
Tested via integration with Daikon tool set. Passed all build and
acceptance tests.
Mark Roberts
-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com]
Sent: Saturday, October 8, 2022 5:36 AM
To: Commons Developers List
Subject: [VOTE] Release Apache Commons BCEL
I would suggest defaulting to the system property "java.version", that is
what the Daikon tool set does.
Mark
-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com]
Sent: Friday, February 4, 2022 7:54 AM
To: Commons Developers List
Subject: Re: BCEL: Can't load Object.clas
I ran all my tests with Java 8 and Java 11 - looks good.
+1
Mark
-Original Message-
From: Gary Gregory [mailto:ggreg...@apache.org]
Sent: Friday, June 5, 2020 3:03 PM
To: Commons Developers List
Subject: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1
We have fixed a few bugs and a
wrote:
> Did I miss a PR? I do not see an open PR from you.
>
> Gary
>
> On Mon, Jun 1, 2020 at 7:54 PM Mark Roberts
> wrote:
>
>> I'm happy to do that - but what about my requested changes to
>> src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.
Monday, June 1, 2020 4:30 PM
To: Commons Developers List
Subject: Re: [bcel] Anything pending for a 6.4.2 release?
Hi Mark,
May you please try the latest from git master and see how that goes? I've
merged PR 39 and 40.
Gary
On Mon, Jun 1, 2020 at 5:15 PM Mark Roberts
wrote:
> In orde
least two rounds of email on the latter item, the most recent in
February of this year which drew no response.
We would really like to see these three changes in an official 6.4.2.
Thank you,
Mark Roberts
-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com]
Sent: Saturday
I really would like to move forward with this. If you look at the code in
src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java you will see:
Public addAttribute ...
Protected addAnnotationEntry ...
Public removeAttribute ...
Protected removeAnnotationEntry ...
Public removeAttributes ..
[mailto:garydgreg...@gmail.com]
Sent: Friday, September 06, 2019 5:01 PM
To: Mark Roberts; Commons Developers List
Subject: Re: [BCEL] Release 6.4.0
Run:
mvn clean site -P jacoco
Then look at the generate site's JaCoCo report and make sure the new code has
as close to possible t
pache/bcel/generic/FieldGenOrMethodGen.java
On Thu, 17 Oct 2019 at 23:16, Mark Roberts wrote:
>
> When the BCEL package was renamed back to org.apache.bcel in:
>
> commit d522432b79044740831a132d8b92e7dab5477444
> Author: Benedikt Ritter
> Date: Tue Jun 7 17:28:43 2016 +000
When the BCEL package was renamed back to org.apache.bcel in:
commit d522432b79044740831a132d8b92e7dab5477444
Author: Benedikt Ritter
Date: Tue Jun 7 17:28:43 2016 +
The methods to add and delete annotations were changed from public to protected
with a confusing comment:
< public voi
[bcel] java.util.EmptyStackException at
org.apache.bcel.classfile.DescendingVisitor.visitModule
(DescendingVisitor.java:592)
Hi All & Mark Roberts,
It looks like I/we did not test BCEL 6.4.0 well enough or broadly enough.
If I take git master for Apache Commons Pool and update the site re
That's exactly what we do with all our projects here at UW/PLSE.
Mark
-Original Message-
From: James Ring [mailto:s...@jdns.org]
Sent: Friday, September 13, 2019 6:44 AM
To: Commons Developers List
Subject: Re: [CONFIGURATION] Formatting braces
What about https://github.com/google/googl
]
Sent: Friday, September 06, 2019 5:01 PM
To: Mark Roberts; Commons Developers List
Subject: Re: [BCEL] Release 6.4.0
Run:
mvn clean site -P jacoco
Then look at the generate site's JaCoCo report and make sure the new code has
as close to possible to 100% code coverage by the unit
I'm good. From our standpoint it would be nice to make a BCEL release so we
don't need to include a special version with our tool set.
Thanks,
Mark
-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com]
Sent: Sunday, September 1, 2019 3:25 PM
To: Commons Developers List
As another data point, we (Univ. of Wash. PLSE dept) moved off of Travis to a
combination of CIrcleCI and Azure Pipleines.
Mark
-Original Message-
From: Gary Gregory [mailto:garydgreg...@gmail.com]
Sent: Saturday, August 31, 2019 10:22 AM
To: Commons Developers List
Subject: Re: [bcel]
I'm very confused by a change made to pom.xml that removed the Javadoc
additionalparm of -Xdoclint:none but nothing was done to the bcel source files
to fix all the Javadoc warnings.
Help me understand why this was done.
Thank you,
Mark Roberts
> -Original Message-
I added that warning while working on the StackMap support for Java7 (and
beyond). We were testing (daikon and randoop) on several very large test
suites and found a large number of class files compiled with an obsolete
version of Java that generated bogus StackMap entries. I don't feel too
s
, you you try this RC and see if it can replace your custom build?
Gary
On Sat, Dec 2, 2017 at 1:27 PM, Mark Roberts
wrote:
> As far as the Daikon tool set is concerned, 295 is not a regression,
> it is a newly discovered fatal flaw. We have already had to release a
> private versio
see if it can replace your custom build?
Gary
On Sat, Dec 2, 2017 at 1:27 PM, Mark Roberts
wrote:
> As far as the Daikon tool set is concerned, 295 is not a regression,
> it is a newly discovered fatal flaw. We have already had to release a
> private version of BCEL, we were hoping
Dec 2, 2017 at 12:35 PM, Mark Roberts
wrote:
> I have to vote -1 until 295 is fixed - this will force us to have a
> private version of bcel.
>
> https://issues.apache.org/jira/browse/BCEL-295
>
> Mark
>
>
> -Original Message-
> From: Gary Gregory [mailto:g
I have to vote -1 until 295 is fixed - this will force us to have a private
version of bcel.
https://issues.apache.org/jira/browse/BCEL-295
Mark
-Original Message-
From: Gary Gregory [mailto:ggreg...@apache.org]
Sent: Thursday, November 30, 2017 8:18 PM
To: Commons Developers List
Sub
+1
-Original Message-
From: Benedikt Ritter [mailto:brit...@apache.org]
Sent: Saturday, October 21, 2017 1:22 AM
To: Commons Developers List
Subject: [VOTE][LAZY] Migrate Apache Commons BCEL to git
Hello,
I’d like to move Apache Commons BCEL codebase to git, so I’m calling a vote by
la
Passed all of the UW PLSE Daikon toolset tests.
+1
Mark
-Original Message-
From: Benedikt Ritter [mailto:brit...@apache.org]
Sent: Thursday, September 14, 2017 1:30 PM
To: Commons Developers List
Subject: [VOTE] Release Apache Commons BCEL 6.1 based on RC1
Hi,
we’ve fixed some bugs an
Subject: Re: [BCEL] Releasing 6.1
Hello Mark,
> Am 28.08.2017 um 16:39 schrieb Mark Roberts :
>
> As I have noted in previous posts, the UW PLSE Daikon toolset is a major user
> of BCEL. I would be happy to help with this release. Some items/questions
> to start with:
>
>
://issues.apache.org/jira/browse/BCEL-283 ,
https://issues.apache.org/jira/browse/BCEL-286 and
https://issues.apache.org/jira/browse/BCEL-287 .
- Is the svn repo still the master? Will you be creating a branch for the
release?
Thank you,
Mark Roberts
-Original Message-
From: Benedikt Ritter
My specification attachments were over the mailer size limit - I have created
https://issues.apache.org/jira/browse/BCEL-283 with the specs attached.
Mark
> -Original Message-
> From: Mark Roberts [mailto:mar...@cs.washington.edu]
> Sent: Wednesday, November 09, 2016 8:2
This issue needs to be reopened as the changes are incorrect. I could not
figure out the magic to do so - but I did add comments and attached the
outline of a solution in the form of a diff file.
Thank you,
Mark Roberts
> -Original Message-
> From: asfgit [mailto:g...@git.apac
This sounds very similar to the previous attempt to do this that broke our tool
Daikon. Please see https://issues.apache.org/jira/browse/BCEL-79 and make sure
we're not doing this incorrectly again.
Unfortunately, I do not have the time right now to do a full review. If no one
else voluntee
Passed our Daikon testing.
+1
Mark
> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org]
> Sent: Sunday, July 10, 2016 2:04 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC8
>
> Benedikt Ritter schrieb am So., 10. Juli
Great - thanks for all the suggestions. I will investigate on Monday.
Mark
> -Original Message-
> From: Gary Gregory [mailto:garydgreg...@gmail.com]
> Sent: Friday, July 08, 2016 4:18 PM
> To: Commons Developers List
> Subject: Re: How tell which BCEL release?
>
> Accessible from java.l
mailto:brit...@apache.org]
> Sent: Thursday, July 07, 2016 11:48 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
>
> Thank you Mark, I'll have a look ASAP.
>
> Mark Roberts schrieb am Do., 7. Juli 2016 um
> 18:4
should wait for your unit test before we cut another (and final I
> hope) RC.
>
> Gary
>
> On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts
>
> wrote:
>
> > The patch that (was) attached to bcel-262 was correct, it just looks
> > like it was never applied. The lin
the ML moes not allow file attachments.
>
> Benedikt
>
>
> > Gary
> >
> > On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts
> >
> > wrote:
> >
> > > Hmm - now I'm thinking the code for InvokeInstruction is not correct.
> > The
> &g
Hmm - now I'm thinking the code for InvokeInstruction is not correct. The
override method getClassName was added, but my patch was not applied to the
added code. I have attached the diff.
Sorry for not catching this the first time.
Thank you,
Mark
> -Original Message-
>
The RELEASE-NOTES.txt entry for BCEL-262 is incorrect. It should be exactly
the opposite. The override was added to InvokeInstruction because an array IS
a legal operand. The code is correct, the throw has been removed.
Mark
> -Original Message-
> From: Benedikt Ritter [mailto:brit..
First, I must apologize for being a little sloppy in my analysis of the RC.
As previously noted https://issues.apache.org/jira/browse/BCEL-262 is open and
is a problem for Daikon. However, I just noticed my changes - as applied by
r1702349 | sebb | 2015-09-10 16:30:33 -0700 (Thu, 10 Sep 2015)
Thanks to sebb's suggestion of using shade I was able to test RC6.
Unfortunately, I am unable to vote as rev 1747124 breaks Daikon. (We are
required to build with -Werror). This change is not in the active tree so
that's good. The problem is that
https://issues.apache.org/jira/browse/BCEL-2
ertainly not going to edit all my sources back to
> the
> 'old' system.
>
> So my question is what is the plan? This release gets me no closer to a place
> where I can quit providing my own version of BCEL with our Daikon product.
> What is the plan for a release from the
sources back
to the 'old' system.
So my question is what is the plan? This release gets me no closer to a place
where I can quit providing my own version of BCEL with our Daikon product.
What is the plan for a release from the active tree with the new class
hierarchy?
Thank
I think sebb already took care of these two issues.
> -Original Message-
> From: Benedikt Ritter [mailto:benerit...@gmail.com]
> Sent: Friday, June 17, 2016 9:50 AM
> To: Commons Developers List
> Subject: Re: [BCEL] Release Candidate on Thursday
>
> Hello Ma
skutov [mailto:losku...@gmx.de]
> Sent: Tuesday, June 14, 2016 9:27 AM
> To: Commons Developers List; Mark Roberts; 'Commons Developers List'
> Subject: RE: [BCEL] Release Candidate on Thursday
>
> 1) You mentioned "private Daikon" build. Can you propose a patch?
> 2
ject: Re: [BCEL] Release Candidate on Thursday
>
> Are they show stoppers?
>
> On Tue, Jun 14, 2016 at 11:50 AM Mark Roberts
>
> wrote:
>
> > I can tell you right now I would vote -1 as you have not picked up the
> > fix for https://issues.apache.org/j
I can tell you right now I would vote -1 as you have not picked up the fix for
https://issues.apache.org/jira/browse/BCEL-243.
Also, I think https://issues.apache.org/jira/browse/BCEL-195 is fixed, but has
not been closed.
Thank you,
Mark Roberts
> -Original Message-
> From: Be
.
Thank you,
Mark Roberts
> -Original Message-
> From: James Carman [mailto:ja...@carmanconsulting.com]
> Sent: Wednesday, June 08, 2016 4:03 AM
> To: Commons Developers List
> Subject: Re: [BCEL6] StackMapTable / StackMapTableEntry gone
>
> Let's be clear here. We
It would most definitely be worth it from our point of view (the Daikon
toolset) as we have already rolled our own Java 8 support. Our primary
motivation is that we have been using our own updated version of BCEL for
years and would love to get back to an official release. Finally, all our
code is
I was actively involved in helping with BCEL 6.0 - but everything seems to have
gone dark for the last couple of months.
So, what's going on?
Thank you,
Mark Roberts
-
To unsubscribe, e-mail: dev-uns
I read and understood the comment as to the reasoning, but the problem is the
shared code nature of FieldOrMethod. When dealing with a method you know a
priori that the object cannot be an array. Now to get the ClassName of an
InvokeInstruction operand you must say
invoke.getReferenceType(cp)
That's a little tricky to answer. As one example, look at
generic/LocalVariableInstruction. Neither the index or opcode is final. A
user needs to be able to insert new local variables and hence they need to be
able to modify the local variable offset (index). And 'beneath the covers'
BCEL w
I hope this doesn't come across as too strident, but working towards a
resolution of this particular issue has got me thinking about how I use BCEL -
and this seems like a good time/place to clarify my understanding of BCEL's
purpose.
Simply stated, it is my belief that a client should be abl
I think 7 is fine. I would be hesitant to go all the way to 8 at this time.
Thanks,
Mark
-Original Message-
From: sebb [mailto:seb...@gmail.com]
Sent: Thursday, August 13, 2015 11:48 AM
To: Commons Developers List
Subject: Re: [BCEL] Java version
On 13 August 2015 at 17:58, Gary Grego
the latest from trunk.
Gary
On Wed, Aug 12, 2015 at 2:43 PM, Mark Roberts
wrote:
> I would like to update some of my proposed fixes and lobby for their
> inclusion in the next release of BCEL. To that end I presume I should
> be comparing my changes with the source in the RC4 tag a
I would like to update some of my proposed fixes and lobby for their inclusion
in the next release of BCEL. To that end I presume I should be comparing my
changes with the source in the RC4 tag as opposed to the trunk. Is that
correct?
Thank you,
Mark Roberts
I am going to try to spend most of today working on BCEL; I am currently
looking at 195, 200,203,208 and 210.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.
I've probably missed something - but I think I've got all of our (PLSE)
changes into the jira database.
I'm going to look at the signatureToString issue now.
Thanks to everybody who helped me along the way...
Mark
-
To uns
I would like to reopen BCEL-79, but I'm new to JIRA and I can't figure out how
to do it.Reopen does not appear to be one of the choices on the drop down
tools menu. Could someone let me know how to do this?
Thank you,
Mark Roberts
-Original Message-
From: benj
w?
Thanks,
Ben
On Tue, Jan 27, 2015 at 1:58 AM, Emmanuel Bourg wrote:
> Le 27/01/2015 05:36, Mark Roberts a écrit :
>
> > To repeat - constructing the local variables from the local variable
> types
> > is totally bogus. I have no idea how that fixed the original problem
pache.org/jira/browse/BCEL-193>.
Are any of these blocking the 6.0 release or do you think we might be able to
cut that now?
Thanks,
Ben
On Tue, Jan 27, 2015 at 1:58 AM, Emmanuel Bourg wrote:
> Le 27/01/2015 05:36, Mark Roberts a écrit :
>
> > To repeat - constructing the l
In our opinion, the fix is worse than the disease. Here are the comments
from our version:
The following piece of code is new since our 5.2 based version.
It was added in revision 524610 on 2007-04-01, more information is at:
http://issues.apache.org/bugzilla/show_bug.cgi?id=39695 (no
I understand the goal of trying to reuse instructions - an 'iadd' is the
same as any other 'iadd'. However, one 'goto 50' is not the same as
another 'goto 50' due to the way Targeters are implemented. If branch
instructions are reused, then only one entry gets put on the Targeter list.
So when s
The InvokeDynamic and BootstrapMethod changes move some class members around.
So any app that writes a serialized version of the BCEL internal data
structures and re-reads later would have to regenerate those files. Our tools
do not do this; I have no idea if this is common. On the other hand
Good question. When I started work here (at PLSE) in Jan 2013, we had been
using BCEL for some time. We had not released a version of our product in
about three years and one of my tasks was to get back to making regular
releases of the Daikon toolset. So in about May of 2013 I picked up the
l
Bourg
Sent: Friday, January 23, 2015 2:11 PM
To: Commons Developers List
Subject: Re: [bcel] new to list - introduction
Le 23/01/2015 20:55, Mark Roberts a écrit :
> My name is Mark Roberts and I work in the Programming Languages and
> Software Engineering group (PLSE) at the University
My name is Mark Roberts and I work in the Programming Languages and Software
Engineering group (PLSE) at the University of Washington.
(http://www.cs.washington.edu/research/plse)
Our team develops and supports a number of open source tools. One of the main
ones, Daikon (http
69 matches
Mail list logo