Hi all guys,
sorry to be late but I had to read all the resume before posting
something useful :P
So, briefly, just my 2 cents with the hope to contribute in a useful way:
About the JMX support, that could involve also the whole design, I
suggest on keeping out the Configuration but rather taking
On Thu, Oct 28, 2010 at 6:50 AM, Simone Tripodi
simone.trip...@gmail.com wrote:
That's why I wouldn't follow the option #2; but please, explain me
which are the side effects of that design, so I can avoid to repeat
the same mistake in the future.
If you make the config objects immutable, you
Hi James,
thanks, understood. I take in charge yet another cycle of refactoring,
I'll ping you all when in trouble about something :)
Have a nice day and thanks for the feedbacks!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Thu, Oct 28, 2010 at 2:12 PM, James Carman
Hi again James, all,
please review my last commit[1], I refactored the Config and related
(Keyed)StackObjectPool(Factory), I tried to implements the concepts
we've been discussing in this thread.
If this fits to our vision, I can follow applying the refactor to
Generic(Keyed)ObjectPool(Factory).
On 28 October 2010 15:16, Simone Tripodi simone.trip...@gmail.com wrote:
Hi again James, all,
please review my last commit[1], I refactored the Config and related
(Keyed)StackObjectPool(Factory), I tried to implements the concepts
we've been discussing in this thread.
The public
Hi Seb,
thanks for your feedbacks. Please read my questions inline your comments
The public StackObjectPoolConfig ctor repeats the settings available
in the nested Builder.
I'm not sure I see the point of having both. Or perhaps the ctor is
supposed to be private?
I'm sorry but I didn't
On 28 October 2010 18:50, Simone Tripodi simone.trip...@gmail.com wrote:
Hi Seb,
thanks for your feedbacks. Please read my questions inline your comments
The public StackObjectPoolConfig ctor repeats the settings available
in the nested Builder.
I'm not sure I see the point of having both.
Thanks a lot Seb, your suggestions are always appreciated :)
Thanks for the sample, I see your troubles on ctor/builder, I think it
makes much more sense when the number of arguments is very large, like
the Generic(Keyed)ObjectPool(Factory). Do you have options to suggest?
Thanks in advance.
...@seagullsoftware.com wrote:
-Original Message-
From: Phil Steitz [mailto:phil.ste...@gmail.com]
Sent: Monday, October 25, 2010 08:50
To: Commons Developers List
Subject: Re: [pool] Reusing Config part 2
On 10/25/10 11:26 AM, Gary Gregory wrote:
Thank you for working through
: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs now, I'm gonna hack out some
simple UML diffs, if only to wrap my head around it all. I'll upload the
file to the issue once complete.
BTW, I hope I didn't offend with the 'academic' comment, I
most certainly did
]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs now, I'm gonna hack out
some
simple UML diffs, if only to wrap my head around it all. I'll upload
the
file to the issue
...@seagullsoftware.com wrote:
-Original Message-
From: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs now, I'm gonna hack
...@gmail.com]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs now, I'm gonna hack
out
some
simple UML diffs, if only to wrap my head around it all. I'll
upload
.99soft.org/
On Fri, Oct 22, 2010 at 5:23 AM, Gary Gregory
ggreg...@seagullsoftware.com wrote:
-Original Message-
From: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary
/
On Fri, Oct 22, 2010 at 5:23 AM, Gary Gregory
ggreg...@seagullsoftware.com wrote:
-Original Message-
From: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking
:23 AM, Gary Gregory
ggreg...@seagullsoftware.com wrote:
-Original Message-
From: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Monday, October 25, 2010 05:36
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Hi all mates,
I updated the jira issue uploading my patch; it contains the
configuration extraction and some code
: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Thursday, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs now, I'm gonna hack out
some
simple UML diffs, if only to wrap my head around it all. I'll upload
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Monday, October 25, 2010 05:36
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Hi all mates,
I updated the jira issue uploading my patch; it contains the
configuration extraction
Email: ggreg...@seagullsoftware.com
Web: seagull.rocketsoftware.com
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Monday, October 25, 2010 05:36
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Hi all mates,
I updated the jira issue uploading
, October 21, 2010 18:08
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Gary,
Great work so far. I'm checking out the diffs now, I'm gonna
hack out
some
simple UML diffs, if only to wrap my head around it all.
I'll upload
the
file to the issue once complete.
BTW, I hope I
On Mon, Oct 25, 2010 at 12:25 PM, Phil Steitz phil.ste...@gmail.com wrote:
I notice now what I missed on initial review of Simo's patch - the pool
accessors now manage the config properties via persisted Config members. I
am OK with this, but it now means that the Config classes have to be
On 10/25/10 12:36 PM, James Carman wrote:
On Mon, Oct 25, 2010 at 12:25 PM, Phil Steitzphil.ste...@gmail.com wrote:
I notice now what I missed on initial review of Simo's patch - the pool
accessors now manage the config properties via persisted Config members. I
am OK with this, but it now
-Original Message-
From: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Monday, October 25, 2010 08:43
To: Commons Developers List
Subject: Re: [pool] Reusing Config part 2
Gary,
I tossed this around as well, and noted these fields as a possible promote
to the Abstract
-Original Message-
From: Phil Steitz [mailto:phil.ste...@gmail.com]
Sent: Monday, October 25, 2010 08:50
To: Commons Developers List
Subject: Re: [pool] Reusing Config part 2
On 10/25/10 11:26 AM, Gary Gregory wrote:
Thank you for working through this Simone.
I would like
, Gary Gregory
ggreg...@seagullsoftware.com wrote:
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Wednesday, October 20, 2010 22:41
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Hi Gary!
unfortunately the link replied with 404 code, can
-Original Message-
From: Phil Steitz [mailto:phil.ste...@gmail.com]
Sent: Thursday, October 21, 2010 06:29
To: Commons Developers List
Subject: Re: [pool] Reusing Config
On 10/21/10, Simone Tripodi simone.trip...@gmail.com wrote:
it seems you've been doing a very good work
Steitz [mailto:phil.ste...@gmail.com]
Sent: Thursday, October 21, 2010 06:29
To: Commons Developers List
Subject: Re: [pool] Reusing Config
On 10/21/10, Simone Tripodi simone.trip...@gmail.com wrote:
it seems you've been doing a very good work, the only thing I *suggest
Hi All:
I think this came up recently. Any thoughts or plans on extracting the Config
class out of GenericKeyedObjectPool and GenericObjectPool so it can be reused.
The constants for default values could then also be moved to Config.
Gary Gregory
Senior Software Engineer
Rocket Software
3340
: Wednesday, October 20, 2010 10:29
To: Commons Developers List
Subject: [pool] Reusing Config
Hi All:
I think this came up recently. Any thoughts or plans on extracting the Config
class out of GenericKeyedObjectPool and GenericObjectPool so it can be reused.
The constants for default values
: Wednesday, October 20, 2010 10:29
To: Commons Developers List
Subject: [pool] Reusing Config
Hi All:
I think this came up recently. Any thoughts or plans on extracting the Config
class out of GenericKeyedObjectPool and GenericObjectPool so it can be
reused.
The constants for default values
, October 20, 2010 10:29
To: Commons Developers List
Subject: [pool] Reusing Config
Hi All:
I think this came up recently. Any thoughts or plans on extracting the
Config
class out of GenericKeyedObjectPool and GenericObjectPool so it can be
reused.
The constants for default values could
, October 20, 2010 10:29
To: Commons Developers List
Subject: [pool] Reusing Config
Hi All:
I think this came up recently. Any thoughts or plans on extracting the
Config
class out of GenericKeyedObjectPool and GenericObjectPool so it can be
reused.
The constants for default values could
...@seagullsoftware.com
Web: seagull.rocketsoftware.com
-Original Message-
From: Gary Gregory [mailto:ggreg...@seagullsoftware.com]
Sent: Wednesday, October 20, 2010 10:29
To: Commons Developers List
Subject: [pool] Reusing Config
Hi All:
I think this came up recently
-Original Message-
From: Steven Siebert [mailto:smsi...@gmail.com]
Sent: Wednesday, October 20, 2010 12:51
To: Commons Developers List
Subject: Re: [pool] Reusing Config
I apologize for not getting the proposal for the MBean API out quite yet -
needed some sleep last night
Email: ggreg...@seagullsoftware.com
Web: seagull.rocketsoftware.com
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Wednesday, October 20, 2010 12:22
To: Commons Developers List
Subject: Re: [pool] Reusing Config
sure, I always wait for feedbacks
[mailto:simone.trip...@gmail.com]
Sent: Wednesday, October 20, 2010 12:22
To: Commons Developers List
Subject: Re: [pool] Reusing Config
sure, I always wait for feedbacks before coding :P Cool expression
Rambo through the code, that was the first time I read it and made
me laugh :D
All the best
Web: seagull.rocketsoftware.com
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Wednesday, October 20, 2010 14:53
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Hi,
sorry for not having been clear, but in my previous email my
Web: seagull.rocketsoftware.com
-Original Message-
From: Simone Tripodi [mailto:simone.trip...@gmail.com]
Sent: Wednesday, October 20, 2010 14:53
To: Commons Developers List
Subject: Re: [pool] Reusing Config
Hi,
sorry for not having been clear, but in my previous email my
39 matches
Mail list logo
