Re: cordova command cli and merges concept pull request

2013-02-12 Thread Gorkem Ercan
I have been cooking up a similar functionality for Cordova development plugins for Eclipse IDE that I am building. I think the only real difference with what I have is I have named the merges folder as www_platform. As my goal is to keep 100% compatible with cordova-cli I was planning to provide a

WPCordovaClassLib.dll in the full template?

2013-02-12 Thread Marcel Kinard
Somebody asked me about the WPCordovaClassLib.dll in Cordova 2.3 for WP7 and WP8. I had never looked at WP7/WP8 before, so I started poking at it a bit. From what I can tell, the documentation says that the full template should include a pre-built dll, but I don't see one in the phonegap distro

Re: Android file chooser

2013-02-12 Thread Max Woghiren
Thanks Simon. The file picker code in that project looks similar to what I was thinking might be useful to add to Cordova itself; however, in the Corinthian philosophy, you mention that this sort of thing isn't necessarily within the scope of Cordova. Does that mean you believe this type of plugi

Re: Android pull request for JS create script on Windows

2013-02-12 Thread Andrew Grieve
And these as well: https://github.com/apache/cordova-android/pull/7 https://github.com/apache/cordova-android/pull/5 On Tue, Feb 12, 2013 at 11:03 AM, Andrew Grieve wrote: > https://github.com/apache/cordova-android/pull/8/files > > Can someone with a windows machine test this out and pull it in

Re: Android file chooser

2013-02-12 Thread Max Woghiren
Just to be clear, I'm asking whether it would be useful to add a file picker plugin for Android to core Cordova. On Tue, Feb 12, 2013 at 10:49 AM, Max Woghiren wrote: > Thanks Simon. > > The file picker code in that project looks similar to what I was thinking > might be useful to add to Cordov

Re: Supporting multiple plugin return values

2013-02-12 Thread Michal Mocny
I've pushed this to a remote branch: multipart_plugin_result for both ios and js repo's: ios: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=shortlog;h=refs/heads/multipart_plugin_result js: https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=shortlog;h=refs/heads/multipart_plu

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Filip Maj
Cool, thanks Michael. I will take a look when I get a chance. Curious what the rest of the list thinks. As for mocking in-browser, I recommend trying out Ripple - it has great support for mocking out arbitrary cordova plugins. On 2/12/13 6:10 AM, "Gorkem Ercan" wrote: >I have been cooking up a

Re: WPCordovaClassLib.dll in the full template?

2013-02-12 Thread Jesse MacFadyen
Docs are wrong. Yes the behavior is currently different as the phonegap distro includes pre-built dll and templates. We are working on automating this, but it is difficult as I am attempting to only rely on the free express tools so users don't have to shell out $$$ for vs-pro. Cheers, Jesse S

Re: BlackBerry 2.4.0 Release

2013-02-12 Thread Brian LeRoux
Ah crap. Well, my thinking is just repackage it anyhow. (Not a world ending bug tracking nightmare.) On Mon, Feb 11, 2013 at 11:40 PM, Tim Kim wrote: > Someone had brought it up through the google groups: > https://groups.google.com/forum/#!topic/phonegap/wnICEdCs-Qk/discussion > > > On 11 Februa

Re: BlackBerry 2.4.0 Release

2013-02-12 Thread Jesse MacFadyen
+1 to repack. Cheers, Jesse Sent from my iPhone5 On 2013-02-12, at 9:36 AM, Brian LeRoux wrote: Ah crap. Well, my thinking is just repackage it anyhow. (Not a world ending bug tracking nightmare.) On Mon, Feb 11, 2013 at 11:40 PM, Tim Kim wrote: > Someone had brought it up through the goog

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Andrew Grieve
I definitely think the use-case of per-platform files is valid. We already have this for plugin.xml I think, by putting tags within . Solving it through directory structure instead of through config.xml is easier I think. We should think about solving this for splash screens images as well. On

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Filip Maj
On the topic of splash screen images, we can use the same approach (I think). 1. Define a location for the splash screen img in your config.xml. 2. Use the merges/overrides feature described here to change it on a per-platform basis. It gets tricky tho when a single platform needs multiple images

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Filip Maj
BTW, Michael love the pull req, but is there any chance you can add tests for it? On 2/11/13 8:28 PM, "Michael Wolf" wrote: >Hey all: > >I submitted a pull request for an enhancement of the addition of a merges >folder/concept into the cli build process. > >https://github.com/apache/cordova-cli/

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Michal Mocny
Perhaps this is crazy, but: We already have all this awesome functionality for plugins -- would it be impossible to just implement an app as a plugin? On Tue, Feb 12, 2013 at 12:59 PM, Filip Maj wrote: > BTW, Michael love the pull req, but is there any chance you can add tests > for it? > > On

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Brian LeRoux
Splash screens and making an app a type of super plugin are rad ideas for other pull requests. ;) Attached image of me when idea of making an app a plugin came up. On Tue, Feb 12, 2013 at 5:58 PM, Michal Mocny wrote: > Perhaps this is crazy, but: We already have all this awesome functionality >

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Michael Wolf
Yup I can add a test for this over the next couple days. mw On 2/12/13 12:59 PM, "Filip Maj" wrote: >BTW, Michael love the pull req, but is there any chance you can add tests >for it? > >On 2/11/13 8:28 PM, "Michael Wolf" wrote: > >>Hey all: >> >>I submitted a pull request for an enhancement o

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Michal Mocny
On Tue, Feb 12, 2013 at 1:11 PM, Brian LeRoux wrote: > Splash screens and making an app a type of super plugin are rad ideas > for other pull requests. ;) > > Attached image of me when idea of making an app a plugin came up. No you didn't ;) > On Tue, Feb 12, 2013 at 5:58 PM, Michal Mocny wro

Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Michal Mocny
It seems as if we could just add a trivial amount of extra functionality to plugins, after which we could implement apps using the same flow/tools as plugin dev. This would have all kinds of benefits. Lets brainstorm what it would take to do this, and what roadblocks we would face, in order to ex

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Michal Mocny
>From the plugin spec description: "a plugin could be a single JavaScript, or some native code with no corresponding JavaScript." which I think applies equally well to apps. Plugins already support: * asset's and platforms (which was just a feature requested to add to apps for cordova-cli) * confi

replace incubator-* github repos with redirect?

2013-02-12 Thread Mike Billau
Hello everyone, I noticed that all of the incubator-* repositories are still up on github and nothing indicates that the project has graduated out of incubator status or has moved to new repositories. I think that this causes confusion for new users looking for Cordova and for new contributors wh

Re: replace incubator-* github repos with redirect?

2013-02-12 Thread Shazron
Actually I don't see any incubator-cordova-* repos on https://github.com/apache ? Are you referring to something else? On Tue, Feb 12, 2013 at 10:37 AM, Mike Billau wrote: > Hello everyone, > > I noticed that all of the incubator-* repositories are still up on github > and nothing indicates tha

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Filip Maj
>So, if an app was bundled as a plugin with its www folder, then if it >could >use config-file modification to set the startPage (this may not be >supported yet), would that be enough? Ideally plugins would support >importing a while config.xml file? I think so.. Currently config file modificati

Re: replace incubator-* github repos with redirect?

2013-02-12 Thread Shazron
Never mind - they start at page 5: https://github.com/apache/repositories?page=5 On Tue, Feb 12, 2013 at 10:40 AM, Shazron wrote: > Actually I don't see any incubator-cordova-* repos on > https://github.com/apache ? > Are you referring to something else? > > > On Tue, Feb 12, 2013 at 10:37 AM,

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Michael Wolf
Have looked at suggesting folks mock in-browser using ripple... however there are a few issues with that, firstly being simply doesn't work for non webkit platforms (ie windows phone... yah the cli doesn't currently support windows phone but no reason why it can't) ... Also while you can mock to wo

Re: replace incubator-* github repos with redirect?

2013-02-12 Thread Shazron
18 repos total. I can add tasks to get these resolved, but ultimately only someone with better privileges than the committers need to close these. I reckon once we are satisfied, we can file an INFRA issue to close these repos down. apache/incubator-cordova-android · GitHub

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Brian LeRoux
yes there is some issues w/ emulation in this approach but I think its a better architectural pattern for a universal project. we can make ripple w/ this style rather the other way around. On Tue, Feb 12, 2013 at 6:48 PM, Michael Wolf wrote: > Have looked at suggesting folks mock in-browser using

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Michal Mocny
On Tue, Feb 12, 2013 at 1:48 PM, Filip Maj wrote: > > >So, if an app was bundled as a plugin with its www folder, then if it > >could > >use config-file modification to set the startPage (this may not be > >supported yet), would that be enough? Ideally plugins would support > >importing a while

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Braden Shepherdson
Plugin devs are left to put together their own file structure. Plugins are pretty freeform, you specify where to find things with and tags; the installed locations have nothing to do with the plugin repo locations. The main difference that I can see is that plugins specify every file they want c

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Michal Mocny
Plugins can specify whole directories as well, so it would be trivial to copy the whole www folder, I believe. On Tue, Feb 12, 2013 at 2:31 PM, Braden Shepherdson wrote: > Plugin devs are left to put together their own file structure. Plugins are > pretty freeform, you specify where to find thin

Re: Symbol Mapping in Cordova

2013-02-12 Thread Andrew Grieve
I've just merged in most of the changes for this (CB-2227). Again, the goal here was to move all plugin-specific logic out of common files. It's not the end-game solution, but a step in the right direction. There are still some changes left on the symbolmapping branch that affect windows & webos.

Re: [jira] [Commented] (CB-2220) iOS version Splash Screen function has problem on iPhone 4 and iTouch 4

2013-02-12 Thread Andrew Grieve
Yaniv, is this something you'd be willing to look at? On Tue, Feb 12, 2013 at 2:19 PM, Kristofor Selden (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/CB-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576907#comment-13576907] > > Kr

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Filip Maj
This is correct Michal. Still not sure I like the fact that we are either a) creating a new manifest for applications that are at odds with config.xml or b) extending config.xml with our own shit. In the end the concern here is smart re-use of code (I.e. Hey, plugin installation is sort of like a

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Andrew Grieve
+1 to moving plugman into CLI. I think the two tools will have more and more overlap going forward. On Tue, Feb 12, 2013 at 3:00 PM, Filip Maj wrote: > This is correct Michal. > > Still not sure I like the fact that we are either a) creating a new > manifest for applications that are at odds wi

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Michal Mocny
That sounds great, Fil! -Michal On Tue, Feb 12, 2013 at 2:59 PM, Andrew Grieve wrote: > +1 to moving plugman into CLI. I think the two tools will have more and > more overlap going forward. > > > On Tue, Feb 12, 2013 at 3:00 PM, Filip Maj wrote: > > > This is correct Michal. > > > > Still not

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Filip Maj
Cool, let me loop back with Anis and come up with a breakdown of the code for both cli and plugman. Once we have it figured I'll come back to the list and we can schedule an online meeting? On 2/12/13 12:11 PM, "Michal Mocny" wrote: >That sounds great, Fil! > >-Michal > > >On Tue, Feb 12, 2013

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Michal Mocny
Sounds good. -Michal On Tue, Feb 12, 2013 at 3:20 PM, Filip Maj wrote: > Cool, let me loop back with Anis and come up with a breakdown of the code > for both cli and plugman. > > Once we have it figured I'll come back to the list and we can schedule an > online meeting? > > On 2/12/13 12:11 PM

Re: replace incubator-* github repos with redirect?

2013-02-12 Thread Shazron
https://issues.apache.org/jira/browse/CB-2417 On Tue, Feb 12, 2013 at 10:55 AM, Shazron wrote: > 18 repos total. I can add tasks to get these resolved, but ultimately only > someone with better privileges than the committers need to close these. I > reckon once we are satisfied, we can file an

Re: BlackBerry 2.4.0 Release

2013-02-12 Thread Steven Gill
+1. On Tue, Feb 12, 2013 at 9:43 AM, Jesse MacFadyen wrote: > +1 to repack. > > Cheers, > Jesse > > Sent from my iPhone5 > > On 2013-02-12, at 9:36 AM, Brian LeRoux wrote: > > Ah crap. Well, my thinking is just repackage it anyhow. (Not a world > ending bug tracking nightmare.) > > On Mon, Feb

Re: BlackBerry 2.4.0 Release

2013-02-12 Thread Tim Kim
All right, it looks like everything is re-packaged and working. On 12 February 2013 13:43, Steven Gill wrote: > +1. > > On Tue, Feb 12, 2013 at 9:43 AM, Jesse MacFadyen >wrote: > > > +1 to repack. > > > > Cheers, > > Jesse > > > > Sent from my iPhone5 > > > > On 2013-02-12, at 9:36 AM, Bri

Re: Proposed patch to prevent crash from malformed javascript in 2.4.0rc1

2013-02-12 Thread Shazron
Sorry for the late reply. Just took a look at it again and I don't see an attachment? On Thu, Feb 7, 2013 at 2:56 AM, Carl Peto wrote: > If it's OK, because I don't plan to contribute often, I've just attached a > formatted patch. > > If I start to do loads of bug fixes, I'll sort out proper fo

Re: Android file chooser

2013-02-12 Thread Simon MacDonald
Well, I didn't want to add an external dependency to Cordova to have a 3rd party app doing the file picking. It would be great to have something like this in Cordova and we've had some success with but it's not all the way there yet. For now this'll remain a plugin. Simon Mac Donald http://hi.im/s

Re: Android file chooser

2013-02-12 Thread Max Woghiren
Okay—I'd like to add an Android file picker plugin to core Cordova in light of the shortcomings with . I've created a bug hereand will create a pull request tomorrow (barring any objections, of course). On Tue, Feb 12, 2013 at 11:10 PM, Simon MacDona

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Anis KADRI
I believe this is a valid request. I like the idea of having platform-specific code only deployed to matching devices. I looked at the pull request and it looks good but as Fil mentioned, it needs some tests. On Tue, Feb 12, 2013 at 11:07 AM, Brian LeRoux wrote: > yes there is some issues w/ em

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Anis KADRI
I'd like to see where the overlap is before jumping in and merging the two code bases. I think that by essence plugins and apps are different. Even though they are close in that they both have manifest/assets/native files. I also like the existence of discrete tools that do one job rather than on

Re: Brainstorming Proposal: Implementing apps as plugins

2013-02-12 Thread Anis KADRI
BTW, because I happen to like contradictions. Plugins are not completely free-form. They still require some sort of directory structure for every supported platform (right now: iOS, Android and BlackBerry 10). Precisely, src/{ios,android,BlackBerry10} needs to be there or libraries (on android, bb1

Re: cordova command cli and merges concept pull request

2013-02-12 Thread Filip Maj
I'm working with Michael off this discussion thread to get the code up to par. Michael, feel free to update your pull request and ping this thread whenever you get a chance to update it. Then we can all take a look. On 2/12/13 10:15 PM, "Anis KADRI" wrote: >I believe this is a valid request. I