Missed CB-2606's birthday

2014-04-23 Thread Axel Nennker
https://issues.apache.org/jira/browse/CB-2606 is now one year old. Happy birthday! Please merge https://github.com/apache/cordova-cli/pull/166

Re: [Android] Refactoring for different engines

2014-04-23 Thread Joe Bowser
I'm fine with 4 pm. The coworking space closes at 5 pm, so Brian and I would have to find another location elsewhere. On Wed, Apr 23, 2014 at 8:45 PM, Michal Mocny wrote: > (Yeah 7pm Friday is more naughty than 4am for those of us with families.) > > I think the original intent was just supposed

RE: [Android] Refactoring for different engines

2014-04-23 Thread Hu, Ningxin
Understood. How about 9am Pacific, 12am Eastern and 0am China? Really appreciate. Thanks, -ningxin > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Thursday, April 24, 2014 11:45 AM > To: dev > Subject: Re: [Android] Refactorin

[GitHub] cordova-plugin-inappbrowser pull request: window.open failing with...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/22#issuecomment-41241090 Just pass an options object ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [Android] Refactoring for different engines

2014-04-23 Thread Michal Mocny
(Yeah 7pm Friday is more naughty than 4am for those of us with families.) I think the original intent was just supposed to be a meet & greet right? Lets just do it asap and consider formal scheduling with ample planning only if there are technical topics to discuss. It would be nice, though, if

Re: [GitHub] cordova-cli pull request: CB-6469 - Restore plugins from config.xm...

2014-04-23 Thread Michal Mocny
Gorkem, as an orthogonal issue to the syntax we use, I think there is another small problem with this patch as-is. "cordova plugin add org.apache.cordova.file-transfer && cordova plugin save" would have my application explicitly depend on org.apache.cordova.file. If in the future the dependency i

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Michal Mocny
Quick code example, which I think demonstrates my dislike of using in top-level application config.xml: > cordova create Foo && cd Foo > cordova platform add android > cordova plugin add org.apache.cordova.file-transfer > cordova plugin add org.chromium.polyfill.xhr_features@1.0.0 > cat ./platfor

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Michal Mocny
So I re-read that thread, and I think it's easiest to just copy the final summary: "I propose three things: 1. Punt all discussion of overhauling configuration files to the new year. 2. Drop my proposals above, as well as the summary Anis posted of last night's discussion. 3. Solve the immediate u

Re: [Android] Refactoring for different engines

2014-04-23 Thread Victor Sosa
4PM PST? That's 6 CST or 7 EST, me thinks. Seems to work for many of us On Apr 23, 2014 8:49 PM, "Brian LeRoux" wrote: > 4pm works for me… > > > On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin wrote: > > > I am in China. 1:00 PM PST means 4:00 AM here :o. > > Could you please schedule it a little b

Re: [Android] Refactoring for different engines

2014-04-23 Thread Josh Soref
Hu, Ningxin wrote: > I am in China. 1:00 PM PST means 4:00 AM here :o. > Could you please schedule it a little bit later, say 4:00 or 5:00 PM >PST? It will be highly appreciated. In principle, as someone on the East Coast. I will not show up for a meeting that might end past 5pm Eastern Time on a

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread Anis KADRI
We've already had a discussion about this very topic in the past [1]. The reason why I prefer is because it's already used in platforms. Therefore it would be the right path towards having a unique top-level config.xml and platforms as true build artifacts. On iOS and Android plugins are loaded on

[GitHub] cordova-plugin-inappbrowser pull request: window.open failing with...

2014-04-23 Thread dotNetkow
Github user dotNetkow commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/22#issuecomment-41236055 Thanks - this saved me! Hope it gets updated soon. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-23 Thread Anis KADRI
On Wed, Apr 23, 2014 at 8:41 AM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > On a side note, does it make sense to make Ripple another platform, just > like iOS, Android or Windows? Given that a lot of people use Ripple in > projects that also have plugins, it may make

Re: [Android] Refactoring for different engines

2014-04-23 Thread Brian LeRoux
4pm works for me… On Wed, Apr 23, 2014 at 6:19 PM, Hu, Ningxin wrote: > I am in China. 1:00 PM PST means 4:00 AM here :o. > Could you please schedule it a little bit later, say 4:00 or 5:00 PM PST? > It will be highly appreciated. > > Thanks, > -ningxin > > From: brian.ler...@gmail.com [mailto:

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Anis KADRI
+1 for Shaz! Thanks for everything Brian! On Wed, Apr 23, 2014 at 3:28 PM, Michael Brooks wrote: > Brian, thank you for all of the hard work that you've done over the past > few years. Drinks will have to be on the Cordova team. > > +1 Shaz for all the reasons listed above. > > > On Wed, Apr 23,

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Anis KADRI
+1 for jshint. On Wed, Apr 23, 2014 at 5:53 PM, Andrew Grieve wrote: > We already use jshint for cordova-js. Totally agree we should enabled > it for plugman/cli & make it run as a part of "npm test". > > On Wed, Apr 23, 2014 at 6:13 PM, Mark Koudritsky > wrote: > > +1 for jshint. > > > > > >

Re: [ANNOUNCE] Plugins released!

2014-04-23 Thread Carlos Santana
Thanks Ian, you earned the PluginRelease Badge! Steve super helpful now to have the doc on frontpage of plugin, Thanks! On Wed, Apr 23, 2014 at 5:46 PM, Brian LeRoux wrote: > \o. > thx ian > > > On Wed, Apr 23, 2014 at 2:16 PM, Mike Billau > wrote: > > > Who!!! > > > > > > On Wed, Apr 23,

RE: [Android] Refactoring for different engines

2014-04-23 Thread Hu, Ningxin
I am in China. 1:00 PM PST means 4:00 AM here :o. Could you please schedule it a little bit later, say 4:00 or 5:00 PM PST? It will be highly appreciated. Thanks, -ningxin From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Thursday, April 24, 2014 6:10

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Andrew Grieve
We already use jshint for cordova-js. Totally agree we should enabled it for plugman/cli & make it run as a part of "npm test". On Wed, Apr 23, 2014 at 6:13 PM, Mark Koudritsky wrote: > +1 for jshint. > > > I've been using it for some time now and it helps me a lot. Especially for > catching the

[GitHub] cordova-android pull request: defaults.xml: Add launch-mode prefer...

2014-04-23 Thread fardjad
GitHub user fardjad opened a pull request: https://github.com/apache/cordova-android/pull/98 defaults.xml: Add launch-mode preference Related: https://github.com/apache/cordova-cli/pull/164 You can merge this pull request into a Git repository by running: $ git pull https://git

[osx] adding osx to cli and plugman

2014-04-23 Thread Tobias Bocanegra
Hi, I would like to add osx to the list of installable platforms. The current state of cordova-osx [0] is now good and produces a working hello-world example ootb. I created an issue to track this [1] and two pull requests for cli [2] and plugman [3]. This is the first stab to get osx working an

[GitHub] cordova-plugman pull request: CB-6506 RTC: Add support for OSX

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-plugman/pull/75 CB-6506 RTC: Add support for OSX note: osx.js is copied from ios.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-p

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-cli/pull/170 CB-6506 RTC: Add support for OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-cli CB-6506 Alternatively you can rev

[GitHub] cordova-osx pull request: CB-6502 Invalid URL and version for osx ...

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/6 CB-6502 Invalid URL and version for osx platform You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-6502 Alternative

[GitHub] cordova-osx pull request: Fixing various project-helper scripts

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/5 Fixing various project-helper scripts fixes: * CB-2979 Add a ./cordova/lib/list-devices project-level helper script to OSX * CB-2971 Add a ./cordova/lib/list-started-emulators as projec

Re: [Android] Refactoring for different engines

2014-04-23 Thread Ian Clelland
That works for me On Wednesday, April 23, 2014, Joe Bowser wrote: > Sounds good > On Apr 23, 2014 3:10 PM, "Brian LeRoux" wrote: > > > How does 1:00PST on Friday work for a hangout for everyone? > > > > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser wrote: > > > >> BTW: Here's my PoC for Mozi

[GitHub] cordova-osx pull request: CB-6493 Project template organization

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/4 CB-6493 Project template organization [CB-6493 Project template organization - add www folder reference, prominent config.xml](https://issues.apache.org/jira/browse/CB-6493) You can merge this

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Michael Brooks
Brian, thank you for all of the hard work that you've done over the past few years. Drinks will have to be on the Cordova team. +1 Shaz for all the reasons listed above. On Wed, Apr 23, 2014 at 1:36 PM, RUDD, Brett wrote: > yep +1 to shaz, known (and worked on and off with) him for ten years a

Re: [Android] Refactoring for different engines

2014-04-23 Thread Joe Bowser
Sounds good On Apr 23, 2014 3:10 PM, "Brian LeRoux" wrote: > How does 1:00PST on Friday work for a hangout for everyone? > > > On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser wrote: > >> BTW: Here's my PoC for Mozilla so far. It's very broken! >> >> https://github.com/infil00p/MozillaView >> >> >>

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Mark Koudritsky
+1 for jshint. I've been using it for some time now and it helps me a lot. Especially for catching the simple errors like typos bad indentation and forgotten "var". Here is an example of jshint inline config in plugman/src/util/config-changes.js

Re: [Android] Refactoring for different engines

2014-04-23 Thread Brian LeRoux
How does 1:00PST on Friday work for a hangout for everyone? On Wed, Apr 23, 2014 at 2:36 PM, Joe Bowser wrote: > BTW: Here's my PoC for Mozilla so far. It's very broken! > > https://github.com/infil00p/MozillaView > > > > On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux wrote: > > So I found a

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Brian LeRoux
This may get rotten eggs thrown at me but I think it would be good to add jshint to the project. The style guidelines are definitely not being followed in the wiki, and this is a good use for a tool. (Like uncrustify but moreso.) This way, whatever we decide is in fashion, can be consistent. And

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread fardjad
Github user fardjad commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11925780 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set

Re: [ANNOUNCE] Plugins released!

2014-04-23 Thread Brian LeRoux
\o. thx ian On Wed, Apr 23, 2014 at 2:16 PM, Mike Billau wrote: > Who!!! > > > On Wed, Apr 23, 2014 at 5:08 PM, Steven Gill > wrote: > > > Yay! Thanks Ian! You rock. > > > > p.s. plugins.cordova.io now shows doc/index.md instead of readme.md when > > available. See > > http://plugins.cordo

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Joe Bowser
Can we have that magic git setting that fixes Windows carriage returns recorded in here? That'd be awesome. On Wed, Apr 23, 2014 at 2:29 PM, Martin Gonzalez Glez wrote: > Yes, we have to get to an agreement on that, and of course, we have to > follow the current style, I'm not proposing create a

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11925400 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set l

Re: [Android] Refactoring for different engines

2014-04-23 Thread Joe Bowser
BTW: Here's my PoC for Mozilla so far. It's very broken! https://github.com/infil00p/MozillaView On Wed, Apr 23, 2014 at 10:50 AM, Brian LeRoux wrote: > So I found a Moz hacker whom can help. what time on Fri do you guys want to > do this? > > > On Wed, Apr 23, 2014 at 10:31 AM, Ian Clelland

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Martin Gonzalez Glez
Yes, we have to get to an agreement on that, and of course, we have to follow the current style, I'm not proposing create a new style or follow another style or pattern. The whole listed items in Style Guide, are part of the feedback that so far, I have received from commiters. What I was trying to

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread fardjad
Github user fardjad commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11924941 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread mmocny
Github user mmocny commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11924705 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set l

Re: [ANNOUNCE] Plugins released!

2014-04-23 Thread Mike Billau
Who!!! On Wed, Apr 23, 2014 at 5:08 PM, Steven Gill wrote: > Yay! Thanks Ian! You rock. > > p.s. plugins.cordova.io now shows doc/index.md instead of readme.md when > available. See > http://plugins.cordova.io/#/package/org.apache.cordova.vibration > > > On Wed, Apr 23, 2014 at 2:05 PM, Ian

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread alessandronunes
Github user alessandronunes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215819 Thanks again. Good job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215581 For Plugins, we aim for a weekly release, however prior to this, our last one was over 5 weeks ago I think. For the core platforms, we used to aim for a month

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread alessandronunes
Github user alessandronunes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215371 Thanks Shaz! Do you know when, usually, Phonegap gets updated after this? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread fardjad
Github user fardjad commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11924083 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set

Re: [ANNOUNCE] Plugins released!

2014-04-23 Thread Steven Gill
Yay! Thanks Ian! You rock. p.s. plugins.cordova.io now shows doc/index.md instead of readme.md when available. See http://plugins.cordova.io/#/package/org.apache.cordova.vibration On Wed, Apr 23, 2014 at 2:05 PM, Ian Clelland wrote: > So, after 88 minutes of effort*, the Cordova core plugins ha

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215140 Woops, it just happened - plugins are released! http://cordova.apache.org/news/2014/04/23/plugins.release.html --- If your project is set up for it, you can

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41215022 @alessandronunes this was a bug in the File plugin. It should be fixed in the dev branch, or wait an hour or so when the new plugin version gets published.

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread fardjad
Github user fardjad commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11923890 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set

[ANNOUNCE] Plugins released!

2014-04-23 Thread Ian Clelland
So, after 88 minutes of effort*, the Cordova core plugins have all been updated and released to plugins.cordova.io and dist.apache.org. Latest versions: org.cordova.battery-status@0.2.8 org.cordova.camera@0.2.9 org.cordova.console@0.2.8 org.cordova.contacts@0.2.10 org.cordova.device@0.2.9 org.cord

[GitHub] cordova-cli pull request: android-parser: Add launch-mode preferen...

2014-04-23 Thread fardjad
Github user fardjad commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/164#discussion_r11923593 --- Diff: src/metadata/android_parser.js --- @@ -97,6 +108,29 @@ module.exports.prototype = { } } +// Set

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Martin Gonzalez Glez
Yes, agree. I can remove it. 2014-04-23 15:25 GMT-05:00 Mark Koudritsky : > The style guide contains the following two points that seem to partially > contradict each other. Ok if we just delete the second one? > >1. Remove unnecessary trailing whitespace in lines; this includes after >o

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-04-23 Thread alessandronunes
Github user alessandronunes commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-41214122 What about the "com.apple.MobileBackup"? I'm trying to set it but neither the success or the fail callback function is being called. --- If your proj

Re: Plugman owners need updating

2014-04-23 Thread Steven Gill
Done! On Wed, Apr 23, 2014 at 1:44 PM, Ian Clelland wrote: > Thanks, Shaz! > > > On Wed, Apr 23, 2014 at 4:40 PM, Shazron wrote: > > > Statusbar fixed -- added a breadth of committers, so they can in turn add > > whomever: > > $ plugman owner ls org.apache.cordova.statusbar > > shazron > > ian

Re: Plugman owners need updating

2014-04-23 Thread Ian Clelland
Thanks, Shaz! On Wed, Apr 23, 2014 at 4:40 PM, Shazron wrote: > Statusbar fixed -- added a breadth of committers, so they can in turn add > whomever: > $ plugman owner ls org.apache.cordova.statusbar > shazron > ian > stevegill > anis > agrieve > purplecabbage > > > > On Wed, Apr 23, 2014

Re: Patches for Tizen support as gitHub PRs

2014-04-23 Thread Ian Clelland
Awesome, thanks! On Wed, Apr 23, 2014 at 4:34 PM, Schulhof, Gabriel < gabriel.schul...@intel.com> wrote: > Hey! > > On Thu, Apr 17, 2014 at 3:49 PM, Ian Clelland > wrote: > > As far as I understand it, if the contributions are yours (and > Salvatore's), > > as they appear to be from the commits

Re: Plugman owners need updating

2014-04-23 Thread Shazron
Statusbar fixed -- added a breadth of committers, so they can in turn add whomever: $ plugman owner ls org.apache.cordova.statusbar shazron ian stevegill anis agrieve purplecabbage On Wed, Apr 23, 2014 at 1:29 PM, Andrew Grieve wrote: > Steve - can you update the owner list for these two

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-23 Thread cmarcelk
Github user cmarcelk commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41211898 I tried to merge this, but it didn't merge cleanly. Conflicts in 3 files. Could you rebase your branch on master so it will merge cleanly? --- If your proje

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread RUDD, Brett
yep +1 to shaz, known (and worked on and off with) him for ten years and once you get used to his jokes (~ year 6) he's fine. > > Off topic: Joe and Jim, please may you each put up email filters for the > others' comments? Its almost entirely you two trolls yelling at each > other, throwing sal

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Jesse
I agree with Andrew, there are several items in the style guide that I question. But mainly I question how a definitive guide can be defined without agreement ... @purplecabbage risingj.com On Wed, Apr 23, 2014 at 1:30 PM, Andrew Grieve wrote: > In general, I think the only style guideline

Re: Patches for Tizen support as gitHub PRs

2014-04-23 Thread Schulhof, Gabriel
Hey! On Thu, Apr 17, 2014 at 3:49 PM, Ian Clelland wrote: > As far as I understand it, if the contributions are yours (and Salvatore's), > as they appear to be from the commits, then you'll need to sign the ICLA. I've asked our legal folks whether it's OK for Salvatore and me to sign the ICLA, e

Re: Problem publishing plugins (was: [VOTE] Plugins Release)

2014-04-23 Thread Ian Clelland
Andrew got the plugman issue sorted out for me -- turns out I was still using an old version which I had installed via NPM; not the version in git. Also I wasn't an owner of any of the core plugins, so I couldn't publish them anyway. On Wed, Apr 23, 2014 at 4:06 PM, Ian Clelland wrote: > Steve -

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Andrew Grieve
In general, I think the only style guideline we need (at least for a non-per-repo sense), is to follow whatever style currently exists. On Wed, Apr 23, 2014 at 4:25 PM, Mark Koudritsky wrote: > The style guide contains the following two points that seem to partially > contradict each other. Ok if

Plugman owners need updating

2014-04-23 Thread Andrew Grieve
Steve - can you update the owner list for these two plugins: $ plugman owner ls org.apache.cordova.device-motion anis stevegill $ plugman owner ls org.apache.cordova.battery-status anis stevegill They should look like: $ plugman owner ls org.apache.cordova.file anis stevegill maxw agrieve

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-04-23 Thread Mark Koudritsky
The style guide contains the following two points that seem to partially contradict each other. Ok if we just delete the second one? 1. Remove unnecessary trailing whitespace in lines; this includes after operators, commas, semicolons or braces. 2. trailing spaces - you should turn off "r

Re: Problem publishing plugins (was: [VOTE] Plugins Release)

2014-04-23 Thread Steven Gill
Hey Ian, I will look into the issue right now. Want to jump on #cordova (irc.freenode.net) -Steve On Wed, Apr 23, 2014 at 1:06 PM, Ian Clelland wrote: > Steve -- > > I just tried to publish with 'plugman publish .' from each plugin > directory, as the release docs say to do. Each plugin claim

[GitHub] cordova-cli pull request: First run at pass through. Works for run...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugman pull request: [CB-5258] use exit library

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: [ubuntu] fix url in platforms.js

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugman pull request: unnecessary to add 'frameworks' to s...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: 3.0.x Unable to do anything with CLI cor...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Blackberry Fixes

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugman pull request: Updated amazon-fireos as a platform.

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: [CB-4376] Read config.xml after "before ...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugman pull request: CB-5316 Spell Cordova as a brand unl...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-5093 versionCode attr support added t...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugman pull request: CB-5017 accept proxy config for plug...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Ignore exception when plugin not install...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Fix for issue CB-3191

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Response the correct content type

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: Add CORDOVA_HOME environment var

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-2606, CB-3571 Add support for ,...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Problem publishing plugins (was: [VOTE] Plugins Release)

2014-04-23 Thread Ian Clelland
Steve -- I just tried to publish with 'plugman publish .' from each plugin directory, as the release docs say to do. Each plugin claimed that it was published (taking 10-20 seconds each, so it appeared to be doing *something*) I don't see the updated plugins on plugins.cordova.io, though -- is th

[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/23#issuecomment-41207048 Hi @vladimir-kotikov I have added a comment in Jira here : https://issues.apache.org/jira/browse/CB-6266?focusedCommentId=13978791&page=com.atlassia

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Marcel Kinard
+1 to Shaz in the PMC Chair role. Brian, you've done a tremendous job helping to build the community and contribute to the direction. I hope that doesn't change! I got to meet Jim and other board members at ApacheCon a couple weeks ago. My takeaway is that they are super nice people, very reaso

[GitHub] cordova-mobile-spec pull request: Fixing firefoxos spec

2014-04-23 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/56#issuecomment-41205846 confirmed - this fixes mobilespec on Firefox OS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41205346 I was expecting for example that it would actually include the (more descriptive) JIRA issue title if I just said CB-6503 to avoid useless cut

[GitHub] cordova-mobile-spec pull request: Fixing firefoxos spec

2014-04-23 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/56 Fixing firefoxos spec Added firefoxos platform and fixed cordova-incl.js to work on firefoxos. You can merge this pull request into a Git repository by running: $ git pull https://g

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204431 Actually, I was correct. When you edited the title to include the issue id, and then commented, see what happened: https://issues.apache.org/jira/br

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204117 Thanks! Appreciate your contrib and you filing the issue. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204151 Thanks. The automagical link is just when the pull request is merged into master, the jira issue gets updated with the commit.

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41203933 @jesse was able to edit out the version change here. @shazron done but manually, no automagical linking detected :-/ --- If your project is

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41202671 @machenmusik the sign up is confusing. You have to click Log In to see the sign up link: https://issues.apache.org/jira/secure/Signup!default.jspa

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread machenmusik
Github user machenmusik commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41202400 @jesse the version change was just so one could tell version I was using a modified version. (mac being my initials) I assume you would c

Re: Nomination for a new chair for Apache Cordova

2014-04-23 Thread Marvin Humphrey
On Wed, Apr 23, 2014 at 11:17 AM, Joe Bowser wrote: > That's actually insane that you can't quit until the meeting. You can > normally resign a post by writing a resignation letter in most places. > Why is this? Brian could resign, but that would leave a vacancy until the Board passes a resoluti

[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: CB-6360: Fix for crash o...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...

2014-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

  1   2   >