[GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....

2014-06-16 Thread jpalermo
Github user jpalermo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/23#issuecomment-46143691 Rebased the commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: CB-6945 Make Camera plugin ind...

2014-06-16 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/33 CB-6945 Make Camera plugin independent from File plugin on windows 8 After resolving [CB-6920](https://issues.apache.org/jira/browse/CB-6920) and

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151067 Pls take a look [here](https://github.com/apache/cordova-plugin-splashscreen/blob/master/doc/index.md#android-quirks_) and

[GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread rohitagg28
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151794 Yes I have used these methods but these all suggest to replace the image into platforms folder that means to add manually but I want to add splashscreen without

Re: [GitHub] cordova-cli pull request: CB-2606 add icon support

2014-06-16 Thread Axel Nennker
I want to make clear that splash icons have nothing to do with CB-2606. Splash icons are handled in this issue: https://issues.apache.org/jira/browse/CB-3571 I have a PR for this https://github.com/apache/cordova-lib/pull/30 that implements this for Android. -Axel 2014-06-16 10:46 GMT+02:00

Re: File transfer and HTTP caching

2014-06-16 Thread Javier Puerto
I've created a test case for the caching problem that works fine with my patched plugin. The problem is that with the unpatched plugin versoin, the test doesn't works because the getMetadata method (nor getFile) it's working if the file was corrupted by the bug. The method is not executed at all,

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371 The usage LGTM. But does current implementation remove all default cordova splash screen images if there is no splash element defined? Also, on Android icons and

File-transfer: delete target file on process error

2014-06-16 Thread Javier Puerto
Hi Cordova developers, I'm creating a system to download/update several resources from a server to the device and I've observe a behaviour that breaks my use case. After fix the issue CB-6928, I'm able to download/update all the resources without problems. My next test was to try to download the

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread AxelNennker
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46165459 The current code does not remove the default cordova splash screens if there are any but there is no splash in config.xml I think the default splash screens

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46166927 @AxelNennker, thx for the clarification! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46170707 Here is proposal for standartized splashscreen support across platforms: https://gist.github.com/vladimir-kotikov/875a5f61a88a508d6ca9 --- If your project

[GitHub] cordova-lib pull request: CB-3571: support for splash element in...

2014-06-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46172077 @AxelNennker ok, i started with WP8, Windows8 and iOS implementations, based on your work here: https://github.com/MSOpenTech/cordova-lib/tree/CB-3571. ---

[GitHub] cordova-docs pull request: 3.0.x

2014-06-16 Thread guglie
GitHub user guglie opened a pull request: https://github.com/apache/cordova-docs/pull/213 3.0.x offline and online event descriptions were *swapped* You can merge this pull request into a Git repository by running: $ git pull https://github.com/guglie/cordova-docs 3.0.x

[CANCELLED][VOTE] Tools release

2014-06-16 Thread Ian Clelland
I'm fine with delaying until then, and through further testing. The vote is hereby CANCELLED. Ian On Fri, Jun 13, 2014 at 1:32 PM, Joe Bowser bows...@gmail.com wrote: I agree. I haven't tested it yet. I'm fine with delaying it. On Fri, Jun 13, 2014 at 10:29 AM, Andrew Grieve

[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...

2014-06-16 Thread drkemp
GitHub user drkemp opened a pull request: https://github.com/apache/cordova-app-harness/pull/1 [CB6947] move app directory by default. for file-by-file use parameter m... Change default zip push behavior to move the base directory instead of file-by-file This reduces the number

[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...

2014-06-16 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-app-harness/pull/1#issuecomment-46182293 Is that literally '`xx`', or is that a placeholder for some other value? --- If your project is set up for it, you can reply to this email and have your

Re: Cordova hooks always verbose.

2014-06-16 Thread Carlos Santana
I agree with this balance that Tommy proposed. Having a simple one liner by default it shows intention, and progress (i.e. not halted). --Carlos On Fri, Jun 13, 2014 at 9:15 PM, tommy-carlos williams to...@devgeeks.org wrote: My personal preference would be (but this is overall, not just for

Re: Browserify JS is in

2014-06-16 Thread Michal Mocny
Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks for landing this this way, and for the useful report. -Michal On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI anis.ka...@gmail.com wrote: Yo, Just wanted to let everyone know that I added browserify

documentation for adding a new platform to cordova

2014-06-16 Thread Puneet Kaur
Hey, Just wished to ask where is the detail documentation of adding a platform ? As I explore for sugar, and go through the repositories, there are soo many things to do but there isn't a word about them anywhere.I wonder how the other platforms made it. Are there some dedicated persons , a few

opened a ticket to add sugar as a platform to cordova

2014-06-16 Thread Puneet Kaur
Hey all, I have opened a ticket to add sugar as a platform to cordova : https://issues.apache.org/jira/browse/CB-6948 Your views are welcome :-) Regards, Puneet

Re: WKWebView for iOS8

2014-06-16 Thread Andrew Grieve
Awesome. Shaz (or anyone else), curious if you've tested yet to see if the whitelist still works with WKWebView? (e.g. does it go through NSURLProtocol?) On Sat, Jun 14, 2014 at 8:16 PM, tommy-carlos williams to...@devgeeks.org wrote: This looks promising. Thanks for the update, Shazron.

Re: File-transfer: delete target file on process error

2014-06-16 Thread Andrew Grieve
I think this behaviour has been around for a while, and makes sense in the majority of cases. Best practice is to download to a temporary location, and then upon success move the file to its final spot. That said, I think it'd be fine to add an option for not delete on error. On Mon, Jun 16,

Re: WKWebView for iOS8

2014-06-16 Thread Shazron
Haven't yet - but from what I read - no. Something about requests being out of process On Monday, June 16, 2014, Andrew Grieve agri...@chromium.org wrote: Awesome. Shaz (or anyone else), curious if you've tested yet to see if the whitelist still works with WKWebView? (e.g. does it go through

cordova 3.5 ios app stuck on splashscreen after long idle on after force close

2014-06-16 Thread smo
hi list sorry to post here but i still have this damn problem only on ios (iphone 3gs, ios 6.1) since months everything is in the title but, the first time i launch my app i see the splashscreen then few seconds later i see the spinner then my app launch normally, right ... now, if i force

[GitHub] cordova-plugin-globalization pull request: The ISO 639-2 code is r...

2014-06-16 Thread svkirans
Github user svkirans closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...

2014-06-16 Thread drkemp
Github user drkemp commented on the pull request: https://github.com/apache/cordova-app-harness/pull/1#issuecomment-46198612 That was an oops. Meant to change the parameter - change submitted. --- If your project is set up for it, you can reply to this email and have your reply

Re: cordova 3.5 ios app stuck on splashscreen after long idle on after force close

2014-06-16 Thread Shazron
This is a mailing list for the development of Cordova itself, not a user list. Please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and you can be notified. Sign up here: https://issues.apache.org/jira/secure/Signup!default.jspa

Re: Plugman support for Android libraries

2014-06-16 Thread Andrew Grieve
PR looks good (and updates tests). Don't think we need a new test. Will try and sanity check (probably tomorrow). On Fri, Jun 13, 2014 at 12:48 PM, Martin Bektchiev martin.bektch...@telerik.com wrote: Hi, I created a PR for this but didn't have time to add any new unit tests. Can you

Re: Browserify JS is in

2014-06-16 Thread Andrew Grieve
Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org wrote: Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks

Re: cordova plugin splashscreen

2014-06-16 Thread Mike Billau
Thanks Axel. It looks like the Icon and Splash Screen guide mentions doing it this way but I will update the Android Quirks section. Good catch. On Sat, Jun 14, 2014 at 3:42 PM, Axel Nennker ignisvul...@gmail.com wrote: Hi, I think that the section about Android quirks is outdated:

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
GitHub user dzeims opened a pull request: https://github.com/apache/cordova-plugin-file/pull/52 CB-6940: Android: context.getExternal* methods return null if sdcard isn't in mou... ...nted state, causing exceptions that prevent startup from reaching readystate You can merge this

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Michal Mocny
I don't think we need to vote for anything but releases. Unless we cannot agree and decide a vote is all that can settle (unlikely). FWIW, I also like semicolons, but I wasn't aware when/why this jshint setting was made. -Michal On Fri, Jun 13, 2014 at 5:46 PM, Jesse purplecabb...@gmail.com

[GitHub] cordova-coho pull request: CB-6941 gnode: Tell people to run npm i...

2014-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
Github user dzeims commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46218127 I've updated the try/catch blocks and wrapped them with an Environment.getExternalStorageState() check I noticed was being used in FileUtils. From what I

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
Github user dzeims commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46221077 My mistake, it should be NullPointerException. Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on

plugin test framework

2014-06-16 Thread Marcel Kinard
Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test framework. Staci Cooper will be leading this effort, and Martin Gonzalez will be a part of it. So

staff change

2014-06-16 Thread Marcel Kinard
Wanted to let the community know about a staff change here at IBM. James Jong, who has been working in the iOS area, is transferring to a different department internally to work on a new product. He will be using Cordova and writing some new native code for the product, so he’s a natural fit,

Re: plugin test framework

2014-06-16 Thread Michal Mocny
Fantastic! I'll try to keep an eye out on the PR's, and please ping me if you would like any help. -Michal On Mon, Jun 16, 2014 at 3:25 PM, Marcel Kinard cmarc...@gmail.com wrote: Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week

Re: staff change

2014-06-16 Thread Michal Mocny
Thanks for the update. See you around James, and hello Eric! On Mon, Jun 16, 2014 at 3:40 PM, Marcel Kinard cmarc...@gmail.com wrote: Wanted to let the community know about a staff change here at IBM. James Jong, who has been working in the iOS area, is transferring to a different

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Marcel Kinard
I may be old school, but I like semicolons and agree. On Jun 13, 2014, at 5:46 PM, Jesse purplecabb...@gmail.com wrote: Rebooting this thread. I just noticed a ton of missing semicolons in the cordova-cli/src/cli.js, so I ran jshint and discovered that we explicitly set asi:true I don't

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Mark Koudritsky
That was me who added asi:true and a bunch of code without semicolons in cli.js. The short wiki doc we have for a style guide https://wiki.apache.org/cordova/StyleGuide#line-19 says that semicolons are unnecessary visual entropy This is consistent with the comma-first style it describes in

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Martin Gonzalez
I'm agree with the use of semicolons. I think we should keep it consistent with the rest of the code, we should be on the same page about the code style. Regards. 2014-06-16 15:09 GMT-05:00 Mark Koudritsky kam...@google.com: That was me who added asi:true and a bunch of code without

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

2014-06-16 Thread EionRobb
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-46233044 ICLA all signed now. Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Mark Koudritsky
To make it clear, I don't really care whether to use semicolons or not, but I do want cordova to have a style guide which I can follow without surprising people too much. Which is obviously not the case with our current style guide :)

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46241179 I've accepted the first two and did the last fix at the same time. Can you close this pull request, since I don't remember how Apache wants us to do this.

Re: cordova 3.5 ios app stuck on splashscreen after long idle on after force close

2014-06-16 Thread smo
problem reported here: https://issues.apache.org/jira/browse/CB-6952 ps: even if the PID is not listed anymore the app won t restart … thanks Le 16 juin 2014 à 22:39, smo s.la...@gmail.com a écrit : hi thanks just found the problem (i think) i downloaded the devicestats app from the

[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...

2014-06-16 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-46241419 And there you are ... https://people.apache.org/committer-index.html --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file-transfer pull request: properly uses the fileK...

2014-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...

2014-06-16 Thread dzeims
Github user dzeims closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: Update FileProxy.js

2014-06-16 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/34#issuecomment-46251489 for some reason that did not close it ... Please close this one. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...

2014-06-16 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-46251564 This code is fully merged. Please close this pull request. Thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-file pull request: Update FileProxy.js

2014-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: Add win8 support for readAsBinar...

2014-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Support for Windows Universal apps (Windows 8.1 and Windows Phone 8.1)

2014-06-16 Thread Jesse
I have discussed this at length already with Parashuram and completely support the proposal as documented, which might not be evident from just looking at the docs and links. Since there has not been much action on this item, I think we are okay to just move ahead Parashuram. Let's consider this

RE: Cordova strategy for Hosted Apps

2014-06-16 Thread Jeff Burtoft
The origin of the question... I'm trying to figure out where an investment makes the most sense. -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, June 10, 2014 11:31 AM To: dev@cordova.apache.org Subject: Re:

Re: plugin test framework

2014-06-16 Thread Andrew Grieve
Yeah, really exciting. Thanks for taking this on. On Mon, Jun 16, 2014 at 3:42 PM, Michal Mocny mmo...@chromium.org wrote: Fantastic! I'll try to keep an eye out on the PR's, and please ping me if you would like any help. -Michal On Mon, Jun 16, 2014 at 3:25 PM, Marcel Kinard

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Andrew Grieve
I haven't seen our style guide followed, and generally don't think style is a thing that can really be enforced without tools or code review. How about deleting the wiki page and doubling down on jshint? Can we tell jshint to force ;s while allowing comma-first? On Mon, Jun 16, 2014 at 5:00 PM,

[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...

2014-06-16 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-app-harness/pull/1#discussion_r13839802 --- Diff: www/cdvah/js/HarnessServer.js --- @@ -272,15 +278,30 @@ app.updatingStatus = unzipPercentage;

Re: [Proposal] Cordova guidelines part of ContributorWorkflow

2014-06-16 Thread Ian Clelland
/* jshint laxcomma: true */ at the top of a JS file should do it. Ref: http://www.jshint.com/docs/options/#laxcomma On Mon, Jun 16, 2014 at 9:34 PM, Andrew Grieve agri...@chromium.org wrote: I haven't seen our style guide followed, and generally don't think style is a thing that can really

[GitHub] cordova-lib pull request: CB-6698 Automatically copy sub-libraries...

2014-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is