2014-06-16 17:01 GMT+02:00 Andrew Grieve agri...@chromium.org:
I think this behaviour has been around for a while, and makes sense in the
majority of cases.
Yep, I did a git blame and this fragment of code was there from the
beginning.
Best practice is to download to a temporary location,
Github user jpuerto closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jpuerto commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/31#issuecomment-46279769
As commented in the dev mailing list, this patch is not valid. We need to
return the caching status with the error callback so the developer can act
Github user mlegenhausen commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/19#issuecomment-46285627
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user hkuiyo opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/50
Fix opening of files in Windows Phone 8.
The files weren't being opened, because of UriKind.Absolute.
For example: entry.toNativeURL() results in x-wmapp0://example.pdf/.
Github user hkuiyo commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/48#issuecomment-46294530
See pull request #50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hkuiyo closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user hkuiyo commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/50#discussion_r13853573
--- Diff: src/wp/InAppBrowser.cs ---
@@ -250,6 +251,30 @@ private void ShowCordovaBrowser(string url)
}
}
I've been playing with Gradle builds for Cordova Android, and have managed
to put together an initial working build system, which I've committted in
the 4.0.x branch.
If anyone wants to test it out, check out and build a project with that
branch. Then, from the platforms/android dir, just run
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/31
CB-6954 Share events.js between cordova and plugman
https://issues.apache.org/jira/browse/CB-6954
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user dzeims opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/18
CB-6944: Android: Fix file permission for camera app image media capture
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-app-harness/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
How about adding a second parameter to the callback? Android and iOS
bridges both support this natively, and you can simulate it on other
platforms by manually unpacking the parameters in your own callback.
On Tue, Jun 17, 2014 at 4:18 AM, Javier Puerto jpue...@gmail.com wrote:
2014-06-16
I think it's better to use the error callback because for cached resources
doesn't makes sense to use the Entry as parameter as the target will not
exists..There's no error but the file transfer was unable to download
anything due to the 304 response so IMO the error callback could do the job.
Hey,
I'm looking into CB-6924 https://issues.apache.org/jira/browse/CB-6924,
where I'm seeing a memory leak in WP8 when navigating back and forth from a
native to a hybrid page. A new page is being created every time you
navigate to the Cordova page, and none of them are garbage collected.
Is
+1
For historical context, there was a time when finding/retaining committers
was more important than concern about the fickle style of JS that came into
fashion that week. We would even accept a pull request if it had tabs
instead of spaces!
But ya lets go bananas on JSHint. Cleaning up those
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-wp8/pull/41
CB-6924 Fixed memory leak in WP page navigation
Occurred when navigating back and forth from native to hybrid page.
You can merge this pull request into a Git repository by running:
$ git
Github user stacic commented on the pull request:
https://github.com/apache/cordova-wp8/pull/41#issuecomment-46341089
I built mobile-spec with these changes and didn't see any new tests failing.
---
If your project is set up for it, you can reply to this email and have your
reply
Don't tell me you would accept patches written using emacs?
On Tue, Jun 17, 2014 at 12:45 PM, Brian LeRoux b...@brian.io wrote:
+1
For historical context, there was a time when finding/retaining committers
was more important than concern about the fickle style of JS that came into
fashion
The memory leak was caused by event listeners for PhoneApplicationService.
I unwired them in CordovaBrowser_Unloaded (pull request:
https://github.com/apache/cordova-wp8/pull/41). It fixes the leak but I
want to make sure it doesn't go against the intended behavior.
On Tue, Jun 17, 2014 at 11:58
Is there any predev document?
Dnia Mon Jun 16 18:30:46 2014 Andrew Grieve pisze:
Yeah, really exciting. Thanks for taking this on.
On Mon, Jun 16, 2014 at 3:42 PM, Michal Mocny mmo...@chromium.org wrote:
Fantastic!
I'll try to keep an eye out on the PR's, and please ping me if you would
Thanks for the update Marcel.
James, it's been great working with you and I hope we still cross paths!
It's incredibly important for all of us to use the product/tool that we
create, so I'm happy to hear that you're stepping into the consumer-side!
Don't be a stranger to submitting issues and
What do you mean?
On Tue, Jun 17, 2014 at 1:50 PM, Piotr Zalewa pzal...@mozilla.com wrote:
Is there any predev document?
Dnia Mon Jun 16 18:30:46 2014 Andrew Grieve pisze:
Yeah, really exciting. Thanks for taking this on.
On Mon, Jun 16, 2014 at 3:42 PM, Michal Mocny
a documentation explaining how it's gonna work
Dnia Tue Jun 17 10:51:58 2014 Michal Mocny pisze:
What do you mean?
On Tue, Jun 17, 2014 at 1:50 PM, Piotr Zalewa pzal...@mozilla.com wrote:
Is there any predev document?
Dnia Mon Jun 16 18:30:46 2014 Andrew Grieve pisze:
Yeah, really
No regrets. ;)
On Tue, Jun 17, 2014 at 10:49 AM, Michal Mocny mmo...@chromium.org wrote:
Don't tell me you would accept patches written using emacs?
On Tue, Jun 17, 2014 at 12:45 PM, Brian LeRoux b...@brian.io wrote:
+1
For historical context, there was a time when finding/retaining
Thanks Staci,
This was a use-case I didn't spend a lot of time on.
@purplecabbage
risingj.com
On Tue, Jun 17, 2014 at 10:49 AM, Staci Cooper staci@gmail.com wrote:
The memory leak was caused by event listeners for PhoneApplicationService.
I unwired them in CordovaBrowser_Unloaded (pull
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
This is the Cordova Plugin Test Framework readme.md, you can catch up with
the functionality by reading some of the content:
Repository:
https://github.com/apache/cordova-labs
Docs:
https://github.com/apache/cordova-labs/blob/master/README.md
Github user yaurthek closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Martin, thanks for posting those links.
And I'll look into the INFRA tickets I need to file to set up a repo for
that plugin, since its ready to come out of labs.
On Tue, Jun 17, 2014 at 2:06 PM, Martin Gonzalez
martin.c.glez.g...@gmail.com wrote:
This is the Cordova Plugin Test Framework
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/8#issuecomment-46357475
Thanks @shatran
`name` is not a supported property of the device info passed back.
`info.model` should return
Github user ceetah commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46358048
newbie here. I stumbled upon this error too. and happily found your fix.
but I do not know how I can add this fix to my application's plugin.
Thanks Martin,
Has it been considered to create a separate command testrun or
similar which would remove the need to edit the config.xml?
Dnia Tue Jun 17 11:58:33 2014 Michal Mocny pisze:
Martin, thanks for posting those links.
And I'll look into the INFRA tickets I need to file to set up a
It would be a nice to have in the cli, aimed to just setup the right path
in the config.xml, maybe along with an another argument to build,
run/emulate as well.
It sounds great.
2014-06-17 15:21 GMT-05:00 Piotr Zalewa pzal...@mozilla.com:
Thanks Martin,
Has it been considered to create a
One thing more - it would be great if user could create a test using
test harness app as well. Is it also considered?
Dnia Tue Jun 17 13:27:22 2014 Martin Gonzalez pisze:
It would be a nice to have in the cli, aimed to just setup the right path
in the config.xml, maybe along with an another
we could do a batch reformat using:
https://github.com/rdio/jsfmt
On Tue, Jun 17, 2014 at 1:28 PM, Mark Koudritsky kam...@google.com wrote:
JSHint is awesome and I'm slowly adding the JSHint config lines to almost
every file I touch in cordova-lib.
But as Shazron mentioned back in April in
At the time I went through my design iterations I just didn't want to
necessarily depend on cordova tooling changes / documentation. In other
words, someone else may have a different strategy for testing..
My personal opinion would be have the test plugin ship with a plugin hook
(those are in,
Piotr: Actually I'm not sure how running tests in the harness would work,
since the path to the resource may be different. However, in general, with
development using the harness you aren't making any changes to plugins.
The whole point is for app developers who want to modify only web
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-blackberry/pull/163
CB-6968 fix bashism (source) in update script and bb10-ndk-version
You can merge this pull request into a Git repository by running:
$ git pull
... and as Joe noticed, I managed to commit all of this locally, and push
none of it.
That's fixed; things should work better now.
Ian
On Tue, Jun 17, 2014 at 9:29 AM, Ian Clelland iclell...@chromium.org
wrote:
I've been playing with Gradle builds for Cordova Android, and have managed
to
I'm getting the following error:
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
Searching for this error tells me that I need the GradleWrapper JAR
file. I'm not sure where we'd get this file from, but it seems
required for this to work.
On Tue, Jun 17, 2014 at
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
If it's cached... won't it exist?
On Tue, Jun 17, 2014 at 11:56 AM, Javier Puerto jpue...@gmail.com wrote:
I think it's better to use the error callback because for cached resources
doesn't makes sense to use the Entry as parameter as the target will not
exists..There's no error but the file
On Tue, Jun 17, 2014 at 9:34 PM, Andrew Grieve agri...@chromium.org wrote:
If it's cached... won't it exist?
Exactly this. A 304 request should only be received in response to a
conditional GET request. There's generally no reason to send a conditional
GET unless you already have a cached copy
I'm looking into this now; as far as I understood the wrapping process, the
files that were checked into git should have been sufficient to download
gradle and all of its dependencies. Obviously something is missing, though.
I'll let you know as soon as I figure out which piece it is.
Ian
On
Github user dozer47528 commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46393109
@ceetah ,@clelland has commited it 8 days ago. You can pull the the new
code from `master`.
---
If your project is set up for it, you
48 matches
Mail list logo
