RE: Plugin Install Hooks

2015-02-10 Thread Horn, Julian C
Thanks for the pointer Shazron. I read through all of this interesting discussion. I agree that sandboxing is hard and prompting is problematic. But there's still an issue here. If there is no mechanism to exclude scripting in untrusted plugins then build servers are unlikely to accept any

ArrayBuffers in WP8 Plugins

2015-02-10 Thread Don Coleman
Are there any examples of deserializing arraybuffers in WP8 plugins? I'm looking for the WP8 equivalent of Android's byte[] data = args. getArrayBuffer(3);

[GitHub] cordova-medic pull request: CB-8452 Set apk path for gradle build

2015-02-10 Thread amfowler
GitHub user amfowler opened a pull request: https://github.com/apache/cordova-medic/pull/30 CB-8452 Set apk path for gradle build You can merge this pull request into a Git repository by running: $ git pull https://github.com/amfowler/cordova-medic CB-8452 Alternatively you

Re: cordova-lib in BitHound

2015-02-10 Thread Gord Tanner
Thanks for the shoutout! Cordova.js has been one of our test case repos in the development of bitHound. Gord On Tue, Feb 10, 2015 at 7:01 AM Andrew Grieve agri...@chromium.org wrote: Pretty cool code analysis tool from the creators of Ripple! https://www.bithound.io/apache/cordova-lib

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-10 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/164 CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `lib-file` and `framework` elements in the windows platform of

Android JUnit Tests Now Pass

2015-02-10 Thread Andrew Grieve
Spent some time cleaning up the tests. Certainly they could be made even better made to test more things, but at least they pass now :) Much of the change was deleting copy paste, and deleting commented out tests: 53 files changed, 941 insertions(+), 2610 deletions(-)

[GitHub] cordova-plugin-console pull request: CB-8362 Add Windows platform ...

2015-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: Does this plugin support the current platform?

2015-02-10 Thread Horn, Julian C
The natural way to determine whether some functionality is available is to use the feature detection pattern. That is, if you want to call some function normally found at myobj.myfunc, you write code like this: If (myobj (typeof myobj.myfunc === 'function')) ... For this to work you must

Re: Plugin Install Hooks

2015-02-10 Thread Andrew Grieve
You can also run arbitrary scripts via the engine tag. (you can specify your own script in it). On Tue, Feb 10, 2015 at 12:22 PM, Horn, Julian C julian.c.h...@intel.com wrote: Actually I see it the other way around. If you want to trust a plugin, you can make that decision; it's your machine.

RE: Plugin Install Hooks

2015-02-10 Thread Horn, Julian C
Actually I see it the other way around. If you want to trust a plugin, you can make that decision; it's your machine. The build server doesn’t trust the plugins you trust. -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Tuesday,

Re: Plugin Install Hooks

2015-02-10 Thread Michal Mocny
..Not to mention, these plugins will be running on end users' personal devices. That sounds vastly more concerning than running hooks on a server you control and can sandbox. On Tue, Feb 10, 2015 at 11:25 AM, Michal Mocny mmo...@chromium.org wrote: So, I think this is not different than

Re: Plugin Install Hooks

2015-02-10 Thread Michal Mocny
So, I think this is not different than downloading and running packages from any package manager. That said, I think a --suppress-hooks flag would be fine. I suggest you file a JIRA so others can chime in, and if you want it to land soon I would take a stab at a PR. -Michal On Tue, Feb 10,

Re: Does this plugin support the current platform?

2015-02-10 Thread Axel Nennker
And then the app has to load that package.json ? On Feb 10, 2015 5:28 PM, Steven Gill stevengil...@gmail.com wrote: Plugin.xml has a platforms tag for what platforms it supports. That info gets uploaded to the Cordova plugins registry when publishing. Soon this info will be available in

[GitHub] cordova-plugin-splashscreen pull request: CB-8397 Add support for ...

2015-02-10 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/35 CB-8397 Add support for Windows Phone 8.1 splashscreen https://issues.apache.org/jira/browse/CB-8397 You can merge this pull request into a Git repository by running: $

Introduction!

2015-02-10 Thread Eric Kidder
The workflow suggested that I introduce myself and so here I am. I'm Eric Kidder and I am a graduate student at GeorgiaTech as well as an employee of GeorgiaTech Research Institute. I've been doing software development for many, many years, but only started using Cordova fairly recently, mostly

RE: Does this plugin support the current platform?

2015-02-10 Thread Tommy Williams
This won't actually help right now, but that feature detection would actually be possible if the plugin's clobbers was always a child of the platform in plugin.xml. Right now, most plugins have their clobbers global to all platforms, supported or not. If the clobbers is a child of the platform,

Re: Plugin Install Hooks

2015-02-10 Thread Michal Mocny
I meant that the developer is shipping a plugin to the store which end users will run. If the contacts plugin is malicious, it wouldn't be running hooks on the devs machine, it would be uploading users' contacts to some website. You as a developer should vet the plugin to make sure it isn't. At

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-02-10 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73752088 Thanks for this, I've been cracking my head open trying to get the web view to shrink! This fork is the only one that does it on the latest iOS 8.1 but you

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-02-10 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-73753163 Just tried this together with wk-webview and getting compilation errors. Works fine with the old UIWebView though. --- If your project is set up for it, you

Re: [Review] plugman createpackagejson

2015-02-10 Thread Steven Gill
Appreciate the feedback! At nodesummit today and tomorrow. Will try to find some time to respond. On Feb 9, 2015 2:46 PM, Michal Mocny mmo...@chromium.org wrote: (I commented on the other thread) Left comments inline, but haven't tested. Overall, looks good and I like the approach! On

Re: Does this plugin support the current platform?

2015-02-10 Thread Michal Mocny
Generally, this is a bit of an unsolved problem. While plugins have platform tags, I believe we install all plugins for all platforms. This is because the platform tag was used for optional configuration initially and was never mandated. So, you can use that as a signal which says should

[GitHub] cordova-coho pull request: CB-8375 Improve windows support for for...

2015-02-10 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-coho/pull/62#issuecomment-73790408 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

nodejitsu bought by godaddy

2015-02-10 Thread Steven Gill
https://blog.nodejitsu.com/nodejitsu-joins-godaddy/ Cordova plugins registry is hosted by iriscouch (owned by nodejitsu). Looks like they are going to be transitioning existing customers to some new vender they are vetting now. Not sure how this will impact us yet. Another push for us to move

[GitHub] cordova-coho pull request: CB-8375 Improve windows support for for...

2015-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: CB-8375 Improve windows support for for...

2015-02-10 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-coho/pull/62#issuecomment-73772237 @sgrebnov Can you please help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/29#discussion_r24476010 --- Diff: src/build/makers/ios.js --- @@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir, sha, devices, entry_poin

Re: Does this plugin support the current platform?

2015-02-10 Thread tommy-carlos williams
Nice +1 One change in Cordova is a lot bette than expecting all plugins to change ;) --  tommy-carlos williams On 11 February 2015 at 07:54:17, Andrew Grieve (agri...@chromium.org) wrote: Strawman: If plugin.xml has *any* platforms, then only apply global tags to those platforms. If

Re: Does this plugin support the current platform?

2015-02-10 Thread Steven Gill
Sounds like a smart change. On Feb 10, 2015 2:10 PM, tommy-carlos williams to...@devgeeks.org wrote: Nice +1 One change in Cordova is a lot bette than expecting all plugins to change ;) -- tommy-carlos williams On 11 February 2015 at 07:54:17, Andrew Grieve (agri...@chromium.org)

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-10 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/29#discussion_r24456808 --- Diff: src/build/makers/ios.js --- @@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir, sha, devices, entry_poin

Re: Build signed archives using CLI

2015-02-10 Thread Victor Sosa
I'm leaning to Andrew and Omar's idea. I like the idea of having a file where all the platform-specific information will be stored, then each platform will take that information to sign the archive and produce a usable, I mean ready-to-distribute, binary. As for Omar's comment, I also concur

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-10 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/155#issuecomment-73799000 I'll close this PR, and open a new, cleaned up PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-10 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/29#issuecomment-73802589 Comments addressed in latest commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-10 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/29#discussion_r24460393 --- Diff: src/build/makers/ios.js --- @@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir, sha, devices, entry_poin

Re: nodejitsu bought by godaddy

2015-02-10 Thread Shazron
Do any of the Cordova IBM guys have any pull with Cloudant to get us free hosting for c.p.r? We would need to run it for at least 6 months for the changeover to npm. On Tue, Feb 10, 2015 at 1:44 PM, Steven Gill stevengil...@gmail.com wrote: https://blog.nodejitsu.com/nodejitsu-joins-godaddy/

RE: Does this plugin support the current platform?

2015-02-10 Thread Horn, Julian C
I like it! -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, February 10, 2015 3:52 PM To: dev Subject: Re: Does this plugin support the current platform? Strawman: If plugin.xml has *any* platforms, then only apply global

Does this plugin support the current platform?

2015-02-10 Thread Axel Nennker
Hi, is there a way how an app can determine whether a plugin supports the current platform? E.g.: the barcodescanner plugin is not supporting firefoxos How could an app know that which out hardcoding this into the app? If there is a standard way in Cordova then this is a userland question. If

[GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe...

2015-02-10 Thread TimBarham
Github user TimBarham closed the pull request at: https://github.com/apache/cordova-lib/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Does this plugin support the current platform?

2015-02-10 Thread Michal Mocny
Indeed. No platform tag kinda implies js-only plugin, so captures the spirit of the intent well! On Tue, Feb 10, 2015 at 5:11 PM, Steven Gill stevengil...@gmail.com wrote: Sounds like a smart change. On Feb 10, 2015 2:10 PM, tommy-carlos williams to...@devgeeks.org wrote: Nice +1

Re: nodejitsu bought by godaddy

2015-02-10 Thread Steven Gill
Chatted with Charlie (nodejitsu ceo). They will help with transitioning if we need to do it before our deprecation date due to npm move. Still would be a good idea for IBM folks to see if we can get a hookup with cloudant. On Feb 10, 2015 1:56 PM, Shazron shaz...@gmail.com wrote: Do any of the