Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26225224
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227988
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26218840
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26218885
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user chrisbubernak commented on the pull request:
https://github.com/apache/cordova-windows/pull/58#issuecomment-78286333
yeah, didn't realize the email address was wrong on that machine until a
week or so after I submitted this :(
---
If your project is set up for it, you
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228733
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
I guess since we have a MAJOR version bump on plugins, I agree thats the
right choice.
-Michal
On Wed, Mar 11, 2015 at 11:15 AM, Andrew Grieve agri...@chromium.org
wrote:
On Wed, Mar 11, 2015 at 10:30 AM, Michal Mocny mmo...@chromium.org
wrote:
On Wed, Mar 11, 2015 at 10:10 AM, Andrew
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227251
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller import
On Wed, Mar 11, 2015 at 10:30 AM, Michal Mocny mmo...@chromium.org wrote:
On Wed, Mar 11, 2015 at 10:10 AM, Andrew Grieve agri...@chromium.org
wrote:
On Mon, Mar 9, 2015 at 8:20 PM, Steven Gill stevengil...@gmail.com
wrote:
Our master branch has plugin fetching from npm set as the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227034
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
+
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26224327
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228193
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227709
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26218471
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -293,58 +293,25 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26218870
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
You used to be able to pass settings for the project's config.json file on the
command line to create:
cordova create test com.johnwargo.test Test {\autosave\:\true\}
That worked pre-4.0 but didn't seem to work in my moments ago test of this with
the latest version. It would make the .cordova
Hey Andrew,
I don't see the new plugins in coho yet. Did you forget to push them?
On Wed, Mar 11, 2015 at 7:35 AM, Andrew Grieve agri...@chromium.org wrote:
Done! They are now alive at their now spots and added to coho's plugins
list.
On Thu, Mar 5, 2015 at 3:49 PM, Jesse
Github user sinofool commented on the pull request:
https://github.com/apache/cordova-ios/pull/131#issuecomment-78368407
Thanks @shazron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Thanks for the response and the tip!
I¹ll submit a JIRA and a PR sometime soon.
As an aside, any chance we can get a preview of your ApacheCon
presentation?
I really need to learn how to set up my environment the right way!
;)
On 3/9/15, 12:05 PM, Andrew Grieve agri...@chromium.org wrote:
I
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/122
Createmobilespec Whitelist Fix
Searching for whitelist plugin in top dir instead of cordova-plugins. Also
factoring out plugin installation into a function. This is change relates to
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26233744
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
LGTM. Only weird thing is that the platforms lib is in
'../platforms/platforms' moved from just '../platforms' - but not a big deal in
the least.
-Original Message-
From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny
Sent: Wednesday, March 11, 2015 7:29 AM
To:
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/131#issuecomment-78356414
Note: will review this for the next release, on the 4.0.x branch. Sorry
it's taking so long but we were working on getting the 3.8.0 release out with
bug fixes.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/180#issuecomment-78390923
This change was merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
-1 Verified it works on the latest release iOS and Android, but I had a
typo in the CSP string:
https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c
Perhaps we could re-spin with this one fix and leave the vote end period
the same (assuming everyone
https://github.com/cordova/apache-board-reports/blob/master/2015/2015-03.md
I intend to submit this by EOD, let me know if any edits needed.
I did not include any releases where votes are under way.
-
To unsubscribe, e-mail:
Excellent board report Shaz!
On Wed, Mar 11, 2015 at 3:38 PM, Shazron shaz...@gmail.com wrote:
https://github.com/cordova/apache-board-reports/blob/master/2015/2015-03.md
I intend to submit this by EOD, let me know if any edits needed.
I did not include any releases where votes are under
Looks good, Shaz.
From: Michael Brooksmailto:mich...@michaelbrooks.ca
Sent: 3/11/2015 4:28 PM
To: dev@cordova.apache.orgmailto:dev@cordova.apache.org
Subject: Re: March 2015 Board Report for Apache Cordova
Excellent board report Shaz!
On Wed, Mar 11, 2015 at
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/181#issuecomment-78387046
closing this PR because #182 went in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user omefire closed the pull request at:
https://github.com/apache/cordova-lib/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user CJRChang opened a pull request:
https://github.com/apache/cordova-windows/pull/61
Fix for callback invocation with NO_RESULT
Due to the enumeration of cordova.callbackStatus (NO_RESULT = 0 and OK =
1), the logic used for defaulting to cordova.callbackStatus.OK will
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/184
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
FOO' should fail when no variables specified.
CB-7698 BugFix: For plugins which require variables, 'cordova plugin add
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/commit/242a8d760267379e963977de68d49aae96928562#commitcomment-10136020
Nice catch, @glasser.
I just sent a PR to fix this :
https://github.com/apache/cordova-lib/pull/184
---
If your
Github user glasser commented on the pull request:
https://github.com/apache/cordova-lib/pull/184#issuecomment-78213647
Awesome, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26201989
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26202982
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26199487
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26202687
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26202848
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26202824
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26198995
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26200013
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26198876
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26199140
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/182#issuecomment-78261223
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Great questions! Certainly was hoping to get more eyes on this!
Not sure where a good spot to document this is, but maybe right in the
template is okay? That way users will also know the rationale :)
On Wed, Mar 11, 2015 at 2:04 PM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
Thanks for
I think if we change the tag, we will have to vote again. However, we don’t
have to necessarily wait for 72 hours, for a fix that is small.
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Wednesday, March 11, 2015 6:18 PM
To: dev
On Wed, Mar 11, 2015 at 10:10 AM, Andrew Grieve agri...@chromium.org
wrote:
On Mon, Mar 9, 2015 at 8:20 PM, Steven Gill stevengil...@gmail.com
wrote:
Our master branch has plugin fetching from npm set as the fallback now.
It
will go directly to npm if the plugin-id entered isn't reverse
Reviewed, left comments. Overall looks good, thanks Mark.
However, seems you left something uncommitted, since you literally cannot
require('cordova-lib'); without an exception thrown. Yet all the
cordova-lib tests pass. What does it say about the quality of the tests ;)
On Tue, Mar 10, 2015
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214063
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
On Mon, Mar 9, 2015 at 8:20 PM, Steven Gill stevengil...@gmail.com wrote:
Our master branch has plugin fetching from npm set as the fallback now. It
will go directly to npm if the plugin-id entered isn't reverse domain name
style. Cordova-lib also warns users to use the package-name instead of
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214642
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215310
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
That's why we have tests! I just changed the activity and saw that we have
one failure. I'm not sure why this test in particular is failing, since
there's too many assertions in one method, so I'll have to try and debug it
today.
The thing is that if we're deprecating something and replacing it
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26213790
--- Diff: cordova-lib/src/PluginInfo.js ---
@@ -288,6 +293,19 @@ function PluginInfo(dirname) {
return ret;
});
};
I wanted to make sure that I didn't break the old way of doing things.
On Tue, Mar 10, 2015 at 2:24 PM, Joe Bowser bows...@gmail.com wrote:
The main issue is that this isn't documented anywhere, and this is
necessary for people to use a Third Party WebView. Also, why didn't you
bother
Note that this pulls in the addition of a content-security-policy meta
tag.
Please ensure that this doesn't break your platform when voting.
On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill stevengil...@gmail.com wrote:
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215186
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215219
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -293,58 +293,25 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26215211
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
yes... yes I did... :) Pushed now.
On Wed, Mar 11, 2015 at 5:49 PM, Steven Gill stevengil...@gmail.com wrote:
Hey Andrew,
I don't see the new plugins in coho yet. Did you forget to push them?
On Wed, Mar 11, 2015 at 7:35 AM, Andrew Grieve agri...@chromium.org
wrote:
Done! They are now
LGTM!
On Wed, Mar 11, 2015 at 1:59 PM, Rob Paveza rob.pav...@microsoft.com
wrote:
LGTM. Only weird thing is that the platforms lib is in
'../platforms/platforms' moved from just '../platforms' - but not a big
deal in the least.
-Original Message-
From: mmo...@google.com
Likely won't create it until closer to the event, but I'll send it to the
list as soon as I do! :)
On Wed, Mar 11, 2015 at 3:44 PM, Homer, Tony tony.ho...@intel.com wrote:
Thanks for the response and the tip!
I¹ll submit a JIRA and a PR sometime soon.
As an aside, any chance we can get a
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
66 matches
Mail list logo
