[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-04 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31790359 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -184,13 +192,65 @@ module.exports = { var xcBuildConfiguration = xcodepr

Translation QA tools

2015-06-04 Thread Andrey Kurdumov
1) I submit pull request to the cordova-docs which add one more QA tool for the translation. I verify that after translation, HTML files generated from Markdown should have same structure of HTML DOM. Sometimes, mostly due to inserting additional lines by CrowdIn the resulting files become corrupt.

Re: Android plugin crash on resume when activity destroyed

2015-06-04 Thread Jesse
I'm off for a week after tomorrow, so 2 weeks? I'll try to get a discuss thread up tomorrow. @purplecabbage risingj.com On Thu, Jun 4, 2015 at 3:00 PM, Serge Huijben wrote: > Sounds great Jesse, it would be awesome to have some context awareness in a > startup event. > any idea when you could h

Re: [DISCUSS] Tools Release June 4th

2015-06-04 Thread Steven Gill
Done! Vote away! On Thu, Jun 4, 2015 at 3:42 PM, Nikhil Khandelwal wrote: > Let us know when you have done that. We can verify the archive for voting. > > Thanks, > Nikhil > > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Thursday, June 4, 2015 2:49 PM

Re: [VOTE] Tools Release June 4th

2015-06-04 Thread Steven Gill
Updated: cordova-lib: 5.1.1 (83cc078229) On Thu, Jun 4, 2015 at 11:20 AM, Steven Gill wrote: > Please review and vote on this Tools Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-9087 > > Both tools have

RE: [VOTE] Partial Tools Release June 1, 2015

2015-06-04 Thread Tim Barham
If we need a blog post for this one, I have one here for review: https://github.com/cordova/apache-blog-posts/blob/c1d53b7a3731a15c40101fe4b2f39041724252c3/2015-06-04-tools-release.md Thanks, Tim -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Thursday, June

RE: [DISCUSS] Tools Release June 4th

2015-06-04 Thread Nikhil Khandelwal
Let us know when you have done that. We can verify the archive for voting. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 2:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Tools Release June 4th Good catch. That

RE: [DISCUSS] Cordova-windows 4.0.0 release

2015-06-04 Thread Nikhil Khandelwal
I have a blog post up here for review: https://github.com/cordova/apache-blog-posts/pull/40 Thanks, Nikhil -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, May 22, 2015 10:55 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-windows 4.0.0

Re: Android plugin crash on resume when activity destroyed

2015-06-04 Thread Serge Huijben
Sounds great Jesse, it would be awesome to have some context awareness in a startup event. any idea when you could have this ready? - Serge Op do 4 jun. 2015 om 22:52 schreef Jesse : > Yes, I am working on a unified solution, which is to include a > pre-deviceready event which contains launch co

Re: [DISCUSS] Tools Release June 4th

2015-06-04 Thread Steven Gill
Good catch. That should have been updated earlier. It shouldn't make a difference though. I believe with our new ranges, it will always grab 4.0.2 when doing a cordova platform add android. I would need to add the commit to both master and 5.1.x branch for cordova-lib. Then retag and upload to dis

[DISCUSS] Tools Release June 4th

2015-06-04 Thread Homer, Tony
Sorry, don¹t see a DISCUSS thread and don¹t want to clutter the VOTE thread. Please let me know if starting a DISCUSS thread to ask a question is the wrong way to go. Shouldn¹t the pinned Android in Tools Release June 4th be bumped to ~4.0.2? Currently it is ~4.0.1: https://github.com/apache/cordo

[GitHub] cordova-plugin-inappbrowser pull request: Updating fork with lates...

2015-06-04 Thread ElliottElectric
Github user ElliottElectric closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

RE: [CI] Builds failing due to cordova lib version bump

2015-06-04 Thread Dmitry Blotsky
On it. Kindly, Dmitry -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 1:42 PM To: dev@cordova.apache.org Subject: Re: [CI] Builds failing due to cordova lib version bump Problem with that is that npm install would fail when it runs `push

Re: Android plugin crash on resume when activity destroyed

2015-06-04 Thread Jesse
Yes, I am working on a unified solution, which is to include a pre-deviceready event which contains launch context data. This would/could include being launched from an intent, or a url:protocol that you have registered, a local notification, a push notification, launch from a secondary tile,

Re: [CI] Builds failing due to cordova lib version bump

2015-06-04 Thread Steven Gill
Problem with that is that npm install would fail when it runs `pushd cordova-cli; npm install; popd` because cordova-lib@5.1.1 doesn't exist on npm. I believe a way around this is to do something like pushd cordova-js; npm install; npm link; popd; pushd cordova-lib/cordova-lib; npm link cordova-js

[GitHub] cordova-plugin-inappbrowser pull request: Updating fork with lates...

2015-06-04 Thread ElliottElectric
GitHub user ElliottElectric opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/103 Updating fork with latest. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ElliottElectric/cordova-plugin-inappbrow

RE: Android plugin crash on resume when activity destroyed

2015-06-04 Thread Dan Polivy
Is there any notification to the app via JS that the activity is being destroyed, e.g. to allow the app to save state? FWIW, I think any plugin that invokes another intent that returns data is potentially vulnerable to this issue -- e.g. barcode scanner being another one (I have a few real wor

RE: [CI] Builds failing due to cordova lib version bump

2015-06-04 Thread Dmitry Blotsky
Sorry, the mail client lost the formatting. Here it is again: pushd cordova-lib/cordova-lib; npm install; popd; pushd cordova-cli; npm install; popd; pushd cordova-plugman; npm install; popd; pushd cordova-js; npm install; popd; coho npm-link; -Original Message- From: Dmitry Blotsky [mail

RE: [CI] Builds failing due to cordova lib version bump

2015-06-04 Thread Dmitry Blotsky
Hmm, I think the CI is doing it wrong then. It should be using the master version of the code, not what's on NPM. The installation steps are: pushd cordova-lib/cordova-lib; npm install; popd pushd cordova-cli; npm install; popd pushd cordova-plugman; npm install; popd pushd cordova-js; npm instal

Re: [CI] Builds failing due to cordova lib version bump

2015-06-04 Thread Steven Gill
Sorry, I didn't publish 5.1.1 for cordova-lib and cli to npm under RC tag yet. (or plugman 0.23.3). If we needed to change something before we vote, I would have to bump all of the versions again to republish (just had to do that and remove 5.1.0 from npm). I can go ahead and publish them under RC

[CI] Builds failing due to cordova lib version bump

2015-06-04 Thread Dmitry Blotsky
Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/steps/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry

Re: Cordova edge docs update needed

2015-06-04 Thread Steven Gill
I went ahead and just updated the edge documentation. We can still cut a 5.1 series of docs if we need to -Steve On Thu, Jun 4, 2015 at 11:49 AM, Raymond Camden wrote: > Steven - does this mean the update to the CLI mentioned in the Tools > release won't be documented when released? > > On Thu

RE: Experimenting with API for cordova tooling

2015-06-04 Thread Vladimir Kotikov (Akvelon)
Hello again :) I wanted to bring your attention to this thread again. I've opened a new PR updated according to Mark's feedback and will be very grateful if someone can review this again before merging. There is also the implementation for Android platform which uses this new API provides own im

[GitHub] cordova-android pull request: Implementation for Unified platform ...

2015-06-04 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/179 Implementation for Unified platform API for Android platform. Draft implementation of Unified Platform API for Windows platform, that inspired by [this thread](http://markmail.org/

[GitHub] cordova-lib pull request: Implementation for Unified platform API

2015-06-04 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/235 Implementation for Unified platform API An mplementation of Unified Platform API for cordova, that inspired by [this thread](http://markmail.org/thread/3dw4mis4qo5d4ecz) in cordova-de

[GitHub] cordova-plugin-media-capture pull request: Various Fixes to crashe...

2015-06-04 Thread aroberson
GitHub user aroberson opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/38 Various Fixes to crashes in Windows Phone 8 This pull request contains the following fixes. 1. The app crashes in wp8 when trying to take a picture or video and use

[GitHub] cordova-plugin-media-capture pull request: Cancel of Image Capture...

2015-06-04 Thread aroberson
Github user aroberson closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

Re: Cordova edge docs update needed

2015-06-04 Thread Raymond Camden
Steven - does this mean the update to the CLI mentioned in the Tools release won't be documented when released? On Thu, Jun 4, 2015 at 1:28 PM, Jesse wrote: > Or, every 13.5 days ... > > @purplecabbage > risingj.com > > On Thu, Jun 4, 2015 at 11:21 AM, Steven Gill wrote: > >> I will update the d

Re: Cordova edge docs update needed

2015-06-04 Thread Jesse
Or, every 13.5 days ... @purplecabbage risingj.com On Thu, Jun 4, 2015 at 11:21 AM, Steven Gill wrote: > I will update the docs after the tools release. We don't have a set > schedule. Right now we do it as needed. Updating docs doesn't require a > vote > > On Wed, Jun 3, 2015 at 5:54 PM, Nikhi

Re: Cordova edge docs update needed

2015-06-04 Thread Steven Gill
I will update the docs after the tools release. We don't have a set schedule. Right now we do it as needed. Updating docs doesn't require a vote On Wed, Jun 3, 2015 at 5:54 PM, Nikhil Khandelwal wrote: > I was looking to make a blog post for the Windows release, but I could not > find the docs f

[VOTE] Tools Release June 4th

2015-06-04 Thread Steven Gill
Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9087 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9087/ The packages were pub

Re: [CI] It's Beautiful

2015-06-04 Thread Steven Gill
Woohoo! On Thu, Jun 4, 2015 at 10:29 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Awesome, congrats! > > -Sergey > -Original Message- > From: Dmitry Blotsky [mailto:dblot...@microsoft.com] > Sent: Thursday, June 4, 2015 8:27 PM > To: dev@cordova.apache.org > Subject: [

RE: [VOTE] Partial Tools Release June 1, 2015

2015-06-04 Thread Tim Barham
The vote has now closed. The results are: Positive binding votes: - Murat Sutunc - Nikhil Khandelwal - Tim Barham No negative votes. The vote has passed. Thanks, Tim -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Thursday, June 4, 2015 10:16 AM To: dev@cor

RE: [CI] It's Beautiful

2015-06-04 Thread Sergey Grebnov (Akvelon)
Awesome, congrats! -Sergey -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, June 4, 2015 8:27 PM To: dev@cordova.apache.org Subject: [CI] It's Beautiful Hey all, This is what our builds are looking like right now: https://paste.apache.org/59w6. Co

[GitHub] cordova-lib pull request: CB-8052 [webOS] Update cordova-lib for w...

2015-06-04 Thread JayCanuck
Github user JayCanuck closed the pull request at: https://github.com/apache/cordova-lib/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[CI] It's Beautiful

2015-06-04 Thread Dmitry Blotsky
Hey all, This is what our builds are looking like right now: https://paste.apache.org/59w6. Congrats to us all! Now we just need more tests, so the builds once again stop being so annoyingly neon green. Kindly, Dmitry P.S. I hope I didn't jinx it!

[GitHub] cordova-webos pull request: CB-6715 [webOS] Upgrade webOS Cordova ...

2015-06-04 Thread JayCanuck
Github user JayCanuck closed the pull request at: https://github.com/apache/cordova-webos/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-js pull request: CB-8051 [webOS] Fixes webOS SmartTV detec...

2015-06-04 Thread JayCanuck
Github user JayCanuck closed the pull request at: https://github.com/apache/cordova-js/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

RE: [VOTE] Partial Tools Release June 1, 2015

2015-06-04 Thread Murat Sutunc
+1 I've verified the following: * coho verify-archive * versions displayed correctly * installed android correctly -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Wednesday, June 3, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/144#discussion_r31741687 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -87,6 +87,13 @@ module.exports.run = function (argv) { } return Q.n

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108975191 @omefire I don't have Android environment on Mac now, but as far as I can see there are no shell scripts in Android platform. --- If your project is set up for it,

[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...

2015-06-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/55#issuecomment-108967609 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108966698 @daserge , does this behavior show up if for example, I add android from windows, then check it into git ? --- If your project is set up for it, you can reply to

[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...

2015-06-04 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/55 CB-9000 Failing properly if no test results were found https://issues.apache.org/jira/browse/CB-9000 You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108915724 @omefire I think that it is because git does not include exec permission for these files. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108911479 LGTM ! - what causes file permissions to change when the platform is added on a non-OSX system ? --- If your project is set up for it, you can reply to this em

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/144#discussion_r31719008 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -87,6 +87,13 @@ module.exports.run = function (argv) { } return Q.nf

[GitHub] cordova-windows pull request: Draft implementation for Unified pla...

2015-06-04 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...

2015-06-04 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/144#discussion_r31713805 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -87,6 +87,13 @@ module.exports.run = function (argv) { } return Q.n

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/144 CB-9116 Ensure platform scripts are executable as the platform could be added on non-OSX environment Corresponding [Jira issue](https://issues.apache.org/jira/browse/CB-9116) You can merge thi