[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/549#issuecomment-194721309 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/548#discussion_r55643636 --- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md --- @@ -224,7 +218,21 @@ To publish a plugin to NPM registry you need to follow steps

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/548#discussion_r55643472 --- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md --- @@ -224,7 +218,21 @@ To publish a plugin to NPM registry you need to follow steps

[GitHub] cordova-docs pull request: Plugin release 03 12

Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/550#discussion_r55639091 --- Diff: www/_posts/2016-03-12-plugin-release.md --- @@ -0,0 +1,74 @@ +--- +layout: post +author: +name: Carlos Santana +

Re: [RELEASES] blog post or reporter.apache.org - report of releases

I realize the reporter.apache.org form process only works in reporting one release at a time, and if you do a big plugins release, it is maddening. To save your sanity I don't expect you to do this for all plugins (unless you want to of course) -- I can enter all of them once a quarter, but I

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/534#discussion_r55634235 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -211,9 +211,8 @@ platform. See [Customize icons topic](images.html) for more information.

[RELEASES] blog post or reporter.apache.org - report of releases

Can everyone doing releases either be consistent in having a blog post for it, or even better, actually posting your release as noted here: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#tell-apache-about-release Apache even emails you about it when you post

Re: [DISCUSS] Cordova-Ubuntu Release

I'm going thru the process right now and reviewing the release-process.md files and will update to be more accurate and correct. On Wed, Mar 9, 2016 at 11:39 PM Carlos Santana wrote: > I vote for doing a blog post for every release, they are very cheap and > easy to do

Re: [DISCUSS] Cordova-Ubuntu Release

I vote for doing a blog post for every release, they are very cheap and easy to do and users subscribe to rss feed as a way to subscribe to releases. On Wed, Mar 9, 2016 at 11:37 PM Shazron wrote: > Well, this is problematic in gathering info for the quarterly report. > >

Re: [DISCUSS] Cordova-Ubuntu Release

Well, this is problematic in gathering info for the quarterly report. Since not all of you put your releases in https://reporter.apache.org/?cordova like mentioned here: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#tell-apache-about-release and when you

Re: [DISCUSS] Plugins release

Blog post for review: https://github.com/apache/cordova-docs/pull/550 On Wed, Mar 9, 2016 at 10:17 PM Carlos Santana wrote: > Richard merge the fix for the camera plugin > > I'm in the process of adding this one: > >- CB-10825

[GitHub] cordova-docs pull request: Plugin release 03 12

GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-docs/pull/550 Plugin release 03 12 You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-docs plugin_release_03_12 Alternatively you

[VOTE] Plugins Release camera@2.1.1 globalization@1.0.3 splashscreen@3.2.1 statusbar@2.1.2

Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10820 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10820/

Re: [ANNOUNCE] cordova-osx 4.0.1 released

Yeah, just tweeted out the release notes. On Wed, Mar 9, 2016 at 6:21 PM, Shazron wrote: > Blog post for this is missing. > > On Wed, Mar 9, 2016 at 1:38 PM, Tobias Bocanegra > wrote: > > Thanks Steve! > > > > Regards, Toby > > > > On Tue, Mar 8, 2016 at

Re: [DISCUSS] Cordova-Ubuntu Release

We didn't do a blog for it. We sometimes don't blog patch releases. Just tweet the releasenotes. -Steve On Wed, Mar 9, 2016 at 6:27 PM, Shazron wrote: > Blog post for this release is missing. > > On Wed, Feb 3, 2016 at 2:35 AM, David Barth >

Re: [ANNOUNCE] cordova-osx 4.0.1 released

Blog post for this is missing. On Wed, Mar 9, 2016 at 1:38 PM, Tobias Bocanegra wrote: > Thanks Steve! > > Regards, Toby > > On Tue, Mar 8, 2016 at 10:48 PM, Steven Gill wrote: >> Tweet: https://twitter.com/apachecordova/status/707321836246204416 > >

[GitHub] cordova-plugin-camera pull request: Fix Crash on Android 6.0 for p...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/189#issuecomment-194618222 This was just fixed in a19c752 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-19461 Alright, I'm going to merge this in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194599948 @riknoll what's the final conclusion for the plugin release? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194598293 I think that fixing (or removing) `getRealPath()` might be a large undertaking, so it shouldn't block the release. This permission request at least

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194593508 @macdonst Not with the current implementation of `getRealPath()` --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194592028 @riknoll yeah, we shouldn't let people into the gallery if we can't read the file later. If we can't tell which gallery they will use is there

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194588633 I guess it does make more sense for us to request the permission before we select the photo because the developer of a Cordova app doesn't really have a

Re: mobilespec problems with ios??

yes node issue, :-( On Wed, Mar 9, 2016 at 7:11 PM Shazron wrote: > Did you check your node version? It's probably the same issue. > > On Wed, Mar 9, 2016 at 4:08 PM, Carlos Santana > wrote: > > There are two problems I hit with mobilespec one is node

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194582918 @riknoll if you call getPicture() to read from the gallery shouldn't it request READ permission before opening the gallery? --- If your project is set

Re: mobilespec problems with ios??

Did you check your node version? It's probably the same issue. On Wed, Mar 9, 2016 at 4:08 PM, Carlos Santana wrote: > There are two problems I hit with mobilespec one is node but the other is > ios@4 specific not handling schem:* for allow-navigation > >

Re: mobilespec problems with ios??

There are two problems I hit with mobilespec one is node but the other is ios@4 specific not handling schem:* for allow-navigation https://issues.apache.org/jira/browse/CB-10828 On Wed, Mar 9, 2016 at 6:27 PM Shazron wrote: > Off by one error, classic, we've all done it XD

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194567940 @riknoll I'm not too familiar with android permission would be up to @infil00p @jcesarmobile or maybe @macdonst --- If your project is set up for

[GitHub] cordova-docs pull request: Document CDVSystemSchemesOverride prefe...

Github user omefire closed the pull request at: https://github.com/apache/cordova-docs/pull/538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Document CDVSystemSchemesOverride prefe...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/538#issuecomment-194564846 Thanks for letting me know, shaz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: mobilespec problems with ios??

Off by one error, classic, we've all done it XD https://github.com/nodejs/node/commit/8b16ba3bbf381249552c2a038233141e4abbe731 On Wed, Mar 9, 2016 at 3:04 PM, Nikhil Khandelwal wrote: > This is a regression in Node 5.7.0 that they fixed as part of Node 5.7.1: > >

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/534#issuecomment-194562009 @rakatyal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/534#discussion_r55608327 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -211,9 +211,8 @@ platform. See [Customize icons topic](images.html) for more information.

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/534#discussion_r55607956 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -245,6 +244,9 @@ platform. See [Customize icons topic](images.html) for more information.

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/534#discussion_r55606933 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -211,9 +211,8 @@ platform. See [Customize icons topic](images.html) for more information.

RE: mobilespec problems with ios??

This is a regression in Node 5.7.0 that they fixed as part of Node 5.7.1: https://issues.apache.org/jira/browse/CB-10675 https://github.com/nodejs/node/blob/v5.7.1/CHANGELOG.md Move to Node 5.7.1 -Nikhil -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent:

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/534#discussion_r55606329 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -60,7 +60,7 @@ platform. See [Customize icons topic](images.html) for more information.

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/405#discussion_r55602266 --- Diff: cordova-common/src/CordovaLogger.js --- @@ -153,6 +153,30 @@ CordovaLogger.prototype.setLevel = function (logLevel) { };

Re: mobilespec problems with ios??

Don't think so because it works on android I think is related on processing the confit.xml during prepare to do add the ATS white list to Info.plist On Wed, Mar 9, 2016 at 5:19 PM Shazron wrote: > Not sure if this is related: > https://issues.apache.org/jira/browse/CB-10718

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-194537453 @daserge Great, thanks for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Edit to Edit on Github for Docs

Also, can we add "Edit on GitHub" to Blog and Plugin pages, please. Regards *Rob Posener* 0419 012 627 On 10 March 2016 at 09:14, Robert Posener wrote: > I like "Edit on GitHub". > > I was never sure how far into "editing" clicking on the "Edit" button > would take me

Re: mobilespec problems with ios??

Not sure if this is related: https://issues.apache.org/jira/browse/CB-10718 On Wed, Mar 9, 2016 at 2:00 PM, Carlos Santana wrote: > I'm having problems creating a mobilespec app using ios platform, anyone > else have tried latetly > > $ node

Re: Edit to Edit on Github for Docs

I like "Edit on GitHub". I was never sure how far into "editing" clicking on the "Edit" button would take me before I hit some roadblock (like needing to be a committer, like having a GitHub login, like being part of the cordova in-crowd, etc) that meant that I had wasted my time. It would be

[GitHub] cordova-ios pull request: CB-10773 Correct FRAMEWORKS_SEARCH_PATHS...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

mobilespec problems with ios??

I'm having problems creating a mobilespec app using ios platform, anyone else have tried latetly $ node cordova-mobile-spec/createmobilespec/createmobilespec.js --ios --global --globalplugins -d Creating project. Using globally installed tools, downloadable platforms and plugins, and local

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/549 Fix syntax highlighting within the Android platform guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilkh/cordova-docs patch-3

Re: [ANNOUNCE] cordova-osx 4.0.1 released

Thanks Steve! Regards, Toby On Tue, Mar 8, 2016 at 10:48 PM, Steven Gill wrote: > Tweet: https://twitter.com/apachecordova/status/707321836246204416 - To unsubscribe, e-mail:

Re: [DISCUSS] Cordova-browser release

Lgtm! > On Mar 9, 2016, at 10:55 AM, Vladimir Kotikov (Akvelon) > wrote: > > Thanks, Carlos > > - > Best regards, Vladmir > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Wednesday, March 9, 2016 7:24 PM > To:

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/536#discussion_r55587679 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -189,7 +189,7 @@ platform. See [Customize icons topic](images.html) for more information.

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194492899 This is a base case that was broken. I think it'd be great if you were to add a test case to prevent that from ever happening again. Also, the way the

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194492790 This is a base case that was broken. I think it'd be great if you were to add a test case to prevent that from ever happening again. Also, the way the

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/191 CB-10825 android: Always request READ permission for gallery source I am unhappy with this change, but this issue is blocking a release and a proper fix could end up being a major

[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194491881 @infil00p @csantanapr @jcesarmobile please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-194490533 @nikhilkh tested and merged. Works well, thanks @dpolivy! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55581042 --- Diff: src/ios/CDVSound.m --- @@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command NSString* mediaId = [command

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55579371 --- Diff: src/ios/CDVSound.m --- @@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command NSString* mediaId = [command

[GitHub] cordova-plugin-splashscreen pull request: CB-10692 Don't fade when...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/86#issuecomment-194467150 @nikhilkh I will test it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [DISCUSS] Plugins release

OK Richard ping me on Slack when you have it ready. Here is the rest of the changes to be included in this release, will wait for CB-10825 for camera plugin ## cordova-plugin-camera ### 2.1.1 (Mar 09, 2016) * added apache license header to appium files * CB-10720 Fixed spelling,

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/405#issuecomment-194464781 Looks like github repo is out of sync with Apache'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

RE: [DISCUSS] Plugins release

I just found a critical camera bug[1], so we should hold off on that one. I think the fix is pretty simple, so I'll try and get a PR for it today. Thanks, Richard [1]: https://issues.apache.org/jira/browse/CB-10825 -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com]

[GitHub] cordova-docs pull request: CB-10813: Fix Hooks Guide

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/548 Clean up plugin publishing guide @riknoll can you please help review? You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/268 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user gaelenh commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194458433 @omefire yes my ICLA has been signed and filed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194455097 @gaelenh have you signed an ICLA ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: [DISCUSS] Cordova-browser release

Thanks, Carlos - Best regards, Vladmir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Wednesday, March 9, 2016 7:24 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-browser release blog post looks good On Wed, Mar 9, 2016 at 10:09 AM Vladimir

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/407#discussion_r55567900 --- Diff: cordova-fetch/index.js --- @@ -0,0 +1,176 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-docs pull request: Master

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10788 Add blog post about browser@4....

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-194441672 To-do: add cordova-lib tests for this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

RE: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

As a user of cordova (and list lurker), I thought I'd chime in and say Carlos hit on some very good points. In theory I like the idea of treating platforms like build artifacts, but in reality -- at least for my current usage -- things are far from that. Making this type of change will make my

Re: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

I agree having an "override" folder is a good start towards that goal In IBM MobileFirst hybrid apps also have similar feature, they don't have a cordova 3.x directory structure but in concept is similar android/native/Resources/ blackberry/native/Resources/ I would not use the folder name

Re: [DISCUSS] Plugins release

ok moving forward. then On Wed, Mar 9, 2016 at 12:20 PM Steven Gill wrote: > Sure! > On Mar 9, 2016 8:32 AM, "Carlos Santana" wrote: > > > Should camera be a patch release (2.1.1)? I don't see any API or > > functionality being added. > > > > ###

[GitHub] cordova-plugin-file pull request: CB-10577: Windows resolveLocalFi...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/169 CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for file The FileEntry constructor should remove any trailing slash from its path. This parallels the existing

RE: [PROPOSAL] 'cordova platform update' alias for rm, add in cordova-ios

In Visual Studio, we have a feature similar to "merges" to allow users to override content of platform folder. We use hooks to copy the contents of the folder to the platforms directory. Other than that VS does consider platforms/ directory a build artifact and often ends up deleting it on

[GitHub] cordova-cli pull request: CB-10679: Adding explanation for plugin ...

Github user riknoll closed the pull request at: https://github.com/apache/cordova-cli/pull/238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-10679: Adding explanation for plugin ...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/238#discussion_r9717 --- Diff: doc/plugin.txt --- @@ -4,20 +4,23 @@ Synopsis Manage project plugins -add [...] Add specified plugins

[GitHub] cordova-docs pull request: CB-10813: Fix Hooks Guide

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/543#issuecomment-194416883 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

RE: [DISCUSS] Android InAppBrowser circular loop with deep links

I haven't heard any feedback on this, but I went ahead and opened a PR with an implementation of option #1 below: https://github.com/apache/cordova-plugin-inappbrowser/pull/154 Note, if the current app is not one of the targets, then the current behavior stays the same. This only impacts

[GitHub] cordova-docs pull request: Fix typo

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Plugins release

Sure! On Mar 9, 2016 8:32 AM, "Carlos Santana" wrote: > Should camera be a patch release (2.1.1)? I don't see any API or > functionality being added. > > ### 2.1.1-dev (Mar 08, 2016) > * added apache license header to appium files > * CB-10720 Fixed spelling,

[GitHub] cordova-plugin-inappbrowser pull request: [CB-10795] Exclude curre...

GitHub user dpolivy opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/154 [CB-10795] Exclude current app from external intent list On Android, if the app defines an intent-filter for a given URL, and then tries to use inappbrowser to launch that

Re: [DISCUSS] Plugins release

Should camera be a patch release (2.1.1)? I don't see any API or functionality being added. ### 2.1.1-dev (Mar 08, 2016) * added apache license header to appium files * CB-10720 Fixed spelling, capitalization, and other small issues. * CB-10414: Adding focus handler to resume video when user

[GitHub] cordova-docs pull request: CB-10788 Add blog post about browser@4....

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/539#issuecomment-194374056 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [DISCUSS] Cordova-browser release

blog post looks good On Wed, Mar 9, 2016 at 10:09 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Friendly pinging... > > - > Best regards, Vladimir > > -Original Message- > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] > Sent: Friday, March 4, 2016

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/149#issuecomment-194349294 You should allow scale 200 images for UWP10 apps. The scale 100 images look a bit blurry on a Lumia 950 and scale 240 is no longer supported: ```js

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

Github user SunboX commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-194337561 Two comments on this: * calling `navigator.splashscreen.hide();` does not hide the splash screen (Windows 10, Lumia 950, build Cordova 6.0 as UWP 10)

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10817 The webView...

Github user dlmma commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194278080 @shazron done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: Fix typo

GitHub user krichtof opened a pull request: https://github.com/apache/cordova-docs/pull/547 Fix typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichtof/cordova-docs patch-1 Alternatively you can review and apply these

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/406#issuecomment-194196784 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work

cool On Wed, Mar 9, 2016 at 12:53 PM, stevengill wrote: > Github user stevengill commented on a diff in the pull request: > > https://github.com/apache/cordova-lib/pull/407#discussion_r55480177 > > --- Diff: cordova-fetch/index.js --- > @@ -0,0 +1,176 @@ >